Close out oldcompare.

At this revision all test logs either pass checkfile comparison
against advent439 or have a NOCOMPARE comment explaining why they don't
pass, turning into a TAP skip. 100% coverage.

diff --git a/tests/Makefile b/tests/Makefile
index 1593b690489d55b9e744d2bd559a6fa49cbfb2bb..7e17443d7b18d9b5752cb2136da5ae7b5310e993 100644 (file)
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -163,6 +163,10 @@ oldcompare: $(SGAMES)
                        fi; \
        done; \
        echo 1..$(words $(shell ls *.log))) | $(TAPFILTER)
-       @rm *.ochk rm *-new advent430 adventure.data
+       @rm *.ochk *-new advent430 adventure.data
+
+# List all NOMPARE tests.
+residuals:
+       @grep -n NOCOMPARE *.log
 
 # end

diff --git a/tests/barehands.log b/tests/barehands.log
index 72fc3de16de063e963ecc1d42646295646d19ce3..233c325b6bedb31252ec90ec8efaec4c9ce4b685 100644 (file)
--- a/tests/barehands.log
+++ b/tests/barehands.log
@@ -1,4 +1,5 @@
 ## Get to dragon, refuse to use bare hands
+#NOCOMPARE Fails due uninteresting difference in whitespace process. 
 # Based on walkthrough at http://www.ecsoftwareconsulting.com/node/56
 n
 seed 1635997320

diff --git a/tests/cheatresume.log b/tests/cheatresume.log
index 13ed78d8d5532f67a243561a297c01ae9c6075a6..4d0121ce3695bdb0c69ed2e432210a42483f374e 100644 (file)
--- a/tests/cheatresume.log
+++ b/tests/cheatresume.log
@@ -1,5 +1,5 @@
 ## Resume from absurd save file with numdie = -900
-#NOCOMPARE Can't compare to asvent430 die to version skew
+#NOCOMPARE Can't compare to asvent430 due to version skew
 n
 resume
 cheat_numdie.adv

diff --git a/tests/cheatresume2.log b/tests/cheatresume2.log
index 28438626a5e2ea081463577e689f22636b8440bd..64586543ce22e5b4078674d8d1e7f300463f54b0 100644 (file)
--- a/tests/cheatresume2.log
+++ b/tests/cheatresume2.log
@@ -1,6 +1,6 @@
 ## Resume from absurd save file with numdie = -1000
 # generating "off my scale" score threshold message
-#NOCOMPARE Can't compare to asvent430 die to version skew
+#NOCOMPARE Can't compare to asvent430 due to version skew
 n
 resume
 cheat_numdie1000.adv

diff --git a/tests/fail_hint_ogre.log b/tests/fail_hint_ogre.log
index c26ecbb2ead9cf8a490f56fac5ded14c0916da83..f75fd79a541c0ed48f406a7a32eca1b7996545d8 100644 (file)
--- a/tests/fail_hint_ogre.log
+++ b/tests/fail_hint_ogre.log
@@ -1,4 +1,5 @@
 ## Qualify for ogre hint but fail due to dwarves dead (fuzzed)
+#NOCOMPARE Fails due uninteresting difference in whitespace process. 
 n
 seed 1838473132
 in

diff --git a/tests/flyback.log b/tests/flyback.log
index 059054e9a10d5af5131c4350f1f922c1e73a5341..d0db54b84e02cab9b476fa6054615d3e172e860c 100644 (file)
--- a/tests/flyback.log
+++ b/tests/flyback.log
@@ -1,4 +1,4 @@
-## Test fix for issue #51: rug flying is broken
+## Test fix for issue 51: rug flying is broken
 #NOCOMPARE Behavior differs due to a bug fix.
 n
 seed 1838473132

diff --git a/tests/goback.log b/tests/goback.log
index 29158367b650eae214c74ac4449eb37ee9a6ec95..490ed7adaa5b07b9efe4f619c195a1dfb74e5989 100644 (file)
--- a/tests/goback.log
+++ b/tests/goback.log
@@ -1,6 +1,7 @@
 ## Test many nonlethal failure conditions
 # This variant elicits the prompt to go back for batteries
 # See comments in this log
+#NOCOMPARE Relies on "waste"
 n
 seed 1838473132
 in

diff --git a/tests/oldstyle.log b/tests/oldstyle.log
index a70456d3e16c6bc20b990a8c006428a4ab30b145..4711df005f0cdfd62fb5f56a3760219b636c924e 100644 (file)
--- a/tests/oldstyle.log
+++ b/tests/oldstyle.log
@@ -1,5 +1,6 @@
 ## Simple quit
 #options: -o
+#NOCOMPARE Comment not interpreted by advent430
 n
 i
 l

diff --git a/tests/oysterbug.log b/tests/oysterbug.log
index 07e15ff1600e17fe87ff3f092ec4662a02fdd79d..0310c97cdade7e706ceeec581b8924d35b6ac132 100644 (file)
--- a/tests/oysterbug.log
+++ b/tests/oysterbug.log
@@ -1,5 +1,5 @@
 # Demonstrate fix of buggy response to unlocking oyster while carrying it.
-#NOCOMPARE This fixes a bug in advent430
+#NOCOMPARE This fails due to a known bug in advent430
 n
 seed 1838473132
 in

diff --git a/tests/saveresume.1.log b/tests/saveresume.1.log
index ceaf6bb9f336ac7f98a3875af6132df18100db8c..77a20ce0c4e538c2ce6f4e5c5c89b14ba5f7f8cc 100644 (file)
--- a/tests/saveresume.1.log
+++ b/tests/saveresume.1.log
@@ -1,5 +1,5 @@
 ## Save right after starting
-#NOCOMPARE Can't compare to asvent430 die to version skew
+#NOCOMPARE Can't compare to asvent430 due to version skew
 n
 seed 1240742801
 save

diff --git a/tests/saveresume.2.log b/tests/saveresume.2.log
index da629bea803fe5e257c2a9db95dafcee7ab5a11e..23dcc9eab6dd960d518dc662a726cae9b0719f6b 100644 (file)
--- a/tests/saveresume.2.log
+++ b/tests/saveresume.2.log
@@ -1,5 +1,5 @@
 ## Resume and then quit
-#NOCOMPARE Can't compate to asvent430 die to version skew
+#NOCOMPARE Can't compate to asvent430 due to version skew
 n
 in
 resume

diff --git a/tests/saveresume.3.log b/tests/saveresume.3.log
index f199c6466276702302e4eefa04a2880bf8a24a4d..fd7be6fedcbe0671821d1101327ed7dda7640659 100644 (file)
--- a/tests/saveresume.3.log
+++ b/tests/saveresume.3.log
@@ -1,6 +1,6 @@
 ## Almost win, then save
 # Based on walkthrough at http://www.ecsoftwareconsulting.com/node/56
-#NOCOMPARE seems to reveal a bug in advent430
+#NOCOMPARE Seems to reveal a bug in advent430's save function.
 n
 seed 1838473132
 in

diff --git a/tests/savetamper.log b/tests/savetamper.log
index e6b763fff5aa48a9b8831c1702392a3bddc5ee71..f86e977c5abeb8a4142a85368b1fdd84ea4f330a 100644 (file)
--- a/tests/savetamper.log
+++ b/tests/savetamper.log
@@ -1,5 +1,5 @@
 ## Resume from artificial "corrupted" save
-#NOCOMPARE Can't compare to asvent430 die to version skew
+#NOCOMPARE Can't compare to asvent430 due to version skew
 n
 resume
 cheat_savetamper.adv

diff --git a/tests/water_plant2.log b/tests/water_plant2.log
index 16fa346fca70af4f34b91f28bc39526735ba0e3c..4f39d8fc07e595fc6672ff987cee6bdef199511f 100644 (file)
--- a/tests/water_plant2.log
+++ b/tests/water_plant2.log
@@ -1,4 +1,5 @@
 ## Check that pour correctly switches among plant states (fuzzed)
+#NOCOMPARE Behavior differs due to a parser bug fix.
 n
 seed 183847312
 in

diff --git a/tests/woodshint.log b/tests/woodshint.log
index 4472b49f4dbed45bae00c304d88f7e5cafa879e9..6052028011f86eb946f4cedea3661286926e6260 100644 (file)
--- a/tests/woodshint.log
+++ b/tests/woodshint.log
@@ -1,4 +1,5 @@
 ## Test hinting logic - elicit forest hint
+#NOCOMPARE Behavior differs due to a parser bug fix.
 # Also some tests of intransitive-verb cases
 n
 seed 2099333241