From: Eric S. Raymond Date: Sat, 1 Apr 2023 22:14:25 +0000 (-0400) Subject: Close out oldcompare. X-Git-Tag: 1.15~15 X-Git-Url: https://jxself.org/git/?p=open-adventure.git;a=commitdiff_plain;h=e49fb5f3673be6b0bf3c407499229b1f5eeacd04 Close out oldcompare. At this revision all test logs either pass checkfile comparison against advent439 or have a NOCOMPARE comment explaining why they don't pass, turning into a TAP skip. 100% coverage. --- diff --git a/tests/Makefile b/tests/Makefile index 1593b69..7e17443 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -163,6 +163,10 @@ oldcompare: $(SGAMES) fi; \ done; \ echo 1..$(words $(shell ls *.log))) | $(TAPFILTER) - @rm *.ochk rm *-new advent430 adventure.data + @rm *.ochk *-new advent430 adventure.data + +# List all NOMPARE tests. +residuals: + @grep -n NOCOMPARE *.log # end diff --git a/tests/barehands.log b/tests/barehands.log index 72fc3de..233c325 100644 --- a/tests/barehands.log +++ b/tests/barehands.log @@ -1,4 +1,5 @@ ## Get to dragon, refuse to use bare hands +#NOCOMPARE Fails due uninteresting difference in whitespace process. # Based on walkthrough at http://www.ecsoftwareconsulting.com/node/56 n seed 1635997320 diff --git a/tests/cheatresume.log b/tests/cheatresume.log index 13ed78d..4d0121c 100644 --- a/tests/cheatresume.log +++ b/tests/cheatresume.log @@ -1,5 +1,5 @@ ## Resume from absurd save file with numdie = -900 -#NOCOMPARE Can't compare to asvent430 die to version skew +#NOCOMPARE Can't compare to asvent430 due to version skew n resume cheat_numdie.adv diff --git a/tests/cheatresume2.log b/tests/cheatresume2.log index 2843862..6458654 100644 --- a/tests/cheatresume2.log +++ b/tests/cheatresume2.log @@ -1,6 +1,6 @@ ## Resume from absurd save file with numdie = -1000 # generating "off my scale" score threshold message -#NOCOMPARE Can't compare to asvent430 die to version skew +#NOCOMPARE Can't compare to asvent430 due to version skew n resume cheat_numdie1000.adv diff --git a/tests/fail_hint_ogre.log b/tests/fail_hint_ogre.log index c26ecbb..f75fd79 100644 --- a/tests/fail_hint_ogre.log +++ b/tests/fail_hint_ogre.log @@ -1,4 +1,5 @@ ## Qualify for ogre hint but fail due to dwarves dead (fuzzed) +#NOCOMPARE Fails due uninteresting difference in whitespace process. n seed 1838473132 in diff --git a/tests/flyback.log b/tests/flyback.log index 059054e..d0db54b 100644 --- a/tests/flyback.log +++ b/tests/flyback.log @@ -1,4 +1,4 @@ -## Test fix for issue #51: rug flying is broken +## Test fix for issue 51: rug flying is broken #NOCOMPARE Behavior differs due to a bug fix. n seed 1838473132 diff --git a/tests/goback.log b/tests/goback.log index 2915836..490ed7a 100644 --- a/tests/goback.log +++ b/tests/goback.log @@ -1,6 +1,7 @@ ## Test many nonlethal failure conditions # This variant elicits the prompt to go back for batteries # See comments in this log +#NOCOMPARE Relies on "waste" n seed 1838473132 in diff --git a/tests/oldstyle.log b/tests/oldstyle.log index a70456d..4711df0 100644 --- a/tests/oldstyle.log +++ b/tests/oldstyle.log @@ -1,5 +1,6 @@ ## Simple quit #options: -o +#NOCOMPARE Comment not interpreted by advent430 n i l diff --git a/tests/oysterbug.log b/tests/oysterbug.log index 07e15ff..0310c97 100644 --- a/tests/oysterbug.log +++ b/tests/oysterbug.log @@ -1,5 +1,5 @@ # Demonstrate fix of buggy response to unlocking oyster while carrying it. -#NOCOMPARE This fixes a bug in advent430 +#NOCOMPARE This fails due to a known bug in advent430 n seed 1838473132 in diff --git a/tests/saveresume.1.log b/tests/saveresume.1.log index ceaf6bb..77a20ce 100644 --- a/tests/saveresume.1.log +++ b/tests/saveresume.1.log @@ -1,5 +1,5 @@ ## Save right after starting -#NOCOMPARE Can't compare to asvent430 die to version skew +#NOCOMPARE Can't compare to asvent430 due to version skew n seed 1240742801 save diff --git a/tests/saveresume.2.log b/tests/saveresume.2.log index da629be..23dcc9e 100644 --- a/tests/saveresume.2.log +++ b/tests/saveresume.2.log @@ -1,5 +1,5 @@ ## Resume and then quit -#NOCOMPARE Can't compate to asvent430 die to version skew +#NOCOMPARE Can't compate to asvent430 due to version skew n in resume diff --git a/tests/saveresume.3.log b/tests/saveresume.3.log index f199c64..fd7be6f 100644 --- a/tests/saveresume.3.log +++ b/tests/saveresume.3.log @@ -1,6 +1,6 @@ ## Almost win, then save # Based on walkthrough at http://www.ecsoftwareconsulting.com/node/56 -#NOCOMPARE seems to reveal a bug in advent430 +#NOCOMPARE Seems to reveal a bug in advent430's save function. n seed 1838473132 in diff --git a/tests/savetamper.log b/tests/savetamper.log index e6b763f..f86e977 100644 --- a/tests/savetamper.log +++ b/tests/savetamper.log @@ -1,5 +1,5 @@ ## Resume from artificial "corrupted" save -#NOCOMPARE Can't compare to asvent430 die to version skew +#NOCOMPARE Can't compare to asvent430 due to version skew n resume cheat_savetamper.adv diff --git a/tests/water_plant2.log b/tests/water_plant2.log index 16fa346..4f39d8f 100644 --- a/tests/water_plant2.log +++ b/tests/water_plant2.log @@ -1,4 +1,5 @@ ## Check that pour correctly switches among plant states (fuzzed) +#NOCOMPARE Behavior differs due to a parser bug fix. n seed 183847312 in diff --git a/tests/woodshint.log b/tests/woodshint.log index 4472b49..6052028 100644 --- a/tests/woodshint.log +++ b/tests/woodshint.log @@ -1,4 +1,5 @@ ## Test hinting logic - elicit forest hint +#NOCOMPARE Behavior differs due to a parser bug fix. # Also some tests of intransitive-verb cases n seed 2099333241