Eric S. Raymond [Wed, 5 Jul 2017 06:02:39 +0000 (02:02 -0400)]
Minor clarifications.
NHOrus [Wed, 5 Jul 2017 05:37:04 +0000 (08:37 +0300)]
Trigger 'NO_EDIBLES' message
Eric S. Raymond [Wed, 5 Jul 2017 05:15:40 +0000 (01:15 -0400)]
Adapt bottle object to use state_change().
NHOrus [Wed, 5 Jul 2017 04:37:42 +0000 (07:37 +0300)]
Magic number elimination
Special state/locations for game.fixd object array
Eric S. Raymond [Wed, 5 Jul 2017 04:40:14 +0000 (00:40 -0400)]
Simplify vase-dropping logic using state_change().
Eric S. Raymond [Wed, 5 Jul 2017 03:46:16 +0000 (23:46 -0400)]
Magic-number elimination.
Eric S. Raymond [Wed, 5 Jul 2017 02:56:02 +0000 (22:56 -0400)]
Magic-number elimination in the olover/alcove pasage code.
Wuth this change, the location table becomes order-independent (I think).
Aaron Traas [Tue, 4 Jul 2017 21:41:42 +0000 (17:41 -0400)]
Coverage -- more odd actions
Aaron Traas [Tue, 4 Jul 2017 21:13:26 +0000 (17:13 -0400)]
Removed equivocation between ROD and ROD2 in throw()
Already dealt with in action(), so redundant and unreachable here.
Eric S. Raymond [Tue, 4 Jul 2017 18:40:10 +0000 (14:40 -0400)]
Magic-number elimination.
Eric S. Raymond [Tue, 4 Jul 2017 18:15:20 +0000 (14:15 -0400)]
Magic-number elimination.
Eric S. Raymond [Tue, 4 Jul 2017 17:40:05 +0000 (13:40 -0400)]
Abstract out some state arithmetic.
NHOrus [Tue, 4 Jul 2017 17:35:03 +0000 (20:35 +0300)]
Test for filling full bottle with different liquid
NHOrus [Tue, 4 Jul 2017 16:50:19 +0000 (19:50 +0300)]
Oops. Also, sometimes it's better be explicit in parameters
NHOrus [Tue, 4 Jul 2017 16:45:00 +0000 (19:45 +0300)]
Localized spk in discard
NHOrus [Tue, 4 Jul 2017 16:41:06 +0000 (19:41 +0300)]
Completed unspk'ing of vcarry.
NHOrus [Tue, 4 Jul 2017 16:27:00 +0000 (19:27 +0300)]
Unspk'd (v)carry. Made logic more visible.
And tested some of newly exposed cases.
NHOrus [Tue, 4 Jul 2017 15:41:28 +0000 (18:41 +0300)]
Unspk'd and streamlined attack. Tested one of discovered gaps.
Aaron Traas [Tue, 4 Jul 2017 13:55:02 +0000 (09:55 -0400)]
Eliminated bivalve function.
Reason: only called in lock(), you can't be TOTING a clam, you can't
have the trident at a carryable oyster, and the code IMHO is more
readable this way.
Eric S. Raymond [Tue, 4 Jul 2017 13:17:20 +0000 (09:17 -0400)]
State-arithmetic elimination.
Eric S. Raymond [Tue, 4 Jul 2017 13:03:42 +0000 (09:03 -0400)]
Grammar fix.
NHOrus [Tue, 4 Jul 2017 11:43:17 +0000 (14:43 +0300)]
Drinking not from stream gets the same result
NHOrus [Tue, 4 Jul 2017 08:02:58 +0000 (11:02 +0300)]
workaround for eat grate bug in retrospective tests
NHOrus [Tue, 4 Jul 2017 12:16:36 +0000 (15:16 +0300)]
Unspk'd chain action
NHOrus [Tue, 4 Jul 2017 11:38:43 +0000 (14:38 +0300)]
linearized drink
NHOrus [Tue, 4 Jul 2017 11:33:30 +0000 (14:33 +0300)]
linearized extinguish
NHOrus [Tue, 4 Jul 2017 10:58:00 +0000 (13:58 +0300)]
Unspk'd and restructured fill
NHOrus [Tue, 4 Jul 2017 10:28:00 +0000 (13:28 +0300)]
Partial cleanup of fill
NHOrus [Tue, 4 Jul 2017 10:04:04 +0000 (13:04 +0300)]
Removed magic from checks for liquids
NHOrus [Tue, 4 Jul 2017 08:49:02 +0000 (11:49 +0300)]
Unspk'd find
NHOrus [Tue, 4 Jul 2017 08:37:30 +0000 (11:37 +0300)]
Unspk'd inventory lookup
NHOrus [Tue, 4 Jul 2017 08:30:39 +0000 (11:30 +0300)]
Unspk'd lock, cleaned up logic
NHOrus [Tue, 4 Jul 2017 08:15:10 +0000 (11:15 +0300)]
Cleaned up unused variables
NHOrus [Tue, 4 Jul 2017 08:12:38 +0000 (11:12 +0300)]
Unspk'd Giant Words
Eric S. Raymond [Tue, 4 Jul 2017 12:16:10 +0000 (08:16 -0400)]
Another use of state_change().
Eric S. Raymond [Tue, 4 Jul 2017 11:59:20 +0000 (07:59 -0400)]
Another use of state_change() and changes messages.
Eric S. Raymond [Tue, 4 Jul 2017 11:39:07 +0000 (07:39 -0400)]
YAML cleanup.
Jason S. Ninneman [Tue, 4 Jul 2017 01:21:25 +0000 (18:21 -0700)]
Begin replacing tests on strings with tests on vocab IDs.
Jason S. Ninneman [Mon, 3 Jul 2017 17:37:44 +0000 (10:37 -0700)]
Upgrade get_vocab_id() to handle empty strings.
Eric S. Raymond [Tue, 4 Jul 2017 00:27:56 +0000 (20:27 -0400)]
Implement and document new state-label syntax.
Eric S. Raymond [Mon, 3 Jul 2017 23:26:32 +0000 (19:26 -0400)]
Comment polishing.
Eric S. Raymond [Mon, 3 Jul 2017 22:40:06 +0000 (18:40 -0400)]
Discard implementation of %L and %U format specifiers, now never used.
Eric S. Raymond [Mon, 3 Jul 2017 21:53:25 +0000 (17:53 -0400)]
Reducing use of dynamic allocation forecloses many errors.
Eric S. Raymond [Mon, 3 Jul 2017 21:21:06 +0000 (17:21 -0400)]
Information hiding.
Eric S. Raymond [Mon, 3 Jul 2017 21:13:28 +0000 (17:13 -0400)]
Simplify tokenization code.
Eric S. Raymond [Mon, 3 Jul 2017 20:49:33 +0000 (16:49 -0400)]
Entirely eliminate wd1x and wd2x members of the command block.
In the process, fix another case-smashing bug.
NHOrus [Mon, 3 Jul 2017 18:54:27 +0000 (21:54 +0300)]
Captured output of help and info commands
Can't believe it wasn't done before
Eric S. Raymond [Mon, 3 Jul 2017 18:55:34 +0000 (14:55 -0400)]
Use DOWN rather thabnd D in YAML.
Eric S. Raymond [Mon, 3 Jul 2017 16:52:28 +0000 (12:52 -0400)]
Use the raw buffer in tr command structure for editing.
This fixes some minor bugs. Unknown words are no longer truncated
nor uppercased on echo.
Eric S. Raymond [Mon, 3 Jul 2017 14:10:14 +0000 (10:10 -0400)]
Remove a bad command from a check log.
It's interfering with a refactor, and pathological cases really
ought to be checked elsewhere.
Eric S. Raymond [Mon, 3 Jul 2017 12:53:10 +0000 (08:53 -0400)]
Refactor tokenization to save raw tokens and use static buffer space...
...rather than dynamic storage.
As a side effect, this seems to have fixed a very ninor bug in the processing
of the bare word 'nothing'. But I don't know where the bug was. Not happy.
Eric S. Raymond [Mon, 3 Jul 2017 11:14:15 +0000 (07:14 -0400)]
Magic-number elimination.
Eric S. Raymond [Mon, 3 Jul 2017 11:00:42 +0000 (07:00 -0400)]
Named state labels for every not clause.
Eric S. Raymond [Mon, 3 Jul 2017 10:31:44 +0000 (06:31 -0400)]
Make the YAML less fussy.
Don't string-quote things that are semantically like enums.
Eric S. Raymond [Mon, 3 Jul 2017 10:08:37 +0000 (06:08 -0400)]
playermove() never returns false; simplify accordingly
NHOrus [Mon, 3 Jul 2017 04:30:53 +0000 (07:30 +0300)]
Visit room with breathtaking view
Try to extinguish a volcano
Closes #22
NHOrus [Mon, 3 Jul 2017 04:20:37 +0000 (07:20 +0300)]
Broke all logical or into multiline statement to show lcov's lies
Results are weird, some things that need to be checked aren't and
at least my local lcov doesn't show them as unchecked
NHOrus [Mon, 3 Jul 2017 03:46:24 +0000 (06:46 +0300)]
Unspk'd bivalve action, exposing more untested surface
NHOrus [Mon, 3 Jul 2017 03:29:02 +0000 (06:29 +0300)]
Unspk'd fly command
NHOrus [Mon, 3 Jul 2017 03:21:38 +0000 (06:21 +0300)]
Unspk'd listen and lock commands
NHOrus [Mon, 3 Jul 2017 03:12:19 +0000 (06:12 +0300)]
Unspk'd pour command
NHOrus [Mon, 3 Jul 2017 03:07:57 +0000 (06:07 +0300)]
Unspk and streamline eat command
NHOrus [Mon, 3 Jul 2017 02:59:57 +0000 (05:59 +0300)]
Removed helper function
NHOrus [Mon, 3 Jul 2017 02:41:49 +0000 (05:41 +0300)]
Wake dwarves differently
NHOrus [Mon, 3 Jul 2017 02:30:46 +0000 (05:30 +0300)]
Cover branch last branch of bird action
And remove distracting line from tests
Aaron Traas [Mon, 3 Jul 2017 02:04:42 +0000 (22:04 -0400)]
Coverage -- attack bird after game closed
Aaron Traas [Mon, 3 Jul 2017 01:56:49 +0000 (21:56 -0400)]
Remove testing for intransitive seperate from NO_OBJECT in attact()
because we look for it immediately below, and this code is never
reached. If it were, intransitive attacks would never work.
Aaron Traas [Mon, 3 Jul 2017 01:53:28 +0000 (21:53 -0400)]
Coverage -- corner cases in lock and find
Aaron Traas [Mon, 3 Jul 2017 01:41:53 +0000 (21:41 -0400)]
Coverage -- giant words
Aaron Traas [Mon, 3 Jul 2017 01:32:47 +0000 (21:32 -0400)]
Coverage -- intransitive attack
NHOrus [Sun, 2 Jul 2017 22:01:01 +0000 (01:01 +0300)]
Removed spk from wave, fixed compiler warning
NHOrus [Sun, 2 Jul 2017 21:47:17 +0000 (00:47 +0300)]
Undid unspeaking of wave, fixed test again.
Changed property math to helper function.
NHOrus [Sun, 2 Jul 2017 21:04:44 +0000 (00:04 +0300)]
Don't spk in wave and action
NHOrus [Sun, 2 Jul 2017 19:57:12 +0000 (22:57 +0300)]
More magic number elimination
NHOrus [Sun, 2 Jul 2017 19:27:41 +0000 (22:27 +0300)]
Unfalsify coverage check
Eric S. Raymond [Sun, 2 Jul 2017 19:32:50 +0000 (15:32 -0400)]
Magic-number elimination.
NHOrus [Sun, 2 Jul 2017 19:13:14 +0000 (22:13 +0300)]
More tests, multilined yaml
Eric S. Raymond [Sun, 2 Jul 2017 18:47:21 +0000 (14:47 -0400)]
Magic-number elimination.
NHOrus [Sun, 2 Jul 2017 18:07:44 +0000 (21:07 +0300)]
Attack content and dead bear
Eric S. Raymond [Sun, 2 Jul 2017 17:57:01 +0000 (13:57 -0400)]
Imprive coverage of cheat.
Aaron Traas [Sun, 2 Jul 2017 17:31:47 +0000 (13:31 -0400)]
Coverage - attack sitting bear
Jason S. Ninneman [Sun, 2 Jul 2017 17:36:51 +0000 (10:36 -0700)]
Eliminate the global game.blklin.
NHOrus [Sun, 2 Jul 2017 16:41:57 +0000 (19:41 +0300)]
Rationalize attack logic
Fix the compiler warnings about bunching ands with ors
Eric S. Raymond [Sun, 2 Jul 2017 17:22:50 +0000 (13:22 -0400)]
Magic-number elimination.
Jason S. Ninneman [Sun, 2 Jul 2017 16:54:33 +0000 (09:54 -0700)]
Bump save file version number.
Also add missing space in the version mesage.
Aaron Traas [Sun, 2 Jul 2017 16:49:46 +0000 (12:49 -0400)]
Test coverage: intransitive lock
Aaron Traas [Sun, 2 Jul 2017 16:49:29 +0000 (12:49 -0400)]
Eliminate unreachable code in lock()
Aaron Traas [Sun, 2 Jul 2017 16:26:04 +0000 (12:26 -0400)]
Add capabilities to cheat. Expand testing to cover.
Aaron Traas [Sun, 2 Jul 2017 06:46:04 +0000 (02:46 -0400)]
Moved application settings to settings_t struct
Since logfp, oldstyle, and prompt were application settings, rather than
have them all as global vars, move them to a single global var, seperate
from game state, as they aren't, technically, game state, but are
application settings.
Jason S. Ninneman [Sun, 2 Jul 2017 16:42:07 +0000 (09:42 -0700)]
Replace datime() with just time().
Also make the 'savetime' value meaningful.
This removes a separate library dependency on some systems.
Eric S. Raymond [Sun, 2 Jul 2017 16:39:56 +0000 (12:39 -0400)]
Change VERSION_SKEW message - save file cersion is now...
...decoupled from program version.
Eric S. Raymond [Sun, 2 Jul 2017 15:19:29 +0000 (11:19 -0400)]
Documentation polishing.
Eric S. Raymond [Sun, 2 Jul 2017 15:01:32 +0000 (11:01 -0400)]
Documentation polishing.
Eric S. Raymond [Sun, 2 Jul 2017 14:38:17 +0000 (10:38 -0400)]
Begin decomposing cond magic numbers.
NHOrus [Sun, 2 Jul 2017 14:50:42 +0000 (17:50 +0300)]
Fixed logic, documented it in notes and tests
NHOrus [Sun, 2 Jul 2017 13:27:20 +0000 (16:27 +0300)]
Fixed regression in #21 Cleaned up logic of light/extinguish
NHOrus [Sun, 2 Jul 2017 13:08:57 +0000 (16:08 +0300)]
Fix for issue #21, hopefully
NHOrus [Sun, 2 Jul 2017 08:36:29 +0000 (11:36 +0300)]
really capture it
NHOrus [Sun, 2 Jul 2017 08:16:29 +0000 (11:16 +0300)]
Capture current state of bugs, for #21
NHOrus [Sun, 2 Jul 2017 07:50:07 +0000 (10:50 +0300)]
Capture wonkyness of extinguishing urn