open-adventure.git
19 months agoMake build with conditional compilation easier.
Eric S. Raymond [Fri, 14 Apr 2023 10:16:29 +0000 (06:16 -0400)]
Make build with conditional compilation easier.

19 months agoRemove a remnant line number.
Eric S. Raymond [Mon, 10 Apr 2023 22:33:36 +0000 (18:33 -0400)]
Remove a remnant line number.

19 months agoMagic-number elimination.
Eric S. Raymond [Mon, 10 Apr 2023 14:28:18 +0000 (10:28 -0400)]
Magic-number elimination.

19 months agoCondition in alternative state-management macros.
Eric S. Raymond [Mon, 10 Apr 2023 22:46:47 +0000 (18:46 -0400)]
Condition in alternative state-management macros.

These do not entirely work yet. #define FOUNDBOOL to enable them.

All tests pass, 100% coverage.

19 months agoConfine use of STATE_NOTFOUND to macros.
Eric S. Raymond [Sun, 9 Apr 2023 02:53:06 +0000 (22:53 -0400)]
Confine use of STATE_NOTFOUND to macros.

19 months agoTurn an odd test into a macro disjunction.
Eric S. Raymond [Sun, 9 Apr 2023 01:17:55 +0000 (21:17 -0400)]
Turn an odd test into a macro disjunction.

Was game.objects[i].prop > STATE_NOTFOUND.

This finishes off all the statec comparisons we want to macroize.

19 months agoMore nontrivial macro abstraction of state checks.
Eric S. Raymond [Sun, 9 Apr 2023 00:20:36 +0000 (20:20 -0400)]
More nontrivial macro abstraction of state checks.

game.prop < 0 becomes an alternation of macros.

19 months agoFirst nontrivial replacement of object state test by macro.
Eric S. Raymond [Sun, 9 Apr 2023 00:02:27 +0000 (20:02 -0400)]
First nontrivial replacement of object state test by macro.

Test was game.objects[i].prop >= 0, but we know that state -1
(STATE_NOTFOUND) can't occiur here because the object is in
a lit room.

19 months agoEncapsulate object-state state tests and setttings in macros.
Eric S. Raymond [Fri, 7 Apr 2023 20:11:04 +0000 (16:11 -0400)]
Encapsulate object-state state tests and setttings in macros.

This isn't a complete refwctoring, just the part than can be done with
transparetly correct capture of inlinre logic into macros.

No logic changes. Tests pass, 100% coverage.

19 months agoRefactor put() function and calls.
Eric S. Raymond [Fri, 7 Apr 2023 17:19:51 +0000 (13:19 -0400)]
Refactor put() function and calls.

19 months agoRemove unneeded use of put().
Eric S. Raymond [Fri, 7 Apr 2023 17:09:57 +0000 (13:09 -0400)]
Remove unneeded use of put().

19 months agoAdd test for behavior of stashed objects in endgame.
Eric S. Raymond [Fri, 7 Apr 2023 16:33:52 +0000 (12:33 -0400)]
Add test for behavior of stashed objects in endgame.

19 months agoStructurization of hints.
Eric S. Raymond [Fri, 7 Apr 2023 14:52:16 +0000 (10:52 -0400)]
Structurization of hints.

19 months agoStructurize object info.
Eric S. Raymond [Fri, 7 Apr 2023 13:51:49 +0000 (09:51 -0400)]
Structurize object info.

19 months agoStructurize locatiuon info.
Eric S. Raymond [Fri, 7 Apr 2023 13:30:33 +0000 (09:30 -0400)]
Structurize locatiuon info.

19 months agoStructurize the informaruin about dwarves.
Eric S. Raymond [Fri, 7 Apr 2023 13:15:20 +0000 (09:15 -0400)]
Structurize the informaruin about dwarves.

19 months agoApply loc_t type.
Eric S. Raymond [Fri, 7 Apr 2023 12:18:50 +0000 (08:18 -0400)]
Apply loc_t type.

19 months agoBoolification.
Eric S. Raymond [Fri, 7 Apr 2023 11:35:28 +0000 (07:35 -0400)]
Boolification.

19 months agoSpelling fixes. 291/head
Torbjörn Andersson [Mon, 3 Apr 2023 17:05:58 +0000 (19:05 +0200)]
Spelling fixes.

19 months agoFix some screwy formatting of conditionals...
Eric S. Raymond [Fri, 7 Apr 2023 01:29:39 +0000 (21:29 -0400)]
Fix some screwy formatting of conditionals...

...probably by the original FOTRAN-to-C translator.

19 months agoComment typo fixes.
Eric S. Raymond [Fri, 7 Apr 2023 01:01:48 +0000 (21:01 -0400)]
Comment typo fixes.

19 months agoIn notes.adoc, update the new-features list and credits.
Eric S. Raymond [Thu, 6 Apr 2023 23:57:05 +0000 (19:57 -0400)]
In notes.adoc, update the new-features list and credits.

19 months agoResume now detects if a save has incompatible endianness.
Eric S. Raymond [Thu, 6 Apr 2023 23:35:56 +0000 (19:35 -0400)]
Resume now detects if a save has incompatible endianness.

19 months agoSimplify the signature of savefile().
Eric S. Raymond [Thu, 6 Apr 2023 23:26:04 +0000 (19:26 -0400)]
Simplify the signature of savefile().

19 months agoImplement the magic-cookie check and its test.
Eric S. Raymond [Thu, 6 Apr 2023 23:03:02 +0000 (19:03 -0400)]
Implement the magic-cookie check and its test.

19 months agoGive savefiles an identifting header. SAve format version gets bumped.
Eric S. Raymond [Thu, 6 Apr 2023 21:54:02 +0000 (17:54 -0400)]
Give savefiles an identifting header.  SAve format version gets bumped.

19 months agoRefactoring step - change some visibilities.
Eric S. Raymond [Thu, 6 Apr 2023 21:44:11 +0000 (17:44 -0400)]
Refactoring step - change some visibilities.

19 months agoQuiet make test down.
Eric S. Raymond [Thu, 6 Apr 2023 21:28:43 +0000 (17:28 -0400)]
Quiet make test down.

19 months agoSimplify and speed up testing.
Eric S. Raymond [Thu, 6 Apr 2023 20:38:21 +0000 (16:38 -0400)]
Simplify and speed up testing.

19 months agoComment typo fix
Eric S. Raymond [Thu, 6 Apr 2023 16:13:38 +0000 (12:13 -0400)]
Comment typo fix

19 months agoMagic-number elimination.
Eric S. Raymond [Thu, 6 Apr 2023 14:03:24 +0000 (10:03 -0400)]
Magic-number elimination.

19 months agoMove NEWS file to asciidoc.
Eric S. Raymond [Thu, 6 Apr 2023 01:48:02 +0000 (21:48 -0400)]
Move NEWS file to asciidoc.

19 months agoAdd some SPDX headers.
Eric S. Raymond [Thu, 6 Apr 2023 01:36:52 +0000 (21:36 -0400)]
Add some SPDX headers.

19 months agoImproved behavior when magic words are said before they're seen.
Eric S. Raymond [Wed, 5 Apr 2023 23:49:38 +0000 (19:49 -0400)]
Improved behavior when magic words are said before they're seen.

Note: there is a tiny risk that this could break savefile
compatibility, as I swiped an unused int member in the game structure
and turned it into a bool. int and bool *should* be the same sixe...

19 months agoMagic number removal.
Eric S. Raymond [Wed, 5 Apr 2023 22:02:47 +0000 (18:02 -0400)]
Magic number removal.

19 months agoGO_* enums no longer have an order constraint.
Eric S. Raymond [Wed, 5 Apr 2023 21:48:26 +0000 (17:48 -0400)]
GO_* enums no longer have an order constraint.

19 months agoHow to set up prerequisites for oldcompare
Eric S. Raymond [Tue, 4 Apr 2023 23:14:45 +0000 (19:14 -0400)]
How to set up prerequisites for oldcompare

19 months agoImprove TAP messages slightly.
Eric S. Raymond [Tue, 4 Apr 2023 13:53:10 +0000 (09:53 -0400)]
Improve TAP messages slightly.

19 months agoUpdate tapdiffer version.
Eric S. Raymond [Tue, 4 Apr 2023 13:32:18 +0000 (09:32 -0400)]
Update tapdiffer version.

19 months agoImprove copyright lines.
Eric S. Raymond [Mon, 3 Apr 2023 21:05:01 +0000 (17:05 -0400)]
Improve copyright lines.

19 months agoReady to ship 1.15. 1.15
Eric S. Raymond [Mon, 3 Apr 2023 15:34:58 +0000 (11:34 -0400)]
Ready to ship 1.15.

19 months agoCommenting fix.
Eric S. Raymond [Mon, 3 Apr 2023 15:36:20 +0000 (11:36 -0400)]
Commenting fix.

19 months agoDocumentation fix.
Eric S. Raymond [Mon, 3 Apr 2023 15:10:03 +0000 (11:10 -0400)]
Documentation fix.

19 months agoPartial REUSE cmpliance.
Eric S. Raymond [Mon, 3 Apr 2023 14:10:06 +0000 (10:10 -0400)]
Partial REUSE cmpliance.

19 months agoAdd explanatory comment.
Eric S. Raymond [Mon, 3 Apr 2023 13:42:55 +0000 (09:42 -0400)]
Add explanatory comment.

19 months agoFix for Gitlab issue #65: revisiting "fee fie foe foo" and "fum".
Eric S. Raymond [Mon, 3 Apr 2023 13:24:21 +0000 (09:24 -0400)]
Fix for Gitlab issue #65: revisiting "fee fie foe foo" and "fum".

100% coverage, "make oldcompare" passes.

19 months agoNothing but FOO can start a magic-word sequence,
Eric S. Raymond [Mon, 3 Apr 2023 10:10:12 +0000 (06:10 -0400)]
Nothing but FOO can start a magic-word sequence,

100% coverage ans oldcompare passes.

19 months agoBack out test lines that break compatibility with advent430.
Eric S. Raymond [Sun, 2 Apr 2023 22:28:45 +0000 (18:28 -0400)]
Back out test lines that break compatibility with advent430.

Coverage is still 100% even withthese lines commebted out.

19 months agoBack out the behavior change to magic words outside the Giant's Room.
Eric S. Raymond [Sun, 2 Apr 2023 21:53:09 +0000 (17:53 -0400)]
Back out the behavior change to magic words outside the Giant's Room.

There are twi reasons for this. One is to decompolicate verifying
the fix for issue $85: revisiting "fee fie foe foo" and "fum". The
other is because I'm now convinced that the test should notr be
"Are you in the Giant's Room" but :Have you read the grafitti there?

19 months agoConsolidate all magicwords tests into one file. 100% coverage.
Eric S. Raymond [Sun, 2 Apr 2023 20:03:42 +0000 (16:03 -0400)]
Consolidate all magicwords tests into one file. 100% coverage.

19 months agoThe oldcompare production no longer requires savefiles.
Eric S. Raymond [Sun, 2 Apr 2023 15:54:37 +0000 (11:54 -0400)]
The oldcompare production no longer requires savefiles.

19 months agoTest name change,
Eric S. Raymond [Sun, 2 Apr 2023 14:42:10 +0000 (10:42 -0400)]
Test name change,

19 months agoStart building a better test load for micwords.
Eric S. Raymond [Sun, 2 Apr 2023 14:23:07 +0000 (10:23 -0400)]
Start building a better test load for micwords.

19 months agoComment typo fixes.
Eric S. Raymond [Sun, 2 Apr 2023 11:41:49 +0000 (07:41 -0400)]
Comment typo fixes.

19 months agoSpelling fixes 290/head
Torbjörn Andersson [Sat, 1 Apr 2023 08:39:21 +0000 (10:39 +0200)]
Spelling fixes

19 months agoClose out oldcompare.
Eric S. Raymond [Sat, 1 Apr 2023 22:14:25 +0000 (18:14 -0400)]
Close out oldcompare.

At this revision all test logs either pass checkfile comparison
against advent439 or have a NOCOMPARE comment explaining why they don't
pass, turning into a TAP skip. 100% coverage.

19 months agoImprove advent430 comparisons.
Eric S. Raymond [Sat, 1 Apr 2023 20:58:52 +0000 (16:58 -0400)]
Improve advent430 comparisons.

19 months agoTest comment typo fixes.
Eric S. Raymond [Sat, 1 Apr 2023 15:34:46 +0000 (11:34 -0400)]
Test comment typo fixes.

19 months agoMerge two NOCOMPARE tests.
Eric S. Raymond [Sat, 1 Apr 2023 15:01:28 +0000 (11:01 -0400)]
Merge two NOCOMPARE tests.

19 months agoTweak a fuzzed test fotr advent430 compability. 100% coverage.
Eric S. Raymond [Sat, 1 Apr 2023 14:47:49 +0000 (10:47 -0400)]
Tweak a fuzzed test fotr advent430 compability. 100% coverage.

19 months agoAdd a warning comment.
Eric S. Raymond [Sat, 1 Apr 2023 12:46:44 +0000 (08:46 -0400)]
Add a warning comment.

19 months agoTrim the illformed test. Still 100% coverage.
Eric S. Raymond [Fri, 31 Mar 2023 00:09:10 +0000 (20:09 -0400)]
Trim the illformed test.  Still 100% coverage.

19 months agoAdd explanatory comments to two tests.
Eric S. Raymond [Thu, 30 Mar 2023 12:46:35 +0000 (08:46 -0400)]
Add explanatory comments to two tests.

19 months agoFactor out the test of the bare word "seed".
Eric S. Raymond [Thu, 30 Mar 2023 04:54:13 +0000 (00:54 -0400)]
Factor out the test of the  bare word "seed".

19 months agoFactor out most of illformed that doesn't cause advent430 problems.
Eric S. Raymond [Thu, 30 Mar 2023 04:05:13 +0000 (00:05 -0400)]
Factor out most of illformed that doesn't cause advent430 problems.

19 months agoAdd more NOCOMPARE exclusions due to version skew.
Eric S. Raymond [Thu, 30 Mar 2023 02:05:27 +0000 (22:05 -0400)]
Add more NOCOMPARE exclusions due to version skew.

19 months agoTruncatte bigfail test because the RNG gets confused by resurrection.
Eric S. Raymond [Wed, 29 Mar 2023 22:17:30 +0000 (18:17 -0400)]
Truncatte bigfail test because the RNG gets confused by resurrection.

19 months agoCoverage exclusions for -d.
Eric S. Raymond [Wed, 29 Mar 2023 22:16:43 +0000 (18:16 -0400)]
Coverage exclusions for -d.

19 months agoAdd -d option
Eric S. Raymond [Wed, 29 Mar 2023 20:04:36 +0000 (16:04 -0400)]
Add -d option

19 months agoMore test cleanup to converge with advent430 branch.
Eric S. Raymond [Wed, 29 Mar 2023 16:15:30 +0000 (12:15 -0400)]
More test cleanup to converge with advent430 branch.

19 months agoAdd a more carefully factored test...
Eric S. Raymond [Wed, 29 Mar 2023 14:59:42 +0000 (10:59 -0400)]
Add a more carefully factored test...

...so we can exclude the part advent430 won't pass.

19 months agoClean up some tests, adding newlines at EOF where they're missing.
Eric S. Raymond [Wed, 29 Mar 2023 14:55:56 +0000 (10:55 -0400)]
Clean up some tests, adding newlines at EOF where they're missing.

The advent430 command interpreter accidentally accepted input lines with no
trailing newline. Thus, these files produced spurious mismatches.

19 months agoAdd a useful warning to the tests makefile
Eric S. Raymond [Wed, 29 Mar 2023 13:33:01 +0000 (09:33 -0400)]
Add a useful warning to the tests makefile

19 months agoDocument a bugfix and isolate it in a test.
Eric S. Raymond [Wed, 29 Mar 2023 13:24:12 +0000 (09:24 -0400)]
Document a bugfix and isolate it in a test.

20 months agoImplement NOCOMPARE magic.
Eric S. Raymond [Thu, 23 Mar 2023 09:38:26 +0000 (05:38 -0400)]
Implement NOCOMPARE magic.

20 months agoTest simplification - we don't care about the difference in processing blank lines.
Eric S. Raymond [Thu, 23 Mar 2023 01:20:24 +0000 (21:20 -0400)]
Test simplification - we don't care about the difference in processing blank lines.

20 months agoReconciliation with advent430.
Eric S. Raymond [Thu, 23 Mar 2023 00:39:36 +0000 (20:39 -0400)]
Reconciliation with advent430.

20 months agoChange prompt generation to be more compatible with the advent430 branch.
Eric S. Raymond [Wed, 22 Mar 2023 21:09:14 +0000 (17:09 -0400)]
Change prompt generation to be more compatible with the advent430 branch.

20 months agoMinor fix to prompt generation.
Eric S. Raymond [Wed, 22 Mar 2023 21:03:50 +0000 (17:03 -0400)]
Minor fix to prompt generation.

20 months agoYAML markup fix.
Eric S. Raymond [Wed, 22 Mar 2023 14:30:10 +0000 (10:30 -0400)]
YAML markup fix.

20 months agoRemove redundant test.
Eric S. Raymond [Wed, 22 Mar 2023 10:40:03 +0000 (06:40 -0400)]
Remove redundant test.

20 months agoTest cleanup and reconvilation with advent430.
Eric S. Raymond [Wed, 22 Mar 2023 10:36:03 +0000 (06:36 -0400)]
Test cleanup and reconvilation with advent430.

20 months agoQuoting fixes in the YAML.
Eric S. Raymond [Wed, 22 Mar 2023 03:57:36 +0000 (23:57 -0400)]
Quoting fixes in the YAML.

20 months agoTAPify the ancient-diffs report.
Eric S. Raymond [Wed, 22 Mar 2023 03:25:43 +0000 (23:25 -0400)]
TAPify the ancient-diffs report.

20 months agoTest cleanup.
Eric S. Raymond [Wed, 22 Mar 2023 00:57:03 +0000 (20:57 -0400)]
Test cleanup.

20 months agoMove in the direction of being able to do ancient regression tests.
Eric S. Raymond [Tue, 21 Mar 2023 18:07:04 +0000 (14:07 -0400)]
Move in the direction of being able to do ancient regression tests.

20 months agoTesting simplification.
Eric S. Raymond [Thu, 16 Mar 2023 14:18:56 +0000 (10:18 -0400)]
Testing simplification.

20 months agoRevert "Tapify output of cheat."
Eric S. Raymond [Thu, 16 Mar 2023 14:15:47 +0000 (10:15 -0400)]
Revert "Tapify output of cheat."

There was a better way.

20 months agoMore TAPification.
Eric S. Raymond [Thu, 16 Mar 2023 12:51:57 +0000 (08:51 -0400)]
More TAPification.

20 months agoTapify output of cheat.
Eric S. Raymond [Thu, 16 Mar 2023 12:32:59 +0000 (08:32 -0400)]
Tapify output of cheat.

20 months agoAddress GitLab issue #66: Missing couple of ; in saveresume.c
Eric S. Raymond [Thu, 16 Mar 2023 11:43:17 +0000 (07:43 -0400)]
Address GitLab issue #66: Missing couple of ; in saveresume.c

20 months agoAvoid a compiler warning.
Eric S. Raymond [Tue, 14 Mar 2023 16:52:35 +0000 (12:52 -0400)]
Avoid a compiler warning.

20 months agoMagic-number elimination.
Eric S. Raymond [Tue, 14 Mar 2023 16:51:26 +0000 (12:51 -0400)]
Magic-number elimination.

20 months agoExperimental test production.
Eric S. Raymond [Tue, 14 Mar 2023 15:35:57 +0000 (11:35 -0400)]
Experimental test production.

20 months agoComment polishing.
Eric S. Raymond [Sun, 12 Mar 2023 21:59:10 +0000 (17:59 -0400)]
Comment polishing.

20 months agoReal test coverage dor SAVE_TAMPERING.
Eric S. Raymond [Sun, 12 Mar 2023 21:37:58 +0000 (17:37 -0400)]
Real test coverage dor SAVE_TAMPERING.

20 months agoCleann up scratchfile after tesrs.
Eric S. Raymond [Sun, 12 Mar 2023 21:21:15 +0000 (17:21 -0400)]
Cleann up scratchfile after tesrs.

20 months agoComment polishing.
Eric S. Raymond [Sun, 12 Mar 2023 21:14:18 +0000 (17:14 -0400)]
Comment polishing.

20 months agoDocumentation polishing.
Eric S. Raymond [Sun, 12 Mar 2023 16:58:11 +0000 (12:58 -0400)]
Documentation polishing.

20 months agoNEWS update.
Eric S. Raymond [Sun, 12 Mar 2023 16:41:13 +0000 (12:41 -0400)]
NEWS update.