Eric S. Raymond [Mon, 3 Jul 2017 18:55:34 +0000 (14:55 -0400)]
Use DOWN rather thabnd D in YAML.
Eric S. Raymond [Mon, 3 Jul 2017 16:52:28 +0000 (12:52 -0400)]
Use the raw buffer in tr command structure for editing.
This fixes some minor bugs. Unknown words are no longer truncated
nor uppercased on echo.
Eric S. Raymond [Mon, 3 Jul 2017 14:10:14 +0000 (10:10 -0400)]
Remove a bad command from a check log.
It's interfering with a refactor, and pathological cases really
ought to be checked elsewhere.
Eric S. Raymond [Mon, 3 Jul 2017 12:53:10 +0000 (08:53 -0400)]
Refactor tokenization to save raw tokens and use static buffer space...
...rather than dynamic storage.
As a side effect, this seems to have fixed a very ninor bug in the processing
of the bare word 'nothing'. But I don't know where the bug was. Not happy.
Eric S. Raymond [Mon, 3 Jul 2017 11:14:15 +0000 (07:14 -0400)]
Magic-number elimination.
Eric S. Raymond [Mon, 3 Jul 2017 11:00:42 +0000 (07:00 -0400)]
Named state labels for every not clause.
Eric S. Raymond [Mon, 3 Jul 2017 10:31:44 +0000 (06:31 -0400)]
Make the YAML less fussy.
Don't string-quote things that are semantically like enums.
Eric S. Raymond [Mon, 3 Jul 2017 10:08:37 +0000 (06:08 -0400)]
playermove() never returns false; simplify accordingly
NHOrus [Mon, 3 Jul 2017 04:30:53 +0000 (07:30 +0300)]
Visit room with breathtaking view
Try to extinguish a volcano
Closes #22
NHOrus [Mon, 3 Jul 2017 04:20:37 +0000 (07:20 +0300)]
Broke all logical or into multiline statement to show lcov's lies
Results are weird, some things that need to be checked aren't and
at least my local lcov doesn't show them as unchecked
NHOrus [Mon, 3 Jul 2017 03:46:24 +0000 (06:46 +0300)]
Unspk'd bivalve action, exposing more untested surface
NHOrus [Mon, 3 Jul 2017 03:29:02 +0000 (06:29 +0300)]
Unspk'd fly command
NHOrus [Mon, 3 Jul 2017 03:21:38 +0000 (06:21 +0300)]
Unspk'd listen and lock commands
NHOrus [Mon, 3 Jul 2017 03:12:19 +0000 (06:12 +0300)]
Unspk'd pour command
NHOrus [Mon, 3 Jul 2017 03:07:57 +0000 (06:07 +0300)]
Unspk and streamline eat command
NHOrus [Mon, 3 Jul 2017 02:59:57 +0000 (05:59 +0300)]
Removed helper function
NHOrus [Mon, 3 Jul 2017 02:41:49 +0000 (05:41 +0300)]
Wake dwarves differently
NHOrus [Mon, 3 Jul 2017 02:30:46 +0000 (05:30 +0300)]
Cover branch last branch of bird action
And remove distracting line from tests
Aaron Traas [Mon, 3 Jul 2017 02:04:42 +0000 (22:04 -0400)]
Coverage -- attack bird after game closed
Aaron Traas [Mon, 3 Jul 2017 01:56:49 +0000 (21:56 -0400)]
Remove testing for intransitive seperate from NO_OBJECT in attact()
because we look for it immediately below, and this code is never
reached. If it were, intransitive attacks would never work.
Aaron Traas [Mon, 3 Jul 2017 01:53:28 +0000 (21:53 -0400)]
Coverage -- corner cases in lock and find
Aaron Traas [Mon, 3 Jul 2017 01:41:53 +0000 (21:41 -0400)]
Coverage -- giant words
Aaron Traas [Mon, 3 Jul 2017 01:32:47 +0000 (21:32 -0400)]
Coverage -- intransitive attack
NHOrus [Sun, 2 Jul 2017 22:01:01 +0000 (01:01 +0300)]
Removed spk from wave, fixed compiler warning
NHOrus [Sun, 2 Jul 2017 21:47:17 +0000 (00:47 +0300)]
Undid unspeaking of wave, fixed test again.
Changed property math to helper function.
NHOrus [Sun, 2 Jul 2017 21:04:44 +0000 (00:04 +0300)]
Don't spk in wave and action
NHOrus [Sun, 2 Jul 2017 19:57:12 +0000 (22:57 +0300)]
More magic number elimination
NHOrus [Sun, 2 Jul 2017 19:27:41 +0000 (22:27 +0300)]
Unfalsify coverage check
Eric S. Raymond [Sun, 2 Jul 2017 19:32:50 +0000 (15:32 -0400)]
Magic-number elimination.
NHOrus [Sun, 2 Jul 2017 19:13:14 +0000 (22:13 +0300)]
More tests, multilined yaml
Eric S. Raymond [Sun, 2 Jul 2017 18:47:21 +0000 (14:47 -0400)]
Magic-number elimination.
NHOrus [Sun, 2 Jul 2017 18:07:44 +0000 (21:07 +0300)]
Attack content and dead bear
Eric S. Raymond [Sun, 2 Jul 2017 17:57:01 +0000 (13:57 -0400)]
Imprive coverage of cheat.
Aaron Traas [Sun, 2 Jul 2017 17:31:47 +0000 (13:31 -0400)]
Coverage - attack sitting bear
Jason S. Ninneman [Sun, 2 Jul 2017 17:36:51 +0000 (10:36 -0700)]
Eliminate the global game.blklin.
NHOrus [Sun, 2 Jul 2017 16:41:57 +0000 (19:41 +0300)]
Rationalize attack logic
Fix the compiler warnings about bunching ands with ors
Eric S. Raymond [Sun, 2 Jul 2017 17:22:50 +0000 (13:22 -0400)]
Magic-number elimination.
Jason S. Ninneman [Sun, 2 Jul 2017 16:54:33 +0000 (09:54 -0700)]
Bump save file version number.
Also add missing space in the version mesage.
Aaron Traas [Sun, 2 Jul 2017 16:49:46 +0000 (12:49 -0400)]
Test coverage: intransitive lock
Aaron Traas [Sun, 2 Jul 2017 16:49:29 +0000 (12:49 -0400)]
Eliminate unreachable code in lock()
Aaron Traas [Sun, 2 Jul 2017 16:26:04 +0000 (12:26 -0400)]
Add capabilities to cheat. Expand testing to cover.
Aaron Traas [Sun, 2 Jul 2017 06:46:04 +0000 (02:46 -0400)]
Moved application settings to settings_t struct
Since logfp, oldstyle, and prompt were application settings, rather than
have them all as global vars, move them to a single global var, seperate
from game state, as they aren't, technically, game state, but are
application settings.
Jason S. Ninneman [Sun, 2 Jul 2017 16:42:07 +0000 (09:42 -0700)]
Replace datime() with just time().
Also make the 'savetime' value meaningful.
This removes a separate library dependency on some systems.
Eric S. Raymond [Sun, 2 Jul 2017 16:39:56 +0000 (12:39 -0400)]
Change VERSION_SKEW message - save file cersion is now...
...decoupled from program version.
Eric S. Raymond [Sun, 2 Jul 2017 15:19:29 +0000 (11:19 -0400)]
Documentation polishing.
Eric S. Raymond [Sun, 2 Jul 2017 15:01:32 +0000 (11:01 -0400)]
Documentation polishing.
Eric S. Raymond [Sun, 2 Jul 2017 14:38:17 +0000 (10:38 -0400)]
Begin decomposing cond magic numbers.
NHOrus [Sun, 2 Jul 2017 14:50:42 +0000 (17:50 +0300)]
Fixed logic, documented it in notes and tests
NHOrus [Sun, 2 Jul 2017 13:27:20 +0000 (16:27 +0300)]
Fixed regression in #21 Cleaned up logic of light/extinguish
NHOrus [Sun, 2 Jul 2017 13:08:57 +0000 (16:08 +0300)]
Fix for issue #21, hopefully
NHOrus [Sun, 2 Jul 2017 08:36:29 +0000 (11:36 +0300)]
really capture it
NHOrus [Sun, 2 Jul 2017 08:16:29 +0000 (11:16 +0300)]
Capture current state of bugs, for #21
NHOrus [Sun, 2 Jul 2017 07:50:07 +0000 (10:50 +0300)]
Capture wonkyness of extinguishing urn
NHOrus [Sun, 2 Jul 2017 07:16:03 +0000 (10:16 +0300)]
more tests
NHOrus [Sun, 2 Jul 2017 06:49:18 +0000 (09:49 +0300)]
Ability to use non-standard FreeBSD gcov tool
NHOrus [Sun, 2 Jul 2017 06:28:18 +0000 (09:28 +0300)]
Make include of dependency platform-generic
Aaron Traas [Sun, 2 Jul 2017 06:28:58 +0000 (02:28 -0400)]
Localize scope for restore file pointer in main.
Aaron Traas [Sun, 2 Jul 2017 06:14:41 +0000 (02:14 -0400)]
Coverage -- version command
Aaron Traas [Sun, 2 Jul 2017 06:02:09 +0000 (02:02 -0400)]
centralize calls to make_zzword()
make_zzword() now called in set_seed(), because the only times it was
called in the entire application is after every invocation of set_seed().
Aaron Traas [Sun, 2 Jul 2017 05:36:28 +0000 (01:36 -0400)]
Fixed -r option. Added test to make sure it doesn't break later.
Aaron Traas [Sun, 2 Jul 2017 05:17:14 +0000 (01:17 -0400)]
Changed usage message to multi-line string for cheat
Aaron Traas [Sun, 2 Jul 2017 05:07:53 +0000 (01:07 -0400)]
make_zzword() moved to initialize. Pruned unused stuff from cheat.c
Eric S. Raymond [Sun, 2 Jul 2017 03:51:24 +0000 (23:51 -0400)]
Improve test coverage.
Eric S. Raymond [Sun, 2 Jul 2017 03:33:57 +0000 (23:33 -0400)]
Rewrite dwarf-encounter ceck so coverage testing sees all predicates.
Eric S. Raymond [Sun, 2 Jul 2017 03:07:23 +0000 (23:07 -0400)]
More magic-number elimination.
Eric S. Raymond [Sun, 2 Jul 2017 02:50:08 +0000 (22:50 -0400)]
Magic-number elimination.
Wayne Conrad [Sat, 1 Jul 2017 21:25:29 +0000 (14:25 -0700)]
Fix typo in data comments
Wayne Conrad [Sat, 1 Jul 2017 21:24:41 +0000 (14:24 -0700)]
Fix typo in notes
Eric S. Raymond [Sat, 1 Jul 2017 22:56:46 +0000 (18:56 -0400)]
Supply missing implementation of nodwarf bit in travel rules.
Eric S. Raymond [Sat, 1 Jul 2017 18:20:34 +0000 (14:20 -0400)]
Another step in de-obscurifying the travel code.
Jason S. Ninneman [Sat, 1 Jul 2017 18:53:54 +0000 (11:53 -0700)]
Refactor specials[] to have strings instead of enum references.
Clean up arbitrary_messages[] accordingly.
Eric S. Raymond [Sat, 1 Jul 2017 18:03:01 +0000 (14:03 -0400)]
Minor refactor - create an equality function to simplify skip logic.
Jason S. Ninneman [Sat, 1 Jul 2017 18:03:20 +0000 (11:03 -0700)]
Never write the input prompt to log files.
Eric S. Raymond [Sat, 1 Jul 2017 16:51:12 +0000 (12:51 -0400)]
Forther break apart the magic enconding of travel arrays.
Eric S. Raymond [Sat, 1 Jul 2017 16:40:12 +0000 (12:40 -0400)]
Remove debris from a misclick.
Eric S. Raymond [Sat, 1 Jul 2017 16:34:44 +0000 (12:34 -0400)]
Ignore l g z i under oldstyle.
NHOrus [Sat, 1 Jul 2017 15:23:51 +0000 (18:23 +0300)]
Change state of vase
Clear temporary save where it needs to be cleared instead of random places
NHOrus [Sat, 1 Jul 2017 15:12:25 +0000 (18:12 +0300)]
Do not compare state to magic numbers
NHOrus [Sat, 1 Jul 2017 14:44:58 +0000 (17:44 +0300)]
Little more less magic in dragon state
Eric S. Raymond [Sat, 1 Jul 2017 15:01:06 +0000 (11:01 -0400)]
Documentation polishing.
Jason S. Ninneman [Sat, 1 Jul 2017 14:29:53 +0000 (07:29 -0700)]
Ensure libedit is installed for the pipeline jobs.
Jason S. Ninneman [Sat, 1 Jul 2017 14:27:37 +0000 (07:27 -0700)]
Attempt to unbreak pipeline.
Jason S. Ninneman [Sat, 1 Jul 2017 14:22:12 +0000 (07:22 -0700)]
Jettison the -s option.
It's no longer needed since libedit doesn't have the 'paste bug'.
Jason S. Ninneman [Sat, 1 Jul 2017 14:17:35 +0000 (07:17 -0700)]
Remove the linenoise submodule.
Jason S. Ninneman [Sat, 1 Jul 2017 14:14:27 +0000 (07:14 -0700)]
Move most build instructions into INSTALL.adoc.
Jason S. Ninneman [Sat, 1 Jul 2017 13:59:39 +0000 (06:59 -0700)]
Update documentation about the libedit conversion.
Jason S. Ninneman [Sat, 1 Jul 2017 13:51:00 +0000 (06:51 -0700)]
Replace linenoise with libedit in code and build.
Eric S. Raymond [Sat, 1 Jul 2017 13:58:45 +0000 (09:58 -0400)]
Magic-number elimination for dragon and rug.
NHOrus [Sat, 1 Jul 2017 13:46:51 +0000 (16:46 +0300)]
Reindend, compile out all save stuff
NHOrus [Sat, 1 Jul 2017 13:45:42 +0000 (16:45 +0300)]
Put stuff back in init, C-style
Jason S. Ninneman [Sat, 1 Jul 2017 13:21:37 +0000 (06:21 -0700)]
Apply DEMOTE_WORD().
Eric S. Raymond [Sat, 1 Jul 2017 13:21:04 +0000 (09:21 -0400)]
Magic-number and state-arithmetic removal.
Jason S. Ninneman [Sat, 1 Jul 2017 13:18:24 +0000 (06:18 -0700)]
Add a DEMOTE_WORD() macro.
Jason S. Ninneman [Sat, 1 Jul 2017 13:15:54 +0000 (06:15 -0700)]
Interim magic number replacement.
Eric S. Raymond [Sat, 1 Jul 2017 12:59:45 +0000 (08:59 -0400)]
Move PRNG initialization to simplify cheat.c
NHOrus [Sat, 1 Jul 2017 11:36:54 +0000 (14:36 +0300)]
Spread documentation from init.c It was empty without anything to document. Reindented, too
NHOrus [Sat, 1 Jul 2017 11:21:07 +0000 (14:21 +0300)]
Cut initialize in favor of implicit/default initialization where possible
NHOrus [Sat, 1 Jul 2017 08:50:49 +0000 (11:50 +0300)]
Putting cleanup in the right place, too
NHOrus [Sat, 1 Jul 2017 07:51:13 +0000 (10:51 +0300)]
Fix make debug check
Eric S. Raymond [Sat, 1 Jul 2017 12:35:05 +0000 (08:35 -0400)]
Without IGNORE, -Wunused-result throws a warning on fread(2).
I've seen it happen on fwrite(2) as well; wrapping that as well in
case some compiler decides to be finicky.