Update to use #:init-thunk instead of #:init-value on actions slot

[mudsync.git] / mudsync / room.scm

diff --git a/mudsync/room.scm b/mudsync/room.scm
index 8dc1d847fa6637d654eb4e729a62486382e9c00e..4c02e7fe3c8d3ed18601434cb0314f7d1a442763 100644 (file)
--- a/mudsync/room.scm
+++ b/mudsync/room.scm
@@ -82,7 +82,7 @@
    #:init-value (wrap %room-contain-commands))
 
   (actions #:allocation #:each-subclass
-           #:init-value
+           #:init-thunk
            (build-actions
             (cmd-go room-cmd-go)
             (cmd-go-where room-cmd-go-where)
@@ -134,23 +134,6 @@
 
 ;;; look commands
 
-(define (list-words-as-string words)
-  "A little utility for listing a bunch of words in an English-style list"
-  ;; TODO: This could be made faster by traversing the O(n)
-  ;;   list once, not twice
-  (let ((word-length (length words)))
-    (cond 
-     ((eqv? word-length 0) "")
-     ((eqv? word-length 1) (car words))
-     (else
-      ;; TODO: and this is NOT efficient
-      (string-append
-       (string-join
-        (drop-right words 1)
-        ", ")
-       " and "
-       (last words))))))
-
 (define (room-player-looks-around room player-id)
   "Handle looking around the room"
   ;; Get the room text
@@ -180,7 +163,8 @@
     (if (eq? occupant-names-filtered '())
         #f
         (format #f "You see here: ~a.\n"
-                (list-words-as-string occupant-names-filtered))))
+                (string-join occupant-names-filtered
+                             ", "))))
 
   (define final-text
     (if occupant-names-string
@@ -227,10 +211,8 @@
            (mbody-val (<-wait matching-object 'get-desc
                             #:whos-looking (message-from message)))))
       (if obj-desc
-          (<- (message-from message) 'tell
-              #:text (string-append obj-desc "\n"))
-          (<- (message-from message) 'tell
-              #:text (string-append %formless-desc "\n")))))
+          (<- (message-from message) 'tell #:text obj-desc)
+          (<- (message-from message) 'tell #:text %formless-desc))))
    (else
     (<- (message-from message) 'tell
         #:text "You don't see that here, so you can't look at it.\n"))))