open-adventure.git
19 months agoMagic-number elimination.
Eric S. Raymond [Thu, 6 Apr 2023 14:03:24 +0000 (10:03 -0400)]
Magic-number elimination.

19 months agoMove NEWS file to asciidoc.
Eric S. Raymond [Thu, 6 Apr 2023 01:48:02 +0000 (21:48 -0400)]
Move NEWS file to asciidoc.

19 months agoAdd some SPDX headers.
Eric S. Raymond [Thu, 6 Apr 2023 01:36:52 +0000 (21:36 -0400)]
Add some SPDX headers.

19 months agoImproved behavior when magic words are said before they're seen.
Eric S. Raymond [Wed, 5 Apr 2023 23:49:38 +0000 (19:49 -0400)]
Improved behavior when magic words are said before they're seen.

Note: there is a tiny risk that this could break savefile
compatibility, as I swiped an unused int member in the game structure
and turned it into a bool. int and bool *should* be the same sixe...

19 months agoMagic number removal.
Eric S. Raymond [Wed, 5 Apr 2023 22:02:47 +0000 (18:02 -0400)]
Magic number removal.

19 months agoGO_* enums no longer have an order constraint.
Eric S. Raymond [Wed, 5 Apr 2023 21:48:26 +0000 (17:48 -0400)]
GO_* enums no longer have an order constraint.

19 months agoHow to set up prerequisites for oldcompare
Eric S. Raymond [Tue, 4 Apr 2023 23:14:45 +0000 (19:14 -0400)]
How to set up prerequisites for oldcompare

19 months agoImprove TAP messages slightly.
Eric S. Raymond [Tue, 4 Apr 2023 13:53:10 +0000 (09:53 -0400)]
Improve TAP messages slightly.

19 months agoUpdate tapdiffer version.
Eric S. Raymond [Tue, 4 Apr 2023 13:32:18 +0000 (09:32 -0400)]
Update tapdiffer version.

19 months agoImprove copyright lines.
Eric S. Raymond [Mon, 3 Apr 2023 21:05:01 +0000 (17:05 -0400)]
Improve copyright lines.

19 months agoReady to ship 1.15. 1.15
Eric S. Raymond [Mon, 3 Apr 2023 15:34:58 +0000 (11:34 -0400)]
Ready to ship 1.15.

19 months agoCommenting fix.
Eric S. Raymond [Mon, 3 Apr 2023 15:36:20 +0000 (11:36 -0400)]
Commenting fix.

19 months agoDocumentation fix.
Eric S. Raymond [Mon, 3 Apr 2023 15:10:03 +0000 (11:10 -0400)]
Documentation fix.

19 months agoPartial REUSE cmpliance.
Eric S. Raymond [Mon, 3 Apr 2023 14:10:06 +0000 (10:10 -0400)]
Partial REUSE cmpliance.

19 months agoAdd explanatory comment.
Eric S. Raymond [Mon, 3 Apr 2023 13:42:55 +0000 (09:42 -0400)]
Add explanatory comment.

19 months agoFix for Gitlab issue #65: revisiting "fee fie foe foo" and "fum".
Eric S. Raymond [Mon, 3 Apr 2023 13:24:21 +0000 (09:24 -0400)]
Fix for Gitlab issue #65: revisiting "fee fie foe foo" and "fum".

100% coverage, "make oldcompare" passes.

19 months agoNothing but FOO can start a magic-word sequence,
Eric S. Raymond [Mon, 3 Apr 2023 10:10:12 +0000 (06:10 -0400)]
Nothing but FOO can start a magic-word sequence,

100% coverage ans oldcompare passes.

19 months agoBack out test lines that break compatibility with advent430.
Eric S. Raymond [Sun, 2 Apr 2023 22:28:45 +0000 (18:28 -0400)]
Back out test lines that break compatibility with advent430.

Coverage is still 100% even withthese lines commebted out.

19 months agoBack out the behavior change to magic words outside the Giant's Room.
Eric S. Raymond [Sun, 2 Apr 2023 21:53:09 +0000 (17:53 -0400)]
Back out the behavior change to magic words outside the Giant's Room.

There are twi reasons for this. One is to decompolicate verifying
the fix for issue $85: revisiting "fee fie foe foo" and "fum". The
other is because I'm now convinced that the test should notr be
"Are you in the Giant's Room" but :Have you read the grafitti there?

19 months agoConsolidate all magicwords tests into one file. 100% coverage.
Eric S. Raymond [Sun, 2 Apr 2023 20:03:42 +0000 (16:03 -0400)]
Consolidate all magicwords tests into one file. 100% coverage.

19 months agoThe oldcompare production no longer requires savefiles.
Eric S. Raymond [Sun, 2 Apr 2023 15:54:37 +0000 (11:54 -0400)]
The oldcompare production no longer requires savefiles.

19 months agoTest name change,
Eric S. Raymond [Sun, 2 Apr 2023 14:42:10 +0000 (10:42 -0400)]
Test name change,

19 months agoStart building a better test load for micwords.
Eric S. Raymond [Sun, 2 Apr 2023 14:23:07 +0000 (10:23 -0400)]
Start building a better test load for micwords.

19 months agoComment typo fixes.
Eric S. Raymond [Sun, 2 Apr 2023 11:41:49 +0000 (07:41 -0400)]
Comment typo fixes.

19 months agoSpelling fixes 290/head
Torbjörn Andersson [Sat, 1 Apr 2023 08:39:21 +0000 (10:39 +0200)]
Spelling fixes

19 months agoClose out oldcompare.
Eric S. Raymond [Sat, 1 Apr 2023 22:14:25 +0000 (18:14 -0400)]
Close out oldcompare.

At this revision all test logs either pass checkfile comparison
against advent439 or have a NOCOMPARE comment explaining why they don't
pass, turning into a TAP skip. 100% coverage.

19 months agoImprove advent430 comparisons.
Eric S. Raymond [Sat, 1 Apr 2023 20:58:52 +0000 (16:58 -0400)]
Improve advent430 comparisons.

19 months agoTest comment typo fixes.
Eric S. Raymond [Sat, 1 Apr 2023 15:34:46 +0000 (11:34 -0400)]
Test comment typo fixes.

19 months agoMerge two NOCOMPARE tests.
Eric S. Raymond [Sat, 1 Apr 2023 15:01:28 +0000 (11:01 -0400)]
Merge two NOCOMPARE tests.

19 months agoTweak a fuzzed test fotr advent430 compability. 100% coverage.
Eric S. Raymond [Sat, 1 Apr 2023 14:47:49 +0000 (10:47 -0400)]
Tweak a fuzzed test fotr advent430 compability. 100% coverage.

19 months agoAdd a warning comment.
Eric S. Raymond [Sat, 1 Apr 2023 12:46:44 +0000 (08:46 -0400)]
Add a warning comment.

19 months agoTrim the illformed test. Still 100% coverage.
Eric S. Raymond [Fri, 31 Mar 2023 00:09:10 +0000 (20:09 -0400)]
Trim the illformed test.  Still 100% coverage.

19 months agoAdd explanatory comments to two tests.
Eric S. Raymond [Thu, 30 Mar 2023 12:46:35 +0000 (08:46 -0400)]
Add explanatory comments to two tests.

19 months agoFactor out the test of the bare word "seed".
Eric S. Raymond [Thu, 30 Mar 2023 04:54:13 +0000 (00:54 -0400)]
Factor out the test of the  bare word "seed".

19 months agoFactor out most of illformed that doesn't cause advent430 problems.
Eric S. Raymond [Thu, 30 Mar 2023 04:05:13 +0000 (00:05 -0400)]
Factor out most of illformed that doesn't cause advent430 problems.

19 months agoAdd more NOCOMPARE exclusions due to version skew.
Eric S. Raymond [Thu, 30 Mar 2023 02:05:27 +0000 (22:05 -0400)]
Add more NOCOMPARE exclusions due to version skew.

19 months agoTruncatte bigfail test because the RNG gets confused by resurrection.
Eric S. Raymond [Wed, 29 Mar 2023 22:17:30 +0000 (18:17 -0400)]
Truncatte bigfail test because the RNG gets confused by resurrection.

19 months agoCoverage exclusions for -d.
Eric S. Raymond [Wed, 29 Mar 2023 22:16:43 +0000 (18:16 -0400)]
Coverage exclusions for -d.

19 months agoAdd -d option
Eric S. Raymond [Wed, 29 Mar 2023 20:04:36 +0000 (16:04 -0400)]
Add -d option

19 months agoMore test cleanup to converge with advent430 branch.
Eric S. Raymond [Wed, 29 Mar 2023 16:15:30 +0000 (12:15 -0400)]
More test cleanup to converge with advent430 branch.

19 months agoAdd a more carefully factored test...
Eric S. Raymond [Wed, 29 Mar 2023 14:59:42 +0000 (10:59 -0400)]
Add a more carefully factored test...

...so we can exclude the part advent430 won't pass.

19 months agoClean up some tests, adding newlines at EOF where they're missing.
Eric S. Raymond [Wed, 29 Mar 2023 14:55:56 +0000 (10:55 -0400)]
Clean up some tests, adding newlines at EOF where they're missing.

The advent430 command interpreter accidentally accepted input lines with no
trailing newline. Thus, these files produced spurious mismatches.

19 months agoAdd a useful warning to the tests makefile
Eric S. Raymond [Wed, 29 Mar 2023 13:33:01 +0000 (09:33 -0400)]
Add a useful warning to the tests makefile

19 months agoDocument a bugfix and isolate it in a test.
Eric S. Raymond [Wed, 29 Mar 2023 13:24:12 +0000 (09:24 -0400)]
Document a bugfix and isolate it in a test.

20 months agoImplement NOCOMPARE magic.
Eric S. Raymond [Thu, 23 Mar 2023 09:38:26 +0000 (05:38 -0400)]
Implement NOCOMPARE magic.

20 months agoTest simplification - we don't care about the difference in processing blank lines.
Eric S. Raymond [Thu, 23 Mar 2023 01:20:24 +0000 (21:20 -0400)]
Test simplification - we don't care about the difference in processing blank lines.

20 months agoReconciliation with advent430.
Eric S. Raymond [Thu, 23 Mar 2023 00:39:36 +0000 (20:39 -0400)]
Reconciliation with advent430.

20 months agoChange prompt generation to be more compatible with the advent430 branch.
Eric S. Raymond [Wed, 22 Mar 2023 21:09:14 +0000 (17:09 -0400)]
Change prompt generation to be more compatible with the advent430 branch.

20 months agoMinor fix to prompt generation.
Eric S. Raymond [Wed, 22 Mar 2023 21:03:50 +0000 (17:03 -0400)]
Minor fix to prompt generation.

20 months agoYAML markup fix.
Eric S. Raymond [Wed, 22 Mar 2023 14:30:10 +0000 (10:30 -0400)]
YAML markup fix.

20 months agoRemove redundant test.
Eric S. Raymond [Wed, 22 Mar 2023 10:40:03 +0000 (06:40 -0400)]
Remove redundant test.

20 months agoTest cleanup and reconvilation with advent430.
Eric S. Raymond [Wed, 22 Mar 2023 10:36:03 +0000 (06:36 -0400)]
Test cleanup and reconvilation with advent430.

20 months agoQuoting fixes in the YAML.
Eric S. Raymond [Wed, 22 Mar 2023 03:57:36 +0000 (23:57 -0400)]
Quoting fixes in the YAML.

20 months agoTAPify the ancient-diffs report.
Eric S. Raymond [Wed, 22 Mar 2023 03:25:43 +0000 (23:25 -0400)]
TAPify the ancient-diffs report.

20 months agoTest cleanup.
Eric S. Raymond [Wed, 22 Mar 2023 00:57:03 +0000 (20:57 -0400)]
Test cleanup.

20 months agoMove in the direction of being able to do ancient regression tests.
Eric S. Raymond [Tue, 21 Mar 2023 18:07:04 +0000 (14:07 -0400)]
Move in the direction of being able to do ancient regression tests.

20 months agoTesting simplification.
Eric S. Raymond [Thu, 16 Mar 2023 14:18:56 +0000 (10:18 -0400)]
Testing simplification.

20 months agoRevert "Tapify output of cheat."
Eric S. Raymond [Thu, 16 Mar 2023 14:15:47 +0000 (10:15 -0400)]
Revert "Tapify output of cheat."

There was a better way.

20 months agoMore TAPification.
Eric S. Raymond [Thu, 16 Mar 2023 12:51:57 +0000 (08:51 -0400)]
More TAPification.

20 months agoTapify output of cheat.
Eric S. Raymond [Thu, 16 Mar 2023 12:32:59 +0000 (08:32 -0400)]
Tapify output of cheat.

20 months agoAddress GitLab issue #66: Missing couple of ; in saveresume.c
Eric S. Raymond [Thu, 16 Mar 2023 11:43:17 +0000 (07:43 -0400)]
Address GitLab issue #66: Missing couple of ; in saveresume.c

20 months agoAvoid a compiler warning.
Eric S. Raymond [Tue, 14 Mar 2023 16:52:35 +0000 (12:52 -0400)]
Avoid a compiler warning.

20 months agoMagic-number elimination.
Eric S. Raymond [Tue, 14 Mar 2023 16:51:26 +0000 (12:51 -0400)]
Magic-number elimination.

20 months agoExperimental test production.
Eric S. Raymond [Tue, 14 Mar 2023 15:35:57 +0000 (11:35 -0400)]
Experimental test production.

20 months agoComment polishing.
Eric S. Raymond [Sun, 12 Mar 2023 21:59:10 +0000 (17:59 -0400)]
Comment polishing.

20 months agoReal test coverage dor SAVE_TAMPERING.
Eric S. Raymond [Sun, 12 Mar 2023 21:37:58 +0000 (17:37 -0400)]
Real test coverage dor SAVE_TAMPERING.

20 months agoCleann up scratchfile after tesrs.
Eric S. Raymond [Sun, 12 Mar 2023 21:21:15 +0000 (17:21 -0400)]
Cleann up scratchfile after tesrs.

20 months agoComment polishing.
Eric S. Raymond [Sun, 12 Mar 2023 21:14:18 +0000 (17:14 -0400)]
Comment polishing.

20 months agoDocumentation polishing.
Eric S. Raymond [Sun, 12 Mar 2023 16:58:11 +0000 (12:58 -0400)]
Documentation polishing.

20 months agoNEWS update.
Eric S. Raymond [Sun, 12 Mar 2023 16:41:13 +0000 (12:41 -0400)]
NEWS update.

20 months agoWhitespace trimming of save and resume names.
Eric S. Raymond [Sun, 12 Mar 2023 15:15:04 +0000 (11:15 -0400)]
Whitespace trimming of save and resume names.

20 months agoAdd coverage exception now that SAVE_TAMPERING is back.
Eric S. Raymond [Sun, 12 Mar 2023 14:11:52 +0000 (10:11 -0400)]
Add coverage exception now that SAVE_TAMPERING is back.

20 months agoRelax the savefile validity check a little.
Eric S. Raymond [Sun, 12 Mar 2023 14:03:43 +0000 (10:03 -0400)]
Relax the savefile validity check a little.

There was a very old bug, probably predating the OpenAdventure port,
that would poke a stashed value of -1 into the snake object if you did
a save in endgame, and then fail the savefile validation on resume.
This was masked for a long time by a bug in put() just fixed a couple
of revisions ago.

20 months agoAdd message and bailout on invalid save.
Eric S. Raymond [Sun, 12 Mar 2023 10:39:57 +0000 (06:39 -0400)]
Add message and bailout on invalid save.

Note: save/resume still fails at saveresume.4
at this revision.

20 months agoDrop an attempt to pacify cppcheck that's no longer needed.
Eric S. Raymond [Sat, 11 Mar 2023 15:58:38 +0000 (10:58 -0500)]
Drop an attempt to pacify cppcheck that's no longer needed.

20 months agoAdd ANSI prototype,
Eric S. Raymond [Sat, 11 Mar 2023 15:40:01 +0000 (10:40 -0500)]
Add ANSI prototype,

20 months agoAdd C coverage exclsion required by unbreaking the property setter.
Eric S. Raymond [Sat, 11 Mar 2023 15:29:38 +0000 (10:29 -0500)]
Add C coverage exclsion required by unbreaking the property setter.

20 months agoFix a formal-type glitch.
Eric S. Raymond [Sat, 11 Mar 2023 14:41:07 +0000 (09:41 -0500)]
Fix a formal-type glitch.

20 months agoBugfix: bird starts caged in endgame.
Eric S. Raymond [Sat, 11 Mar 2023 14:35:26 +0000 (09:35 -0500)]
Bugfix: bird starts caged in endgame.

Turns out the code of put() had been modified ibcorrectly, but
the bug was masked in all but a few cases, noe of which would be
encountered in normal gameplay.

A test to ensure this bug does noit recur has been added.

20 months agoDocument a bugfix.
Eric S. Raymond [Fri, 10 Mar 2023 22:17:38 +0000 (17:17 -0500)]
Document a bugfix.

20 months agoFix interrupted-magic-words cosmetic bug.
Eric S. Raymond [Fri, 10 Mar 2023 21:43:27 +0000 (16:43 -0500)]
Fix interrupted-magic-words cosmetic bug.

C patch by Torbjörn Andersson.

20 months agoReady to ship 1.14. 1.14
Eric S. Raymond [Thu, 9 Mar 2023 15:16:22 +0000 (10:16 -0500)]
Ready to ship 1.14.

20 months agoFix whitespace glitch.
Eric S. Raymond [Thu, 9 Mar 2023 15:19:34 +0000 (10:19 -0500)]
Fix whitespace glitch.

20 months agoUse $(advent) rather than advent where needed.
Eric S. Raymond [Thu, 9 Mar 2023 13:54:20 +0000 (08:54 -0500)]
Use $(advent) rather than advent where needed.

20 months agoComplete fix of GitLab issue #64: Coverage summary looks wrong
Eric S. Raymond [Thu, 9 Mar 2023 03:55:12 +0000 (22:55 -0500)]
Complete fix of GitLab issue #64: Coverage summary looks wrong

20 months agoPartially address Gitlsb issue #64: Coverage summary looks wrong
Eric S. Raymond [Thu, 9 Mar 2023 02:54:45 +0000 (21:54 -0500)]
Partially address Gitlsb issue #64: Coverage summary looks wrong

20 months agoAnother typo fix. 289/head
Torbjörn Andersson [Wed, 8 Mar 2023 17:15:51 +0000 (18:15 +0100)]
Another typo fix.

20 months agoAdd a comment to the code that fixes the inventory-count bug.
Eric S. Raymond [Tue, 7 Mar 2023 12:56:04 +0000 (07:56 -0500)]
Add a comment to the code that fixes the inventory-count bug.

20 months agoDocumentation polishing.
Eric S. Raymond [Tue, 7 Mar 2023 04:51:52 +0000 (23:51 -0500)]
Documentation polishing.

20 months agoEliminate some forwards.
Eric S. Raymond [Tue, 7 Mar 2023 04:41:07 +0000 (23:41 -0500)]
Eliminate some forwards.

20 months agoImprove Makefile recipe for coverage testing.
Eric S. Raymond [Mon, 6 Mar 2023 17:23:40 +0000 (12:23 -0500)]
Improve Makefile recipe for coverage testing.

20 months agoAdd test for interspersed non-motion command amidst magic words.
Eric S. Raymond [Sun, 5 Mar 2023 01:26:13 +0000 (20:26 -0500)]
Add test for interspersed non-motion command amidst magic words.

20 months agoNEWS and notes.adoc update.
Eric S. Raymond [Sun, 5 Mar 2023 01:16:07 +0000 (20:16 -0500)]
NEWS and notes.adoc update.

20 months agoPrevent a spurious coverage error.
Eric S. Raymond [Sun, 5 Mar 2023 00:58:57 +0000 (19:58 -0500)]
Prevent a spurious coverage error.

20 months agoComplain to user on save/resume.restore when it's disabled.
Eric S. Raymond [Sun, 5 Mar 2023 00:48:17 +0000 (19:48 -0500)]
Complain to user on save/resume.restore when it's disabled.

20 months agoDocument -a option.
Eric S. Raymond [Fri, 3 Mar 2023 22:18:00 +0000 (17:18 -0500)]
Document -a option.

20 months agoAdd optional auto-save/restore feature using -a <filename> option 288/head
Rob Swindell (on Debian Linux) [Fri, 3 Mar 2023 03:44:47 +0000 (19:44 -0800)]
Add optional auto-save/restore feature using -a <filename> option

To enable use with online Bulletin Board Systems (BBSes) where users
may be disconnected unexpectedly, but would naturally want to resume
playing their same game, added support for an optional save game
path/filename to be specified on the command-line (very similar to
"-r <filename>"), except this save/restore file is:
1. automatically loaded/restored if it exists
2. automatically created when starting a new game
3. automatically updated when exiting a game for any reason
4. cannot be changed to a different path/filename by the user

Since a BBS server program can be expected to send a SIGHUP or SIGTERM
to the game process upon user disconnection (or timeout), those
signals are caught and a graceful termination will occur which saves
the current game state.

Build with ADVENT_AUTOSAVE defined to enable this option.

BUG:
The 'info' command still reports the save/suspend/pause commands as
valid, though they are not when this build option is used (same is
true of ADVENT_NOSAVE, and that doesn't apparently bother anyone).

20 months agoIncrease retrigressiveness of oldstyle a bit.
Eric S. Raymond [Wed, 1 Mar 2023 22:46:13 +0000 (17:46 -0500)]
Increase retrigressiveness of oldstyle a bit.

20 months agoComment typo fix.
Eric S. Raymond [Wed, 1 Mar 2023 21:03:13 +0000 (16:03 -0500)]
Comment typo fix.

20 months agoDon't crap out on failed diff.
Eric S. Raymond [Wed, 1 Mar 2023 19:01:44 +0000 (14:01 -0500)]
Don't crap out on failed diff.