projects
/
open-adventure.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
More goto elimination.
[open-adventure.git]
/
TODO
diff --git
a/TODO
b/TODO
index f8dc544d5af8234867f339f6dc653e322bfb1b38..62eef63e12afc119442a1d7813af9bfe4bd8127e 100644
(file)
--- a/
TODO
+++ b/
TODO
@@
-3,13
+3,15
@@
The FORTRANish mess that once was is now mostly idiomatic C. Some issues
remain to be cleaned up:
The FORTRANish mess that once was is now mostly idiomatic C. Some issues
remain to be cleaned up:
-* The remaining shared globals:
K, SPK,
WD1, WD1X, WD2, WD2X. These are used
+* The remaining shared globals: WD1, WD1X, WD2, WD2X. These are used
rather promiscuously to pass around information that ought to be function
rather promiscuously to pass around information that ought to be function
- arguments in a modern language.
K and SPK are particular offenders
+ arguments in a modern language.
-* Remaining unstructured gotos in playermove() and do_command().
+* Remaining unstructured gotos in playermove() and do_command(). The goto L12
+ in playermove() is particularly horrible, jumping backwards into the
+ middle of a loop.
* The way return values from handlers such as 2012 trigger side effects
* The way return values from handlers such as 2012 trigger side effects
- based on global state
such as K and SPK
is nasty.
+ based on global state is nasty.