kconfig: echo stdin to stdout if either is redirected
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Thu, 8 Feb 2018 05:56:40 +0000 (14:56 +0900)
committerChristian Lamparter <chunkeey@gmail.com>
Sun, 10 Feb 2019 20:58:40 +0000 (21:58 +0100)
commit1822e0e755a34e8f31dba5a03b7d0006eb7c803c
tree1255947094da8f8b77f556b55c3dba6d2e7ce26f
parent06d54e73fd0c3f59f892c2ba2605f0e8dcb8995f
kconfig: echo stdin to stdout if either is redirected

If stdio is not tty, conf_askvalue() puts additional new line to
prevent prompts from being concatenated into a single line.  This
care is missing in conf_choice(), so a 'choice' prompt and the next
prompt are shown in the same line.

Move the code into xfgets() to cater to all cases.  To improve this
more, let's echo stdin to stdout.  This clarifies what keys were
input from stdio and the stdout looks like as if it were from tty.

I removed the isatty(2) check since stderr is unrelated here.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
config/conf.c