open-adventure.git
7 years agoMagic-number elimination.
Eric S. Raymond [Fri, 16 Jun 2017 12:55:53 +0000 (08:55 -0400)]
Magic-number elimination.

7 years agoRemove total-ordering assumption.
Eric S. Raymond [Fri, 16 Jun 2017 12:39:01 +0000 (08:39 -0400)]
Remove total-ordering assumption.

7 years agoMagic-number elimination.
Eric S. Raymond [Fri, 16 Jun 2017 11:00:57 +0000 (07:00 -0400)]
Magic-number elimination.

7 years agoCode simplification.
Eric S. Raymond [Fri, 16 Jun 2017 10:44:22 +0000 (06:44 -0400)]
Code simplification.

7 years agoReduce verbosity.
Eric S. Raymond [Fri, 16 Jun 2017 01:36:06 +0000 (21:36 -0400)]
Reduce verbosity.

7 years agoSquasgh -Wextra warnings.
Eric S. Raymond [Thu, 15 Jun 2017 23:39:43 +0000 (19:39 -0400)]
Squasgh -Wextra warnings.

7 years agoDocumentation polishing.
Eric S. Raymond [Thu, 15 Jun 2017 21:58:52 +0000 (17:58 -0400)]
Documentation polishing.

7 years agoDocumentation polishing.
Eric S. Raymond [Thu, 15 Jun 2017 21:39:53 +0000 (17:39 -0400)]
Documentation polishing.

7 years agoName another magic number.
Eric S. Raymond [Thu, 15 Jun 2017 21:34:06 +0000 (17:34 -0400)]
Name another magic number.

7 years agoAdd regression test for seed crash bug.
Eric S. Raymond [Thu, 15 Jun 2017 20:58:48 +0000 (16:58 -0400)]
Add regression test for seed crash bug.

7 years agoDon't do dwarf moves after a fallback command.
Eric S. Raymond [Thu, 15 Jun 2017 20:54:29 +0000 (16:54 -0400)]
Don't do dwarf moves after a fallback command.

Avoids a crash bug.

7 years agoComment fix.
Eric S. Raymond [Thu, 15 Jun 2017 16:20:49 +0000 (12:20 -0400)]
Comment fix.

7 years agoMagic-numnber elimination.
Eric S. Raymond [Thu, 15 Jun 2017 16:18:37 +0000 (12:18 -0400)]
Magic-numnber elimination.

7 years agoMerge branch 'master' into actions-arithmetic 84/head
Peje Nilsson [Thu, 15 Jun 2017 15:33:15 +0000 (17:33 +0200)]
Merge branch 'master' into actions-arithmetic

7 years agoMore use of manifeat constants.
Eric S. Raymond [Thu, 15 Jun 2017 15:15:45 +0000 (11:15 -0400)]
More use of manifeat constants.

7 years agoFix arithmetic on message number
Peje Nilsson [Thu, 15 Jun 2017 15:01:10 +0000 (17:01 +0200)]
Fix arithmetic on message number

7 years agoMore use of manifest constants.
Eric S. Raymond [Thu, 15 Jun 2017 14:59:43 +0000 (10:59 -0400)]
More use of manifest constants.

7 years agoUse symbolic shortnames for locations.
Eric S. Raymond [Thu, 15 Jun 2017 14:31:26 +0000 (10:31 -0400)]
Use symbolic shortnames for locations.

7 years agoLocalizing variables 82/head 83/head
NHOrus [Thu, 15 Jun 2017 13:16:21 +0000 (16:16 +0300)]
Localizing variables

7 years agoUse LOC_* constants for locations. Clean up some ARB_* constants.
Eric S. Raymond [Thu, 15 Jun 2017 12:49:47 +0000 (08:49 -0400)]
Use LOC_* constants for locations. Clean up some ARB_* constants.

7 years agoMeaningful shortnames for RSPEAK messages.
Eric S. Raymond [Thu, 15 Jun 2017 11:35:03 +0000 (07:35 -0400)]
Meaningful shortnames for RSPEAK messages.

7 years agoMore ARB tagging.
Eric S. Raymond [Thu, 15 Jun 2017 11:16:39 +0000 (07:16 -0400)]
More ARB tagging.

7 years agoImprove test coverage 81/head
NHOrus [Thu, 15 Jun 2017 06:49:29 +0000 (09:49 +0300)]
Improve test coverage

7 years agodungeon now outputs just database.h 80/head
Bob Little [Thu, 15 Jun 2017 01:54:49 +0000 (21:54 -0400)]
dungeon now outputs just database.h

Added macro DEFINE_GLOBALS_FROM_INCLUDES to main.c
Makefile no longer has to deal with database.c and database.o

7 years agoPut the long and short location descriptions into a 'locations' data structure. 79/head
Jason S. Ninneman [Wed, 14 Jun 2017 23:45:49 +0000 (16:45 -0700)]
Put the long and short location descriptions into a 'locations' data structure.

They're renamed 'small' and 'big' to avoid colliding with C reserved words.

7 years agoClean up remnant magic labels.
Eric S. Raymond [Wed, 14 Jun 2017 21:41:01 +0000 (17:41 -0400)]
Clean up remnant magic labels.

7 years agoMove from random message numbers to ARB_* symbols generate from YAML.
Eric S. Raymond [Wed, 14 Jun 2017 21:36:30 +0000 (17:36 -0400)]
Move from random message numbers to ARB_* symbols generate from YAML.

7 years agoDocument build-time dependencies.
Eric S. Raymond [Wed, 14 Jun 2017 21:12:00 +0000 (17:12 -0400)]
Document build-time dependencies.

7 years agoRepair a checkfile.
Eric S. Raymond [Wed, 14 Jun 2017 20:59:26 +0000 (16:59 -0400)]
Repair a checkfile.

7 years agoFix some Makefile glitches. 78/head
Jason S. Ninneman [Wed, 14 Jun 2017 20:48:21 +0000 (13:48 -0700)]
Fix some Makefile glitches.

7 years agoUse Python 3's pip.
Jason S. Ninneman [Wed, 14 Jun 2017 20:36:10 +0000 (13:36 -0700)]
Use Python 3's pip.

7 years agoUpdate pipeline for python3 and PyYAML.
Jason S. Ninneman [Wed, 14 Jun 2017 20:28:59 +0000 (13:28 -0700)]
Update pipeline for python3 and PyYAML.

7 years agogit-ignore newdb.[ch].
Jason S. Ninneman [Wed, 14 Jun 2017 20:25:36 +0000 (13:25 -0700)]
git-ignore newdb.[ch].

7 years agoRun python3 explicitly at build.
Jason S. Ninneman [Wed, 14 Jun 2017 18:39:01 +0000 (11:39 -0700)]
Run python3 explicitly at build.

7 years agoGenerate newdb.[ch] at build time, parallel with database.[ch].
Jason S. Ninneman [Wed, 14 Jun 2017 18:32:41 +0000 (11:32 -0700)]
Generate newdb.[ch] at build time, parallel with database.[ch].

Having two data compile jobs is a temporary situation. Eventually newdb.[ch] will supersede database.[ch].

7 years agoRemove newdb.[ch] from version control.
Jason S. Ninneman [Wed, 14 Jun 2017 15:33:01 +0000 (08:33 -0700)]
Remove newdb.[ch] from version control.

7 years agoNew dungeon compiler to gradually replace the existing one.
Jason S. Ninneman [Wed, 14 Jun 2017 15:32:31 +0000 (08:32 -0700)]
New dungeon compiler to gradually replace the existing one.

7 years agoAdd test for feeding ogre.
Eric S. Raymond [Wed, 14 Jun 2017 20:53:45 +0000 (16:53 -0400)]
Add test for feeding ogre.

7 years agoImprove test coverage.
Eric S. Raymond [Wed, 14 Jun 2017 20:35:10 +0000 (16:35 -0400)]
Improve test coverage.

7 years agoLowering the scope And cleaning up some warnings from static analysis
NHOrus [Wed, 14 Jun 2017 19:08:43 +0000 (22:08 +0300)]
Lowering the scope And cleaning up some warnings from static analysis

7 years agoFix handling of intransitive "say".
Eric S. Raymond [Wed, 14 Jun 2017 19:15:00 +0000 (15:15 -0400)]
Fix handling of intransitive "say".

7 years agoEliminate magic return value.
Eric S. Raymond [Wed, 14 Jun 2017 17:35:06 +0000 (13:35 -0400)]
Eliminate magic return value.

7 years agoInclude LCG state in game saves.
Eric S. Raymond [Wed, 14 Jun 2017 17:00:28 +0000 (13:00 -0400)]
Include LCG state in game saves.

7 years agoFix a minor memory leak.
Eric S. Raymond [Wed, 14 Jun 2017 12:50:41 +0000 (08:50 -0400)]
Fix a minor memory leak.

7 years agoAdd statistic on coverage extent.
Eric S. Raymond [Wed, 14 Jun 2017 12:47:24 +0000 (08:47 -0400)]
Add statistic on coverage extent.

7 years agoRun the rm in the same subshell
Peje Nilsson [Wed, 14 Jun 2017 11:23:58 +0000 (11:23 +0000)]
Run the rm in the same subshell

7 years agoRepair and simplify complicated pirare-robbery logic.
Eric S. Raymond [Wed, 14 Jun 2017 12:26:49 +0000 (08:26 -0400)]
Repair and simplify complicated pirare-robbery logic.

I think we previously mistranslated this in a way that didn't show up
because it would only manifest if you found the penultimare treasure
without encountering the pirate.

This version is much easier to understand.

7 years agoExtend test coverage to novice mode.
Eric S. Raymond [Wed, 14 Jun 2017 10:41:04 +0000 (06:41 -0400)]
Extend test coverage to novice mode.

7 years agoIncrease test coverage.
Eric S. Raymond [Wed, 14 Jun 2017 10:34:43 +0000 (06:34 -0400)]
Increase test coverage.

7 years agoIncrease test coverage.
Eric S. Raymond [Wed, 14 Jun 2017 10:02:42 +0000 (06:02 -0400)]
Increase test coverage.

7 years agoImprove test coverage.
Eric S. Raymond [Wed, 14 Jun 2017 09:44:45 +0000 (05:44 -0400)]
Improve test coverage.

7 years agoDe-FORTRANize the code.
Eric S. Raymond [Wed, 14 Jun 2017 09:36:55 +0000 (05:36 -0400)]
De-FORTRANize the code.

7 years agoCode simplification.
Eric S. Raymond [Wed, 14 Jun 2017 00:06:07 +0000 (20:06 -0400)]
Code simplification.

7 years agoUse more C-like naming conventions for variables.
Eric S. Raymond [Tue, 13 Jun 2017 23:17:24 +0000 (19:17 -0400)]
Use more C-like naming conventions for variables.

7 years agoMagic-number elimination.
Eric S. Raymond [Tue, 13 Jun 2017 22:54:53 +0000 (18:54 -0400)]
Magic-number elimination.

7 years agoMakere magic numbers for cond bits into symbols.
Eric S. Raymond [Tue, 13 Jun 2017 22:38:04 +0000 (18:38 -0400)]
Makere magic numbers for cond bits into symbols.

7 years agoMore tests of nonsense in the forest.
Eric S. Raymond [Tue, 13 Jun 2017 21:48:05 +0000 (17:48 -0400)]
More tests of nonsense in the forest.

7 years agoCorrect a typo, and a test for the affected verb.
Eric S. Raymond [Tue, 13 Jun 2017 21:32:07 +0000 (17:32 -0400)]
Correct a typo, and a test for the affected verb.

7 years agoTypo fix.
Eric S. Raymond [Tue, 13 Jun 2017 21:13:38 +0000 (17:13 -0400)]
Typo fix.

7 years agoAdd test for urn actions.
Eric S. Raymond [Tue, 13 Jun 2017 21:02:52 +0000 (17:02 -0400)]
Add test for urn actions.

7 years agoFix compiler warnings.
Eric S. Raymond [Tue, 13 Jun 2017 18:33:19 +0000 (14:33 -0400)]
Fix compiler warnings.

7 years agoFix all the simple compiler warnings. 74/head
Jason S. Ninneman [Tue, 13 Jun 2017 18:15:43 +0000 (11:15 -0700)]
Fix all the simple compiler warnings.

7 years agoMax out compiler warnings, and rearrange the debug build recipe.
Jason S. Ninneman [Tue, 13 Jun 2017 18:15:22 +0000 (11:15 -0700)]
Max out compiler warnings, and rearrange the debug build recipe.

7 years agoRemove shadowing of variable 73/head
NHOrus [Tue, 13 Jun 2017 18:12:16 +0000 (21:12 +0300)]
Remove shadowing of variable

7 years agoTest for regression from before localizing SPK 72/head
NHOrus [Tue, 13 Jun 2017 17:49:01 +0000 (20:49 +0300)]
Test for regression from before localizing SPK

7 years agoImprove test coverage.
Eric S. Raymond [Tue, 13 Jun 2017 17:36:27 +0000 (13:36 -0400)]
Improve test coverage.

7 years agoDocumentation improvements.
Eric S. Raymond [Tue, 13 Jun 2017 17:13:30 +0000 (13:13 -0400)]
Documentation improvements.

7 years agoMove awqy from FORTRANISH conditionals.
Eric S. Raymond [Tue, 13 Jun 2017 16:47:34 +0000 (12:47 -0400)]
Move awqy from FORTRANISH conditionals.

7 years agoTypo fixes.
Eric S. Raymond [Tue, 13 Jun 2017 16:25:19 +0000 (12:25 -0400)]
Typo fixes.

7 years agoExplain the prompting logic more fully.
Eric S. Raymond [Tue, 13 Jun 2017 16:18:46 +0000 (12:18 -0400)]
Explain the prompting logic more fully.

7 years agoFix a minor bug in -l operation. Explain the input logic.
Eric S. Raymond [Tue, 13 Jun 2017 15:59:49 +0000 (11:59 -0400)]
Fix a minor bug in -l operation. Explain the input logic.

7 years agoCode simplification.
Eric S. Raymond [Tue, 13 Jun 2017 15:28:53 +0000 (11:28 -0400)]
Code simplification.

7 years agoCode simplification.
Eric S. Raymond [Tue, 13 Jun 2017 15:12:38 +0000 (11:12 -0400)]
Code simplification.

7 years agoMore test coverage.
Eric S. Raymond [Tue, 13 Jun 2017 14:57:03 +0000 (10:57 -0400)]
More test coverage.

7 years agoMore test coverage of odd cases.
Eric S. Raymond [Tue, 13 Jun 2017 14:43:06 +0000 (10:43 -0400)]
More test coverage of odd cases.

7 years agoAbolish setup check, there's no possibility of restart.
Eric S. Raymond [Tue, 13 Jun 2017 14:20:15 +0000 (10:20 -0400)]
Abolish setup check, there's no possibility of restart.

Note, this silently breaks old saves.

7 years agoAdd woods hint and hint display to test coverage.
Eric S. Raymond [Tue, 13 Jun 2017 14:05:48 +0000 (10:05 -0400)]
Add woods hint and hint display to test coverage.

7 years agoArrange test coverage of reincarnation code.
Eric S. Raymond [Tue, 13 Jun 2017 13:48:32 +0000 (09:48 -0400)]
Arrange test coverage of reincarnation code.

7 years agoRemove more unused code.
Eric S. Raymond [Tue, 13 Jun 2017 13:42:18 +0000 (09:42 -0400)]
Remove more unused code.

7 years agoSpeling misstakes
Peje Nilsson [Tue, 13 Jun 2017 13:20:28 +0000 (13:20 +0000)]
Speling misstakes

7 years agoRemove now-unused code.
Eric S. Raymond [Tue, 13 Jun 2017 13:34:53 +0000 (09:34 -0400)]
Remove now-unused code.

7 years agoCleanup leftover comments 69/head
Peje Nilsson [Tue, 13 Jun 2017 13:27:44 +0000 (13:27 +0000)]
Cleanup leftover comments

7 years agoFurther increase test coverage.
Eric S. Raymond [Tue, 13 Jun 2017 13:26:54 +0000 (09:26 -0400)]
Further increase test coverage.

7 years agoImprove regression-test coverage.
Eric S. Raymond [Tue, 13 Jun 2017 13:18:24 +0000 (09:18 -0400)]
Improve regression-test coverage.

7 years agoDocumentation update.
Eric S. Raymond [Tue, 13 Jun 2017 12:37:36 +0000 (08:37 -0400)]
Documentation update.

7 years agoUpdate docs to track Peje's latest patch.
Eric S. Raymond [Tue, 13 Jun 2017 12:30:49 +0000 (08:30 -0400)]
Update docs to track Peje's latest patch.

7 years agoRefactor part of dwarfmove to remove goto jumpout 67/head
Peje Nilsson [Tue, 13 Jun 2017 12:18:06 +0000 (14:18 +0200)]
Refactor part of dwarfmove to remove goto jumpout

7 years agoComment polishing.
Eric S. Raymond [Tue, 13 Jun 2017 12:15:01 +0000 (08:15 -0400)]
Comment polishing.

7 years agoAddress GitLab issue #10: Spurious '>' characters appearing in console output
Eric S. Raymond [Tue, 13 Jun 2017 12:03:27 +0000 (08:03 -0400)]
Address GitLab issue #10: Spurious '>' characters appearing in console output

The prompt logic has become unpleasantly complicated.

7 years agoAdjust for Peje Add Peje Nilsson to credits.
Eric S. Raymond [Tue, 13 Jun 2017 11:49:53 +0000 (07:49 -0400)]
Adjust for Peje Add Peje Nilsson to credits.

7 years agoRemove L19999
Peje Nilsson [Tue, 13 Jun 2017 11:14:40 +0000 (13:14 +0200)]
Remove L19999

7 years agoImprove slightly on Peje's L12 patch, changing documentation to match.
Eric S. Raymond [Tue, 13 Jun 2017 11:36:57 +0000 (07:36 -0400)]
Improve slightly on Peje's L12 patch, changing documentation to match.

7 years agoMore documentation updates.
Eric S. Raymond [Tue, 13 Jun 2017 02:15:38 +0000 (22:15 -0400)]
More documentation updates.

7 years agoRelocate L12 65/head
Peje Nilsson [Tue, 13 Jun 2017 05:41:09 +0000 (07:41 +0200)]
Relocate L12

With a bit of code duplication the L12 label can be moved outside
the loop.

7 years agoNew notes.adoc file; major documentation update.
Eric S. Raymond [Tue, 13 Jun 2017 02:02:32 +0000 (22:02 -0400)]
New notes.adoc file; major documentation update.

7 years agoDon't output disused dungeon data. 64/head
Jason S. Ninneman [Mon, 12 Jun 2017 21:44:24 +0000 (14:44 -0700)]
Don't output disused dungeon data.

7 years agoRemove some hard-coded array dimensions. Generate CLSSES at compile time. 63/head
Jason S. Ninneman [Mon, 12 Jun 2017 18:02:16 +0000 (11:02 -0700)]
Remove some hard-coded array dimensions. Generate CLSSES at compile time.

(How did this ever even work without 'extern'?)

7 years agoClean up function argument.
Jason S. Ninneman [Mon, 12 Jun 2017 16:36:14 +0000 (09:36 -0700)]
Clean up function argument.

7 years agoUse strdup() instead of strncpy().
Jason S. Ninneman [Mon, 12 Jun 2017 16:21:24 +0000 (09:21 -0700)]
Use strdup() instead of strncpy().

7 years agoTurn MOD from function to macro.
Eric S. Raymond [Mon, 12 Jun 2017 21:33:21 +0000 (17:33 -0400)]
Turn MOD from function to macro.

I experimented with expanding it to ((N % M) everywhere, but in context
the MOD(N, M) notation seems easier to read.