Alexander Popov [Wed, 19 Jun 2024 18:12:05 +0000 (21:12 +0300)]
Update the KSPP recommendations (https://github.com/KSPP/linux/issues/362)
Thanks to @kees!
Alexander Popov [Sun, 16 Jun 2024 05:48:52 +0000 (08:48 +0300)]
Update the 'kernel.modules_disabled' check
Alexander Popov [Sun, 16 Jun 2024 05:48:14 +0000 (08:48 +0300)]
Add the 'kernel.oops_limit' and 'kernel.warn_limit' checks
Alexander Popov [Sun, 16 Jun 2024 05:23:40 +0000 (08:23 +0300)]
Add the "cfi" check
Alexander Popov [Sun, 16 Jun 2024 04:24:56 +0000 (07:24 +0300)]
Add the "MAGIC_SYSRQ_SERIAL" check
Thanks to @thestinger.
Refers to #104.
Alexander Popov [Sun, 16 Jun 2024 04:03:29 +0000 (07:03 +0300)]
Add the "kernel.sysrq" check
Thanks to @thestinger.
Refers to #104.
Alexander Popov [Sat, 15 Jun 2024 21:56:25 +0000 (00:56 +0300)]
Add the MAGIC_SYSRQ_DEFAULT_ENABLE check
Thanks to @thestinger.
Refers to #104.
Alexander Popov [Sat, 15 Jun 2024 20:16:35 +0000 (23:16 +0300)]
Sync with KSPP: update the `decision` for some checks
Thanks to @kees for the collaboration.
Alexander Popov [Sat, 15 Jun 2024 19:20:51 +0000 (22:20 +0300)]
Add CONFIG_CC_IS_CLANG and CONFIG_CC_IS_GCC to the KSPP recommendations
It makes the tool show less FAILs.
Alexander Popov [Sat, 15 Jun 2024 10:21:23 +0000 (13:21 +0300)]
ruff: Fix EXE001 "Shebang is present but file is not executable"
Alexander Popov [Mon, 10 Jun 2024 14:10:47 +0000 (17:10 +0300)]
Add the comment about 'if arch' for the 'cut_attack_surface' checks
Refers to #135.
Alexander Popov [Mon, 10 Jun 2024 13:44:21 +0000 (16:44 +0300)]
Update the KSPP recommendations
Thanks to Kees for working together!
Alexander Popov [Mon, 10 Jun 2024 13:13:28 +0000 (16:13 +0300)]
Code refactoring to improve test coverage (II)
Test the `-v` argument.
Alexander Popov [Mon, 10 Jun 2024 13:12:15 +0000 (16:12 +0300)]
Code refactoring to improve test coverage (I)
Alexander Popov [Sun, 9 Jun 2024 10:40:00 +0000 (13:40 +0300)]
Merge branch 'scs-pac'
Refers to #131
Thanks @jvoisin
Alexander Popov [Sun, 9 Jun 2024 09:00:36 +0000 (12:00 +0300)]
Merge branch 'page-table-check'
Refers to #140
Thanks to @jvoisin
Alexander Popov [Sun, 2 Jun 2024 17:37:31 +0000 (20:37 +0300)]
Merge branch 'open_check'
Refers to #134.
Alexander Popov [Sun, 2 Jun 2024 17:24:52 +0000 (20:24 +0300)]
CI: Add the test for the code checking that the cmdline file is not empty
Alexander Popov [Sun, 2 Jun 2024 17:13:10 +0000 (20:13 +0300)]
CI: Add the tests for the code checking that the config files exist
Alexander Popov [Sun, 2 Jun 2024 16:59:36 +0000 (19:59 +0300)]
Check that the cmdline file is not empty
Alexander Popov [Sun, 2 Jun 2024 16:58:59 +0000 (19:58 +0300)]
Also check that the cmdline file and sysctl file exist
Alexander Popov [Sun, 2 Jun 2024 16:38:10 +0000 (19:38 +0300)]
Merge branch 'master' into open-check
Alexander Popov [Sun, 2 Jun 2024 15:19:44 +0000 (18:19 +0300)]
Check MITIGATION_SPECTRE_BHI and spectre_bhi
Alexander Popov [Sun, 2 Jun 2024 14:57:49 +0000 (17:57 +0300)]
Check MITIGATION_RFDS and reg_file_data_sampling
Refers to #116
Alexander Popov [Sun, 2 Jun 2024 12:31:12 +0000 (15:31 +0300)]
Add the new name of SPECULATION_MITIGATIONS
Since Linux v6.9 it's called CONFIG_CPU_MITIGATIONS.
Refers to #127, #117
Alexander Popov [Sun, 2 Jun 2024 12:12:55 +0000 (15:12 +0300)]
Add the new names of RETPOLINE, CPU_SRSO, SLS
Since Linux v6.9 they are renamed:
RETPOLINE -> MITIGATION_RETPOLINE
CPU_SRSO -> MITIGATION_SRSO
SLS -> MITIGATION_SLS
Refers to #127, #117
Alexander Popov [Sun, 2 Jun 2024 11:54:07 +0000 (14:54 +0300)]
Add the new name of PAGE_TABLE_ISOLATION
Since Linux v6.9 it's called CONFIG_MITIGATION_PAGE_TABLE_ISOLATION.
Refers to #127, #117
jvoisin [Wed, 22 May 2024 20:03:43 +0000 (22:03 +0200)]
Add two PAGE_TABLE_CHECK related checks from kspp
Newly added in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=
87caef42200cd44f8b808ec2f8ac2257f3e0a8c1
Julien Voisin [Sun, 19 May 2024 19:17:19 +0000 (19:17 +0000)]
Merge branch 'master' into scs_pac
Alexander Popov [Tue, 14 May 2024 14:07:04 +0000 (17:07 +0300)]
Merge remote-tracking branch 'origin/pylint'
Refers to #136
Alexander Popov [Tue, 14 May 2024 13:15:27 +0000 (16:15 +0300)]
Don't use TODO to avoid pylint warnings
Alexander Popov [Tue, 14 May 2024 13:16:29 +0000 (16:16 +0300)]
CI: add pylint
Alexander Popov [Tue, 14 May 2024 13:14:56 +0000 (16:14 +0300)]
Drop 'disable=invalid-name' for pylint
Alexander Popov [Tue, 14 May 2024 13:12:43 +0000 (16:12 +0300)]
Drop __about__.py and use 'version = attr:' in setup.cfg
Alexander Popov [Mon, 13 May 2024 23:56:14 +0000 (02:56 +0300)]
CI: Add the mypy arguments to the WoodPecker CI
Alexander Popov [Mon, 13 May 2024 23:49:45 +0000 (02:49 +0300)]
Merge branch 'typing'
Refers to #121
Alexander Popov [Mon, 13 May 2024 23:26:36 +0000 (02:26 +0300)]
CI: Put mypy into a separate workflow and add some useful arguments
Alexander Popov [Mon, 13 May 2024 23:17:21 +0000 (02:17 +0300)]
Introduce ResultType and improve static typing in test_engine.py
Alexander Popov [Mon, 13 May 2024 23:10:36 +0000 (02:10 +0300)]
Improve the VersionCheck static typing
Alexander Popov [Mon, 13 May 2024 22:12:17 +0000 (01:12 +0300)]
Improve typing and drop the unused **kwargs in the KconfigCheck constructor
Alexander Popov [Mon, 13 May 2024 22:09:48 +0000 (01:09 +0300)]
Improve _open() to avoid mypy and pylint warnings
No untyped *args and **kwargs.
Explicit encoding.
Nice!
Alexander Popov [Mon, 13 May 2024 17:06:16 +0000 (20:06 +0300)]
CI: Check static typing with mypy during the functional test
Alexander Popov [Mon, 13 May 2024 16:40:54 +0000 (19:40 +0300)]
Style fixes for engine import
Alexander Popov [Mon, 13 May 2024 16:03:19 +0000 (19:03 +0300)]
Use dict instead of OrderedDict
Changed in Python version 3.7:
Dictionary order is guaranteed to be insertion order.
This makes the code simpler and faster.
Alexander Popov [Mon, 13 May 2024 15:52:39 +0000 (18:52 +0300)]
Add more typing annotations to test_engine.py
Annotate all functions to enable mypy checking for them.
Alexander Popov [Mon, 13 May 2024 15:16:37 +0000 (18:16 +0300)]
Fix mypy typing warnings for ChecklistObjType
Alexander Popov [Mon, 13 May 2024 15:12:35 +0000 (18:12 +0300)]
Add more precise typing for checklist: List[ChecklistObjType]
Alexander Popov [Mon, 13 May 2024 13:26:42 +0000 (16:26 +0300)]
Fix assertion style
Make assertions look similarly.
Alexander Popov [Sun, 12 May 2024 23:27:07 +0000 (02:27 +0300)]
Fix mypy typing warnings in engine.py
Alexander Popov [Mon, 13 May 2024 12:07:08 +0000 (15:07 +0300)]
Add more typing annotations to engine.py
Annotate all functions to enable mypy checking for them.
Alexander Popov [Mon, 13 May 2024 11:57:26 +0000 (14:57 +0300)]
Move print_unknown_options() to engine.py
That is better for specifying typing.
Alexander Popov [Sun, 12 May 2024 20:13:57 +0000 (23:13 +0300)]
Add more precise typing for OrderedDict
Alexander Popov [Sun, 12 May 2024 16:20:33 +0000 (19:20 +0300)]
Add more typing annotations to checks.py
Annotate all functions to enable mypy checking for them.
Alexander Popov [Sun, 12 May 2024 16:15:23 +0000 (19:15 +0300)]
Make the static typing work for Python v3.8
Kind of hackish :)
Alexander Popov [Sun, 12 May 2024 15:31:23 +0000 (18:31 +0300)]
Fix mypy typing warnings in __init__.py
Alexander Popov [Sun, 12 May 2024 15:29:25 +0000 (18:29 +0300)]
Add more typing annotations to __init__.py
Annotate all functions to enable mypy checking for them.
Alexander Popov [Sun, 12 May 2024 15:21:44 +0000 (18:21 +0300)]
Fix pylint warnings in _open
jvoisin [Sun, 12 May 2024 14:59:42 +0000 (16:59 +0200)]
Add a check to `_open`
This shall transform ugly stacktraces into aesthetically pleasant error
messages.
Alexander Popov [Sun, 12 May 2024 13:44:29 +0000 (16:44 +0300)]
Fix mypy warning in _open()
kernel_hardening_checker/__init__.py:28: error: Incompatible types in assignment (expression has type overloaded function, variable has type overloaded function) [assignment]
Refactor the _open function to fix this and add the type hint by the way.
Alexander Popov [Sun, 12 May 2024 13:28:03 +0000 (16:28 +0300)]
Fix mypy warning in json_dump()
kernel_hardening_checker/engine.py:119: error: "None" has no attribute "startswith" [attr-defined]
The `json_dump()` function printing the results should not be called
for the OptCheck and ComplexOptCheck objects with empty results.
jvoisin [Fri, 3 May 2024 13:43:43 +0000 (15:43 +0200)]
Add a check for CONFIG_UNWIND_PATCH_PAC_INTO_SCS
It allows to fallback to a shadow call stack on aarch64 if PAC isn't supported.
Julien Voisin [Fri, 3 May 2024 12:51:07 +0000 (12:51 +0000)]
Merge branch 'master' into typing
Alexander Popov [Fri, 3 May 2024 11:26:39 +0000 (14:26 +0300)]
CI: Don't run the tests with coverage control for pull requests
Refers to #126
Alexander Popov [Thu, 2 May 2024 13:02:03 +0000 (16:02 +0300)]
CI: Add a functional test without collecting coverage (tired of codecov failures)
Alexander Popov [Thu, 2 May 2024 12:57:46 +0000 (15:57 +0300)]
CI: Fix the name of engine_unit-test_no_coverage (II)
Alexander Popov [Thu, 2 May 2024 12:53:37 +0000 (15:53 +0300)]
CI: Fix the name of engine_unit-test_no_coverage
Alexander Popov [Thu, 2 May 2024 12:50:53 +0000 (15:50 +0300)]
CI: Add a unit-test without collecting coverage (tired of codecov failures)
Alexander Popov [Thu, 2 May 2024 12:19:05 +0000 (15:19 +0300)]
Merge branch 'skip_sysctl'
Refers to #125.
Thanks for the collaboration, @cotequeiroz
Alexander Popov [Thu, 2 May 2024 12:15:44 +0000 (15:15 +0300)]
Style fixes, should be no functional changes
Alexander Popov [Thu, 2 May 2024 12:09:46 +0000 (15:09 +0300)]
Fix the reason and decision of the KEXEC_CORE check
KSPP doesn't recommend to disable it.
Refers to #125
Alexander Popov [Thu, 2 May 2024 11:52:27 +0000 (14:52 +0300)]
Fix the reason and decision of the BPF_JIT check
KSPP doesn't recommend to disable it.
Refers to #125
Alexander Popov [Thu, 2 May 2024 10:30:42 +0000 (13:30 +0300)]
Restore the `dev.tty.legacy_tiocsti` check
The kernel documentations says:
```
Historically the kernel has allowed TIOCSTI, which will push
characters into a controlling TTY. This continues to be used
as a malicious privilege escalation mechanism, and provides no
meaningful real-world utility any more. Its use is considered
a dangerous legacy operation, and can be disabled on most
systems.
```
https://elixir.bootlin.com/linux/v6.8.8/source/drivers/tty/Kconfig#L152
In other words, not having the `dev.tty.legacy_tiocsti` sysctl means that
the dangerous functionality is enabled by default.
Alexander Popov [Thu, 2 May 2024 09:32:58 +0000 (12:32 +0300)]
Use CONFIG_LOCALVERSION instead of CONFIG_DEFAULT_INIT since it's older
Eneas U de Queiroz [Mon, 8 Apr 2024 21:09:56 +0000 (18:09 -0300)]
skip kernel.modules_disabled if MODULES not set
Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
Eneas U de Queiroz [Fri, 10 Nov 2023 18:21:19 +0000 (15:21 -0300)]
Skip unprivileged_userfaultfd if USERFAULTFD unset
Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
Eneas U de Queiroz [Fri, 10 Nov 2023 18:02:57 +0000 (15:02 -0300)]
Don't fail if dev.tty.legacy_tiocsti not found
The sysctl is available for Kernel 6.2 and later only.
Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
Eneas U de Queiroz [Wed, 6 Sep 2023 17:20:53 +0000 (14:20 -0300)]
Skip unprivileged_bpf_disabled if BPF_SYSCALL not set
Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
Eneas U de Queiroz [Wed, 6 Sep 2023 17:20:53 +0000 (14:20 -0300)]
Skip kexec_load_disabled if KEXEC_CORE is not set
Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
Eneas U de Queiroz [Wed, 6 Sep 2023 17:20:53 +0000 (14:20 -0300)]
Skip bpf_jit_harden sysctl if BPF_JIT is not set
Also, switch the test for root sysctl to the 'kernel.cad_pid' symbol.
Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
Alexander Popov [Tue, 30 Apr 2024 16:53:56 +0000 (19:53 +0300)]
Merge branch 'cpu_depend'
Thanks, @cotequeiroz.
Refers to #123
jvoisin [Mon, 15 Apr 2024 12:49:22 +0000 (14:49 +0200)]
Add some lightweight typing
Alexander Popov [Tue, 30 Apr 2024 08:02:32 +0000 (11:02 +0300)]
Fix the reason and decision for CPU_SUP_INTEL
Alexander Popov [Tue, 30 Apr 2024 07:59:34 +0000 (10:59 +0300)]
Style fixes
Eneas U de Queiroz [Wed, 6 Sep 2023 13:30:27 +0000 (10:30 -0300)]
Skip CPU-dependent checks if CPU is not supported
Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
Alexander Popov [Sun, 21 Apr 2024 22:39:17 +0000 (01:39 +0300)]
Like grep, colorize the output only if stdout is connected to a terminal
Nice.
With this, if you redirect the output of kernel-hardening-checker to a file,
it doesn't contain the ANSI escape sequences for colorizing.
Alexander Popov [Sun, 21 Apr 2024 00:12:20 +0000 (03:12 +0300)]
Don't use the `type` name for the class methods
There should be no functional changes
Alexander Popov [Thu, 18 Apr 2024 06:27:38 +0000 (09:27 +0300)]
Add the BLK_DEV_WRITE_MOUNTED/bdev_allow_write_mounted check
And fix the check order by the way.
Thanks to @izh1979 for the idea
Alexander Popov [Wed, 17 Apr 2024 17:47:09 +0000 (20:47 +0300)]
CI: codecov-action@v3.1.5 with token doesn't work well, go to v4 (facepalm)
Alexander Popov [Wed, 17 Apr 2024 17:32:59 +0000 (20:32 +0300)]
CI: Return to codecov-action@v3.1.5, but with tokens
codecov-action@v4 is unstable and sometimes gives the error:
```
Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
```
Alexander Popov [Wed, 17 Apr 2024 17:30:02 +0000 (20:30 +0300)]
CI: Update python versions
Alexander Popov [Wed, 17 Apr 2024 17:08:30 +0000 (20:08 +0300)]
Add the links to the corresponding codecov pages in the README badges
Alexander Popov [Wed, 17 Apr 2024 16:58:53 +0000 (19:58 +0300)]
CI: Move to codecov-action@4
Again, trying to fix the error
```
Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255
```
https://github.com/codecov/codecov-action/issues/598
Alexander Popov [Wed, 17 Apr 2024 16:46:41 +0000 (19:46 +0300)]
CI: Move to codecov-action@v3.1.5
Trying to fix the error
```
Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255
```
https://github.com/codecov/codecov-action/issues/598
Alexander Popov [Wed, 17 Apr 2024 16:27:42 +0000 (19:27 +0300)]
Merge branch 'shstk'
Refers to #114, #120
Thanks, @jvoisin.
Alexander Popov [Wed, 17 Apr 2024 16:12:12 +0000 (19:12 +0300)]
Fix 'decision' for the X86_USER_SHADOW_STACK check
Refers to #114, #120
jvoisin [Mon, 15 Apr 2024 12:05:42 +0000 (14:05 +0200)]
Add a check for X86_USER_SHADOW_STACK
This should close #114
Alexander Popov [Sat, 30 Mar 2024 11:36:34 +0000 (14:36 +0300)]
Add a comment that 'user.max_user_namespaces=0' may break the upower daemon
Alexander Popov [Mon, 25 Mar 2024 19:16:38 +0000 (22:16 +0300)]
Update the README
Alexander Popov [Mon, 25 Mar 2024 18:23:04 +0000 (21:23 +0300)]
Improve the CONFIG_CFI_CLANG checks (add the CONFIG_CC_IS_CLANG dependency)
Refers to #102
Alexander Popov [Mon, 25 Mar 2024 17:40:15 +0000 (20:40 +0300)]
Drop the GCC_PLUGINS check (checking CC_IS_GCC is enough)
Refers to #102