open-adventure.git
19 months agoAdd a more carefully factored test...
Eric S. Raymond [Wed, 29 Mar 2023 14:59:42 +0000 (10:59 -0400)]
Add a more carefully factored test...

...so we can exclude the part advent430 won't pass.

19 months agoClean up some tests, adding newlines at EOF where they're missing.
Eric S. Raymond [Wed, 29 Mar 2023 14:55:56 +0000 (10:55 -0400)]
Clean up some tests, adding newlines at EOF where they're missing.

The advent430 command interpreter accidentally accepted input lines with no
trailing newline. Thus, these files produced spurious mismatches.

19 months agoAdd a useful warning to the tests makefile
Eric S. Raymond [Wed, 29 Mar 2023 13:33:01 +0000 (09:33 -0400)]
Add a useful warning to the tests makefile

19 months agoDocument a bugfix and isolate it in a test.
Eric S. Raymond [Wed, 29 Mar 2023 13:24:12 +0000 (09:24 -0400)]
Document a bugfix and isolate it in a test.

20 months agoImplement NOCOMPARE magic.
Eric S. Raymond [Thu, 23 Mar 2023 09:38:26 +0000 (05:38 -0400)]
Implement NOCOMPARE magic.

20 months agoTest simplification - we don't care about the difference in processing blank lines.
Eric S. Raymond [Thu, 23 Mar 2023 01:20:24 +0000 (21:20 -0400)]
Test simplification - we don't care about the difference in processing blank lines.

20 months agoReconciliation with advent430.
Eric S. Raymond [Thu, 23 Mar 2023 00:39:36 +0000 (20:39 -0400)]
Reconciliation with advent430.

20 months agoChange prompt generation to be more compatible with the advent430 branch.
Eric S. Raymond [Wed, 22 Mar 2023 21:09:14 +0000 (17:09 -0400)]
Change prompt generation to be more compatible with the advent430 branch.

20 months agoMinor fix to prompt generation.
Eric S. Raymond [Wed, 22 Mar 2023 21:03:50 +0000 (17:03 -0400)]
Minor fix to prompt generation.

20 months agoYAML markup fix.
Eric S. Raymond [Wed, 22 Mar 2023 14:30:10 +0000 (10:30 -0400)]
YAML markup fix.

20 months agoRemove redundant test.
Eric S. Raymond [Wed, 22 Mar 2023 10:40:03 +0000 (06:40 -0400)]
Remove redundant test.

20 months agoTest cleanup and reconvilation with advent430.
Eric S. Raymond [Wed, 22 Mar 2023 10:36:03 +0000 (06:36 -0400)]
Test cleanup and reconvilation with advent430.

20 months agoQuoting fixes in the YAML.
Eric S. Raymond [Wed, 22 Mar 2023 03:57:36 +0000 (23:57 -0400)]
Quoting fixes in the YAML.

20 months agoTAPify the ancient-diffs report.
Eric S. Raymond [Wed, 22 Mar 2023 03:25:43 +0000 (23:25 -0400)]
TAPify the ancient-diffs report.

20 months agoTest cleanup.
Eric S. Raymond [Wed, 22 Mar 2023 00:57:03 +0000 (20:57 -0400)]
Test cleanup.

20 months agoMove in the direction of being able to do ancient regression tests.
Eric S. Raymond [Tue, 21 Mar 2023 18:07:04 +0000 (14:07 -0400)]
Move in the direction of being able to do ancient regression tests.

20 months agoTesting simplification.
Eric S. Raymond [Thu, 16 Mar 2023 14:18:56 +0000 (10:18 -0400)]
Testing simplification.

20 months agoRevert "Tapify output of cheat."
Eric S. Raymond [Thu, 16 Mar 2023 14:15:47 +0000 (10:15 -0400)]
Revert "Tapify output of cheat."

There was a better way.

20 months agoMore TAPification.
Eric S. Raymond [Thu, 16 Mar 2023 12:51:57 +0000 (08:51 -0400)]
More TAPification.

20 months agoTapify output of cheat.
Eric S. Raymond [Thu, 16 Mar 2023 12:32:59 +0000 (08:32 -0400)]
Tapify output of cheat.

20 months agoAddress GitLab issue #66: Missing couple of ; in saveresume.c
Eric S. Raymond [Thu, 16 Mar 2023 11:43:17 +0000 (07:43 -0400)]
Address GitLab issue #66: Missing couple of ; in saveresume.c

20 months agoAvoid a compiler warning.
Eric S. Raymond [Tue, 14 Mar 2023 16:52:35 +0000 (12:52 -0400)]
Avoid a compiler warning.

20 months agoMagic-number elimination.
Eric S. Raymond [Tue, 14 Mar 2023 16:51:26 +0000 (12:51 -0400)]
Magic-number elimination.

20 months agoExperimental test production.
Eric S. Raymond [Tue, 14 Mar 2023 15:35:57 +0000 (11:35 -0400)]
Experimental test production.

20 months agoComment polishing.
Eric S. Raymond [Sun, 12 Mar 2023 21:59:10 +0000 (17:59 -0400)]
Comment polishing.

20 months agoReal test coverage dor SAVE_TAMPERING.
Eric S. Raymond [Sun, 12 Mar 2023 21:37:58 +0000 (17:37 -0400)]
Real test coverage dor SAVE_TAMPERING.

20 months agoCleann up scratchfile after tesrs.
Eric S. Raymond [Sun, 12 Mar 2023 21:21:15 +0000 (17:21 -0400)]
Cleann up scratchfile after tesrs.

20 months agoComment polishing.
Eric S. Raymond [Sun, 12 Mar 2023 21:14:18 +0000 (17:14 -0400)]
Comment polishing.

20 months agoDocumentation polishing.
Eric S. Raymond [Sun, 12 Mar 2023 16:58:11 +0000 (12:58 -0400)]
Documentation polishing.

20 months agoNEWS update.
Eric S. Raymond [Sun, 12 Mar 2023 16:41:13 +0000 (12:41 -0400)]
NEWS update.

20 months agoWhitespace trimming of save and resume names.
Eric S. Raymond [Sun, 12 Mar 2023 15:15:04 +0000 (11:15 -0400)]
Whitespace trimming of save and resume names.

20 months agoAdd coverage exception now that SAVE_TAMPERING is back.
Eric S. Raymond [Sun, 12 Mar 2023 14:11:52 +0000 (10:11 -0400)]
Add coverage exception now that SAVE_TAMPERING is back.

20 months agoRelax the savefile validity check a little.
Eric S. Raymond [Sun, 12 Mar 2023 14:03:43 +0000 (10:03 -0400)]
Relax the savefile validity check a little.

There was a very old bug, probably predating the OpenAdventure port,
that would poke a stashed value of -1 into the snake object if you did
a save in endgame, and then fail the savefile validation on resume.
This was masked for a long time by a bug in put() just fixed a couple
of revisions ago.

20 months agoAdd message and bailout on invalid save.
Eric S. Raymond [Sun, 12 Mar 2023 10:39:57 +0000 (06:39 -0400)]
Add message and bailout on invalid save.

Note: save/resume still fails at saveresume.4
at this revision.

20 months agoDrop an attempt to pacify cppcheck that's no longer needed.
Eric S. Raymond [Sat, 11 Mar 2023 15:58:38 +0000 (10:58 -0500)]
Drop an attempt to pacify cppcheck that's no longer needed.

20 months agoAdd ANSI prototype,
Eric S. Raymond [Sat, 11 Mar 2023 15:40:01 +0000 (10:40 -0500)]
Add ANSI prototype,

20 months agoAdd C coverage exclsion required by unbreaking the property setter.
Eric S. Raymond [Sat, 11 Mar 2023 15:29:38 +0000 (10:29 -0500)]
Add C coverage exclsion required by unbreaking the property setter.

20 months agoFix a formal-type glitch.
Eric S. Raymond [Sat, 11 Mar 2023 14:41:07 +0000 (09:41 -0500)]
Fix a formal-type glitch.

20 months agoBugfix: bird starts caged in endgame.
Eric S. Raymond [Sat, 11 Mar 2023 14:35:26 +0000 (09:35 -0500)]
Bugfix: bird starts caged in endgame.

Turns out the code of put() had been modified ibcorrectly, but
the bug was masked in all but a few cases, noe of which would be
encountered in normal gameplay.

A test to ensure this bug does noit recur has been added.

20 months agoDocument a bugfix.
Eric S. Raymond [Fri, 10 Mar 2023 22:17:38 +0000 (17:17 -0500)]
Document a bugfix.

20 months agoFix interrupted-magic-words cosmetic bug.
Eric S. Raymond [Fri, 10 Mar 2023 21:43:27 +0000 (16:43 -0500)]
Fix interrupted-magic-words cosmetic bug.

C patch by Torbjörn Andersson.

20 months agoReady to ship 1.14. 1.14
Eric S. Raymond [Thu, 9 Mar 2023 15:16:22 +0000 (10:16 -0500)]
Ready to ship 1.14.

20 months agoFix whitespace glitch.
Eric S. Raymond [Thu, 9 Mar 2023 15:19:34 +0000 (10:19 -0500)]
Fix whitespace glitch.

20 months agoUse $(advent) rather than advent where needed.
Eric S. Raymond [Thu, 9 Mar 2023 13:54:20 +0000 (08:54 -0500)]
Use $(advent) rather than advent where needed.

20 months agoComplete fix of GitLab issue #64: Coverage summary looks wrong
Eric S. Raymond [Thu, 9 Mar 2023 03:55:12 +0000 (22:55 -0500)]
Complete fix of GitLab issue #64: Coverage summary looks wrong

20 months agoPartially address Gitlsb issue #64: Coverage summary looks wrong
Eric S. Raymond [Thu, 9 Mar 2023 02:54:45 +0000 (21:54 -0500)]
Partially address Gitlsb issue #64: Coverage summary looks wrong

20 months agoAnother typo fix. 289/head
Torbjörn Andersson [Wed, 8 Mar 2023 17:15:51 +0000 (18:15 +0100)]
Another typo fix.

20 months agoAdd a comment to the code that fixes the inventory-count bug.
Eric S. Raymond [Tue, 7 Mar 2023 12:56:04 +0000 (07:56 -0500)]
Add a comment to the code that fixes the inventory-count bug.

20 months agoDocumentation polishing.
Eric S. Raymond [Tue, 7 Mar 2023 04:51:52 +0000 (23:51 -0500)]
Documentation polishing.

20 months agoEliminate some forwards.
Eric S. Raymond [Tue, 7 Mar 2023 04:41:07 +0000 (23:41 -0500)]
Eliminate some forwards.

20 months agoImprove Makefile recipe for coverage testing.
Eric S. Raymond [Mon, 6 Mar 2023 17:23:40 +0000 (12:23 -0500)]
Improve Makefile recipe for coverage testing.

20 months agoAdd test for interspersed non-motion command amidst magic words.
Eric S. Raymond [Sun, 5 Mar 2023 01:26:13 +0000 (20:26 -0500)]
Add test for interspersed non-motion command amidst magic words.

20 months agoNEWS and notes.adoc update.
Eric S. Raymond [Sun, 5 Mar 2023 01:16:07 +0000 (20:16 -0500)]
NEWS and notes.adoc update.

20 months agoPrevent a spurious coverage error.
Eric S. Raymond [Sun, 5 Mar 2023 00:58:57 +0000 (19:58 -0500)]
Prevent a spurious coverage error.

20 months agoComplain to user on save/resume.restore when it's disabled.
Eric S. Raymond [Sun, 5 Mar 2023 00:48:17 +0000 (19:48 -0500)]
Complain to user on save/resume.restore when it's disabled.

20 months agoDocument -a option.
Eric S. Raymond [Fri, 3 Mar 2023 22:18:00 +0000 (17:18 -0500)]
Document -a option.

20 months agoAdd optional auto-save/restore feature using -a <filename> option 288/head
Rob Swindell (on Debian Linux) [Fri, 3 Mar 2023 03:44:47 +0000 (19:44 -0800)]
Add optional auto-save/restore feature using -a <filename> option

To enable use with online Bulletin Board Systems (BBSes) where users
may be disconnected unexpectedly, but would naturally want to resume
playing their same game, added support for an optional save game
path/filename to be specified on the command-line (very similar to
"-r <filename>"), except this save/restore file is:
1. automatically loaded/restored if it exists
2. automatically created when starting a new game
3. automatically updated when exiting a game for any reason
4. cannot be changed to a different path/filename by the user

Since a BBS server program can be expected to send a SIGHUP or SIGTERM
to the game process upon user disconnection (or timeout), those
signals are caught and a graceful termination will occur which saves
the current game state.

Build with ADVENT_AUTOSAVE defined to enable this option.

BUG:
The 'info' command still reports the save/suspend/pause commands as
valid, though they are not when this build option is used (same is
true of ADVENT_NOSAVE, and that doesn't apparently bother anyone).

20 months agoIncrease retrigressiveness of oldstyle a bit.
Eric S. Raymond [Wed, 1 Mar 2023 22:46:13 +0000 (17:46 -0500)]
Increase retrigressiveness of oldstyle a bit.

20 months agoComment typo fix.
Eric S. Raymond [Wed, 1 Mar 2023 21:03:13 +0000 (16:03 -0500)]
Comment typo fix.

20 months agoDon't crap out on failed diff.
Eric S. Raymond [Wed, 1 Mar 2023 19:01:44 +0000 (14:01 -0500)]
Don't crap out on failed diff.

20 months agoAnother comment typo fix.
Eric S. Raymond [Wed, 1 Mar 2023 18:52:54 +0000 (13:52 -0500)]
Another comment typo fix.

20 months agoAddress Gitlab isse #62: Comment typos.
Eric S. Raymond [Wed, 1 Mar 2023 18:04:53 +0000 (13:04 -0500)]
Address Gitlab isse #62: Comment typos.

20 months agoMove pylint suppressions inline.
Eric S. Raymond [Wed, 1 Mar 2023 00:46:50 +0000 (19:46 -0500)]
Move pylint suppressions inline.

20 months agoReady to ship 1.13. 1.13
Eric S. Raymond [Tue, 28 Feb 2023 23:48:57 +0000 (18:48 -0500)]
Ready to ship 1.13.

20 months agocppcheck cleanup.
Eric S. Raymond [Tue, 28 Feb 2023 23:54:07 +0000 (18:54 -0500)]
cppcheck cleanup.

20 months agoNEWS update.
Eric S. Raymond [Tue, 28 Feb 2023 23:40:40 +0000 (18:40 -0500)]
NEWS update.

20 months agoDocumerntation and comment polishing.
Eric S. Raymond [Tue, 28 Feb 2023 22:05:37 +0000 (17:05 -0500)]
Documerntation and comment polishing.

20 months agoImprove message emission when player wins.
Eric S. Raymond [Tue, 28 Feb 2023 20:06:06 +0000 (15:06 -0500)]
Improve message emission when player wins.

20 months agoUpdate our tapview copy.
Eric S. Raymond [Tue, 28 Feb 2023 20:04:42 +0000 (15:04 -0500)]
Update our tapview copy.

20 months agoSPDXify generated code.
Eric S. Raymond [Tue, 28 Feb 2023 19:55:40 +0000 (14:55 -0500)]
SPDXify generated code.

20 months agoPrevent spurious error return.
Eric S. Raymond [Tue, 28 Feb 2023 19:48:33 +0000 (14:48 -0500)]
Prevent spurious error return.

20 months agoEliminate a bad code smell.
Eric S. Raymond [Tue, 28 Feb 2023 11:45:24 +0000 (06:45 -0500)]
Eliminate a bad code smell.

20 months agoAdd Ryan Sarson's 430-point win to the test suite.
Eric S. Raymond [Tue, 28 Feb 2023 04:03:38 +0000 (23:03 -0500)]
Add Ryan Sarson's 430-point win to the test suite.

21 months agoCleanup for current pylint.
Eric S. Raymond [Fri, 17 Feb 2023 18:45:50 +0000 (13:45 -0500)]
Cleanup for current pylint.

21 months agoDocumentation polishing.
Eric S. Raymond [Tue, 7 Feb 2023 10:27:24 +0000 (05:27 -0500)]
Documentation polishing.

21 months agoComment improvements.
Eric S. Raymond [Tue, 7 Feb 2023 09:55:59 +0000 (04:55 -0500)]
Comment improvements.

21 months agoReady to ship 1.12 1.12
Eric S. Raymond [Mon, 6 Feb 2023 22:03:34 +0000 (17:03 -0500)]
Ready to ship 1.12

21 months agoNEWS update.
Eric S. Raymond [Mon, 6 Feb 2023 21:52:16 +0000 (16:52 -0500)]
NEWS update.

21 months agoAnother typo fix.
Eric S. Raymond [Mon, 6 Feb 2023 21:46:03 +0000 (16:46 -0500)]
Another typo fix.

21 months agoExperimental tweak of Docker image to try to fix manpage build.
Eric S. Raymond [Mon, 6 Feb 2023 21:36:59 +0000 (16:36 -0500)]
Experimental tweak of Docker image to try to fix manpage build.

21 months agoTypo fixes.
Eric S. Raymond [Mon, 6 Feb 2023 20:55:03 +0000 (15:55 -0500)]
Typo fixes.

2 years agoFix for GitLab issue #59.
Eric S. Raymond [Fri, 21 Oct 2022 15:21:58 +0000 (11:21 -0400)]
Fix for GitLab issue #59.

2 years agoAdd Patreon link.
Eric S. Raymond [Wed, 20 Apr 2022 15:59:26 +0000 (11:59 -0400)]
Add Patreon link.

2 years agoRemove ibsoletre constraint comment.
Eric S. Raymond [Wed, 20 Apr 2022 15:32:02 +0000 (11:32 -0400)]
Remove ibsoletre constraint comment.

I think it became obsolete when we factored out state-change messages.

2 years agoIn the grapher,add some room condition bits to clean up code.
Eric S. Raymond [Wed, 20 Apr 2022 12:27:30 +0000 (08:27 -0400)]
In the grapher,add some room condition bits to clean up code.

2 years agoIn the grapher, split forset from surface mode.
Eric S. Raymond [Wed, 20 Apr 2022 11:08:11 +0000 (07:08 -0400)]
In the grapher, split forset from surface mode.

2 years agopy;imt cleanup.
Eric S. Raymond [Wed, 20 Apr 2022 02:41:14 +0000 (22:41 -0400)]
py;imt cleanup.

2 years agoMore grapher improvement.
Eric S. Raymond [Wed, 20 Apr 2022 00:55:23 +0000 (20:55 -0400)]
More grapher improvement.

2 years agoAdd verbose optionm to grapher.
Eric S. Raymond [Wed, 20 Apr 2022 00:39:54 +0000 (20:39 -0400)]
Add verbose optionm to grapher.

2 years agoVarious grapher improvements.
Eric S. Raymond [Tue, 19 Apr 2022 21:51:10 +0000 (17:51 -0400)]
Various grapher improvements.

2 years agoMagic-number elimination.
Eric S. Raymond [Tue, 19 Apr 2022 21:07:46 +0000 (17:07 -0400)]
Magic-number elimination.

2 years agoCode cleanup.
Eric S. Raymond [Tue, 19 Apr 2022 20:26:43 +0000 (16:26 -0400)]
Code cleanup.

2 years agoImprove comments.
Eric S. Raymond [Mon, 18 Apr 2022 22:07:28 +0000 (18:07 -0400)]
Improve comments.

2 years agoDeclare the poject finished in the designer's notes.
Eric S. Raymond [Mon, 18 Apr 2022 20:41:13 +0000 (16:41 -0400)]
Declare the poject finished in the designer's notes.

2 years agoRemove the TODo, last iten about lamp image is obsolerte
Eric S. Raymond [Mon, 18 Apr 2022 20:18:43 +0000 (16:18 -0400)]
Remove the TODo, last iten about lamp image is obsolerte

* We are aware that the lamp currently used as the project logo is a
hurricane lamp, not a proper miner's lamp. Submissions of potential
replacement images would be welcome.
The deleted TODO said:

* We are aware that the lamp currently used as the project logo is a
  hurricane lamp, not a proper miner's lamp. Submissions of potential
  replacement images would be welcome.

Further research using an image search on the web reveals that there
have been miners' lamps thart visually resemble outr hurricane-lamp
images pretty closely,  so we can keep using it.

2 years agoDo full code validation before each release.
Eric S. Raymond [Mon, 18 Apr 2022 18:47:01 +0000 (14:47 -0400)]
Do full code validation before each release.

2 years agoNEWS update,
Eric S. Raymond [Mon, 18 Apr 2022 18:06:54 +0000 (14:06 -0400)]
NEWS update,

2 years agoRemove an issue about dropping the vase, the drop code doesn't change state.
Eric S. Raymond [Mon, 18 Apr 2022 17:57:29 +0000 (13:57 -0400)]
Remove an issue about dropping the vase, the drop code doesn't change state.

2 years agoDrop vase on pillow in well house and confirm that you get points for it.
Eric S. Raymond [Mon, 18 Apr 2022 16:40:09 +0000 (12:40 -0400)]
Drop vase on pillow in well house and confirm that you get points for it.

2 years agoNEWS update.
Eric S. Raymond [Mon, 18 Apr 2022 15:57:02 +0000 (11:57 -0400)]
NEWS update.

After re-reading the code, I have concluded that the objective of making it
more typeful can be abandoned. The tyings typefulness could give us are
largely achieved.