Test an unexpected line in the sysctl file

diff --git a/.github/workflows/functional_test.sh b/.github/workflows/functional_test.sh
index a4fb08597e7141b9f23f3c3ad22fd222a1fca95a..cbacf872d07c4b42c3c05436c4f22f2e7d8326df 100644 (file)
--- a/.github/workflows/functional_test.sh
+++ b/.github/workflows/functional_test.sh
@@ -125,4 +125,9 @@ echo 'hey man 1' > cmdline
 echo 'hey man 2' >> cmdline
 coverage run -a --branch bin/kconfig-hardened-check -c test.config -l cmdline && exit 1
 
+echo ">>>>> unexpected line in the sysctl file <<<<<"
+cp $SYSCTL_EXAMPLE error_sysctls
+echo 'some strange line' >> error_sysctls
+coverage run -a --branch bin/kconfig-hardened-check -c test.config -s error_sysctls && exit 1
+
 echo "The end of the functional tests"

diff --git a/kconfig_hardened_check/__init__.py b/kconfig_hardened_check/__init__.py
index d7df1bf58908a3c1818700cc266b67aa322a162a..3e4db1c96989a70385becacc6805702e9cbd55a8 100644 (file)
--- a/kconfig_hardened_check/__init__.py
+++ b/kconfig_hardened_check/__init__.py
@@ -205,7 +205,7 @@ def parse_sysctl_file(mode, parsed_options, fname):
         for line in f.readlines():
             line = line.strip()
             if not sysctl_pattern.match(line):
-                sys.exit(f'[!] ERROR: unexpected line in sysctl file: {line}')
+                sys.exit(f'[!] ERROR: unexpected line in sysctl file: "{line}"')
             option, value = line.split('=', 1)
             option = option.strip()
             value = value.strip()