projects
/
open-adventure.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
98b02ee
)
L12 is gone again. Magic numbers have been almost eliminated.
author
Eric S. Raymond
<esr@thyrsus.com>
Mon, 19 Jun 2017 12:43:51 +0000
(08:43 -0400)
committer
Eric S. Raymond
<esr@thyrsus.com>
Mon, 19 Jun 2017 12:43:51 +0000
(08:43 -0400)
notes.adoc
patch
|
blob
|
history
diff --git
a/notes.adoc
b/notes.adoc
index 067ddf16a69a316ca67efe6aa7847925d3ed5218..75c2333375275de6032624803ed92f26757160c8 100644
(file)
--- a/
notes.adoc
+++ b/
notes.adoc
@@
-117,10
+117,9
@@
ways:
and the choice to refrain will make forward translation into future
languages easier.
and the choice to refrain will make forward translation into future
languages easier.
-* There are a few gotos left that resist restructuring; all but of these
- are in the principal command interpreter function implementing its
- state machine. the remaining one is a truly mysterious artficat in
- the player-movement code.
+* There are a few gotos left that resist restructuring; all are in the
+ principal command interpreter function implementing its state
+ machine.
* Linked lists (for objects at a location) are implemented using an array
of link indices. This is a surviving FORTRANism that is quite unlike
* Linked lists (for objects at a location) are implemented using an array
of link indices. This is a surviving FORTRANism that is quite unlike
@@
-128,9
+127,6
@@
ways:
to fix it because doing so would (a) be quite difficult, and (b)
compromise forward-portability to other languages.
to fix it because doing so would (a) be quite difficult, and (b)
compromise forward-portability to other languages.
-* The code still has an unfortunately high density of magic numbers - in
- particular, numeric object IDs. There are plans to fix this.
-
* Much of the code still uses FORTRAN-style uppercase names.
* The code still assumes one-origin array indexing. Thus, arrays are
* Much of the code still uses FORTRAN-style uppercase names.
* The code still assumes one-origin array indexing. Thus, arrays are