1 // SPDX-License-Identifier: GPL-2.0
3 * Broadcom BM2835 V4L2 driver
5 * Copyright © 2013 Raspberry Pi (Trading) Ltd.
7 * Authors: Vincent Sanders @ Collabora
8 * Dave Stevenson @ Broadcom
9 * (now dave.stevenson@raspberrypi.org)
10 * Simon Mellor @ Broadcom
11 * Luke Diamand @ Broadcom
14 #include <linux/errno.h>
15 #include <linux/kernel.h>
16 #include <linux/module.h>
17 #include <linux/slab.h>
18 #include <media/videobuf2-vmalloc.h>
19 #include <media/v4l2-device.h>
20 #include <media/v4l2-ioctl.h>
21 #include <media/v4l2-ctrls.h>
22 #include <media/v4l2-fh.h>
23 #include <media/v4l2-event.h>
24 #include <media/v4l2-common.h>
26 #include "mmal-common.h"
27 #include "mmal-vchiq.h"
28 #include "mmal-parameters.h"
29 #include "bcm2835-camera.h"
31 /* The supported V4L2_CID_AUTO_EXPOSURE_BIAS values are from -4.0 to +4.0.
32 * MMAL values are in 1/6th increments so the MMAL range is -24 to +24.
33 * V4L2 docs say value "is expressed in terms of EV, drivers should interpret
34 * the values as 0.001 EV units, where the value 1000 stands for +1 EV."
35 * V4L2 is limited to a max of 32 values in a menu, so count in 1/3rds from
38 static const s64 ev_bias_qmenu[] = {
50 /* Supported ISO values (*1000)
53 static const s64 iso_qmenu[] = {
54 0, 100000, 200000, 400000, 800000,
57 static const u32 iso_values[] = {
58 0, 100, 200, 400, 800,
61 enum bm2835_mmal_ctrl_type {
62 MMAL_CONTROL_TYPE_STD,
63 MMAL_CONTROL_TYPE_STD_MENU,
64 MMAL_CONTROL_TYPE_INT_MENU,
65 MMAL_CONTROL_TYPE_CLUSTER, /* special cluster entry */
68 struct bm2835_mmal_v4l2_ctrl;
70 typedef int(bm2835_mmal_v4l2_ctrl_cb)(
71 struct bm2835_mmal_dev *dev,
72 struct v4l2_ctrl *ctrl,
73 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl);
75 struct bm2835_mmal_v4l2_ctrl {
76 u32 id; /* v4l2 control identifier */
77 enum bm2835_mmal_ctrl_type type;
78 /* control minimum value or
79 * mask for MMAL_CONTROL_TYPE_STD_MENU
82 s64 max; /* maximum value of control */
83 s64 def; /* default value of control */
84 u64 step; /* step size of the control */
85 const s64 *imenu; /* integer menu array */
86 u32 mmal_id; /* mmal parameter id */
87 bm2835_mmal_v4l2_ctrl_cb *setter;
90 struct v4l2_to_mmal_effects_setting {
94 s32 col_fx_fixed_cbcr;
97 u32 num_effect_params;
98 u32 effect_params[MMAL_MAX_IMAGEFX_PARAMETERS];
101 static const struct v4l2_to_mmal_effects_setting
102 v4l2_to_mmal_effects_values[] = {
103 { V4L2_COLORFX_NONE, MMAL_PARAM_IMAGEFX_NONE,
104 0, 0, 0, 0, 0, {0, 0, 0, 0, 0} },
105 { V4L2_COLORFX_BW, MMAL_PARAM_IMAGEFX_NONE,
106 1, 0, 128, 128, 0, {0, 0, 0, 0, 0} },
107 { V4L2_COLORFX_SEPIA, MMAL_PARAM_IMAGEFX_NONE,
108 1, 0, 87, 151, 0, {0, 0, 0, 0, 0} },
109 { V4L2_COLORFX_NEGATIVE, MMAL_PARAM_IMAGEFX_NEGATIVE,
110 0, 0, 0, 0, 0, {0, 0, 0, 0, 0} },
111 { V4L2_COLORFX_EMBOSS, MMAL_PARAM_IMAGEFX_EMBOSS,
112 0, 0, 0, 0, 0, {0, 0, 0, 0, 0} },
113 { V4L2_COLORFX_SKETCH, MMAL_PARAM_IMAGEFX_SKETCH,
114 0, 0, 0, 0, 0, {0, 0, 0, 0, 0} },
115 { V4L2_COLORFX_SKY_BLUE, MMAL_PARAM_IMAGEFX_PASTEL,
116 0, 0, 0, 0, 0, {0, 0, 0, 0, 0} },
117 { V4L2_COLORFX_GRASS_GREEN, MMAL_PARAM_IMAGEFX_WATERCOLOUR,
118 0, 0, 0, 0, 0, {0, 0, 0, 0, 0} },
119 { V4L2_COLORFX_SKIN_WHITEN, MMAL_PARAM_IMAGEFX_WASHEDOUT,
120 0, 0, 0, 0, 0, {0, 0, 0, 0, 0} },
121 { V4L2_COLORFX_VIVID, MMAL_PARAM_IMAGEFX_SATURATION,
122 0, 0, 0, 0, 0, {0, 0, 0, 0, 0} },
123 { V4L2_COLORFX_AQUA, MMAL_PARAM_IMAGEFX_NONE,
124 1, 0, 171, 121, 0, {0, 0, 0, 0, 0} },
125 { V4L2_COLORFX_ART_FREEZE, MMAL_PARAM_IMAGEFX_HATCH,
126 0, 0, 0, 0, 0, {0, 0, 0, 0, 0} },
127 { V4L2_COLORFX_SILHOUETTE, MMAL_PARAM_IMAGEFX_FILM,
128 0, 0, 0, 0, 0, {0, 0, 0, 0, 0} },
129 { V4L2_COLORFX_SOLARIZATION, MMAL_PARAM_IMAGEFX_SOLARIZE,
130 0, 0, 0, 0, 5, {1, 128, 160, 160, 48} },
131 { V4L2_COLORFX_ANTIQUE, MMAL_PARAM_IMAGEFX_COLOURBALANCE,
132 0, 0, 0, 0, 3, {108, 274, 238, 0, 0} },
133 { V4L2_COLORFX_SET_CBCR, MMAL_PARAM_IMAGEFX_NONE,
134 1, 1, 0, 0, 0, {0, 0, 0, 0, 0} }
137 struct v4l2_mmal_scene_config {
138 enum v4l2_scene_mode v4l2_scene;
139 enum mmal_parameter_exposuremode exposure_mode;
140 enum mmal_parameter_exposuremeteringmode metering_mode;
143 static const struct v4l2_mmal_scene_config scene_configs[] = {
144 /* V4L2_SCENE_MODE_NONE automatically added */
146 V4L2_SCENE_MODE_NIGHT,
147 MMAL_PARAM_EXPOSUREMODE_NIGHT,
148 MMAL_PARAM_EXPOSUREMETERINGMODE_AVERAGE
151 V4L2_SCENE_MODE_SPORTS,
152 MMAL_PARAM_EXPOSUREMODE_SPORTS,
153 MMAL_PARAM_EXPOSUREMETERINGMODE_AVERAGE
157 /* control handlers*/
159 static int ctrl_set_rational(struct bm2835_mmal_dev *dev,
160 struct v4l2_ctrl *ctrl,
161 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
163 struct mmal_parameter_rational rational_value;
164 struct vchiq_mmal_port *control;
166 control = &dev->component[COMP_CAMERA]->control;
168 rational_value.num = ctrl->val;
169 rational_value.den = 100;
171 return vchiq_mmal_port_parameter_set(dev->instance, control,
174 sizeof(rational_value));
177 static int ctrl_set_value(struct bm2835_mmal_dev *dev,
178 struct v4l2_ctrl *ctrl,
179 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
182 struct vchiq_mmal_port *control;
184 control = &dev->component[COMP_CAMERA]->control;
186 u32_value = ctrl->val;
188 return vchiq_mmal_port_parameter_set(dev->instance, control,
190 &u32_value, sizeof(u32_value));
193 static int ctrl_set_iso(struct bm2835_mmal_dev *dev,
194 struct v4l2_ctrl *ctrl,
195 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
198 struct vchiq_mmal_port *control;
200 if (ctrl->val > mmal_ctrl->max || ctrl->val < mmal_ctrl->min)
203 if (ctrl->id == V4L2_CID_ISO_SENSITIVITY)
204 dev->iso = iso_values[ctrl->val];
205 else if (ctrl->id == V4L2_CID_ISO_SENSITIVITY_AUTO)
206 dev->manual_iso_enabled =
207 (ctrl->val == V4L2_ISO_SENSITIVITY_MANUAL);
209 control = &dev->component[COMP_CAMERA]->control;
211 if (dev->manual_iso_enabled)
212 u32_value = dev->iso;
216 return vchiq_mmal_port_parameter_set(dev->instance, control,
218 &u32_value, sizeof(u32_value));
221 static int ctrl_set_value_ev(struct bm2835_mmal_dev *dev,
222 struct v4l2_ctrl *ctrl,
223 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
226 struct vchiq_mmal_port *control;
228 control = &dev->component[COMP_CAMERA]->control;
230 s32_value = (ctrl->val - 12) * 2; /* Convert from index to 1/6ths */
232 return vchiq_mmal_port_parameter_set(dev->instance, control,
234 &s32_value, sizeof(s32_value));
237 static int ctrl_set_rotate(struct bm2835_mmal_dev *dev,
238 struct v4l2_ctrl *ctrl,
239 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
243 struct vchiq_mmal_component *camera;
245 camera = dev->component[COMP_CAMERA];
247 u32_value = ((ctrl->val % 360) / 90) * 90;
249 ret = vchiq_mmal_port_parameter_set(dev->instance, &camera->output[0],
251 &u32_value, sizeof(u32_value));
255 ret = vchiq_mmal_port_parameter_set(dev->instance, &camera->output[1],
257 &u32_value, sizeof(u32_value));
261 return vchiq_mmal_port_parameter_set(dev->instance, &camera->output[2],
263 &u32_value, sizeof(u32_value));
266 static int ctrl_set_flip(struct bm2835_mmal_dev *dev,
267 struct v4l2_ctrl *ctrl,
268 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
272 struct vchiq_mmal_component *camera;
274 if (ctrl->id == V4L2_CID_HFLIP)
275 dev->hflip = ctrl->val;
277 dev->vflip = ctrl->val;
279 camera = dev->component[COMP_CAMERA];
281 if (dev->hflip && dev->vflip)
282 u32_value = MMAL_PARAM_MIRROR_BOTH;
284 u32_value = MMAL_PARAM_MIRROR_HORIZONTAL;
286 u32_value = MMAL_PARAM_MIRROR_VERTICAL;
288 u32_value = MMAL_PARAM_MIRROR_NONE;
290 ret = vchiq_mmal_port_parameter_set(dev->instance, &camera->output[0],
292 &u32_value, sizeof(u32_value));
296 ret = vchiq_mmal_port_parameter_set(dev->instance, &camera->output[1],
298 &u32_value, sizeof(u32_value));
302 return vchiq_mmal_port_parameter_set(dev->instance, &camera->output[2],
304 &u32_value, sizeof(u32_value));
307 static int ctrl_set_exposure(struct bm2835_mmal_dev *dev,
308 struct v4l2_ctrl *ctrl,
309 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
311 enum mmal_parameter_exposuremode exp_mode = dev->exposure_mode_user;
312 u32 shutter_speed = 0;
313 struct vchiq_mmal_port *control;
316 control = &dev->component[COMP_CAMERA]->control;
318 if (mmal_ctrl->mmal_id == MMAL_PARAMETER_SHUTTER_SPEED) {
319 /* V4L2 is in 100usec increments.
322 dev->manual_shutter_speed = ctrl->val * 100;
323 } else if (mmal_ctrl->mmal_id == MMAL_PARAMETER_EXPOSURE_MODE) {
325 case V4L2_EXPOSURE_AUTO:
326 exp_mode = MMAL_PARAM_EXPOSUREMODE_AUTO;
329 case V4L2_EXPOSURE_MANUAL:
330 exp_mode = MMAL_PARAM_EXPOSUREMODE_OFF;
333 dev->exposure_mode_user = exp_mode;
334 dev->exposure_mode_v4l2_user = ctrl->val;
335 } else if (mmal_ctrl->id == V4L2_CID_EXPOSURE_AUTO_PRIORITY) {
336 dev->exp_auto_priority = ctrl->val;
339 if (dev->scene_mode == V4L2_SCENE_MODE_NONE) {
340 if (exp_mode == MMAL_PARAM_EXPOSUREMODE_OFF)
341 shutter_speed = dev->manual_shutter_speed;
343 ret = vchiq_mmal_port_parameter_set(dev->instance,
345 MMAL_PARAMETER_SHUTTER_SPEED,
347 sizeof(shutter_speed));
348 ret += vchiq_mmal_port_parameter_set(dev->instance,
350 MMAL_PARAMETER_EXPOSURE_MODE,
353 dev->exposure_mode_active = exp_mode;
355 /* exposure_dynamic_framerate (V4L2_CID_EXPOSURE_AUTO_PRIORITY) should
356 * always apply irrespective of scene mode.
358 ret += set_framerate_params(dev);
363 static int ctrl_set_metering_mode(struct bm2835_mmal_dev *dev,
364 struct v4l2_ctrl *ctrl,
365 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
368 case V4L2_EXPOSURE_METERING_AVERAGE:
369 dev->metering_mode = MMAL_PARAM_EXPOSUREMETERINGMODE_AVERAGE;
372 case V4L2_EXPOSURE_METERING_CENTER_WEIGHTED:
373 dev->metering_mode = MMAL_PARAM_EXPOSUREMETERINGMODE_BACKLIT;
376 case V4L2_EXPOSURE_METERING_SPOT:
377 dev->metering_mode = MMAL_PARAM_EXPOSUREMETERINGMODE_SPOT;
380 case V4L2_EXPOSURE_METERING_MATRIX:
381 dev->metering_mode = MMAL_PARAM_EXPOSUREMETERINGMODE_MATRIX;
385 if (dev->scene_mode == V4L2_SCENE_MODE_NONE) {
386 struct vchiq_mmal_port *control;
387 u32 u32_value = dev->metering_mode;
389 control = &dev->component[COMP_CAMERA]->control;
391 return vchiq_mmal_port_parameter_set(dev->instance, control,
393 &u32_value, sizeof(u32_value));
399 static int ctrl_set_flicker_avoidance(struct bm2835_mmal_dev *dev,
400 struct v4l2_ctrl *ctrl,
401 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
404 struct vchiq_mmal_port *control;
406 control = &dev->component[COMP_CAMERA]->control;
409 case V4L2_CID_POWER_LINE_FREQUENCY_DISABLED:
410 u32_value = MMAL_PARAM_FLICKERAVOID_OFF;
412 case V4L2_CID_POWER_LINE_FREQUENCY_50HZ:
413 u32_value = MMAL_PARAM_FLICKERAVOID_50HZ;
415 case V4L2_CID_POWER_LINE_FREQUENCY_60HZ:
416 u32_value = MMAL_PARAM_FLICKERAVOID_60HZ;
418 case V4L2_CID_POWER_LINE_FREQUENCY_AUTO:
419 u32_value = MMAL_PARAM_FLICKERAVOID_AUTO;
423 return vchiq_mmal_port_parameter_set(dev->instance, control,
425 &u32_value, sizeof(u32_value));
428 static int ctrl_set_awb_mode(struct bm2835_mmal_dev *dev,
429 struct v4l2_ctrl *ctrl,
430 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
433 struct vchiq_mmal_port *control;
435 control = &dev->component[COMP_CAMERA]->control;
438 case V4L2_WHITE_BALANCE_MANUAL:
439 u32_value = MMAL_PARAM_AWBMODE_OFF;
442 case V4L2_WHITE_BALANCE_AUTO:
443 u32_value = MMAL_PARAM_AWBMODE_AUTO;
446 case V4L2_WHITE_BALANCE_INCANDESCENT:
447 u32_value = MMAL_PARAM_AWBMODE_INCANDESCENT;
450 case V4L2_WHITE_BALANCE_FLUORESCENT:
451 u32_value = MMAL_PARAM_AWBMODE_FLUORESCENT;
454 case V4L2_WHITE_BALANCE_FLUORESCENT_H:
455 u32_value = MMAL_PARAM_AWBMODE_TUNGSTEN;
458 case V4L2_WHITE_BALANCE_HORIZON:
459 u32_value = MMAL_PARAM_AWBMODE_HORIZON;
462 case V4L2_WHITE_BALANCE_DAYLIGHT:
463 u32_value = MMAL_PARAM_AWBMODE_SUNLIGHT;
466 case V4L2_WHITE_BALANCE_FLASH:
467 u32_value = MMAL_PARAM_AWBMODE_FLASH;
470 case V4L2_WHITE_BALANCE_CLOUDY:
471 u32_value = MMAL_PARAM_AWBMODE_CLOUDY;
474 case V4L2_WHITE_BALANCE_SHADE:
475 u32_value = MMAL_PARAM_AWBMODE_SHADE;
479 return vchiq_mmal_port_parameter_set(dev->instance, control,
481 &u32_value, sizeof(u32_value));
484 static int ctrl_set_awb_gains(struct bm2835_mmal_dev *dev,
485 struct v4l2_ctrl *ctrl,
486 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
488 struct vchiq_mmal_port *control;
489 struct mmal_parameter_awbgains gains;
491 control = &dev->component[COMP_CAMERA]->control;
493 if (ctrl->id == V4L2_CID_RED_BALANCE)
494 dev->red_gain = ctrl->val;
495 else if (ctrl->id == V4L2_CID_BLUE_BALANCE)
496 dev->blue_gain = ctrl->val;
498 gains.r_gain.num = dev->red_gain;
499 gains.b_gain.num = dev->blue_gain;
500 gains.r_gain.den = gains.b_gain.den = 1000;
502 return vchiq_mmal_port_parameter_set(dev->instance, control,
504 &gains, sizeof(gains));
507 static int ctrl_set_image_effect(struct bm2835_mmal_dev *dev,
508 struct v4l2_ctrl *ctrl,
509 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
513 struct vchiq_mmal_port *control;
514 struct mmal_parameter_imagefx_parameters imagefx;
516 for (i = 0; i < ARRAY_SIZE(v4l2_to_mmal_effects_values); i++) {
517 if (ctrl->val != v4l2_to_mmal_effects_values[i].v4l2_effect)
521 v4l2_to_mmal_effects_values[i].mmal_effect;
522 imagefx.num_effect_params =
523 v4l2_to_mmal_effects_values[i].num_effect_params;
525 if (imagefx.num_effect_params > MMAL_MAX_IMAGEFX_PARAMETERS)
526 imagefx.num_effect_params = MMAL_MAX_IMAGEFX_PARAMETERS;
528 for (j = 0; j < imagefx.num_effect_params; j++)
529 imagefx.effect_parameter[j] =
530 v4l2_to_mmal_effects_values[i].effect_params[j];
532 dev->colourfx.enable =
533 v4l2_to_mmal_effects_values[i].col_fx_enable;
534 if (!v4l2_to_mmal_effects_values[i].col_fx_fixed_cbcr) {
535 dev->colourfx.u = v4l2_to_mmal_effects_values[i].u;
536 dev->colourfx.v = v4l2_to_mmal_effects_values[i].v;
539 control = &dev->component[COMP_CAMERA]->control;
541 ret = vchiq_mmal_port_parameter_set(
542 dev->instance, control,
543 MMAL_PARAMETER_IMAGE_EFFECT_PARAMETERS,
544 &imagefx, sizeof(imagefx));
548 ret = vchiq_mmal_port_parameter_set(
549 dev->instance, control,
550 MMAL_PARAMETER_COLOUR_EFFECT,
551 &dev->colourfx, sizeof(dev->colourfx));
555 v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev,
556 "mmal_ctrl:%p ctrl id:0x%x ctrl val:%d imagefx:0x%x color_effect:%s u:%d v:%d ret %d(%d)\n",
557 mmal_ctrl, ctrl->id, ctrl->val, imagefx.effect,
558 dev->colourfx.enable ? "true" : "false",
559 dev->colourfx.u, dev->colourfx.v,
560 ret, (ret == 0 ? 0 : -EINVAL));
561 return (ret == 0 ? 0 : -EINVAL);
564 static int ctrl_set_colfx(struct bm2835_mmal_dev *dev,
565 struct v4l2_ctrl *ctrl,
566 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
569 struct vchiq_mmal_port *control;
571 control = &dev->component[COMP_CAMERA]->control;
573 dev->colourfx.u = (ctrl->val & 0xff00) >> 8;
574 dev->colourfx.v = ctrl->val & 0xff;
576 ret = vchiq_mmal_port_parameter_set(dev->instance, control,
577 MMAL_PARAMETER_COLOUR_EFFECT,
579 sizeof(dev->colourfx));
581 v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev,
582 "%s: After: mmal_ctrl:%p ctrl id:0x%x ctrl val:%d ret %d(%d)\n",
583 __func__, mmal_ctrl, ctrl->id, ctrl->val, ret,
584 (ret == 0 ? 0 : -EINVAL));
585 return (ret == 0 ? 0 : -EINVAL);
588 static int ctrl_set_bitrate(struct bm2835_mmal_dev *dev,
589 struct v4l2_ctrl *ctrl,
590 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
593 struct vchiq_mmal_port *encoder_out;
595 dev->capture.encode_bitrate = ctrl->val;
597 encoder_out = &dev->component[COMP_VIDEO_ENCODE]->output[0];
599 ret = vchiq_mmal_port_parameter_set(dev->instance, encoder_out,
600 mmal_ctrl->mmal_id, &ctrl->val,
603 v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev,
604 "%s: After: mmal_ctrl:%p ctrl id:0x%x ctrl val:%d ret %d(%d)\n",
605 __func__, mmal_ctrl, ctrl->id, ctrl->val, ret,
606 (ret == 0 ? 0 : -EINVAL));
609 * Older firmware versions (pre July 2019) have a bug in handling
610 * MMAL_PARAMETER_VIDEO_BIT_RATE that result in the call
611 * returning -MMAL_MSG_STATUS_EINVAL. So ignore errors from this call.
616 static int ctrl_set_bitrate_mode(struct bm2835_mmal_dev *dev,
617 struct v4l2_ctrl *ctrl,
618 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
621 struct vchiq_mmal_port *encoder_out;
623 encoder_out = &dev->component[COMP_VIDEO_ENCODE]->output[0];
625 dev->capture.encode_bitrate_mode = ctrl->val;
628 case V4L2_MPEG_VIDEO_BITRATE_MODE_VBR:
629 bitrate_mode = MMAL_VIDEO_RATECONTROL_VARIABLE;
631 case V4L2_MPEG_VIDEO_BITRATE_MODE_CBR:
632 bitrate_mode = MMAL_VIDEO_RATECONTROL_CONSTANT;
636 vchiq_mmal_port_parameter_set(dev->instance, encoder_out,
639 sizeof(bitrate_mode));
643 static int ctrl_set_image_encode_output(struct bm2835_mmal_dev *dev,
644 struct v4l2_ctrl *ctrl,
645 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
648 struct vchiq_mmal_port *jpeg_out;
650 jpeg_out = &dev->component[COMP_IMAGE_ENCODE]->output[0];
652 u32_value = ctrl->val;
654 return vchiq_mmal_port_parameter_set(dev->instance, jpeg_out,
656 &u32_value, sizeof(u32_value));
659 static int ctrl_set_video_encode_param_output(struct bm2835_mmal_dev *dev,
660 struct v4l2_ctrl *ctrl,
661 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
664 struct vchiq_mmal_port *vid_enc_ctl;
666 vid_enc_ctl = &dev->component[COMP_VIDEO_ENCODE]->output[0];
668 u32_value = ctrl->val;
670 return vchiq_mmal_port_parameter_set(dev->instance, vid_enc_ctl,
672 &u32_value, sizeof(u32_value));
675 static int ctrl_set_video_encode_profile_level(struct bm2835_mmal_dev *dev,
676 struct v4l2_ctrl *ctrl,
677 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
679 struct mmal_parameter_video_profile param;
682 if (ctrl->id == V4L2_CID_MPEG_VIDEO_H264_PROFILE) {
684 case V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE:
685 case V4L2_MPEG_VIDEO_H264_PROFILE_CONSTRAINED_BASELINE:
686 case V4L2_MPEG_VIDEO_H264_PROFILE_MAIN:
687 case V4L2_MPEG_VIDEO_H264_PROFILE_HIGH:
688 dev->capture.enc_profile = ctrl->val;
694 } else if (ctrl->id == V4L2_CID_MPEG_VIDEO_H264_LEVEL) {
696 case V4L2_MPEG_VIDEO_H264_LEVEL_1_0:
697 case V4L2_MPEG_VIDEO_H264_LEVEL_1B:
698 case V4L2_MPEG_VIDEO_H264_LEVEL_1_1:
699 case V4L2_MPEG_VIDEO_H264_LEVEL_1_2:
700 case V4L2_MPEG_VIDEO_H264_LEVEL_1_3:
701 case V4L2_MPEG_VIDEO_H264_LEVEL_2_0:
702 case V4L2_MPEG_VIDEO_H264_LEVEL_2_1:
703 case V4L2_MPEG_VIDEO_H264_LEVEL_2_2:
704 case V4L2_MPEG_VIDEO_H264_LEVEL_3_0:
705 case V4L2_MPEG_VIDEO_H264_LEVEL_3_1:
706 case V4L2_MPEG_VIDEO_H264_LEVEL_3_2:
707 case V4L2_MPEG_VIDEO_H264_LEVEL_4_0:
708 dev->capture.enc_level = ctrl->val;
717 switch (dev->capture.enc_profile) {
718 case V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE:
719 param.profile = MMAL_VIDEO_PROFILE_H264_BASELINE;
721 case V4L2_MPEG_VIDEO_H264_PROFILE_CONSTRAINED_BASELINE:
723 MMAL_VIDEO_PROFILE_H264_CONSTRAINED_BASELINE;
725 case V4L2_MPEG_VIDEO_H264_PROFILE_MAIN:
726 param.profile = MMAL_VIDEO_PROFILE_H264_MAIN;
728 case V4L2_MPEG_VIDEO_H264_PROFILE_HIGH:
729 param.profile = MMAL_VIDEO_PROFILE_H264_HIGH;
732 /* Should never get here */
736 switch (dev->capture.enc_level) {
737 case V4L2_MPEG_VIDEO_H264_LEVEL_1_0:
738 param.level = MMAL_VIDEO_LEVEL_H264_1;
740 case V4L2_MPEG_VIDEO_H264_LEVEL_1B:
741 param.level = MMAL_VIDEO_LEVEL_H264_1b;
743 case V4L2_MPEG_VIDEO_H264_LEVEL_1_1:
744 param.level = MMAL_VIDEO_LEVEL_H264_11;
746 case V4L2_MPEG_VIDEO_H264_LEVEL_1_2:
747 param.level = MMAL_VIDEO_LEVEL_H264_12;
749 case V4L2_MPEG_VIDEO_H264_LEVEL_1_3:
750 param.level = MMAL_VIDEO_LEVEL_H264_13;
752 case V4L2_MPEG_VIDEO_H264_LEVEL_2_0:
753 param.level = MMAL_VIDEO_LEVEL_H264_2;
755 case V4L2_MPEG_VIDEO_H264_LEVEL_2_1:
756 param.level = MMAL_VIDEO_LEVEL_H264_21;
758 case V4L2_MPEG_VIDEO_H264_LEVEL_2_2:
759 param.level = MMAL_VIDEO_LEVEL_H264_22;
761 case V4L2_MPEG_VIDEO_H264_LEVEL_3_0:
762 param.level = MMAL_VIDEO_LEVEL_H264_3;
764 case V4L2_MPEG_VIDEO_H264_LEVEL_3_1:
765 param.level = MMAL_VIDEO_LEVEL_H264_31;
767 case V4L2_MPEG_VIDEO_H264_LEVEL_3_2:
768 param.level = MMAL_VIDEO_LEVEL_H264_32;
770 case V4L2_MPEG_VIDEO_H264_LEVEL_4_0:
771 param.level = MMAL_VIDEO_LEVEL_H264_4;
774 /* Should never get here */
778 ret = vchiq_mmal_port_parameter_set(dev->instance,
779 &dev->component[COMP_VIDEO_ENCODE]->output[0],
781 ¶m, sizeof(param));
786 static int ctrl_set_scene_mode(struct bm2835_mmal_dev *dev,
787 struct v4l2_ctrl *ctrl,
788 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
792 struct vchiq_mmal_port *control;
794 v4l2_dbg(0, bcm2835_v4l2_debug, &dev->v4l2_dev,
795 "scene mode selected %d, was %d\n", ctrl->val,
797 control = &dev->component[COMP_CAMERA]->control;
799 if (ctrl->val == dev->scene_mode)
802 if (ctrl->val == V4L2_SCENE_MODE_NONE) {
803 /* Restore all user selections */
804 dev->scene_mode = V4L2_SCENE_MODE_NONE;
806 if (dev->exposure_mode_user == MMAL_PARAM_EXPOSUREMODE_OFF)
807 shutter_speed = dev->manual_shutter_speed;
811 v4l2_dbg(0, bcm2835_v4l2_debug, &dev->v4l2_dev,
812 "%s: scene mode none: shut_speed %d, exp_mode %d, metering %d\n",
813 __func__, shutter_speed, dev->exposure_mode_user,
815 ret = vchiq_mmal_port_parameter_set(dev->instance,
817 MMAL_PARAMETER_SHUTTER_SPEED,
819 sizeof(shutter_speed));
820 ret += vchiq_mmal_port_parameter_set(dev->instance,
822 MMAL_PARAMETER_EXPOSURE_MODE,
823 &dev->exposure_mode_user,
825 dev->exposure_mode_active = dev->exposure_mode_user;
826 ret += vchiq_mmal_port_parameter_set(dev->instance,
828 MMAL_PARAMETER_EXP_METERING_MODE,
831 ret += set_framerate_params(dev);
833 /* Set up scene mode */
835 const struct v4l2_mmal_scene_config *scene = NULL;
837 enum mmal_parameter_exposuremode exposure_mode;
838 enum mmal_parameter_exposuremeteringmode metering_mode;
840 for (i = 0; i < ARRAY_SIZE(scene_configs); i++) {
841 if (scene_configs[i].v4l2_scene == ctrl->val) {
842 scene = &scene_configs[i];
848 if (i >= ARRAY_SIZE(scene_configs))
851 /* Set all the values */
852 dev->scene_mode = ctrl->val;
854 if (scene->exposure_mode == MMAL_PARAM_EXPOSUREMODE_OFF)
855 shutter_speed = dev->manual_shutter_speed;
858 exposure_mode = scene->exposure_mode;
859 metering_mode = scene->metering_mode;
861 v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev,
862 "%s: scene mode none: shut_speed %d, exp_mode %d, metering %d\n",
863 __func__, shutter_speed, exposure_mode, metering_mode);
865 ret = vchiq_mmal_port_parameter_set(dev->instance, control,
866 MMAL_PARAMETER_SHUTTER_SPEED,
868 sizeof(shutter_speed));
869 ret += vchiq_mmal_port_parameter_set(dev->instance, control,
870 MMAL_PARAMETER_EXPOSURE_MODE,
873 dev->exposure_mode_active = exposure_mode;
874 ret += vchiq_mmal_port_parameter_set(dev->instance, control,
875 MMAL_PARAMETER_EXPOSURE_MODE,
878 ret += vchiq_mmal_port_parameter_set(dev->instance, control,
879 MMAL_PARAMETER_EXP_METERING_MODE,
882 ret += set_framerate_params(dev);
885 v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev,
886 "%s: Setting scene to %d, ret=%d\n",
887 __func__, ctrl->val, ret);
893 static int bm2835_mmal_s_ctrl(struct v4l2_ctrl *ctrl)
895 struct bm2835_mmal_dev *dev =
896 container_of(ctrl->handler, struct bm2835_mmal_dev,
898 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl = ctrl->priv;
901 if (!mmal_ctrl || mmal_ctrl->id != ctrl->id || !mmal_ctrl->setter) {
902 pr_warn("mmal_ctrl:%p ctrl id:%d\n", mmal_ctrl, ctrl->id);
906 ret = mmal_ctrl->setter(dev, ctrl, mmal_ctrl);
908 pr_warn("ctrl id:%d/MMAL param %08X- returned ret %d\n",
909 ctrl->id, mmal_ctrl->mmal_id, ret);
913 static const struct v4l2_ctrl_ops bm2835_mmal_ctrl_ops = {
914 .s_ctrl = bm2835_mmal_s_ctrl,
917 static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[V4L2_CTRL_COUNT] = {
919 .id = V4L2_CID_SATURATION,
920 .type = MMAL_CONTROL_TYPE_STD,
926 .mmal_id = MMAL_PARAMETER_SATURATION,
927 .setter = ctrl_set_rational,
930 .id = V4L2_CID_SHARPNESS,
931 .type = MMAL_CONTROL_TYPE_STD,
937 .mmal_id = MMAL_PARAMETER_SHARPNESS,
938 .setter = ctrl_set_rational,
941 .id = V4L2_CID_CONTRAST,
942 .type = MMAL_CONTROL_TYPE_STD,
948 .mmal_id = MMAL_PARAMETER_CONTRAST,
949 .setter = ctrl_set_rational,
952 .id = V4L2_CID_BRIGHTNESS,
953 .type = MMAL_CONTROL_TYPE_STD,
959 .mmal_id = MMAL_PARAMETER_BRIGHTNESS,
960 .setter = ctrl_set_rational,
963 .id = V4L2_CID_ISO_SENSITIVITY,
964 .type = MMAL_CONTROL_TYPE_INT_MENU,
966 .max = ARRAY_SIZE(iso_qmenu) - 1,
970 .mmal_id = MMAL_PARAMETER_ISO,
971 .setter = ctrl_set_iso,
974 .id = V4L2_CID_ISO_SENSITIVITY_AUTO,
975 .type = MMAL_CONTROL_TYPE_STD_MENU,
977 .max = V4L2_ISO_SENSITIVITY_AUTO,
978 .def = V4L2_ISO_SENSITIVITY_AUTO,
981 .mmal_id = MMAL_PARAMETER_ISO,
982 .setter = ctrl_set_iso,
985 .id = V4L2_CID_IMAGE_STABILIZATION,
986 .type = MMAL_CONTROL_TYPE_STD,
992 .mmal_id = MMAL_PARAMETER_VIDEO_STABILISATION,
993 .setter = ctrl_set_value,
996 .id = V4L2_CID_EXPOSURE_AUTO,
997 .type = MMAL_CONTROL_TYPE_STD_MENU,
999 .max = V4L2_EXPOSURE_APERTURE_PRIORITY,
1000 .def = V4L2_EXPOSURE_AUTO,
1003 .mmal_id = MMAL_PARAMETER_EXPOSURE_MODE,
1004 .setter = ctrl_set_exposure,
1007 .id = V4L2_CID_EXPOSURE_ABSOLUTE,
1008 .type = MMAL_CONTROL_TYPE_STD,
1009 /* Units of 100usecs */
1011 .max = 1 * 1000 * 10,
1015 .mmal_id = MMAL_PARAMETER_SHUTTER_SPEED,
1016 .setter = ctrl_set_exposure,
1019 .id = V4L2_CID_AUTO_EXPOSURE_BIAS,
1020 .type = MMAL_CONTROL_TYPE_INT_MENU,
1022 .max = ARRAY_SIZE(ev_bias_qmenu) - 1,
1023 .def = (ARRAY_SIZE(ev_bias_qmenu) + 1) / 2 - 1,
1025 .imenu = ev_bias_qmenu,
1026 .mmal_id = MMAL_PARAMETER_EXPOSURE_COMP,
1027 .setter = ctrl_set_value_ev,
1030 .id = V4L2_CID_EXPOSURE_AUTO_PRIORITY,
1031 .type = MMAL_CONTROL_TYPE_STD,
1037 /* Dummy MMAL ID as it gets mapped into FPS range */
1039 .setter = ctrl_set_exposure,
1042 .id = V4L2_CID_EXPOSURE_METERING,
1043 .type = MMAL_CONTROL_TYPE_STD_MENU,
1045 .max = V4L2_EXPOSURE_METERING_MATRIX,
1046 .def = V4L2_EXPOSURE_METERING_AVERAGE,
1049 .mmal_id = MMAL_PARAMETER_EXP_METERING_MODE,
1050 .setter = ctrl_set_metering_mode,
1053 .id = V4L2_CID_AUTO_N_PRESET_WHITE_BALANCE,
1054 .type = MMAL_CONTROL_TYPE_STD_MENU,
1056 .max = V4L2_WHITE_BALANCE_SHADE,
1057 .def = V4L2_WHITE_BALANCE_AUTO,
1060 .mmal_id = MMAL_PARAMETER_AWB_MODE,
1061 .setter = ctrl_set_awb_mode,
1064 .id = V4L2_CID_RED_BALANCE,
1065 .type = MMAL_CONTROL_TYPE_STD,
1071 .mmal_id = MMAL_PARAMETER_CUSTOM_AWB_GAINS,
1072 .setter = ctrl_set_awb_gains,
1075 .id = V4L2_CID_BLUE_BALANCE,
1076 .type = MMAL_CONTROL_TYPE_STD,
1082 .mmal_id = MMAL_PARAMETER_CUSTOM_AWB_GAINS,
1083 .setter = ctrl_set_awb_gains,
1086 .id = V4L2_CID_COLORFX,
1087 .type = MMAL_CONTROL_TYPE_STD_MENU,
1089 .max = V4L2_COLORFX_SET_CBCR,
1090 .def = V4L2_COLORFX_NONE,
1093 .mmal_id = MMAL_PARAMETER_IMAGE_EFFECT,
1094 .setter = ctrl_set_image_effect,
1097 .id = V4L2_CID_COLORFX_CBCR,
1098 .type = MMAL_CONTROL_TYPE_STD,
1104 .mmal_id = MMAL_PARAMETER_COLOUR_EFFECT,
1105 .setter = ctrl_set_colfx,
1108 .id = V4L2_CID_ROTATE,
1109 .type = MMAL_CONTROL_TYPE_STD,
1115 .mmal_id = MMAL_PARAMETER_ROTATION,
1116 .setter = ctrl_set_rotate,
1119 .id = V4L2_CID_HFLIP,
1120 .type = MMAL_CONTROL_TYPE_STD,
1126 .mmal_id = MMAL_PARAMETER_MIRROR,
1127 .setter = ctrl_set_flip,
1130 .id = V4L2_CID_VFLIP,
1131 .type = MMAL_CONTROL_TYPE_STD,
1137 .mmal_id = MMAL_PARAMETER_MIRROR,
1138 .setter = ctrl_set_flip,
1141 .id = V4L2_CID_MPEG_VIDEO_BITRATE_MODE,
1142 .type = MMAL_CONTROL_TYPE_STD_MENU,
1144 .max = V4L2_MPEG_VIDEO_BITRATE_MODE_CBR,
1148 .mmal_id = MMAL_PARAMETER_RATECONTROL,
1149 .setter = ctrl_set_bitrate_mode,
1152 .id = V4L2_CID_MPEG_VIDEO_BITRATE,
1153 .type = MMAL_CONTROL_TYPE_STD,
1155 .max = 25 * 1000 * 1000,
1156 .def = 10 * 1000 * 1000,
1159 .mmal_id = MMAL_PARAMETER_VIDEO_BIT_RATE,
1160 .setter = ctrl_set_bitrate,
1163 .id = V4L2_CID_JPEG_COMPRESSION_QUALITY,
1164 .type = MMAL_CONTROL_TYPE_STD,
1170 .mmal_id = MMAL_PARAMETER_JPEG_Q_FACTOR,
1171 .setter = ctrl_set_image_encode_output,
1174 .id = V4L2_CID_POWER_LINE_FREQUENCY,
1175 .type = MMAL_CONTROL_TYPE_STD_MENU,
1177 .max = V4L2_CID_POWER_LINE_FREQUENCY_AUTO,
1181 .mmal_id = MMAL_PARAMETER_FLICKER_AVOID,
1182 .setter = ctrl_set_flicker_avoidance,
1185 .id = V4L2_CID_MPEG_VIDEO_REPEAT_SEQ_HEADER,
1186 .type = MMAL_CONTROL_TYPE_STD,
1192 .mmal_id = MMAL_PARAMETER_VIDEO_ENCODE_INLINE_HEADER,
1193 .setter = ctrl_set_video_encode_param_output,
1196 .id = V4L2_CID_MPEG_VIDEO_H264_PROFILE,
1197 .type = MMAL_CONTROL_TYPE_STD_MENU,
1198 .min = ~(BIT(V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE) |
1199 BIT(V4L2_MPEG_VIDEO_H264_PROFILE_CONSTRAINED_BASELINE) |
1200 BIT(V4L2_MPEG_VIDEO_H264_PROFILE_MAIN) |
1201 BIT(V4L2_MPEG_VIDEO_H264_PROFILE_HIGH)),
1202 .max = V4L2_MPEG_VIDEO_H264_PROFILE_HIGH,
1203 .def = V4L2_MPEG_VIDEO_H264_PROFILE_HIGH,
1206 .mmal_id = MMAL_PARAMETER_PROFILE,
1207 .setter = ctrl_set_video_encode_profile_level,
1210 .id = V4L2_CID_MPEG_VIDEO_H264_LEVEL,
1211 .type = MMAL_CONTROL_TYPE_STD_MENU,
1212 .min = ~(BIT(V4L2_MPEG_VIDEO_H264_LEVEL_1_0) |
1213 BIT(V4L2_MPEG_VIDEO_H264_LEVEL_1B) |
1214 BIT(V4L2_MPEG_VIDEO_H264_LEVEL_1_1) |
1215 BIT(V4L2_MPEG_VIDEO_H264_LEVEL_1_2) |
1216 BIT(V4L2_MPEG_VIDEO_H264_LEVEL_1_3) |
1217 BIT(V4L2_MPEG_VIDEO_H264_LEVEL_2_0) |
1218 BIT(V4L2_MPEG_VIDEO_H264_LEVEL_2_1) |
1219 BIT(V4L2_MPEG_VIDEO_H264_LEVEL_2_2) |
1220 BIT(V4L2_MPEG_VIDEO_H264_LEVEL_3_0) |
1221 BIT(V4L2_MPEG_VIDEO_H264_LEVEL_3_1) |
1222 BIT(V4L2_MPEG_VIDEO_H264_LEVEL_3_2) |
1223 BIT(V4L2_MPEG_VIDEO_H264_LEVEL_4_0)),
1224 .max = V4L2_MPEG_VIDEO_H264_LEVEL_4_0,
1225 .def = V4L2_MPEG_VIDEO_H264_LEVEL_4_0,
1228 .mmal_id = MMAL_PARAMETER_PROFILE,
1229 .setter = ctrl_set_video_encode_profile_level,
1232 .id = V4L2_CID_SCENE_MODE,
1233 .type = MMAL_CONTROL_TYPE_STD_MENU,
1234 /* mask is computed at runtime */
1236 .max = V4L2_SCENE_MODE_TEXT,
1237 .def = V4L2_SCENE_MODE_NONE,
1240 .mmal_id = MMAL_PARAMETER_PROFILE,
1241 .setter = ctrl_set_scene_mode,
1244 .id = V4L2_CID_MPEG_VIDEO_H264_I_PERIOD,
1245 .type = MMAL_CONTROL_TYPE_STD,
1251 .mmal_id = MMAL_PARAMETER_INTRAPERIOD,
1252 .setter = ctrl_set_video_encode_param_output,
1256 int bm2835_mmal_set_all_camera_controls(struct bm2835_mmal_dev *dev)
1261 for (c = 0; c < V4L2_CTRL_COUNT; c++) {
1262 if ((dev->ctrls[c]) && (v4l2_ctrls[c].setter)) {
1263 ret = v4l2_ctrls[c].setter(dev, dev->ctrls[c],
1266 v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev,
1267 "Failed when setting default values for ctrl %d\n",
1276 int set_framerate_params(struct bm2835_mmal_dev *dev)
1278 struct mmal_parameter_fps_range fps_range;
1281 fps_range.fps_high.num = dev->capture.timeperframe.denominator;
1282 fps_range.fps_high.den = dev->capture.timeperframe.numerator;
1284 if ((dev->exposure_mode_active != MMAL_PARAM_EXPOSUREMODE_OFF) &&
1285 (dev->exp_auto_priority)) {
1286 /* Variable FPS. Define min FPS as 1fps. */
1287 fps_range.fps_low.num = 1;
1288 fps_range.fps_low.den = 1;
1290 /* Fixed FPS - set min and max to be the same */
1291 fps_range.fps_low.num = fps_range.fps_high.num;
1292 fps_range.fps_low.den = fps_range.fps_high.den;
1295 v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev,
1296 "Set fps range to %d/%d to %d/%d\n",
1297 fps_range.fps_low.num,
1298 fps_range.fps_low.den,
1299 fps_range.fps_high.num,
1300 fps_range.fps_high.den);
1302 ret = vchiq_mmal_port_parameter_set(dev->instance,
1303 &dev->component[COMP_CAMERA]->output[CAM_PORT_PREVIEW],
1304 MMAL_PARAMETER_FPS_RANGE,
1305 &fps_range, sizeof(fps_range));
1306 ret += vchiq_mmal_port_parameter_set(dev->instance,
1307 &dev->component[COMP_CAMERA]->output[CAM_PORT_VIDEO],
1308 MMAL_PARAMETER_FPS_RANGE,
1309 &fps_range, sizeof(fps_range));
1310 ret += vchiq_mmal_port_parameter_set(dev->instance,
1311 &dev->component[COMP_CAMERA]->output[CAM_PORT_CAPTURE],
1312 MMAL_PARAMETER_FPS_RANGE,
1313 &fps_range, sizeof(fps_range));
1315 v4l2_dbg(0, bcm2835_v4l2_debug, &dev->v4l2_dev,
1316 "Failed to set fps ret %d\n", ret);
1321 int bm2835_mmal_init_controls(struct bm2835_mmal_dev *dev,
1322 struct v4l2_ctrl_handler *hdl)
1325 const struct bm2835_mmal_v4l2_ctrl *ctrl;
1327 v4l2_ctrl_handler_init(hdl, V4L2_CTRL_COUNT);
1329 for (c = 0; c < V4L2_CTRL_COUNT; c++) {
1330 ctrl = &v4l2_ctrls[c];
1332 switch (ctrl->type) {
1333 case MMAL_CONTROL_TYPE_STD:
1335 v4l2_ctrl_new_std(hdl,
1336 &bm2835_mmal_ctrl_ops,
1337 ctrl->id, ctrl->min,
1338 ctrl->max, ctrl->step,
1342 case MMAL_CONTROL_TYPE_STD_MENU:
1344 u64 mask = ctrl->min;
1346 if (ctrl->id == V4L2_CID_SCENE_MODE) {
1347 /* Special handling to work out the mask
1348 * value based on the scene_configs array
1349 * at runtime. Reduces the chance of
1354 mask = BIT(V4L2_SCENE_MODE_NONE);
1356 i < ARRAY_SIZE(scene_configs);
1358 mask |= BIT(scene_configs[i].v4l2_scene);
1364 v4l2_ctrl_new_std_menu(hdl,
1365 &bm2835_mmal_ctrl_ops,
1366 ctrl->id, ctrl->max,
1371 case MMAL_CONTROL_TYPE_INT_MENU:
1373 v4l2_ctrl_new_int_menu(hdl,
1374 &bm2835_mmal_ctrl_ops,
1375 ctrl->id, ctrl->max,
1376 ctrl->def, ctrl->imenu);
1379 case MMAL_CONTROL_TYPE_CLUSTER:
1380 /* skip this entry when constructing controls */
1387 dev->ctrls[c]->priv = (void *)ctrl;
1391 pr_err("error adding control %d/%d id 0x%x\n", c,
1392 V4L2_CTRL_COUNT, ctrl->id);
1396 for (c = 0; c < V4L2_CTRL_COUNT; c++) {
1397 ctrl = &v4l2_ctrls[c];
1399 switch (ctrl->type) {
1400 case MMAL_CONTROL_TYPE_CLUSTER:
1401 v4l2_ctrl_auto_cluster(ctrl->min,
1407 case MMAL_CONTROL_TYPE_STD:
1408 case MMAL_CONTROL_TYPE_STD_MENU:
1409 case MMAL_CONTROL_TYPE_INT_MENU: