1 // SPDX-License-Identifier: GPL-2.0
2 /* Driver for the Texas Instruments DP83869 PHY
3 * Copyright (C) 2019 Texas Instruments Inc.
6 #include <linux/ethtool.h>
7 #include <linux/etherdevice.h>
8 #include <linux/kernel.h>
10 #include <linux/module.h>
12 #include <linux/phy.h>
13 #include <linux/delay.h>
14 #include <linux/bitfield.h>
16 #include <dt-bindings/net/ti-dp83869.h>
18 #define DP83869_PHY_ID 0x2000a0f1
19 #define DP83869_DEVADDR 0x1f
21 #define MII_DP83869_PHYCTRL 0x10
22 #define MII_DP83869_MICR 0x12
23 #define MII_DP83869_ISR 0x13
24 #define DP83869_CFG2 0x14
25 #define DP83869_CTRL 0x1f
26 #define DP83869_CFG4 0x1e
28 /* Extended Registers */
29 #define DP83869_GEN_CFG3 0x0031
30 #define DP83869_RGMIICTL 0x0032
31 #define DP83869_STRAP_STS1 0x006e
32 #define DP83869_RGMIIDCTL 0x0086
33 #define DP83869_RXFCFG 0x0134
34 #define DP83869_RXFPMD1 0x0136
35 #define DP83869_RXFPMD2 0x0137
36 #define DP83869_RXFPMD3 0x0138
37 #define DP83869_RXFSOP1 0x0139
38 #define DP83869_RXFSOP2 0x013A
39 #define DP83869_RXFSOP3 0x013B
40 #define DP83869_IO_MUX_CFG 0x0170
41 #define DP83869_OP_MODE 0x01df
42 #define DP83869_FX_CTRL 0x0c00
44 #define DP83869_SW_RESET BIT(15)
45 #define DP83869_SW_RESTART BIT(14)
47 /* MICR Interrupt bits */
48 #define MII_DP83869_MICR_AN_ERR_INT_EN BIT(15)
49 #define MII_DP83869_MICR_SPEED_CHNG_INT_EN BIT(14)
50 #define MII_DP83869_MICR_DUP_MODE_CHNG_INT_EN BIT(13)
51 #define MII_DP83869_MICR_PAGE_RXD_INT_EN BIT(12)
52 #define MII_DP83869_MICR_AUTONEG_COMP_INT_EN BIT(11)
53 #define MII_DP83869_MICR_LINK_STS_CHNG_INT_EN BIT(10)
54 #define MII_DP83869_MICR_FALSE_CARRIER_INT_EN BIT(8)
55 #define MII_DP83869_MICR_SLEEP_MODE_CHNG_INT_EN BIT(4)
56 #define MII_DP83869_MICR_WOL_INT_EN BIT(3)
57 #define MII_DP83869_MICR_XGMII_ERR_INT_EN BIT(2)
58 #define MII_DP83869_MICR_POL_CHNG_INT_EN BIT(1)
59 #define MII_DP83869_MICR_JABBER_INT_EN BIT(0)
61 #define MII_DP83869_BMCR_DEFAULT (BMCR_ANENABLE | \
65 #define MII_DP83869_FIBER_ADVERTISE (ADVERTISED_FIBRE | \
67 ADVERTISED_Asym_Pause)
69 /* This is the same bit mask as the BMCR so re-use the BMCR default */
70 #define DP83869_FX_CTRL_DEFAULT MII_DP83869_BMCR_DEFAULT
73 #define DP83869_CFG1_DEFAULT (ADVERTISE_1000HALF | \
74 ADVERTISE_1000FULL | \
78 #define DP83869_RGMII_TX_CLK_DELAY_EN BIT(1)
79 #define DP83869_RGMII_RX_CLK_DELAY_EN BIT(0)
82 #define DP83869_RGMII_CLK_DELAY_SHIFT 4
83 #define DP83869_CLK_DELAY_DEF 7
86 #define DP83869_STRAP_OP_MODE_MASK GENMASK(2, 0)
87 #define DP83869_STRAP_STS1_RESERVED BIT(11)
88 #define DP83869_STRAP_MIRROR_ENABLED BIT(12)
91 #define DP83869_RX_FIFO_SHIFT 12
92 #define DP83869_TX_FIFO_SHIFT 14
94 /* PHY_CTRL lower bytes 0x48 are declared as reserved */
95 #define DP83869_PHY_CTRL_DEFAULT 0x48
96 #define DP83869_PHYCR_FIFO_DEPTH_MASK GENMASK(15, 12)
97 #define DP83869_PHYCR_RESERVED_MASK BIT(11)
100 #define DP83869_IO_MUX_CFG_IO_IMPEDANCE_CTRL 0x1f
102 #define DP83869_IO_MUX_CFG_IO_IMPEDANCE_MAX 0x0
103 #define DP83869_IO_MUX_CFG_IO_IMPEDANCE_MIN 0x1f
104 #define DP83869_IO_MUX_CFG_CLK_O_SEL_MASK (0x1f << 8)
105 #define DP83869_IO_MUX_CFG_CLK_O_SEL_SHIFT 8
108 #define DP83869_CFG3_PORT_MIRROR_EN BIT(0)
111 #define DP83869_INT_OE BIT(7)
114 #define DP83869_OP_MODE_MII BIT(5)
115 #define DP83869_SGMII_RGMII_BRIDGE BIT(6)
118 #define DP83869_WOL_MAGIC_EN BIT(0)
119 #define DP83869_WOL_PATTERN_EN BIT(1)
120 #define DP83869_WOL_BCAST_EN BIT(2)
121 #define DP83869_WOL_UCAST_EN BIT(4)
122 #define DP83869_WOL_SEC_EN BIT(5)
123 #define DP83869_WOL_ENH_MAC BIT(7)
126 #define DP83869_DOWNSHIFT_EN (BIT(8) | BIT(9))
127 #define DP83869_DOWNSHIFT_ATTEMPT_MASK (BIT(10) | BIT(11))
128 #define DP83869_DOWNSHIFT_1_COUNT_VAL 0
129 #define DP83869_DOWNSHIFT_2_COUNT_VAL 1
130 #define DP83869_DOWNSHIFT_4_COUNT_VAL 2
131 #define DP83869_DOWNSHIFT_8_COUNT_VAL 3
132 #define DP83869_DOWNSHIFT_1_COUNT 1
133 #define DP83869_DOWNSHIFT_2_COUNT 2
134 #define DP83869_DOWNSHIFT_4_COUNT 4
135 #define DP83869_DOWNSHIFT_8_COUNT 8
138 DP83869_PORT_MIRRORING_KEEP,
139 DP83869_PORT_MIRRORING_EN,
140 DP83869_PORT_MIRRORING_DIS,
143 struct dp83869_private {
150 bool rxctrl_strap_quirk;
155 static int dp83869_read_status(struct phy_device *phydev)
157 struct dp83869_private *dp83869 = phydev->priv;
160 ret = genphy_read_status(phydev);
164 if (linkmode_test_bit(ETHTOOL_LINK_MODE_FIBRE_BIT, phydev->supported)) {
166 if (dp83869->mode == DP83869_RGMII_100_BASE)
167 phydev->speed = SPEED_100;
169 phydev->speed = SPEED_UNKNOWN;
170 phydev->duplex = DUPLEX_UNKNOWN;
177 static int dp83869_ack_interrupt(struct phy_device *phydev)
179 int err = phy_read(phydev, MII_DP83869_ISR);
187 static int dp83869_config_intr(struct phy_device *phydev)
191 if (phydev->interrupts == PHY_INTERRUPT_ENABLED) {
192 micr_status = phy_read(phydev, MII_DP83869_MICR);
197 (MII_DP83869_MICR_AN_ERR_INT_EN |
198 MII_DP83869_MICR_SPEED_CHNG_INT_EN |
199 MII_DP83869_MICR_AUTONEG_COMP_INT_EN |
200 MII_DP83869_MICR_LINK_STS_CHNG_INT_EN |
201 MII_DP83869_MICR_DUP_MODE_CHNG_INT_EN |
202 MII_DP83869_MICR_SLEEP_MODE_CHNG_INT_EN);
204 return phy_write(phydev, MII_DP83869_MICR, micr_status);
207 return phy_write(phydev, MII_DP83869_MICR, micr_status);
210 static int dp83869_set_wol(struct phy_device *phydev,
211 struct ethtool_wolinfo *wol)
213 struct net_device *ndev = phydev->attached_dev;
214 int val_rxcfg, val_micr;
218 val_rxcfg = phy_read_mmd(phydev, DP83869_DEVADDR, DP83869_RXFCFG);
222 val_micr = phy_read(phydev, MII_DP83869_MICR);
226 if (wol->wolopts & (WAKE_MAGIC | WAKE_MAGICSECURE | WAKE_UCAST |
228 val_rxcfg |= DP83869_WOL_ENH_MAC;
229 val_micr |= MII_DP83869_MICR_WOL_INT_EN;
231 if (wol->wolopts & WAKE_MAGIC ||
232 wol->wolopts & WAKE_MAGICSECURE) {
233 mac = (u8 *)ndev->dev_addr;
235 if (!is_valid_ether_addr(mac))
238 ret = phy_write_mmd(phydev, DP83869_DEVADDR,
240 mac[1] << 8 | mac[0]);
244 ret = phy_write_mmd(phydev, DP83869_DEVADDR,
246 mac[3] << 8 | mac[2]);
250 ret = phy_write_mmd(phydev, DP83869_DEVADDR,
252 mac[5] << 8 | mac[4]);
256 val_rxcfg |= DP83869_WOL_MAGIC_EN;
258 val_rxcfg &= ~DP83869_WOL_MAGIC_EN;
261 if (wol->wolopts & WAKE_MAGICSECURE) {
262 ret = phy_write_mmd(phydev, DP83869_DEVADDR,
264 (wol->sopass[1] << 8) | wol->sopass[0]);
268 ret = phy_write_mmd(phydev, DP83869_DEVADDR,
270 (wol->sopass[3] << 8) | wol->sopass[2]);
273 ret = phy_write_mmd(phydev, DP83869_DEVADDR,
275 (wol->sopass[5] << 8) | wol->sopass[4]);
279 val_rxcfg |= DP83869_WOL_SEC_EN;
281 val_rxcfg &= ~DP83869_WOL_SEC_EN;
284 if (wol->wolopts & WAKE_UCAST)
285 val_rxcfg |= DP83869_WOL_UCAST_EN;
287 val_rxcfg &= ~DP83869_WOL_UCAST_EN;
289 if (wol->wolopts & WAKE_BCAST)
290 val_rxcfg |= DP83869_WOL_BCAST_EN;
292 val_rxcfg &= ~DP83869_WOL_BCAST_EN;
294 val_rxcfg &= ~DP83869_WOL_ENH_MAC;
295 val_micr &= ~MII_DP83869_MICR_WOL_INT_EN;
298 ret = phy_write_mmd(phydev, DP83869_DEVADDR, DP83869_RXFCFG, val_rxcfg);
302 return phy_write(phydev, MII_DP83869_MICR, val_micr);
305 static void dp83869_get_wol(struct phy_device *phydev,
306 struct ethtool_wolinfo *wol)
308 int value, sopass_val;
310 wol->supported = (WAKE_UCAST | WAKE_BCAST | WAKE_MAGIC |
314 value = phy_read_mmd(phydev, DP83869_DEVADDR, DP83869_RXFCFG);
316 phydev_err(phydev, "Failed to read RX CFG\n");
320 if (value & DP83869_WOL_UCAST_EN)
321 wol->wolopts |= WAKE_UCAST;
323 if (value & DP83869_WOL_BCAST_EN)
324 wol->wolopts |= WAKE_BCAST;
326 if (value & DP83869_WOL_MAGIC_EN)
327 wol->wolopts |= WAKE_MAGIC;
329 if (value & DP83869_WOL_SEC_EN) {
330 sopass_val = phy_read_mmd(phydev, DP83869_DEVADDR,
332 if (sopass_val < 0) {
333 phydev_err(phydev, "Failed to read RX SOP 1\n");
337 wol->sopass[0] = (sopass_val & 0xff);
338 wol->sopass[1] = (sopass_val >> 8);
340 sopass_val = phy_read_mmd(phydev, DP83869_DEVADDR,
342 if (sopass_val < 0) {
343 phydev_err(phydev, "Failed to read RX SOP 2\n");
347 wol->sopass[2] = (sopass_val & 0xff);
348 wol->sopass[3] = (sopass_val >> 8);
350 sopass_val = phy_read_mmd(phydev, DP83869_DEVADDR,
352 if (sopass_val < 0) {
353 phydev_err(phydev, "Failed to read RX SOP 3\n");
357 wol->sopass[4] = (sopass_val & 0xff);
358 wol->sopass[5] = (sopass_val >> 8);
360 wol->wolopts |= WAKE_MAGICSECURE;
363 if (!(value & DP83869_WOL_ENH_MAC))
367 static int dp83869_get_downshift(struct phy_device *phydev, u8 *data)
369 int val, cnt, enable, count;
371 val = phy_read(phydev, DP83869_CFG2);
375 enable = FIELD_GET(DP83869_DOWNSHIFT_EN, val);
376 cnt = FIELD_GET(DP83869_DOWNSHIFT_ATTEMPT_MASK, val);
379 case DP83869_DOWNSHIFT_1_COUNT_VAL:
380 count = DP83869_DOWNSHIFT_1_COUNT;
382 case DP83869_DOWNSHIFT_2_COUNT_VAL:
383 count = DP83869_DOWNSHIFT_2_COUNT;
385 case DP83869_DOWNSHIFT_4_COUNT_VAL:
386 count = DP83869_DOWNSHIFT_4_COUNT;
388 case DP83869_DOWNSHIFT_8_COUNT_VAL:
389 count = DP83869_DOWNSHIFT_8_COUNT;
395 *data = enable ? count : DOWNSHIFT_DEV_DISABLE;
400 static int dp83869_set_downshift(struct phy_device *phydev, u8 cnt)
404 if (cnt > DP83869_DOWNSHIFT_8_COUNT)
408 return phy_clear_bits(phydev, DP83869_CFG2,
409 DP83869_DOWNSHIFT_EN);
412 case DP83869_DOWNSHIFT_1_COUNT:
413 count = DP83869_DOWNSHIFT_1_COUNT_VAL;
415 case DP83869_DOWNSHIFT_2_COUNT:
416 count = DP83869_DOWNSHIFT_2_COUNT_VAL;
418 case DP83869_DOWNSHIFT_4_COUNT:
419 count = DP83869_DOWNSHIFT_4_COUNT_VAL;
421 case DP83869_DOWNSHIFT_8_COUNT:
422 count = DP83869_DOWNSHIFT_8_COUNT_VAL;
426 "Downshift count must be 1, 2, 4 or 8\n");
430 val = DP83869_DOWNSHIFT_EN;
431 val |= FIELD_PREP(DP83869_DOWNSHIFT_ATTEMPT_MASK, count);
433 return phy_modify(phydev, DP83869_CFG2,
434 DP83869_DOWNSHIFT_EN | DP83869_DOWNSHIFT_ATTEMPT_MASK,
438 static int dp83869_get_tunable(struct phy_device *phydev,
439 struct ethtool_tunable *tuna, void *data)
442 case ETHTOOL_PHY_DOWNSHIFT:
443 return dp83869_get_downshift(phydev, data);
449 static int dp83869_set_tunable(struct phy_device *phydev,
450 struct ethtool_tunable *tuna, const void *data)
453 case ETHTOOL_PHY_DOWNSHIFT:
454 return dp83869_set_downshift(phydev, *(const u8 *)data);
460 static int dp83869_config_port_mirroring(struct phy_device *phydev)
462 struct dp83869_private *dp83869 = phydev->priv;
464 if (dp83869->port_mirroring == DP83869_PORT_MIRRORING_EN)
465 return phy_set_bits_mmd(phydev, DP83869_DEVADDR,
467 DP83869_CFG3_PORT_MIRROR_EN);
469 return phy_clear_bits_mmd(phydev, DP83869_DEVADDR,
471 DP83869_CFG3_PORT_MIRROR_EN);
474 static int dp83869_set_strapped_mode(struct phy_device *phydev)
476 struct dp83869_private *dp83869 = phydev->priv;
479 val = phy_read_mmd(phydev, DP83869_DEVADDR, DP83869_STRAP_STS1);
483 dp83869->mode = val & DP83869_STRAP_OP_MODE_MASK;
488 #if IS_ENABLED(CONFIG_OF_MDIO)
489 static const int dp83869_internal_delay[] = {250, 500, 750, 1000, 1250, 1500,
490 1750, 2000, 2250, 2500, 2750, 3000,
491 3250, 3500, 3750, 4000};
493 static int dp83869_of_init(struct phy_device *phydev)
495 struct dp83869_private *dp83869 = phydev->priv;
496 struct device *dev = &phydev->mdio.dev;
497 struct device_node *of_node = dev->of_node;
498 int delay_size = ARRAY_SIZE(dp83869_internal_delay);
504 dp83869->io_impedance = -EINVAL;
506 /* Optional configuration */
507 ret = of_property_read_u32(of_node, "ti,clk-output-sel",
508 &dp83869->clk_output_sel);
509 if (ret || dp83869->clk_output_sel > DP83869_CLK_O_SEL_REF_CLK)
510 dp83869->clk_output_sel = DP83869_CLK_O_SEL_REF_CLK;
512 ret = of_property_read_u32(of_node, "ti,op-mode", &dp83869->mode);
514 if (dp83869->mode < DP83869_RGMII_COPPER_ETHERNET ||
515 dp83869->mode > DP83869_SGMII_COPPER_ETHERNET)
518 ret = dp83869_set_strapped_mode(phydev);
523 if (of_property_read_bool(of_node, "ti,max-output-impedance"))
524 dp83869->io_impedance = DP83869_IO_MUX_CFG_IO_IMPEDANCE_MAX;
525 else if (of_property_read_bool(of_node, "ti,min-output-impedance"))
526 dp83869->io_impedance = DP83869_IO_MUX_CFG_IO_IMPEDANCE_MIN;
528 if (of_property_read_bool(of_node, "enet-phy-lane-swap")) {
529 dp83869->port_mirroring = DP83869_PORT_MIRRORING_EN;
531 /* If the lane swap is not in the DT then check the straps */
532 ret = phy_read_mmd(phydev, DP83869_DEVADDR, DP83869_STRAP_STS1);
536 if (ret & DP83869_STRAP_MIRROR_ENABLED)
537 dp83869->port_mirroring = DP83869_PORT_MIRRORING_EN;
539 dp83869->port_mirroring = DP83869_PORT_MIRRORING_DIS;
544 if (of_property_read_u32(of_node, "rx-fifo-depth",
545 &dp83869->rx_fifo_depth))
546 dp83869->rx_fifo_depth = DP83869_PHYCR_FIFO_DEPTH_4_B_NIB;
548 if (of_property_read_u32(of_node, "tx-fifo-depth",
549 &dp83869->tx_fifo_depth))
550 dp83869->tx_fifo_depth = DP83869_PHYCR_FIFO_DEPTH_4_B_NIB;
552 dp83869->rx_int_delay = phy_get_internal_delay(phydev, dev,
553 &dp83869_internal_delay[0],
555 if (dp83869->rx_int_delay < 0)
556 dp83869->rx_int_delay = DP83869_CLK_DELAY_DEF;
558 dp83869->tx_int_delay = phy_get_internal_delay(phydev, dev,
559 &dp83869_internal_delay[0],
561 if (dp83869->tx_int_delay < 0)
562 dp83869->tx_int_delay = DP83869_CLK_DELAY_DEF;
567 static int dp83869_of_init(struct phy_device *phydev)
569 return dp83869_set_strapped_mode(phydev);
571 #endif /* CONFIG_OF_MDIO */
573 static int dp83869_configure_rgmii(struct phy_device *phydev,
574 struct dp83869_private *dp83869)
578 if (phy_interface_is_rgmii(phydev)) {
579 val = phy_read(phydev, MII_DP83869_PHYCTRL);
583 val &= ~DP83869_PHYCR_FIFO_DEPTH_MASK;
584 val |= (dp83869->tx_fifo_depth << DP83869_TX_FIFO_SHIFT);
585 val |= (dp83869->rx_fifo_depth << DP83869_RX_FIFO_SHIFT);
587 ret = phy_write(phydev, MII_DP83869_PHYCTRL, val);
592 if (dp83869->io_impedance >= 0)
593 ret = phy_modify_mmd(phydev, DP83869_DEVADDR,
595 DP83869_IO_MUX_CFG_IO_IMPEDANCE_CTRL,
596 dp83869->io_impedance &
597 DP83869_IO_MUX_CFG_IO_IMPEDANCE_CTRL);
602 static int dp83869_configure_fiber(struct phy_device *phydev,
603 struct dp83869_private *dp83869)
608 /* Only allow advertising what this PHY supports */
609 linkmode_and(phydev->advertising, phydev->advertising,
612 linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BIT, phydev->supported);
613 linkmode_set_bit(ADVERTISED_FIBRE, phydev->advertising);
615 if (dp83869->mode == DP83869_RGMII_1000_BASE) {
616 linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseX_Full_BIT,
619 linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Full_BIT,
621 linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Half_BIT,
624 /* Auto neg is not supported in 100base FX mode */
625 bmcr = phy_read(phydev, MII_BMCR);
629 phydev->autoneg = AUTONEG_DISABLE;
630 linkmode_clear_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, phydev->supported);
631 linkmode_clear_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, phydev->advertising);
633 if (bmcr & BMCR_ANENABLE) {
634 ret = phy_modify(phydev, MII_BMCR, BMCR_ANENABLE, 0);
640 /* Update advertising from supported */
641 linkmode_or(phydev->advertising, phydev->advertising,
647 static int dp83869_configure_mode(struct phy_device *phydev,
648 struct dp83869_private *dp83869)
653 if (dp83869->mode < DP83869_RGMII_COPPER_ETHERNET ||
654 dp83869->mode > DP83869_SGMII_COPPER_ETHERNET)
657 /* Below init sequence for each operational mode is defined in
658 * section 9.4.8 of the datasheet.
660 ret = phy_write_mmd(phydev, DP83869_DEVADDR, DP83869_OP_MODE,
665 ret = phy_write(phydev, MII_BMCR, MII_DP83869_BMCR_DEFAULT);
669 phy_ctrl_val = (dp83869->rx_fifo_depth << DP83869_RX_FIFO_SHIFT |
670 dp83869->tx_fifo_depth << DP83869_TX_FIFO_SHIFT |
671 DP83869_PHY_CTRL_DEFAULT);
673 switch (dp83869->mode) {
674 case DP83869_RGMII_COPPER_ETHERNET:
675 ret = phy_write(phydev, MII_DP83869_PHYCTRL,
680 ret = phy_write(phydev, MII_CTRL1000, DP83869_CFG1_DEFAULT);
684 ret = dp83869_configure_rgmii(phydev, dp83869);
688 case DP83869_RGMII_SGMII_BRIDGE:
689 ret = phy_modify_mmd(phydev, DP83869_DEVADDR, DP83869_OP_MODE,
690 DP83869_SGMII_RGMII_BRIDGE,
691 DP83869_SGMII_RGMII_BRIDGE);
695 ret = phy_write_mmd(phydev, DP83869_DEVADDR,
696 DP83869_FX_CTRL, DP83869_FX_CTRL_DEFAULT);
701 case DP83869_1000M_MEDIA_CONVERT:
702 ret = phy_write(phydev, MII_DP83869_PHYCTRL,
707 ret = phy_write_mmd(phydev, DP83869_DEVADDR,
708 DP83869_FX_CTRL, DP83869_FX_CTRL_DEFAULT);
712 case DP83869_100M_MEDIA_CONVERT:
713 ret = phy_write(phydev, MII_DP83869_PHYCTRL,
718 case DP83869_SGMII_COPPER_ETHERNET:
719 ret = phy_write(phydev, MII_DP83869_PHYCTRL,
724 ret = phy_write(phydev, MII_CTRL1000, DP83869_CFG1_DEFAULT);
728 ret = phy_write_mmd(phydev, DP83869_DEVADDR,
729 DP83869_FX_CTRL, DP83869_FX_CTRL_DEFAULT);
734 case DP83869_RGMII_1000_BASE:
735 case DP83869_RGMII_100_BASE:
736 ret = dp83869_configure_fiber(phydev, dp83869);
745 static int dp83869_config_init(struct phy_device *phydev)
747 struct dp83869_private *dp83869 = phydev->priv;
750 /* Force speed optimization for the PHY even if it strapped */
751 ret = phy_modify(phydev, DP83869_CFG2, DP83869_DOWNSHIFT_EN,
752 DP83869_DOWNSHIFT_EN);
756 ret = dp83869_configure_mode(phydev, dp83869);
760 /* Enable Interrupt output INT_OE in CFG4 register */
761 if (phy_interrupt_is_valid(phydev)) {
762 val = phy_read(phydev, DP83869_CFG4);
763 val |= DP83869_INT_OE;
764 phy_write(phydev, DP83869_CFG4, val);
767 if (dp83869->port_mirroring != DP83869_PORT_MIRRORING_KEEP)
768 dp83869_config_port_mirroring(phydev);
770 /* Clock output selection if muxing property is set */
771 if (dp83869->clk_output_sel != DP83869_CLK_O_SEL_REF_CLK)
772 ret = phy_modify_mmd(phydev,
773 DP83869_DEVADDR, DP83869_IO_MUX_CFG,
774 DP83869_IO_MUX_CFG_CLK_O_SEL_MASK,
775 dp83869->clk_output_sel <<
776 DP83869_IO_MUX_CFG_CLK_O_SEL_SHIFT);
778 if (phy_interface_is_rgmii(phydev)) {
779 ret = phy_write_mmd(phydev, DP83869_DEVADDR, DP83869_RGMIIDCTL,
780 dp83869->rx_int_delay |
781 dp83869->tx_int_delay << DP83869_RGMII_CLK_DELAY_SHIFT);
785 val = phy_read_mmd(phydev, DP83869_DEVADDR, DP83869_RGMIICTL);
786 val |= (DP83869_RGMII_TX_CLK_DELAY_EN |
787 DP83869_RGMII_RX_CLK_DELAY_EN);
789 if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
790 val &= ~(DP83869_RGMII_TX_CLK_DELAY_EN |
791 DP83869_RGMII_RX_CLK_DELAY_EN);
793 if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID)
794 val &= ~DP83869_RGMII_TX_CLK_DELAY_EN;
796 if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID)
797 val &= ~DP83869_RGMII_RX_CLK_DELAY_EN;
799 ret = phy_write_mmd(phydev, DP83869_DEVADDR, DP83869_RGMIICTL,
806 static int dp83869_probe(struct phy_device *phydev)
808 struct dp83869_private *dp83869;
811 dp83869 = devm_kzalloc(&phydev->mdio.dev, sizeof(*dp83869),
816 phydev->priv = dp83869;
818 ret = dp83869_of_init(phydev);
822 if (dp83869->mode == DP83869_RGMII_100_BASE ||
823 dp83869->mode == DP83869_RGMII_1000_BASE)
824 phydev->port = PORT_FIBRE;
826 return dp83869_config_init(phydev);
829 static int dp83869_phy_reset(struct phy_device *phydev)
833 ret = phy_write(phydev, DP83869_CTRL, DP83869_SW_RESET);
837 usleep_range(10, 20);
839 /* Global sw reset sets all registers to default.
840 * Need to set the registers in the PHY to the right config.
842 return dp83869_config_init(phydev);
845 static struct phy_driver dp83869_driver[] = {
847 PHY_ID_MATCH_MODEL(DP83869_PHY_ID),
848 .name = "TI DP83869",
850 .probe = dp83869_probe,
851 .config_init = dp83869_config_init,
852 .soft_reset = dp83869_phy_reset,
855 .ack_interrupt = dp83869_ack_interrupt,
856 .config_intr = dp83869_config_intr,
857 .read_status = dp83869_read_status,
859 .get_tunable = dp83869_get_tunable,
860 .set_tunable = dp83869_set_tunable,
862 .get_wol = dp83869_get_wol,
863 .set_wol = dp83869_set_wol,
865 .suspend = genphy_suspend,
866 .resume = genphy_resume,
869 module_phy_driver(dp83869_driver);
871 static struct mdio_device_id __maybe_unused dp83869_tbl[] = {
872 { PHY_ID_MATCH_MODEL(DP83869_PHY_ID) },
875 MODULE_DEVICE_TABLE(mdio, dp83869_tbl);
877 MODULE_DESCRIPTION("Texas Instruments DP83869 PHY driver");
878 MODULE_AUTHOR("Dan Murphy <dmurphy@ti.com");
879 MODULE_LICENSE("GPL v2");