1 /****************************************************************************
2 * Driver for Solarflare network controllers and boards
3 * Copyright 2015 Solarflare Communications Inc.
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 as published
7 * by the Free Software Foundation, incorporated herein by reference.
10 #include <linux/module.h>
11 #include "net_driver.h"
12 #include "ef10_sriov.h"
15 #include "mcdi_pcol.h"
17 static int efx_ef10_evb_port_assign(struct efx_nic *efx, unsigned int port_id,
20 MCDI_DECLARE_BUF(inbuf, MC_CMD_EVB_PORT_ASSIGN_IN_LEN);
21 struct efx_ef10_nic_data *nic_data = efx->nic_data;
23 MCDI_SET_DWORD(inbuf, EVB_PORT_ASSIGN_IN_PORT_ID, port_id);
24 MCDI_POPULATE_DWORD_2(inbuf, EVB_PORT_ASSIGN_IN_FUNCTION,
25 EVB_PORT_ASSIGN_IN_PF, nic_data->pf_index,
26 EVB_PORT_ASSIGN_IN_VF, vf_fn);
28 return efx_mcdi_rpc(efx, MC_CMD_EVB_PORT_ASSIGN, inbuf, sizeof(inbuf),
32 static int efx_ef10_vswitch_alloc(struct efx_nic *efx, unsigned int port_id,
33 unsigned int vswitch_type)
35 MCDI_DECLARE_BUF(inbuf, MC_CMD_VSWITCH_ALLOC_IN_LEN);
38 MCDI_SET_DWORD(inbuf, VSWITCH_ALLOC_IN_UPSTREAM_PORT_ID, port_id);
39 MCDI_SET_DWORD(inbuf, VSWITCH_ALLOC_IN_TYPE, vswitch_type);
40 MCDI_SET_DWORD(inbuf, VSWITCH_ALLOC_IN_NUM_VLAN_TAGS, 2);
41 MCDI_POPULATE_DWORD_1(inbuf, VSWITCH_ALLOC_IN_FLAGS,
42 VSWITCH_ALLOC_IN_FLAG_AUTO_PORT, 0);
44 /* Quietly try to allocate 2 VLAN tags */
45 rc = efx_mcdi_rpc_quiet(efx, MC_CMD_VSWITCH_ALLOC, inbuf, sizeof(inbuf),
48 /* If 2 VLAN tags is too many, revert to trying with 1 VLAN tags */
50 MCDI_SET_DWORD(inbuf, VSWITCH_ALLOC_IN_NUM_VLAN_TAGS, 1);
51 rc = efx_mcdi_rpc(efx, MC_CMD_VSWITCH_ALLOC, inbuf,
52 sizeof(inbuf), NULL, 0, NULL);
54 efx_mcdi_display_error(efx, MC_CMD_VSWITCH_ALLOC,
55 MC_CMD_VSWITCH_ALLOC_IN_LEN,
61 static int efx_ef10_vswitch_free(struct efx_nic *efx, unsigned int port_id)
63 MCDI_DECLARE_BUF(inbuf, MC_CMD_VSWITCH_FREE_IN_LEN);
65 MCDI_SET_DWORD(inbuf, VSWITCH_FREE_IN_UPSTREAM_PORT_ID, port_id);
67 return efx_mcdi_rpc(efx, MC_CMD_VSWITCH_FREE, inbuf, sizeof(inbuf),
71 static int efx_ef10_vport_alloc(struct efx_nic *efx,
72 unsigned int port_id_in,
73 unsigned int vport_type,
75 unsigned int *port_id_out)
77 MCDI_DECLARE_BUF(inbuf, MC_CMD_VPORT_ALLOC_IN_LEN);
78 MCDI_DECLARE_BUF(outbuf, MC_CMD_VPORT_ALLOC_OUT_LEN);
82 EFX_WARN_ON_PARANOID(!port_id_out);
84 MCDI_SET_DWORD(inbuf, VPORT_ALLOC_IN_UPSTREAM_PORT_ID, port_id_in);
85 MCDI_SET_DWORD(inbuf, VPORT_ALLOC_IN_TYPE, vport_type);
86 MCDI_SET_DWORD(inbuf, VPORT_ALLOC_IN_NUM_VLAN_TAGS,
87 (vlan != EFX_EF10_NO_VLAN));
88 MCDI_POPULATE_DWORD_1(inbuf, VPORT_ALLOC_IN_FLAGS,
89 VPORT_ALLOC_IN_FLAG_AUTO_PORT, 0);
90 if (vlan != EFX_EF10_NO_VLAN)
91 MCDI_POPULATE_DWORD_1(inbuf, VPORT_ALLOC_IN_VLAN_TAGS,
92 VPORT_ALLOC_IN_VLAN_TAG_0, vlan);
94 rc = efx_mcdi_rpc(efx, MC_CMD_VPORT_ALLOC, inbuf, sizeof(inbuf),
95 outbuf, sizeof(outbuf), &outlen);
98 if (outlen < MC_CMD_VPORT_ALLOC_OUT_LEN)
101 *port_id_out = MCDI_DWORD(outbuf, VPORT_ALLOC_OUT_VPORT_ID);
105 static int efx_ef10_vport_free(struct efx_nic *efx, unsigned int port_id)
107 MCDI_DECLARE_BUF(inbuf, MC_CMD_VPORT_FREE_IN_LEN);
109 MCDI_SET_DWORD(inbuf, VPORT_FREE_IN_VPORT_ID, port_id);
111 return efx_mcdi_rpc(efx, MC_CMD_VPORT_FREE, inbuf, sizeof(inbuf),
115 static void efx_ef10_sriov_free_vf_vports(struct efx_nic *efx)
117 struct efx_ef10_nic_data *nic_data = efx->nic_data;
123 for (i = 0; i < efx->vf_count; i++) {
124 struct ef10_vf *vf = nic_data->vf + i;
126 /* If VF is assigned, do not free the vport */
128 vf->pci_dev->dev_flags & PCI_DEV_FLAGS_ASSIGNED)
131 if (vf->vport_assigned) {
132 efx_ef10_evb_port_assign(efx, EVB_PORT_ID_NULL, i);
133 vf->vport_assigned = 0;
136 if (!is_zero_ether_addr(vf->mac)) {
137 efx_ef10_vport_del_mac(efx, vf->vport_id, vf->mac);
138 eth_zero_addr(vf->mac);
142 efx_ef10_vport_free(efx, vf->vport_id);
150 static void efx_ef10_sriov_free_vf_vswitching(struct efx_nic *efx)
152 struct efx_ef10_nic_data *nic_data = efx->nic_data;
154 efx_ef10_sriov_free_vf_vports(efx);
159 static int efx_ef10_sriov_assign_vf_vport(struct efx_nic *efx,
162 struct efx_ef10_nic_data *nic_data = efx->nic_data;
163 struct ef10_vf *vf = nic_data->vf + vf_i;
166 if (WARN_ON_ONCE(!nic_data->vf))
169 rc = efx_ef10_vport_alloc(efx, EVB_PORT_ID_ASSIGNED,
170 MC_CMD_VPORT_ALLOC_IN_VPORT_TYPE_NORMAL,
171 vf->vlan, &vf->vport_id);
175 rc = efx_ef10_vport_add_mac(efx, vf->vport_id, vf->mac);
177 eth_zero_addr(vf->mac);
181 rc = efx_ef10_evb_port_assign(efx, vf->vport_id, vf_i);
185 vf->vport_assigned = 1;
189 static int efx_ef10_sriov_alloc_vf_vswitching(struct efx_nic *efx)
191 struct efx_ef10_nic_data *nic_data = efx->nic_data;
195 nic_data->vf = kcalloc(efx->vf_count, sizeof(struct ef10_vf),
200 for (i = 0; i < efx->vf_count; i++) {
201 random_ether_addr(nic_data->vf[i].mac);
202 nic_data->vf[i].efx = NULL;
203 nic_data->vf[i].vlan = EFX_EF10_NO_VLAN;
205 rc = efx_ef10_sriov_assign_vf_vport(efx, i);
212 efx_ef10_sriov_free_vf_vports(efx);
218 static int efx_ef10_sriov_restore_vf_vswitching(struct efx_nic *efx)
223 for (i = 0; i < efx->vf_count; i++) {
224 rc = efx_ef10_sriov_assign_vf_vport(efx, i);
231 efx_ef10_sriov_free_vf_vswitching(efx);
235 static int efx_ef10_vadaptor_alloc_set_features(struct efx_nic *efx)
237 struct efx_ef10_nic_data *nic_data = efx->nic_data;
241 rc = efx_ef10_vadaptor_alloc(efx, nic_data->vport_id);
243 goto fail_vadaptor_alloc;
245 rc = efx_ef10_vadaptor_query(efx, nic_data->vport_id,
246 &port_flags, NULL, NULL);
248 goto fail_vadaptor_query;
251 (1 << MC_CMD_VPORT_ALLOC_IN_FLAG_VLAN_RESTRICT_LBN))
252 efx->fixed_features |= NETIF_F_HW_VLAN_CTAG_FILTER;
254 efx->fixed_features &= ~NETIF_F_HW_VLAN_CTAG_FILTER;
259 efx_ef10_vadaptor_free(efx, EVB_PORT_ID_ASSIGNED);
264 /* On top of the default firmware vswitch setup, create a VEB vswitch and
265 * expansion vport for use by this function.
267 int efx_ef10_vswitching_probe_pf(struct efx_nic *efx)
269 struct efx_ef10_nic_data *nic_data = efx->nic_data;
270 struct net_device *net_dev = efx->net_dev;
273 if (pci_sriov_get_totalvfs(efx->pci_dev) <= 0) {
274 /* vswitch not needed as we have no VFs */
275 efx_ef10_vadaptor_alloc_set_features(efx);
279 rc = efx_ef10_vswitch_alloc(efx, EVB_PORT_ID_ASSIGNED,
280 MC_CMD_VSWITCH_ALLOC_IN_VSWITCH_TYPE_VEB);
284 rc = efx_ef10_vport_alloc(efx, EVB_PORT_ID_ASSIGNED,
285 MC_CMD_VPORT_ALLOC_IN_VPORT_TYPE_NORMAL,
286 EFX_EF10_NO_VLAN, &nic_data->vport_id);
290 rc = efx_ef10_vport_add_mac(efx, nic_data->vport_id, net_dev->dev_addr);
293 ether_addr_copy(nic_data->vport_mac, net_dev->dev_addr);
295 rc = efx_ef10_vadaptor_alloc_set_features(efx);
301 efx_ef10_vport_del_mac(efx, nic_data->vport_id, nic_data->vport_mac);
302 eth_zero_addr(nic_data->vport_mac);
304 efx_ef10_vport_free(efx, nic_data->vport_id);
305 nic_data->vport_id = EVB_PORT_ID_ASSIGNED;
307 efx_ef10_vswitch_free(efx, EVB_PORT_ID_ASSIGNED);
312 int efx_ef10_vswitching_probe_vf(struct efx_nic *efx)
314 return efx_ef10_vadaptor_alloc_set_features(efx);
317 int efx_ef10_vswitching_restore_pf(struct efx_nic *efx)
319 struct efx_ef10_nic_data *nic_data = efx->nic_data;
322 if (!nic_data->must_probe_vswitching)
325 rc = efx_ef10_vswitching_probe_pf(efx);
329 rc = efx_ef10_sriov_restore_vf_vswitching(efx);
333 nic_data->must_probe_vswitching = false;
338 int efx_ef10_vswitching_restore_vf(struct efx_nic *efx)
340 struct efx_ef10_nic_data *nic_data = efx->nic_data;
343 if (!nic_data->must_probe_vswitching)
346 rc = efx_ef10_vadaptor_free(efx, EVB_PORT_ID_ASSIGNED);
350 nic_data->must_probe_vswitching = false;
354 void efx_ef10_vswitching_remove_pf(struct efx_nic *efx)
356 struct efx_ef10_nic_data *nic_data = efx->nic_data;
358 efx_ef10_sriov_free_vf_vswitching(efx);
360 efx_ef10_vadaptor_free(efx, nic_data->vport_id);
362 if (nic_data->vport_id == EVB_PORT_ID_ASSIGNED)
363 return; /* No vswitch was ever created */
365 if (!is_zero_ether_addr(nic_data->vport_mac)) {
366 efx_ef10_vport_del_mac(efx, nic_data->vport_id,
367 efx->net_dev->dev_addr);
368 eth_zero_addr(nic_data->vport_mac);
370 efx_ef10_vport_free(efx, nic_data->vport_id);
371 nic_data->vport_id = EVB_PORT_ID_ASSIGNED;
373 /* Only free the vswitch if no VFs are assigned */
374 if (!pci_vfs_assigned(efx->pci_dev))
375 efx_ef10_vswitch_free(efx, nic_data->vport_id);
378 void efx_ef10_vswitching_remove_vf(struct efx_nic *efx)
380 efx_ef10_vadaptor_free(efx, EVB_PORT_ID_ASSIGNED);
383 static int efx_ef10_pci_sriov_enable(struct efx_nic *efx, int num_vfs)
386 struct pci_dev *dev = efx->pci_dev;
388 efx->vf_count = num_vfs;
390 rc = efx_ef10_sriov_alloc_vf_vswitching(efx);
394 rc = pci_enable_sriov(dev, num_vfs);
400 efx_ef10_sriov_free_vf_vswitching(efx);
403 netif_err(efx, probe, efx->net_dev,
404 "Failed to enable SRIOV VFs\n");
408 /* Disable SRIOV and remove VFs
409 * If some VFs are attached to a guest (using Xen, only) nothing is
410 * done if force=false, and vports are freed if force=true (for the non
411 * attachedc ones, only) but SRIOV is not disabled and VFs are not
412 * removed in either case.
414 static int efx_ef10_pci_sriov_disable(struct efx_nic *efx, bool force)
416 struct pci_dev *dev = efx->pci_dev;
417 struct efx_ef10_nic_data *nic_data = efx->nic_data;
418 unsigned int vfs_assigned = pci_vfs_assigned(dev);
421 if (vfs_assigned && !force) {
422 netif_info(efx, drv, efx->net_dev, "VFs are assigned to guests; "
423 "please detach them before disabling SR-IOV\n");
428 for (i = 0; i < efx->vf_count; i++)
429 nic_data->vf[i].pci_dev = NULL;
430 pci_disable_sriov(dev);
435 efx_ef10_sriov_free_vf_vswitching(efx);
440 int efx_ef10_sriov_configure(struct efx_nic *efx, int num_vfs)
443 return efx_ef10_pci_sriov_disable(efx, false);
445 return efx_ef10_pci_sriov_enable(efx, num_vfs);
448 int efx_ef10_sriov_init(struct efx_nic *efx)
453 void efx_ef10_sriov_fini(struct efx_nic *efx)
455 struct efx_ef10_nic_data *nic_data = efx->nic_data;
459 /* Remove any un-assigned orphaned VFs */
460 if (pci_num_vf(efx->pci_dev) && !pci_vfs_assigned(efx->pci_dev))
461 pci_disable_sriov(efx->pci_dev);
465 /* Disable SRIOV and remove any VFs in the host */
466 rc = efx_ef10_pci_sriov_disable(efx, true);
468 netif_dbg(efx, drv, efx->net_dev,
469 "Disabling SRIOV was not successful rc=%d\n", rc);
471 netif_dbg(efx, drv, efx->net_dev, "SRIOV disabled\n");
474 static int efx_ef10_vport_del_vf_mac(struct efx_nic *efx, unsigned int port_id,
477 MCDI_DECLARE_BUF(inbuf, MC_CMD_VPORT_DEL_MAC_ADDRESS_IN_LEN);
478 MCDI_DECLARE_BUF_ERR(outbuf);
482 MCDI_SET_DWORD(inbuf, VPORT_DEL_MAC_ADDRESS_IN_VPORT_ID, port_id);
483 ether_addr_copy(MCDI_PTR(inbuf, VPORT_DEL_MAC_ADDRESS_IN_MACADDR), mac);
485 rc = efx_mcdi_rpc(efx, MC_CMD_VPORT_DEL_MAC_ADDRESS, inbuf,
486 sizeof(inbuf), outbuf, sizeof(outbuf), &outlen);
491 int efx_ef10_sriov_set_vf_mac(struct efx_nic *efx, int vf_i, u8 *mac)
493 struct efx_ef10_nic_data *nic_data = efx->nic_data;
500 if (vf_i >= efx->vf_count)
502 vf = nic_data->vf + vf_i;
505 efx_device_detach_sync(vf->efx);
506 efx_net_stop(vf->efx->net_dev);
508 down_write(&vf->efx->filter_sem);
509 vf->efx->type->filter_table_remove(vf->efx);
511 rc = efx_ef10_vadaptor_free(vf->efx, EVB_PORT_ID_ASSIGNED);
513 up_write(&vf->efx->filter_sem);
518 rc = efx_ef10_evb_port_assign(efx, EVB_PORT_ID_NULL, vf_i);
522 if (!is_zero_ether_addr(vf->mac)) {
523 rc = efx_ef10_vport_del_vf_mac(efx, vf->vport_id, vf->mac);
528 if (!is_zero_ether_addr(mac)) {
529 rc = efx_ef10_vport_add_mac(efx, vf->vport_id, mac);
531 eth_zero_addr(vf->mac);
535 ether_addr_copy(vf->efx->net_dev->dev_addr, mac);
538 ether_addr_copy(vf->mac, mac);
540 rc = efx_ef10_evb_port_assign(efx, vf->vport_id, vf_i);
545 /* VF cannot use the vport_id that the PF created */
546 rc = efx_ef10_vadaptor_alloc(vf->efx, EVB_PORT_ID_ASSIGNED);
548 up_write(&vf->efx->filter_sem);
551 vf->efx->type->filter_table_probe(vf->efx);
552 up_write(&vf->efx->filter_sem);
553 efx_net_open(vf->efx->net_dev);
554 netif_device_attach(vf->efx->net_dev);
560 memset(vf->mac, 0, ETH_ALEN);
564 int efx_ef10_sriov_set_vf_vlan(struct efx_nic *efx, int vf_i, u16 vlan,
567 struct efx_ef10_nic_data *nic_data = efx->nic_data;
569 u16 old_vlan, new_vlan;
572 if (vf_i >= efx->vf_count)
577 vf = nic_data->vf + vf_i;
579 new_vlan = (vlan == 0) ? EFX_EF10_NO_VLAN : vlan;
580 if (new_vlan == vf->vlan)
584 efx_device_detach_sync(vf->efx);
585 efx_net_stop(vf->efx->net_dev);
587 mutex_lock(&vf->efx->mac_lock);
588 down_write(&vf->efx->filter_sem);
589 vf->efx->type->filter_table_remove(vf->efx);
591 rc = efx_ef10_vadaptor_free(vf->efx, EVB_PORT_ID_ASSIGNED);
593 goto restore_filters;
596 if (vf->vport_assigned) {
597 rc = efx_ef10_evb_port_assign(efx, EVB_PORT_ID_NULL, vf_i);
599 netif_warn(efx, drv, efx->net_dev,
600 "Failed to change vlan on VF %d.\n", vf_i);
601 netif_warn(efx, drv, efx->net_dev,
602 "This is likely because the VF is bound to a driver in a VM.\n");
603 netif_warn(efx, drv, efx->net_dev,
604 "Please unload the driver in the VM.\n");
605 goto restore_vadaptor;
607 vf->vport_assigned = 0;
610 if (!is_zero_ether_addr(vf->mac)) {
611 rc = efx_ef10_vport_del_mac(efx, vf->vport_id, vf->mac);
613 goto restore_evb_port;
617 rc = efx_ef10_vport_free(efx, vf->vport_id);
623 /* Do the actual vlan change */
627 /* Restore everything in reverse order */
628 rc = efx_ef10_vport_alloc(efx, EVB_PORT_ID_ASSIGNED,
629 MC_CMD_VPORT_ALLOC_IN_VPORT_TYPE_NORMAL,
630 vf->vlan, &vf->vport_id);
632 goto reset_nic_up_write;
635 if (!is_zero_ether_addr(vf->mac)) {
636 rc2 = efx_ef10_vport_add_mac(efx, vf->vport_id, vf->mac);
638 eth_zero_addr(vf->mac);
639 goto reset_nic_up_write;
644 rc2 = efx_ef10_evb_port_assign(efx, vf->vport_id, vf_i);
646 goto reset_nic_up_write;
648 vf->vport_assigned = 1;
652 rc2 = efx_ef10_vadaptor_alloc(vf->efx, EVB_PORT_ID_ASSIGNED);
654 goto reset_nic_up_write;
659 rc2 = vf->efx->type->filter_table_probe(vf->efx);
661 goto reset_nic_up_write;
663 up_write(&vf->efx->filter_sem);
664 mutex_unlock(&vf->efx->mac_lock);
666 up_write(&vf->efx->filter_sem);
668 rc2 = efx_net_open(vf->efx->net_dev);
672 netif_device_attach(vf->efx->net_dev);
678 up_write(&vf->efx->filter_sem);
679 mutex_unlock(&vf->efx->mac_lock);
683 netif_err(efx, drv, efx->net_dev,
684 "Failed to restore VF - scheduling reset.\n");
685 efx_schedule_reset(vf->efx, RESET_TYPE_DATAPATH);
687 netif_err(efx, drv, efx->net_dev,
688 "Failed to restore the VF and cannot reset the VF "
689 "- VF is not functional.\n");
690 netif_err(efx, drv, efx->net_dev,
691 "Please reload the driver attached to the VF.\n");
694 return rc ? rc : rc2;
697 int efx_ef10_sriov_set_vf_spoofchk(struct efx_nic *efx, int vf_i,
700 return spoofchk ? -EOPNOTSUPP : 0;
703 int efx_ef10_sriov_set_vf_link_state(struct efx_nic *efx, int vf_i,
706 MCDI_DECLARE_BUF(inbuf, MC_CMD_LINK_STATE_MODE_IN_LEN);
707 struct efx_ef10_nic_data *nic_data = efx->nic_data;
709 BUILD_BUG_ON(IFLA_VF_LINK_STATE_AUTO !=
710 MC_CMD_LINK_STATE_MODE_IN_LINK_STATE_AUTO);
711 BUILD_BUG_ON(IFLA_VF_LINK_STATE_ENABLE !=
712 MC_CMD_LINK_STATE_MODE_IN_LINK_STATE_UP);
713 BUILD_BUG_ON(IFLA_VF_LINK_STATE_DISABLE !=
714 MC_CMD_LINK_STATE_MODE_IN_LINK_STATE_DOWN);
715 MCDI_POPULATE_DWORD_2(inbuf, LINK_STATE_MODE_IN_FUNCTION,
716 LINK_STATE_MODE_IN_FUNCTION_PF,
718 LINK_STATE_MODE_IN_FUNCTION_VF, vf_i);
719 MCDI_SET_DWORD(inbuf, LINK_STATE_MODE_IN_NEW_MODE, link_state);
720 return efx_mcdi_rpc(efx, MC_CMD_LINK_STATE_MODE, inbuf, sizeof(inbuf),
721 NULL, 0, NULL); /* don't care what old mode was */
724 int efx_ef10_sriov_get_vf_config(struct efx_nic *efx, int vf_i,
725 struct ifla_vf_info *ivf)
727 MCDI_DECLARE_BUF(inbuf, MC_CMD_LINK_STATE_MODE_IN_LEN);
728 MCDI_DECLARE_BUF(outbuf, MC_CMD_LINK_STATE_MODE_OUT_LEN);
730 struct efx_ef10_nic_data *nic_data = efx->nic_data;
735 if (vf_i >= efx->vf_count)
741 vf = nic_data->vf + vf_i;
744 ivf->min_tx_rate = 0;
745 ivf->max_tx_rate = 0;
746 ether_addr_copy(ivf->mac, vf->mac);
747 ivf->vlan = (vf->vlan == EFX_EF10_NO_VLAN) ? 0 : vf->vlan;
750 MCDI_POPULATE_DWORD_2(inbuf, LINK_STATE_MODE_IN_FUNCTION,
751 LINK_STATE_MODE_IN_FUNCTION_PF,
753 LINK_STATE_MODE_IN_FUNCTION_VF, vf_i);
754 MCDI_SET_DWORD(inbuf, LINK_STATE_MODE_IN_NEW_MODE,
755 MC_CMD_LINK_STATE_MODE_IN_DO_NOT_CHANGE);
756 rc = efx_mcdi_rpc(efx, MC_CMD_LINK_STATE_MODE, inbuf, sizeof(inbuf),
757 outbuf, sizeof(outbuf), &outlen);
760 if (outlen < MC_CMD_LINK_STATE_MODE_OUT_LEN)
762 ivf->linkstate = MCDI_DWORD(outbuf, LINK_STATE_MODE_OUT_OLD_MODE);
767 int efx_ef10_sriov_get_phys_port_id(struct efx_nic *efx,
768 struct netdev_phys_item_id *ppid)
770 struct efx_ef10_nic_data *nic_data = efx->nic_data;
772 if (!is_valid_ether_addr(nic_data->port_id))
775 ppid->id_len = ETH_ALEN;
776 memcpy(ppid->id, nic_data->port_id, ppid->id_len);