4 * Copyright (C) 2013-2015 Ideas on Board
5 * Copyright (C) 2013-2015 Xilinx, Inc.
7 * Contacts: Hyun Kwon <hyun.kwon@xilinx.com>
8 * Laurent Pinchart <laurent.pinchart@ideasonboard.com>
10 * This program is free software; you can redistribute it and/or modify
11 * it under the terms of the GNU General Public License version 2 as
12 * published by the Free Software Foundation.
15 #include <linux/dma/xilinx_dma.h>
16 #include <linux/lcm.h>
17 #include <linux/list.h>
18 #include <linux/module.h>
20 #include <linux/slab.h>
22 #include <media/v4l2-dev.h>
23 #include <media/v4l2-fh.h>
24 #include <media/v4l2-ioctl.h>
25 #include <media/videobuf2-v4l2.h>
26 #include <media/videobuf2-dma-contig.h>
28 #include "xilinx-dma.h"
29 #include "xilinx-vip.h"
30 #include "xilinx-vipp.h"
32 #define XVIP_DMA_DEF_FORMAT V4L2_PIX_FMT_YUYV
33 #define XVIP_DMA_DEF_WIDTH 1920
34 #define XVIP_DMA_DEF_HEIGHT 1080
36 /* Minimum and maximum widths are expressed in bytes */
37 #define XVIP_DMA_MIN_WIDTH 1U
38 #define XVIP_DMA_MAX_WIDTH 65535U
39 #define XVIP_DMA_MIN_HEIGHT 1U
40 #define XVIP_DMA_MAX_HEIGHT 8191U
42 /* -----------------------------------------------------------------------------
46 static struct v4l2_subdev *
47 xvip_dma_remote_subdev(struct media_pad *local, u32 *pad)
49 struct media_pad *remote;
51 remote = media_entity_remote_pad(local);
52 if (!remote || !is_media_entity_v4l2_subdev(remote->entity))
58 return media_entity_to_v4l2_subdev(remote->entity);
61 static int xvip_dma_verify_format(struct xvip_dma *dma)
63 struct v4l2_subdev_format fmt;
64 struct v4l2_subdev *subdev;
67 subdev = xvip_dma_remote_subdev(&dma->pad, &fmt.pad);
71 fmt.which = V4L2_SUBDEV_FORMAT_ACTIVE;
72 ret = v4l2_subdev_call(subdev, pad, get_fmt, NULL, &fmt);
74 return ret == -ENOIOCTLCMD ? -EINVAL : ret;
76 if (dma->fmtinfo->code != fmt.format.code ||
77 dma->format.height != fmt.format.height ||
78 dma->format.width != fmt.format.width ||
79 dma->format.colorspace != fmt.format.colorspace)
85 /* -----------------------------------------------------------------------------
86 * Pipeline Stream Management
90 * xvip_pipeline_start_stop - Start ot stop streaming on a pipeline
92 * @start: Start (when true) or stop (when false) the pipeline
94 * Walk the entities chain starting at the pipeline output video node and start
95 * or stop all of them.
97 * Return: 0 if successful, or the return value of the failed video::s_stream
98 * operation otherwise.
100 static int xvip_pipeline_start_stop(struct xvip_pipeline *pipe, bool start)
102 struct xvip_dma *dma = pipe->output;
103 struct media_entity *entity;
104 struct media_pad *pad;
105 struct v4l2_subdev *subdev;
108 entity = &dma->video.entity;
110 pad = &entity->pads[0];
111 if (!(pad->flags & MEDIA_PAD_FL_SINK))
114 pad = media_entity_remote_pad(pad);
115 if (!pad || !is_media_entity_v4l2_subdev(pad->entity))
118 entity = pad->entity;
119 subdev = media_entity_to_v4l2_subdev(entity);
121 ret = v4l2_subdev_call(subdev, video, s_stream, start);
122 if (start && ret < 0 && ret != -ENOIOCTLCMD)
130 * xvip_pipeline_set_stream - Enable/disable streaming on a pipeline
131 * @pipe: The pipeline
132 * @on: Turn the stream on when true or off when false
134 * The pipeline is shared between all DMA engines connect at its input and
135 * output. While the stream state of DMA engines can be controlled
136 * independently, pipelines have a shared stream state that enable or disable
137 * all entities in the pipeline. For this reason the pipeline uses a streaming
138 * counter that tracks the number of DMA engines that have requested the stream
141 * When called with the @on argument set to true, this function will increment
142 * the pipeline streaming count. If the streaming count reaches the number of
143 * DMA engines in the pipeline it will enable all entities that belong to the
146 * Similarly, when called with the @on argument set to false, this function will
147 * decrement the pipeline streaming count and disable all entities in the
148 * pipeline when the streaming count reaches zero.
150 * Return: 0 if successful, or the return value of the failed video::s_stream
151 * operation otherwise. Stopping the pipeline never fails. The pipeline state is
152 * not updated when the operation fails.
154 static int xvip_pipeline_set_stream(struct xvip_pipeline *pipe, bool on)
158 mutex_lock(&pipe->lock);
161 if (pipe->stream_count == pipe->num_dmas - 1) {
162 ret = xvip_pipeline_start_stop(pipe, true);
166 pipe->stream_count++;
168 if (--pipe->stream_count == 0)
169 xvip_pipeline_start_stop(pipe, false);
173 mutex_unlock(&pipe->lock);
177 static int xvip_pipeline_validate(struct xvip_pipeline *pipe,
178 struct xvip_dma *start)
180 struct media_graph graph;
181 struct media_entity *entity = &start->video.entity;
182 struct media_device *mdev = entity->graph_obj.mdev;
183 unsigned int num_inputs = 0;
184 unsigned int num_outputs = 0;
187 mutex_lock(&mdev->graph_mutex);
189 /* Walk the graph to locate the video nodes. */
190 ret = media_graph_walk_init(&graph, mdev);
192 mutex_unlock(&mdev->graph_mutex);
196 media_graph_walk_start(&graph, entity);
198 while ((entity = media_graph_walk_next(&graph))) {
199 struct xvip_dma *dma;
201 if (entity->function != MEDIA_ENT_F_IO_V4L)
204 dma = to_xvip_dma(media_entity_to_video_device(entity));
206 if (dma->pad.flags & MEDIA_PAD_FL_SINK) {
214 mutex_unlock(&mdev->graph_mutex);
216 media_graph_walk_cleanup(&graph);
218 /* We need exactly one output and zero or one input. */
219 if (num_outputs != 1 || num_inputs > 1)
222 pipe->num_dmas = num_inputs + num_outputs;
227 static void __xvip_pipeline_cleanup(struct xvip_pipeline *pipe)
234 * xvip_pipeline_cleanup - Cleanup the pipeline after streaming
235 * @pipe: the pipeline
237 * Decrease the pipeline use count and clean it up if we were the last user.
239 static void xvip_pipeline_cleanup(struct xvip_pipeline *pipe)
241 mutex_lock(&pipe->lock);
243 /* If we're the last user clean up the pipeline. */
244 if (--pipe->use_count == 0)
245 __xvip_pipeline_cleanup(pipe);
247 mutex_unlock(&pipe->lock);
251 * xvip_pipeline_prepare - Prepare the pipeline for streaming
252 * @pipe: the pipeline
253 * @dma: DMA engine at one end of the pipeline
255 * Validate the pipeline if no user exists yet, otherwise just increase the use
258 * Return: 0 if successful or -EPIPE if the pipeline is not valid.
260 static int xvip_pipeline_prepare(struct xvip_pipeline *pipe,
261 struct xvip_dma *dma)
265 mutex_lock(&pipe->lock);
267 /* If we're the first user validate and initialize the pipeline. */
268 if (pipe->use_count == 0) {
269 ret = xvip_pipeline_validate(pipe, dma);
271 __xvip_pipeline_cleanup(pipe);
280 mutex_unlock(&pipe->lock);
284 /* -----------------------------------------------------------------------------
285 * videobuf2 queue operations
289 * struct xvip_dma_buffer - Video DMA buffer
290 * @buf: vb2 buffer base object
291 * @queue: buffer list entry in the DMA engine queued buffers list
292 * @dma: DMA channel that uses the buffer
294 struct xvip_dma_buffer {
295 struct vb2_v4l2_buffer buf;
296 struct list_head queue;
297 struct xvip_dma *dma;
300 #define to_xvip_dma_buffer(vb) container_of(vb, struct xvip_dma_buffer, buf)
302 static void xvip_dma_complete(void *param)
304 struct xvip_dma_buffer *buf = param;
305 struct xvip_dma *dma = buf->dma;
307 spin_lock(&dma->queued_lock);
308 list_del(&buf->queue);
309 spin_unlock(&dma->queued_lock);
311 buf->buf.field = V4L2_FIELD_NONE;
312 buf->buf.sequence = dma->sequence++;
313 buf->buf.vb2_buf.timestamp = ktime_get_ns();
314 vb2_set_plane_payload(&buf->buf.vb2_buf, 0, dma->format.sizeimage);
315 vb2_buffer_done(&buf->buf.vb2_buf, VB2_BUF_STATE_DONE);
319 xvip_dma_queue_setup(struct vb2_queue *vq,
320 unsigned int *nbuffers, unsigned int *nplanes,
321 unsigned int sizes[], struct device *alloc_devs[])
323 struct xvip_dma *dma = vb2_get_drv_priv(vq);
325 /* Make sure the image size is large enough. */
327 return sizes[0] < dma->format.sizeimage ? -EINVAL : 0;
330 sizes[0] = dma->format.sizeimage;
335 static int xvip_dma_buffer_prepare(struct vb2_buffer *vb)
337 struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
338 struct xvip_dma *dma = vb2_get_drv_priv(vb->vb2_queue);
339 struct xvip_dma_buffer *buf = to_xvip_dma_buffer(vbuf);
346 static void xvip_dma_buffer_queue(struct vb2_buffer *vb)
348 struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
349 struct xvip_dma *dma = vb2_get_drv_priv(vb->vb2_queue);
350 struct xvip_dma_buffer *buf = to_xvip_dma_buffer(vbuf);
351 struct dma_async_tx_descriptor *desc;
352 dma_addr_t addr = vb2_dma_contig_plane_dma_addr(vb, 0);
355 if (dma->queue.type == V4L2_BUF_TYPE_VIDEO_CAPTURE) {
356 flags = DMA_PREP_INTERRUPT | DMA_CTRL_ACK;
357 dma->xt.dir = DMA_DEV_TO_MEM;
358 dma->xt.src_sgl = false;
359 dma->xt.dst_sgl = true;
360 dma->xt.dst_start = addr;
362 flags = DMA_PREP_INTERRUPT | DMA_CTRL_ACK;
363 dma->xt.dir = DMA_MEM_TO_DEV;
364 dma->xt.src_sgl = true;
365 dma->xt.dst_sgl = false;
366 dma->xt.src_start = addr;
369 dma->xt.frame_size = 1;
370 dma->sgl[0].size = dma->format.width * dma->fmtinfo->bpp;
371 dma->sgl[0].icg = dma->format.bytesperline - dma->sgl[0].size;
372 dma->xt.numf = dma->format.height;
374 desc = dmaengine_prep_interleaved_dma(dma->dma, &dma->xt, flags);
376 dev_err(dma->xdev->dev, "Failed to prepare DMA transfer\n");
377 vb2_buffer_done(&buf->buf.vb2_buf, VB2_BUF_STATE_ERROR);
380 desc->callback = xvip_dma_complete;
381 desc->callback_param = buf;
383 spin_lock_irq(&dma->queued_lock);
384 list_add_tail(&buf->queue, &dma->queued_bufs);
385 spin_unlock_irq(&dma->queued_lock);
387 dmaengine_submit(desc);
389 if (vb2_is_streaming(&dma->queue))
390 dma_async_issue_pending(dma->dma);
393 static int xvip_dma_start_streaming(struct vb2_queue *vq, unsigned int count)
395 struct xvip_dma *dma = vb2_get_drv_priv(vq);
396 struct xvip_dma_buffer *buf, *nbuf;
397 struct xvip_pipeline *pipe;
403 * Start streaming on the pipeline. No link touching an entity in the
404 * pipeline can be activated or deactivated once streaming is started.
406 * Use the pipeline object embedded in the first DMA object that starts
409 pipe = dma->video.entity.pipe
410 ? to_xvip_pipeline(&dma->video.entity) : &dma->pipe;
412 ret = media_pipeline_start(&dma->video.entity, &pipe->pipe);
416 /* Verify that the configured format matches the output of the
419 ret = xvip_dma_verify_format(dma);
423 ret = xvip_pipeline_prepare(pipe, dma);
427 /* Start the DMA engine. This must be done before starting the blocks
428 * in the pipeline to avoid DMA synchronization issues.
430 dma_async_issue_pending(dma->dma);
432 /* Start the pipeline. */
433 xvip_pipeline_set_stream(pipe, true);
438 media_pipeline_stop(&dma->video.entity);
441 /* Give back all queued buffers to videobuf2. */
442 spin_lock_irq(&dma->queued_lock);
443 list_for_each_entry_safe(buf, nbuf, &dma->queued_bufs, queue) {
444 vb2_buffer_done(&buf->buf.vb2_buf, VB2_BUF_STATE_QUEUED);
445 list_del(&buf->queue);
447 spin_unlock_irq(&dma->queued_lock);
452 static void xvip_dma_stop_streaming(struct vb2_queue *vq)
454 struct xvip_dma *dma = vb2_get_drv_priv(vq);
455 struct xvip_pipeline *pipe = to_xvip_pipeline(&dma->video.entity);
456 struct xvip_dma_buffer *buf, *nbuf;
458 /* Stop the pipeline. */
459 xvip_pipeline_set_stream(pipe, false);
461 /* Stop and reset the DMA engine. */
462 dmaengine_terminate_all(dma->dma);
464 /* Cleanup the pipeline and mark it as being stopped. */
465 xvip_pipeline_cleanup(pipe);
466 media_pipeline_stop(&dma->video.entity);
468 /* Give back all queued buffers to videobuf2. */
469 spin_lock_irq(&dma->queued_lock);
470 list_for_each_entry_safe(buf, nbuf, &dma->queued_bufs, queue) {
471 vb2_buffer_done(&buf->buf.vb2_buf, VB2_BUF_STATE_ERROR);
472 list_del(&buf->queue);
474 spin_unlock_irq(&dma->queued_lock);
477 static const struct vb2_ops xvip_dma_queue_qops = {
478 .queue_setup = xvip_dma_queue_setup,
479 .buf_prepare = xvip_dma_buffer_prepare,
480 .buf_queue = xvip_dma_buffer_queue,
481 .wait_prepare = vb2_ops_wait_prepare,
482 .wait_finish = vb2_ops_wait_finish,
483 .start_streaming = xvip_dma_start_streaming,
484 .stop_streaming = xvip_dma_stop_streaming,
487 /* -----------------------------------------------------------------------------
492 xvip_dma_querycap(struct file *file, void *fh, struct v4l2_capability *cap)
494 struct v4l2_fh *vfh = file->private_data;
495 struct xvip_dma *dma = to_xvip_dma(vfh->vdev);
497 cap->device_caps = V4L2_CAP_STREAMING;
499 if (dma->queue.type == V4L2_BUF_TYPE_VIDEO_CAPTURE)
500 cap->device_caps |= V4L2_CAP_VIDEO_CAPTURE;
502 cap->device_caps |= V4L2_CAP_VIDEO_OUTPUT;
504 cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS
505 | dma->xdev->v4l2_caps;
507 strlcpy(cap->driver, "xilinx-vipp", sizeof(cap->driver));
508 strlcpy(cap->card, dma->video.name, sizeof(cap->card));
509 snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s:%u",
510 dma->xdev->dev->of_node->name, dma->port);
515 /* FIXME: without this callback function, some applications are not configured
516 * with correct formats, and it results in frames in wrong format. Whether this
517 * callback needs to be required is not clearly defined, so it should be
518 * clarified through the mailing list.
521 xvip_dma_enum_format(struct file *file, void *fh, struct v4l2_fmtdesc *f)
523 struct v4l2_fh *vfh = file->private_data;
524 struct xvip_dma *dma = to_xvip_dma(vfh->vdev);
529 f->pixelformat = dma->format.pixelformat;
530 strlcpy(f->description, dma->fmtinfo->description,
531 sizeof(f->description));
537 xvip_dma_get_format(struct file *file, void *fh, struct v4l2_format *format)
539 struct v4l2_fh *vfh = file->private_data;
540 struct xvip_dma *dma = to_xvip_dma(vfh->vdev);
542 format->fmt.pix = dma->format;
548 __xvip_dma_try_format(struct xvip_dma *dma, struct v4l2_pix_format *pix,
549 const struct xvip_video_format **fmtinfo)
551 const struct xvip_video_format *info;
552 unsigned int min_width;
553 unsigned int max_width;
554 unsigned int min_bpl;
555 unsigned int max_bpl;
560 /* Retrieve format information and select the default format if the
561 * requested format isn't supported.
563 info = xvip_get_format_by_fourcc(pix->pixelformat);
565 info = xvip_get_format_by_fourcc(XVIP_DMA_DEF_FORMAT);
567 pix->pixelformat = info->fourcc;
568 pix->field = V4L2_FIELD_NONE;
570 /* The transfer alignment requirements are expressed in bytes. Compute
571 * the minimum and maximum values, clamp the requested width and convert
574 align = lcm(dma->align, info->bpp);
575 min_width = roundup(XVIP_DMA_MIN_WIDTH, align);
576 max_width = rounddown(XVIP_DMA_MAX_WIDTH, align);
577 width = rounddown(pix->width * info->bpp, align);
579 pix->width = clamp(width, min_width, max_width) / info->bpp;
580 pix->height = clamp(pix->height, XVIP_DMA_MIN_HEIGHT,
581 XVIP_DMA_MAX_HEIGHT);
583 /* Clamp the requested bytes per line value. If the maximum bytes per
584 * line value is zero, the module doesn't support user configurable line
585 * sizes. Override the requested value with the minimum in that case.
587 min_bpl = pix->width * info->bpp;
588 max_bpl = rounddown(XVIP_DMA_MAX_WIDTH, dma->align);
589 bpl = rounddown(pix->bytesperline, dma->align);
591 pix->bytesperline = clamp(bpl, min_bpl, max_bpl);
592 pix->sizeimage = pix->bytesperline * pix->height;
599 xvip_dma_try_format(struct file *file, void *fh, struct v4l2_format *format)
601 struct v4l2_fh *vfh = file->private_data;
602 struct xvip_dma *dma = to_xvip_dma(vfh->vdev);
604 __xvip_dma_try_format(dma, &format->fmt.pix, NULL);
609 xvip_dma_set_format(struct file *file, void *fh, struct v4l2_format *format)
611 struct v4l2_fh *vfh = file->private_data;
612 struct xvip_dma *dma = to_xvip_dma(vfh->vdev);
613 const struct xvip_video_format *info;
615 __xvip_dma_try_format(dma, &format->fmt.pix, &info);
617 if (vb2_is_busy(&dma->queue))
620 dma->format = format->fmt.pix;
626 static const struct v4l2_ioctl_ops xvip_dma_ioctl_ops = {
627 .vidioc_querycap = xvip_dma_querycap,
628 .vidioc_enum_fmt_vid_cap = xvip_dma_enum_format,
629 .vidioc_g_fmt_vid_cap = xvip_dma_get_format,
630 .vidioc_g_fmt_vid_out = xvip_dma_get_format,
631 .vidioc_s_fmt_vid_cap = xvip_dma_set_format,
632 .vidioc_s_fmt_vid_out = xvip_dma_set_format,
633 .vidioc_try_fmt_vid_cap = xvip_dma_try_format,
634 .vidioc_try_fmt_vid_out = xvip_dma_try_format,
635 .vidioc_reqbufs = vb2_ioctl_reqbufs,
636 .vidioc_querybuf = vb2_ioctl_querybuf,
637 .vidioc_qbuf = vb2_ioctl_qbuf,
638 .vidioc_dqbuf = vb2_ioctl_dqbuf,
639 .vidioc_create_bufs = vb2_ioctl_create_bufs,
640 .vidioc_expbuf = vb2_ioctl_expbuf,
641 .vidioc_streamon = vb2_ioctl_streamon,
642 .vidioc_streamoff = vb2_ioctl_streamoff,
645 /* -----------------------------------------------------------------------------
646 * V4L2 file operations
649 static const struct v4l2_file_operations xvip_dma_fops = {
650 .owner = THIS_MODULE,
651 .unlocked_ioctl = video_ioctl2,
652 .open = v4l2_fh_open,
653 .release = vb2_fop_release,
654 .poll = vb2_fop_poll,
655 .mmap = vb2_fop_mmap,
658 /* -----------------------------------------------------------------------------
659 * Xilinx Video DMA Core
662 int xvip_dma_init(struct xvip_composite_device *xdev, struct xvip_dma *dma,
663 enum v4l2_buf_type type, unsigned int port)
670 mutex_init(&dma->lock);
671 mutex_init(&dma->pipe.lock);
672 INIT_LIST_HEAD(&dma->queued_bufs);
673 spin_lock_init(&dma->queued_lock);
675 dma->fmtinfo = xvip_get_format_by_fourcc(XVIP_DMA_DEF_FORMAT);
676 dma->format.pixelformat = dma->fmtinfo->fourcc;
677 dma->format.colorspace = V4L2_COLORSPACE_SRGB;
678 dma->format.field = V4L2_FIELD_NONE;
679 dma->format.width = XVIP_DMA_DEF_WIDTH;
680 dma->format.height = XVIP_DMA_DEF_HEIGHT;
681 dma->format.bytesperline = dma->format.width * dma->fmtinfo->bpp;
682 dma->format.sizeimage = dma->format.bytesperline * dma->format.height;
684 /* Initialize the media entity... */
685 dma->pad.flags = type == V4L2_BUF_TYPE_VIDEO_CAPTURE
686 ? MEDIA_PAD_FL_SINK : MEDIA_PAD_FL_SOURCE;
688 ret = media_entity_pads_init(&dma->video.entity, 1, &dma->pad);
692 /* ... and the video node... */
693 dma->video.fops = &xvip_dma_fops;
694 dma->video.v4l2_dev = &xdev->v4l2_dev;
695 dma->video.queue = &dma->queue;
696 snprintf(dma->video.name, sizeof(dma->video.name), "%s %s %u",
697 xdev->dev->of_node->name,
698 type == V4L2_BUF_TYPE_VIDEO_CAPTURE ? "output" : "input",
700 dma->video.vfl_type = VFL_TYPE_GRABBER;
701 dma->video.vfl_dir = type == V4L2_BUF_TYPE_VIDEO_CAPTURE
702 ? VFL_DIR_RX : VFL_DIR_TX;
703 dma->video.release = video_device_release_empty;
704 dma->video.ioctl_ops = &xvip_dma_ioctl_ops;
705 dma->video.lock = &dma->lock;
707 video_set_drvdata(&dma->video, dma);
709 /* ... and the buffers queue... */
710 /* Don't enable VB2_READ and VB2_WRITE, as using the read() and write()
711 * V4L2 APIs would be inefficient. Testing on the command line with a
712 * 'cat /dev/video?' thus won't be possible, but given that the driver
713 * anyway requires a test tool to setup the pipeline before any video
714 * stream can be started, requiring a specific V4L2 test tool as well
715 * instead of 'cat' isn't really a drawback.
717 dma->queue.type = type;
718 dma->queue.io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF;
719 dma->queue.lock = &dma->lock;
720 dma->queue.drv_priv = dma;
721 dma->queue.buf_struct_size = sizeof(struct xvip_dma_buffer);
722 dma->queue.ops = &xvip_dma_queue_qops;
723 dma->queue.mem_ops = &vb2_dma_contig_memops;
724 dma->queue.timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC
725 | V4L2_BUF_FLAG_TSTAMP_SRC_EOF;
726 dma->queue.dev = dma->xdev->dev;
727 ret = vb2_queue_init(&dma->queue);
729 dev_err(dma->xdev->dev, "failed to initialize VB2 queue\n");
733 /* ... and the DMA channel. */
734 snprintf(name, sizeof(name), "port%u", port);
735 dma->dma = dma_request_slave_channel(dma->xdev->dev, name);
736 if (dma->dma == NULL) {
737 dev_err(dma->xdev->dev, "no VDMA channel found\n");
742 dma->align = 1 << dma->dma->device->copy_align;
744 ret = video_register_device(&dma->video, VFL_TYPE_GRABBER, -1);
746 dev_err(dma->xdev->dev, "failed to register video device\n");
753 xvip_dma_cleanup(dma);
757 void xvip_dma_cleanup(struct xvip_dma *dma)
759 if (video_is_registered(&dma->video))
760 video_unregister_device(&dma->video);
763 dma_release_channel(dma->dma);
765 media_entity_cleanup(&dma->video.entity);
767 mutex_destroy(&dma->lock);
768 mutex_destroy(&dma->pipe.lock);