drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c

   1 /**************************************************************************
   2  *
   3  * Copyright © 2009-2015 VMware, Inc., Palo Alto, CA., USA
   4  * All Rights Reserved.
   5  *
   6  * Permission is hereby granted, free of charge, to any person obtaining a
   7  * copy of this software and associated documentation files (the
   8  * "Software"), to deal in the Software without restriction, including
   9  * without limitation the rights to use, copy, modify, merge, publish,
  10  * distribute, sub license, and/or sell copies of the Software, and to
  11  * permit persons to whom the Software is furnished to do so, subject to
  12  * the following conditions:
  13  *
  14  * The above copyright notice and this permission notice (including the
  15  * next paragraph) shall be included in all copies or substantial portions
  16  * of the Software.
  17  *
  18  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  19  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  20  * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL
  21  * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM,
  22  * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
  23  * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
  24  * USE OR OTHER DEALINGS IN THE SOFTWARE.
  25  *
  26  **************************************************************************/
  27
  28 #include "vmwgfx_kms.h"
  29 #include <drm/drm_plane_helper.h>
  30 #include <drm/drm_atomic.h>
  31 #include <drm/drm_atomic_helper.h>
  32
  33
  34 #define vmw_crtc_to_ldu(x) \
  35         container_of(x, struct vmw_legacy_display_unit, base.crtc)
  36 #define vmw_encoder_to_ldu(x) \
  37         container_of(x, struct vmw_legacy_display_unit, base.encoder)
  38 #define vmw_connector_to_ldu(x) \
  39         container_of(x, struct vmw_legacy_display_unit, base.connector)
  40
  41 struct vmw_legacy_display {
  42         struct list_head active;
  43
  44         unsigned num_active;
  45         unsigned last_num_active;
  46
  47         struct vmw_framebuffer *fb;
  48 };
  49
  50 /**
  51  * Display unit using the legacy register interface.
  52  */
  53 struct vmw_legacy_display_unit {
  54         struct vmw_display_unit base;
  55
  56         struct list_head active;
  57 };
  58
  59 static void vmw_ldu_destroy(struct vmw_legacy_display_unit *ldu)
  60 {
  61         list_del_init(&ldu->active);
  62         vmw_du_cleanup(&ldu->base);
  63         kfree(ldu);
  64 }
  65
  66
  67 /*
  68  * Legacy Display Unit CRTC functions
  69  */
  70
  71 static void vmw_ldu_crtc_destroy(struct drm_crtc *crtc)
  72 {
  73         vmw_ldu_destroy(vmw_crtc_to_ldu(crtc));
  74 }
  75
  76 static int vmw_ldu_commit_list(struct vmw_private *dev_priv)
  77 {
  78         struct vmw_legacy_display *lds = dev_priv->ldu_priv;
  79         struct vmw_legacy_display_unit *entry;
  80         struct drm_framebuffer *fb = NULL;
  81         struct drm_crtc *crtc = NULL;
  82         int i;
  83
  84         /* If there is no display topology the host just assumes
  85          * that the guest will set the same layout as the host.
  86          */
  87         if (!(dev_priv->capabilities & SVGA_CAP_DISPLAY_TOPOLOGY)) {
  88                 int w = 0, h = 0;
  89                 list_for_each_entry(entry, &lds->active, active) {
  90                         crtc = &entry->base.crtc;
  91                         w = max(w, crtc->x + crtc->mode.hdisplay);
  92                         h = max(h, crtc->y + crtc->mode.vdisplay);
  93                 }
  94
  95                 if (crtc == NULL)
  96                         return 0;
  97                 fb = crtc->primary->state->fb;
  98
  99                 return vmw_kms_write_svga(dev_priv, w, h, fb->pitches[0],
 100                                           fb->format->cpp[0] * 8,
 101                                           fb->format->depth);
 102         }
 103
 104         if (!list_empty(&lds->active)) {
 105                 entry = list_entry(lds->active.next, typeof(*entry), active);
 106                 fb = entry->base.crtc.primary->state->fb;
 107
 108                 vmw_kms_write_svga(dev_priv, fb->width, fb->height, fb->pitches[0],
 109                                    fb->format->cpp[0] * 8, fb->format->depth);
 110         }
 111
 112         /* Make sure we always show something. */
 113         vmw_write(dev_priv, SVGA_REG_NUM_GUEST_DISPLAYS,
 114                   lds->num_active ? lds->num_active : 1);
 115
 116         i = 0;
 117         list_for_each_entry(entry, &lds->active, active) {
 118                 crtc = &entry->base.crtc;
 119
 120                 vmw_write(dev_priv, SVGA_REG_DISPLAY_ID, i);
 121                 vmw_write(dev_priv, SVGA_REG_DISPLAY_IS_PRIMARY, !i);
 122                 vmw_write(dev_priv, SVGA_REG_DISPLAY_POSITION_X, crtc->x);
 123                 vmw_write(dev_priv, SVGA_REG_DISPLAY_POSITION_Y, crtc->y);
 124                 vmw_write(dev_priv, SVGA_REG_DISPLAY_WIDTH, crtc->mode.hdisplay);
 125                 vmw_write(dev_priv, SVGA_REG_DISPLAY_HEIGHT, crtc->mode.vdisplay);
 126                 vmw_write(dev_priv, SVGA_REG_DISPLAY_ID, SVGA_ID_INVALID);
 127
 128                 i++;
 129         }
 130
 131         BUG_ON(i != lds->num_active);
 132
 133         lds->last_num_active = lds->num_active;
 134
 135         return 0;
 136 }
 137
 138 static int vmw_ldu_del_active(struct vmw_private *vmw_priv,
 139                               struct vmw_legacy_display_unit *ldu)
 140 {
 141         struct vmw_legacy_display *ld = vmw_priv->ldu_priv;
 142         if (list_empty(&ldu->active))
 143                 return 0;
 144
 145         /* Must init otherwise list_empty(&ldu->active) will not work. */
 146         list_del_init(&ldu->active);
 147         if (--(ld->num_active) == 0) {
 148                 BUG_ON(!ld->fb);
 149                 if (ld->fb->unpin)
 150                         ld->fb->unpin(ld->fb);
 151                 ld->fb = NULL;
 152         }
 153
 154         return 0;
 155 }
 156
 157 static int vmw_ldu_add_active(struct vmw_private *vmw_priv,
 158                               struct vmw_legacy_display_unit *ldu,
 159                               struct vmw_framebuffer *vfb)
 160 {
 161         struct vmw_legacy_display *ld = vmw_priv->ldu_priv;
 162         struct vmw_legacy_display_unit *entry;
 163         struct list_head *at;
 164
 165         BUG_ON(!ld->num_active && ld->fb);
 166         if (vfb != ld->fb) {
 167                 if (ld->fb && ld->fb->unpin)
 168                         ld->fb->unpin(ld->fb);
 169                 vmw_svga_enable(vmw_priv);
 170                 if (vfb->pin)
 171                         vfb->pin(vfb);
 172                 ld->fb = vfb;
 173         }
 174
 175         if (!list_empty(&ldu->active))
 176                 return 0;
 177
 178         at = &ld->active;
 179         list_for_each_entry(entry, &ld->active, active) {
 180                 if (entry->base.unit > ldu->base.unit)
 181                         break;
 182
 183                 at = &entry->active;
 184         }
 185
 186         list_add(&ldu->active, at);
 187
 188         ld->num_active++;
 189
 190         return 0;
 191 }
 192
 193 /**
 194  * vmw_ldu_crtc_mode_set_nofb - Enable svga
 195  *
 196  * @crtc: CRTC associated with the new screen
 197  *
 198  * For LDU, just enable the svga
 199  */
 200 static void vmw_ldu_crtc_mode_set_nofb(struct drm_crtc *crtc)
 201 {
 202 }
 203
 204 /**
 205  * vmw_ldu_crtc_atomic_enable - Noop
 206  *
 207  * @crtc: CRTC associated with the new screen
 208  *
 209  * This is called after a mode set has been completed.  Here's
 210  * usually a good place to call vmw_ldu_add_active/vmw_ldu_del_active
 211  * but since for LDU the display plane is closely tied to the
 212  * CRTC, it makes more sense to do those at plane update time.
 213  */
 214 static void vmw_ldu_crtc_atomic_enable(struct drm_crtc *crtc,
 215                                        struct drm_crtc_state *old_state)
 216 {
 217 }
 218
 219 /**
 220  * vmw_ldu_crtc_atomic_disable - Turns off CRTC
 221  *
 222  * @crtc: CRTC to be turned off
 223  */
 224 static void vmw_ldu_crtc_atomic_disable(struct drm_crtc *crtc,
 225                                         struct drm_crtc_state *old_state)
 226 {
 227 }
 228
 229 static const struct drm_crtc_funcs vmw_legacy_crtc_funcs = {
 230         .gamma_set = vmw_du_crtc_gamma_set,
 231         .destroy = vmw_ldu_crtc_destroy,
 232         .reset = vmw_du_crtc_reset,
 233         .atomic_duplicate_state = vmw_du_crtc_duplicate_state,
 234         .atomic_destroy_state = vmw_du_crtc_destroy_state,
 235         .set_config = vmw_kms_set_config,
 236 };
 237
 238
 239 /*
 240  * Legacy Display Unit encoder functions
 241  */
 242
 243 static void vmw_ldu_encoder_destroy(struct drm_encoder *encoder)
 244 {
 245         vmw_ldu_destroy(vmw_encoder_to_ldu(encoder));
 246 }
 247
 248 static const struct drm_encoder_funcs vmw_legacy_encoder_funcs = {
 249         .destroy = vmw_ldu_encoder_destroy,
 250 };
 251
 252 /*
 253  * Legacy Display Unit connector functions
 254  */
 255
 256 static void vmw_ldu_connector_destroy(struct drm_connector *connector)
 257 {
 258         vmw_ldu_destroy(vmw_connector_to_ldu(connector));
 259 }
 260
 261 static const struct drm_connector_funcs vmw_legacy_connector_funcs = {
 262         .dpms = vmw_du_connector_dpms,
 263         .detect = vmw_du_connector_detect,
 264         .fill_modes = vmw_du_connector_fill_modes,
 265         .set_property = vmw_du_connector_set_property,
 266         .destroy = vmw_ldu_connector_destroy,
 267         .reset = vmw_du_connector_reset,
 268         .atomic_duplicate_state = vmw_du_connector_duplicate_state,
 269         .atomic_destroy_state = vmw_du_connector_destroy_state,
 270         .atomic_set_property = vmw_du_connector_atomic_set_property,
 271         .atomic_get_property = vmw_du_connector_atomic_get_property,
 272 };
 273
 274 static const struct
 275 drm_connector_helper_funcs vmw_ldu_connector_helper_funcs = {
 276         .best_encoder = drm_atomic_helper_best_encoder,
 277 };
 278
 279 /*
 280  * Legacy Display Plane Functions
 281  */
 282
 283 /**
 284  * vmw_ldu_primary_plane_cleanup_fb - Noop
 285  *
 286  * @plane:  display plane
 287  * @old_state: Contains the FB to clean up
 288  *
 289  * Unpins the display surface
 290  *
 291  * Returns 0 on success
 292  */
 293 static void
 294 vmw_ldu_primary_plane_cleanup_fb(struct drm_plane *plane,
 295                                  struct drm_plane_state *old_state)
 296 {
 297 }
 298
 299
 300 /**
 301  * vmw_ldu_primary_plane_prepare_fb - Noop
 302  *
 303  * @plane:  display plane
 304  * @new_state: info on the new plane state, including the FB
 305  *
 306  * Returns 0 on success
 307  */
 308 static int
 309 vmw_ldu_primary_plane_prepare_fb(struct drm_plane *plane,
 310                                  struct drm_plane_state *new_state)
 311 {
 312         return 0;
 313 }
 314
 315
 316 static void
 317 vmw_ldu_primary_plane_atomic_update(struct drm_plane *plane,
 318                                     struct drm_plane_state *old_state)
 319 {
 320         struct vmw_private *dev_priv;
 321         struct vmw_legacy_display_unit *ldu;
 322         struct vmw_framebuffer *vfb;
 323         struct drm_framebuffer *fb;
 324         struct drm_crtc *crtc = plane->state->crtc ?: old_state->crtc;
 325
 326
 327         ldu = vmw_crtc_to_ldu(crtc);
 328         dev_priv = vmw_priv(plane->dev);
 329         fb       = plane->state->fb;
 330
 331         vfb = (fb) ? vmw_framebuffer_to_vfb(fb) : NULL;
 332
 333         if (vfb)
 334                 vmw_ldu_add_active(dev_priv, ldu, vfb);
 335         else
 336                 vmw_ldu_del_active(dev_priv, ldu);
 337
 338         vmw_ldu_commit_list(dev_priv);
 339 }
 340
 341
 342 static const struct drm_plane_funcs vmw_ldu_plane_funcs = {
 343         .update_plane = drm_atomic_helper_update_plane,
 344         .disable_plane = drm_atomic_helper_disable_plane,
 345         .destroy = vmw_du_primary_plane_destroy,
 346         .reset = vmw_du_plane_reset,
 347         .atomic_duplicate_state = vmw_du_plane_duplicate_state,
 348         .atomic_destroy_state = vmw_du_plane_destroy_state,
 349 };
 350
 351 static const struct drm_plane_funcs vmw_ldu_cursor_funcs = {
 352         .update_plane = drm_atomic_helper_update_plane,
 353         .disable_plane = drm_atomic_helper_disable_plane,
 354         .destroy = vmw_du_cursor_plane_destroy,
 355         .reset = vmw_du_plane_reset,
 356         .atomic_duplicate_state = vmw_du_plane_duplicate_state,
 357         .atomic_destroy_state = vmw_du_plane_destroy_state,
 358 };
 359
 360 /*
 361  * Atomic Helpers
 362  */
 363 static const struct
 364 drm_plane_helper_funcs vmw_ldu_cursor_plane_helper_funcs = {
 365         .atomic_check = vmw_du_cursor_plane_atomic_check,
 366         .atomic_update = vmw_du_cursor_plane_atomic_update,
 367         .prepare_fb = vmw_du_cursor_plane_prepare_fb,
 368         .cleanup_fb = vmw_du_plane_cleanup_fb,
 369 };
 370
 371 static const struct
 372 drm_plane_helper_funcs vmw_ldu_primary_plane_helper_funcs = {
 373         .atomic_check = vmw_du_primary_plane_atomic_check,
 374         .atomic_update = vmw_ldu_primary_plane_atomic_update,
 375         .prepare_fb = vmw_ldu_primary_plane_prepare_fb,
 376         .cleanup_fb = vmw_ldu_primary_plane_cleanup_fb,
 377 };
 378
 379 static const struct drm_crtc_helper_funcs vmw_ldu_crtc_helper_funcs = {
 380         .mode_set_nofb = vmw_ldu_crtc_mode_set_nofb,
 381         .atomic_check = vmw_du_crtc_atomic_check,
 382         .atomic_begin = vmw_du_crtc_atomic_begin,
 383         .atomic_flush = vmw_du_crtc_atomic_flush,
 384         .atomic_enable = vmw_ldu_crtc_atomic_enable,
 385         .atomic_disable = vmw_ldu_crtc_atomic_disable,
 386 };
 387
 388
 389 static int vmw_ldu_init(struct vmw_private *dev_priv, unsigned unit)
 390 {
 391         struct vmw_legacy_display_unit *ldu;
 392         struct drm_device *dev = dev_priv->dev;
 393         struct drm_connector *connector;
 394         struct drm_encoder *encoder;
 395         struct drm_plane *primary, *cursor;
 396         struct drm_crtc *crtc;
 397         int ret;
 398
 399         ldu = kzalloc(sizeof(*ldu), GFP_KERNEL);
 400         if (!ldu)
 401                 return -ENOMEM;
 402
 403         ldu->base.unit = unit;
 404         crtc = &ldu->base.crtc;
 405         encoder = &ldu->base.encoder;
 406         connector = &ldu->base.connector;
 407         primary = &ldu->base.primary;
 408         cursor = &ldu->base.cursor;
 409
 410         INIT_LIST_HEAD(&ldu->active);
 411
 412         ldu->base.pref_active = (unit == 0);
 413         ldu->base.pref_width = dev_priv->initial_width;
 414         ldu->base.pref_height = dev_priv->initial_height;
 415         ldu->base.pref_mode = NULL;
 416
 417         /*
 418          * Remove this after enabling atomic because property values can
 419          * only exist in a state object
 420          */
 421         ldu->base.is_implicit = true;
 422
 423         /* Initialize primary plane */
 424         vmw_du_plane_reset(primary);
 425
 426         ret = drm_universal_plane_init(dev, &ldu->base.primary,
 427                                        0, &vmw_ldu_plane_funcs,
 428                                        vmw_primary_plane_formats,
 429                                        ARRAY_SIZE(vmw_primary_plane_formats),
 430                                        NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
 431         if (ret) {
 432                 DRM_ERROR("Failed to initialize primary plane");
 433                 goto err_free;
 434         }
 435
 436         drm_plane_helper_add(primary, &vmw_ldu_primary_plane_helper_funcs);
 437
 438         /* Initialize cursor plane */
 439         vmw_du_plane_reset(cursor);
 440
 441         ret = drm_universal_plane_init(dev, &ldu->base.cursor,
 442                         0, &vmw_ldu_cursor_funcs,
 443                         vmw_cursor_plane_formats,
 444                         ARRAY_SIZE(vmw_cursor_plane_formats),
 445                         NULL, DRM_PLANE_TYPE_CURSOR, NULL);
 446         if (ret) {
 447                 DRM_ERROR("Failed to initialize cursor plane");
 448                 drm_plane_cleanup(&ldu->base.primary);
 449                 goto err_free;
 450         }
 451
 452         drm_plane_helper_add(cursor, &vmw_ldu_cursor_plane_helper_funcs);
 453
 454
 455         vmw_du_connector_reset(connector);
 456         ret = drm_connector_init(dev, connector, &vmw_legacy_connector_funcs,
 457                                  DRM_MODE_CONNECTOR_VIRTUAL);
 458         if (ret) {
 459                 DRM_ERROR("Failed to initialize connector\n");
 460                 goto err_free;
 461         }
 462
 463         drm_connector_helper_add(connector, &vmw_ldu_connector_helper_funcs);
 464         connector->status = vmw_du_connector_detect(connector, true);
 465         vmw_connector_state_to_vcs(connector->state)->is_implicit = true;
 466
 467
 468         ret = drm_encoder_init(dev, encoder, &vmw_legacy_encoder_funcs,
 469                                DRM_MODE_ENCODER_VIRTUAL, NULL);
 470         if (ret) {
 471                 DRM_ERROR("Failed to initialize encoder\n");
 472                 goto err_free_connector;
 473         }
 474
 475         (void) drm_mode_connector_attach_encoder(connector, encoder);
 476         encoder->possible_crtcs = (1 << unit);
 477         encoder->possible_clones = 0;
 478
 479         ret = drm_connector_register(connector);
 480         if (ret) {
 481                 DRM_ERROR("Failed to register connector\n");
 482                 goto err_free_encoder;
 483         }
 484
 485
 486         vmw_du_crtc_reset(crtc);
 487         ret = drm_crtc_init_with_planes(dev, crtc, &ldu->base.primary,
 488                                         &ldu->base.cursor,
 489                                         &vmw_legacy_crtc_funcs, NULL);
 490         if (ret) {
 491                 DRM_ERROR("Failed to initialize CRTC\n");
 492                 goto err_free_unregister;
 493         }
 494
 495         drm_crtc_helper_add(crtc, &vmw_ldu_crtc_helper_funcs);
 496
 497         drm_mode_crtc_set_gamma_size(crtc, 256);
 498
 499         drm_object_attach_property(&connector->base,
 500                                    dev_priv->hotplug_mode_update_property, 1);
 501         drm_object_attach_property(&connector->base,
 502                                    dev->mode_config.suggested_x_property, 0);
 503         drm_object_attach_property(&connector->base,
 504                                    dev->mode_config.suggested_y_property, 0);
 505         if (dev_priv->implicit_placement_property)
 506                 drm_object_attach_property
 507                         (&connector->base,
 508                          dev_priv->implicit_placement_property,
 509                          1);
 510
 511         return 0;
 512
 513 err_free_unregister:
 514         drm_connector_unregister(connector);
 515 err_free_encoder:
 516         drm_encoder_cleanup(encoder);
 517 err_free_connector:
 518         drm_connector_cleanup(connector);
 519 err_free:
 520         kfree(ldu);
 521         return ret;
 522 }
 523
 524 int vmw_kms_ldu_init_display(struct vmw_private *dev_priv)
 525 {
 526         struct drm_device *dev = dev_priv->dev;
 527         int i, ret;
 528
 529         if (dev_priv->ldu_priv) {
 530                 DRM_INFO("ldu system already on\n");
 531                 return -EINVAL;
 532         }
 533
 534         dev_priv->ldu_priv = kmalloc(sizeof(*dev_priv->ldu_priv), GFP_KERNEL);
 535         if (!dev_priv->ldu_priv)
 536                 return -ENOMEM;
 537
 538         INIT_LIST_HEAD(&dev_priv->ldu_priv->active);
 539         dev_priv->ldu_priv->num_active = 0;
 540         dev_priv->ldu_priv->last_num_active = 0;
 541         dev_priv->ldu_priv->fb = NULL;
 542
 543         /* for old hardware without multimon only enable one display */
 544         if (dev_priv->capabilities & SVGA_CAP_MULTIMON)
 545                 ret = drm_vblank_init(dev, VMWGFX_NUM_DISPLAY_UNITS);
 546         else
 547                 ret = drm_vblank_init(dev, 1);
 548         if (ret != 0)
 549                 goto err_free;
 550
 551         vmw_kms_create_implicit_placement_property(dev_priv, true);
 552
 553         if (dev_priv->capabilities & SVGA_CAP_MULTIMON)
 554                 for (i = 0; i < VMWGFX_NUM_DISPLAY_UNITS; ++i)
 555                         vmw_ldu_init(dev_priv, i);
 556         else
 557                 vmw_ldu_init(dev_priv, 0);
 558
 559         dev_priv->active_display_unit = vmw_du_legacy;
 560
 561         DRM_INFO("Legacy Display Unit initialized\n");
 562
 563         return 0;
 564
 565 err_free:
 566         kfree(dev_priv->ldu_priv);
 567         dev_priv->ldu_priv = NULL;
 568         return ret;
 569 }
 570
 571 int vmw_kms_ldu_close_display(struct vmw_private *dev_priv)
 572 {
 573         if (!dev_priv->ldu_priv)
 574                 return -ENOSYS;
 575
 576         BUG_ON(!list_empty(&dev_priv->ldu_priv->active));
 577
 578         kfree(dev_priv->ldu_priv);
 579
 580         return 0;
 581 }
 582
 583
 584 int vmw_kms_ldu_do_dmabuf_dirty(struct vmw_private *dev_priv,
 585                                 struct vmw_framebuffer *framebuffer,
 586                                 unsigned flags, unsigned color,
 587                                 struct drm_clip_rect *clips,
 588                                 unsigned num_clips, int increment)
 589 {
 590         size_t fifo_size;
 591         int i;
 592
 593         struct {
 594                 uint32_t header;
 595                 SVGAFifoCmdUpdate body;
 596         } *cmd;
 597
 598         fifo_size = sizeof(*cmd) * num_clips;
 599         cmd = vmw_fifo_reserve(dev_priv, fifo_size);
 600         if (unlikely(cmd == NULL)) {
 601                 DRM_ERROR("Fifo reserve failed.\n");
 602                 return -ENOMEM;
 603         }
 604
 605         memset(cmd, 0, fifo_size);
 606         for (i = 0; i < num_clips; i++, clips += increment) {
 607                 cmd[i].header = SVGA_CMD_UPDATE;
 608                 cmd[i].body.x = clips->x1;
 609                 cmd[i].body.y = clips->y1;
 610                 cmd[i].body.width = clips->x2 - clips->x1;
 611                 cmd[i].body.height = clips->y2 - clips->y1;
 612         }
 613
 614         vmw_fifo_commit(dev_priv, fifo_size);
 615         return 0;
 616 }