drivers/gpu/drm/i915/intel_dp_mst.c

   1 /*
   2  * Copyright © 2008 Intel Corporation
   3  *             2014 Red Hat Inc.
   4  *
   5  * Permission is hereby granted, free of charge, to any person obtaining a
   6  * copy of this software and associated documentation files (the "Software"),
   7  * to deal in the Software without restriction, including without limitation
   8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   9  * and/or sell copies of the Software, and to permit persons to whom the
  10  * Software is furnished to do so, subject to the following conditions:
  11  *
  12  * The above copyright notice and this permission notice (including the next
  13  * paragraph) shall be included in all copies or substantial portions of the
  14  * Software.
  15  *
  16  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  17  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  18  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  19  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  20  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  21  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  22  * IN THE SOFTWARE.
  23  *
  24  */
  25
  26 #include <drm/drmP.h>
  27 #include "i915_drv.h"
  28 #include "intel_drv.h"
  29 #include <drm/drm_atomic_helper.h>
  30 #include <drm/drm_crtc_helper.h>
  31 #include <drm/drm_edid.h>
  32
  33 static bool intel_dp_mst_compute_config(struct intel_encoder *encoder,
  34                                         struct intel_crtc_state *pipe_config,
  35                                         struct drm_connector_state *conn_state)
  36 {
  37         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
  38         struct intel_digital_port *intel_dig_port = intel_mst->primary;
  39         struct intel_dp *intel_dp = &intel_dig_port->dp;
  40         struct drm_atomic_state *state;
  41         int bpp;
  42         int lane_count, slots;
  43         const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
  44         int mst_pbn;
  45
  46         pipe_config->dp_encoder_is_mst = true;
  47         pipe_config->has_pch_encoder = false;
  48         bpp = 24;
  49         /*
  50          * for MST we always configure max link bw - the spec doesn't
  51          * seem to suggest we should do otherwise.
  52          */
  53         lane_count = drm_dp_max_lane_count(intel_dp->dpcd);
  54
  55         pipe_config->lane_count = lane_count;
  56
  57         pipe_config->pipe_bpp = 24;
  58         pipe_config->port_clock = intel_dp_max_link_rate(intel_dp);
  59
  60         state = pipe_config->base.state;
  61
  62         mst_pbn = drm_dp_calc_pbn_mode(adjusted_mode->crtc_clock, bpp);
  63
  64         pipe_config->pbn = mst_pbn;
  65         slots = drm_dp_find_vcpi_slots(&intel_dp->mst_mgr, mst_pbn);
  66
  67         intel_link_compute_m_n(bpp, lane_count,
  68                                adjusted_mode->crtc_clock,
  69                                pipe_config->port_clock,
  70                                &pipe_config->dp_m_n);
  71
  72         pipe_config->dp_m_n.tu = slots;
  73
  74         return true;
  75
  76 }
  77
  78 static void intel_mst_disable_dp(struct intel_encoder *encoder,
  79                                  struct intel_crtc_state *old_crtc_state,
  80                                  struct drm_connector_state *old_conn_state)
  81 {
  82         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
  83         struct intel_digital_port *intel_dig_port = intel_mst->primary;
  84         struct intel_dp *intel_dp = &intel_dig_port->dp;
  85         struct intel_connector *connector =
  86                 to_intel_connector(old_conn_state->connector);
  87         int ret;
  88
  89         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
  90
  91         drm_dp_mst_reset_vcpi_slots(&intel_dp->mst_mgr, connector->port);
  92
  93         ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
  94         if (ret) {
  95                 DRM_ERROR("failed to update payload %d\n", ret);
  96         }
  97 }
  98
  99 static void intel_mst_post_disable_dp(struct intel_encoder *encoder,
 100                                       struct intel_crtc_state *old_crtc_state,
 101                                       struct drm_connector_state *old_conn_state)
 102 {
 103         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 104         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 105         struct intel_dp *intel_dp = &intel_dig_port->dp;
 106         struct intel_connector *connector =
 107                 to_intel_connector(old_conn_state->connector);
 108
 109         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
 110
 111         /* this can fail */
 112         drm_dp_check_act_status(&intel_dp->mst_mgr);
 113         /* and this can also fail */
 114         drm_dp_update_payload_part2(&intel_dp->mst_mgr);
 115
 116         drm_dp_mst_deallocate_vcpi(&intel_dp->mst_mgr, connector->port);
 117
 118         intel_dp->active_mst_links--;
 119
 120         intel_mst->connector = NULL;
 121         if (intel_dp->active_mst_links == 0) {
 122                 intel_dig_port->base.post_disable(&intel_dig_port->base,
 123                                                   NULL, NULL);
 124
 125                 intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
 126         }
 127 }
 128
 129 static void intel_mst_pre_enable_dp(struct intel_encoder *encoder,
 130                                     struct intel_crtc_state *pipe_config,
 131                                     struct drm_connector_state *conn_state)
 132 {
 133         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 134         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 135         struct intel_dp *intel_dp = &intel_dig_port->dp;
 136         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 137         enum port port = intel_dig_port->port;
 138         struct intel_connector *connector =
 139                 to_intel_connector(conn_state->connector);
 140         int ret;
 141         uint32_t temp;
 142         int slots;
 143
 144         /* MST encoders are bound to a crtc, not to a connector,
 145          * force the mapping here for get_hw_state.
 146          */
 147         connector->encoder = encoder;
 148         intel_mst->connector = connector;
 149
 150         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
 151
 152         if (intel_dp->active_mst_links == 0) {
 153                 intel_ddi_clk_select(&intel_dig_port->base,
 154                                      pipe_config->shared_dpll);
 155
 156                 intel_prepare_dp_ddi_buffers(&intel_dig_port->base);
 157                 intel_dp_set_link_params(intel_dp,
 158                                          pipe_config->port_clock,
 159                                          pipe_config->lane_count,
 160                                          true);
 161
 162                 intel_ddi_init_dp_buf_reg(&intel_dig_port->base);
 163
 164                 intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON);
 165
 166                 intel_dp_start_link_train(intel_dp);
 167                 intel_dp_stop_link_train(intel_dp);
 168         }
 169
 170         ret = drm_dp_mst_allocate_vcpi(&intel_dp->mst_mgr,
 171                                        connector->port,
 172                                        pipe_config->pbn, &slots);
 173         if (ret == false) {
 174                 DRM_ERROR("failed to allocate vcpi\n");
 175                 return;
 176         }
 177
 178
 179         intel_dp->active_mst_links++;
 180         temp = I915_READ(DP_TP_STATUS(port));
 181         I915_WRITE(DP_TP_STATUS(port), temp);
 182
 183         ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
 184 }
 185
 186 static void intel_mst_enable_dp(struct intel_encoder *encoder,
 187                                 struct intel_crtc_state *pipe_config,
 188                                 struct drm_connector_state *conn_state)
 189 {
 190         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 191         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 192         struct intel_dp *intel_dp = &intel_dig_port->dp;
 193         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 194         enum port port = intel_dig_port->port;
 195         int ret;
 196
 197         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
 198
 199         if (intel_wait_for_register(dev_priv,
 200                                     DP_TP_STATUS(port),
 201                                     DP_TP_STATUS_ACT_SENT,
 202                                     DP_TP_STATUS_ACT_SENT,
 203                                     1))
 204                 DRM_ERROR("Timed out waiting for ACT sent\n");
 205
 206         ret = drm_dp_check_act_status(&intel_dp->mst_mgr);
 207
 208         ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr);
 209 }
 210
 211 static bool intel_dp_mst_enc_get_hw_state(struct intel_encoder *encoder,
 212                                       enum pipe *pipe)
 213 {
 214         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 215         *pipe = intel_mst->pipe;
 216         if (intel_mst->connector)
 217                 return true;
 218         return false;
 219 }
 220
 221 static void intel_dp_mst_enc_get_config(struct intel_encoder *encoder,
 222                                         struct intel_crtc_state *pipe_config)
 223 {
 224         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 225         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 226         struct intel_crtc *crtc = to_intel_crtc(pipe_config->base.crtc);
 227         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 228         enum transcoder cpu_transcoder = pipe_config->cpu_transcoder;
 229         u32 temp, flags = 0;
 230
 231         temp = I915_READ(TRANS_DDI_FUNC_CTL(cpu_transcoder));
 232         if (temp & TRANS_DDI_PHSYNC)
 233                 flags |= DRM_MODE_FLAG_PHSYNC;
 234         else
 235                 flags |= DRM_MODE_FLAG_NHSYNC;
 236         if (temp & TRANS_DDI_PVSYNC)
 237                 flags |= DRM_MODE_FLAG_PVSYNC;
 238         else
 239                 flags |= DRM_MODE_FLAG_NVSYNC;
 240
 241         switch (temp & TRANS_DDI_BPC_MASK) {
 242         case TRANS_DDI_BPC_6:
 243                 pipe_config->pipe_bpp = 18;
 244                 break;
 245         case TRANS_DDI_BPC_8:
 246                 pipe_config->pipe_bpp = 24;
 247                 break;
 248         case TRANS_DDI_BPC_10:
 249                 pipe_config->pipe_bpp = 30;
 250                 break;
 251         case TRANS_DDI_BPC_12:
 252                 pipe_config->pipe_bpp = 36;
 253                 break;
 254         default:
 255                 break;
 256         }
 257         pipe_config->base.adjusted_mode.flags |= flags;
 258
 259         pipe_config->lane_count =
 260                 ((temp & DDI_PORT_WIDTH_MASK) >> DDI_PORT_WIDTH_SHIFT) + 1;
 261
 262         intel_dp_get_m_n(crtc, pipe_config);
 263
 264         intel_ddi_clock_get(&intel_dig_port->base, pipe_config);
 265 }
 266
 267 static int intel_dp_mst_get_ddc_modes(struct drm_connector *connector)
 268 {
 269         struct intel_connector *intel_connector = to_intel_connector(connector);
 270         struct intel_dp *intel_dp = intel_connector->mst_port;
 271         struct edid *edid;
 272         int ret;
 273
 274         if (!intel_dp) {
 275                 return intel_connector_update_modes(connector, NULL);
 276         }
 277
 278         edid = drm_dp_mst_get_edid(connector, &intel_dp->mst_mgr, intel_connector->port);
 279         ret = intel_connector_update_modes(connector, edid);
 280         kfree(edid);
 281
 282         return ret;
 283 }
 284
 285 static enum drm_connector_status
 286 intel_dp_mst_detect(struct drm_connector *connector, bool force)
 287 {
 288         struct intel_connector *intel_connector = to_intel_connector(connector);
 289         struct intel_dp *intel_dp = intel_connector->mst_port;
 290
 291         if (!intel_dp)
 292                 return connector_status_disconnected;
 293         return drm_dp_mst_detect_port(connector, &intel_dp->mst_mgr, intel_connector->port);
 294 }
 295
 296 static int
 297 intel_dp_mst_set_property(struct drm_connector *connector,
 298                           struct drm_property *property,
 299                           uint64_t val)
 300 {
 301         return 0;
 302 }
 303
 304 static void
 305 intel_dp_mst_connector_destroy(struct drm_connector *connector)
 306 {
 307         struct intel_connector *intel_connector = to_intel_connector(connector);
 308
 309         if (!IS_ERR_OR_NULL(intel_connector->edid))
 310                 kfree(intel_connector->edid);
 311
 312         drm_connector_cleanup(connector);
 313         kfree(connector);
 314 }
 315
 316 static const struct drm_connector_funcs intel_dp_mst_connector_funcs = {
 317         .dpms = drm_atomic_helper_connector_dpms,
 318         .detect = intel_dp_mst_detect,
 319         .fill_modes = drm_helper_probe_single_connector_modes,
 320         .set_property = intel_dp_mst_set_property,
 321         .atomic_get_property = intel_connector_atomic_get_property,
 322         .late_register = intel_connector_register,
 323         .early_unregister = intel_connector_unregister,
 324         .destroy = intel_dp_mst_connector_destroy,
 325         .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
 326         .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
 327 };
 328
 329 static int intel_dp_mst_get_modes(struct drm_connector *connector)
 330 {
 331         return intel_dp_mst_get_ddc_modes(connector);
 332 }
 333
 334 static enum drm_mode_status
 335 intel_dp_mst_mode_valid(struct drm_connector *connector,
 336                         struct drm_display_mode *mode)
 337 {
 338         int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
 339
 340         /* TODO - validate mode against available PBN for link */
 341         if (mode->clock < 10000)
 342                 return MODE_CLOCK_LOW;
 343
 344         if (mode->flags & DRM_MODE_FLAG_DBLCLK)
 345                 return MODE_H_ILLEGAL;
 346
 347         if (mode->clock > max_dotclk)
 348                 return MODE_CLOCK_HIGH;
 349
 350         return MODE_OK;
 351 }
 352
 353 static struct drm_encoder *intel_mst_atomic_best_encoder(struct drm_connector *connector,
 354                                                          struct drm_connector_state *state)
 355 {
 356         struct intel_connector *intel_connector = to_intel_connector(connector);
 357         struct intel_dp *intel_dp = intel_connector->mst_port;
 358         struct intel_crtc *crtc = to_intel_crtc(state->crtc);
 359
 360         if (!intel_dp)
 361                 return NULL;
 362         return &intel_dp->mst_encoders[crtc->pipe]->base.base;
 363 }
 364
 365 static struct drm_encoder *intel_mst_best_encoder(struct drm_connector *connector)
 366 {
 367         struct intel_connector *intel_connector = to_intel_connector(connector);
 368         struct intel_dp *intel_dp = intel_connector->mst_port;
 369         if (!intel_dp)
 370                 return NULL;
 371         return &intel_dp->mst_encoders[0]->base.base;
 372 }
 373
 374 static const struct drm_connector_helper_funcs intel_dp_mst_connector_helper_funcs = {
 375         .get_modes = intel_dp_mst_get_modes,
 376         .mode_valid = intel_dp_mst_mode_valid,
 377         .atomic_best_encoder = intel_mst_atomic_best_encoder,
 378         .best_encoder = intel_mst_best_encoder,
 379 };
 380
 381 static void intel_dp_mst_encoder_destroy(struct drm_encoder *encoder)
 382 {
 383         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(encoder);
 384
 385         drm_encoder_cleanup(encoder);
 386         kfree(intel_mst);
 387 }
 388
 389 static const struct drm_encoder_funcs intel_dp_mst_enc_funcs = {
 390         .destroy = intel_dp_mst_encoder_destroy,
 391 };
 392
 393 static bool intel_dp_mst_get_hw_state(struct intel_connector *connector)
 394 {
 395         if (connector->encoder && connector->base.state->crtc) {
 396                 enum pipe pipe;
 397                 if (!connector->encoder->get_hw_state(connector->encoder, &pipe))
 398                         return false;
 399                 return true;
 400         }
 401         return false;
 402 }
 403
 404 static void intel_connector_add_to_fbdev(struct intel_connector *connector)
 405 {
 406 #ifdef CONFIG_DRM_FBDEV_EMULATION
 407         struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 408
 409         if (dev_priv->fbdev)
 410                 drm_fb_helper_add_one_connector(&dev_priv->fbdev->helper,
 411                                                 &connector->base);
 412 #endif
 413 }
 414
 415 static void intel_connector_remove_from_fbdev(struct intel_connector *connector)
 416 {
 417 #ifdef CONFIG_DRM_FBDEV_EMULATION
 418         struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 419
 420         if (dev_priv->fbdev)
 421                 drm_fb_helper_remove_one_connector(&dev_priv->fbdev->helper,
 422                                                    &connector->base);
 423 #endif
 424 }
 425
 426 static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, const char *pathprop)
 427 {
 428         struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
 429         struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
 430         struct drm_device *dev = intel_dig_port->base.base.dev;
 431         struct intel_connector *intel_connector;
 432         struct drm_connector *connector;
 433         int i;
 434
 435         intel_connector = intel_connector_alloc();
 436         if (!intel_connector)
 437                 return NULL;
 438
 439         connector = &intel_connector->base;
 440         drm_connector_init(dev, connector, &intel_dp_mst_connector_funcs, DRM_MODE_CONNECTOR_DisplayPort);
 441         drm_connector_helper_add(connector, &intel_dp_mst_connector_helper_funcs);
 442
 443         intel_connector->get_hw_state = intel_dp_mst_get_hw_state;
 444         intel_connector->mst_port = intel_dp;
 445         intel_connector->port = port;
 446
 447         for (i = PIPE_A; i <= PIPE_C; i++) {
 448                 drm_mode_connector_attach_encoder(&intel_connector->base,
 449                                                   &intel_dp->mst_encoders[i]->base.base);
 450         }
 451         intel_dp_add_properties(intel_dp, connector);
 452
 453         drm_object_attach_property(&connector->base, dev->mode_config.path_property, 0);
 454         drm_object_attach_property(&connector->base, dev->mode_config.tile_property, 0);
 455
 456         drm_mode_connector_set_path_property(connector, pathprop);
 457         return connector;
 458 }
 459
 460 static void intel_dp_register_mst_connector(struct drm_connector *connector)
 461 {
 462         struct intel_connector *intel_connector = to_intel_connector(connector);
 463         struct drm_device *dev = connector->dev;
 464
 465         drm_modeset_lock_all(dev);
 466         intel_connector_add_to_fbdev(intel_connector);
 467         drm_modeset_unlock_all(dev);
 468
 469         drm_connector_register(&intel_connector->base);
 470 }
 471
 472 static void intel_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
 473                                            struct drm_connector *connector)
 474 {
 475         struct intel_connector *intel_connector = to_intel_connector(connector);
 476         struct drm_device *dev = connector->dev;
 477
 478         drm_connector_unregister(connector);
 479
 480         /* need to nuke the connector */
 481         drm_modeset_lock_all(dev);
 482         intel_connector_remove_from_fbdev(intel_connector);
 483         intel_connector->mst_port = NULL;
 484         drm_modeset_unlock_all(dev);
 485
 486         drm_connector_unreference(&intel_connector->base);
 487         DRM_DEBUG_KMS("\n");
 488 }
 489
 490 static void intel_dp_mst_hotplug(struct drm_dp_mst_topology_mgr *mgr)
 491 {
 492         struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
 493         struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
 494         struct drm_device *dev = intel_dig_port->base.base.dev;
 495
 496         drm_kms_helper_hotplug_event(dev);
 497 }
 498
 499 static const struct drm_dp_mst_topology_cbs mst_cbs = {
 500         .add_connector = intel_dp_add_mst_connector,
 501         .register_connector = intel_dp_register_mst_connector,
 502         .destroy_connector = intel_dp_destroy_mst_connector,
 503         .hotplug = intel_dp_mst_hotplug,
 504 };
 505
 506 static struct intel_dp_mst_encoder *
 507 intel_dp_create_fake_mst_encoder(struct intel_digital_port *intel_dig_port, enum pipe pipe)
 508 {
 509         struct intel_dp_mst_encoder *intel_mst;
 510         struct intel_encoder *intel_encoder;
 511         struct drm_device *dev = intel_dig_port->base.base.dev;
 512
 513         intel_mst = kzalloc(sizeof(*intel_mst), GFP_KERNEL);
 514
 515         if (!intel_mst)
 516                 return NULL;
 517
 518         intel_mst->pipe = pipe;
 519         intel_encoder = &intel_mst->base;
 520         intel_mst->primary = intel_dig_port;
 521
 522         drm_encoder_init(dev, &intel_encoder->base, &intel_dp_mst_enc_funcs,
 523                          DRM_MODE_ENCODER_DPMST, "DP-MST %c", pipe_name(pipe));
 524
 525         intel_encoder->type = INTEL_OUTPUT_DP_MST;
 526         intel_encoder->crtc_mask = 0x7;
 527         intel_encoder->cloneable = 0;
 528
 529         intel_encoder->compute_config = intel_dp_mst_compute_config;
 530         intel_encoder->disable = intel_mst_disable_dp;
 531         intel_encoder->post_disable = intel_mst_post_disable_dp;
 532         intel_encoder->pre_enable = intel_mst_pre_enable_dp;
 533         intel_encoder->enable = intel_mst_enable_dp;
 534         intel_encoder->get_hw_state = intel_dp_mst_enc_get_hw_state;
 535         intel_encoder->get_config = intel_dp_mst_enc_get_config;
 536
 537         return intel_mst;
 538
 539 }
 540
 541 static bool
 542 intel_dp_create_fake_mst_encoders(struct intel_digital_port *intel_dig_port)
 543 {
 544         int i;
 545         struct intel_dp *intel_dp = &intel_dig_port->dp;
 546
 547         for (i = PIPE_A; i <= PIPE_C; i++)
 548                 intel_dp->mst_encoders[i] = intel_dp_create_fake_mst_encoder(intel_dig_port, i);
 549         return true;
 550 }
 551
 552 int
 553 intel_dp_mst_encoder_init(struct intel_digital_port *intel_dig_port, int conn_base_id)
 554 {
 555         struct intel_dp *intel_dp = &intel_dig_port->dp;
 556         struct drm_device *dev = intel_dig_port->base.base.dev;
 557         int ret;
 558
 559         intel_dp->can_mst = true;
 560         intel_dp->mst_mgr.cbs = &mst_cbs;
 561
 562         /* create encoders */
 563         intel_dp_create_fake_mst_encoders(intel_dig_port);
 564         ret = drm_dp_mst_topology_mgr_init(&intel_dp->mst_mgr, dev->dev, &intel_dp->aux, 16, 3, conn_base_id);
 565         if (ret) {
 566                 intel_dp->can_mst = false;
 567                 return ret;
 568         }
 569         return 0;
 570 }
 571
 572 void
 573 intel_dp_mst_encoder_cleanup(struct intel_digital_port *intel_dig_port)
 574 {
 575         struct intel_dp *intel_dp = &intel_dig_port->dp;
 576
 577         if (!intel_dp->can_mst)
 578                 return;
 579
 580         drm_dp_mst_topology_mgr_destroy(&intel_dp->mst_mgr);
 581         /* encoders will get killed by normal cleanup */
 582 }