From e07cedf332029369f2ce09a6f6ced3dda0de2558 Mon Sep 17 00:00:00 2001 From: "Eric S. Raymond" Date: Tue, 13 Jun 2017 13:13:30 -0400 Subject: [PATCH] Documentation improvements. --- README.adoc | 4 ++++ tests/README | 31 +++++++++++++++++++++++++++---- tests/illformed.chk | 9 +++++++-- tests/illformed.log | 1 + 4 files changed, 39 insertions(+), 6 deletions(-) diff --git a/README.adoc b/README.adoc index e511d88..07d9ae8 100644 --- a/README.adoc +++ b/README.adoc @@ -21,6 +21,10 @@ care has been taken to not silently change gameplay. By policy, all user-visible changes from 2.5 are revertible with the -o (oldstyle) option. +If you encounter a bug (not likely; thuis code is old and well tested) +please try to make a test log that reproduces it, using the -l option, +and ship it to the maintainers. + // end diff --git a/tests/README b/tests/README index 9708155..5666e77 100644 --- a/tests/README +++ b/tests/README @@ -1,20 +1,43 @@ = Notes on the test machinery = -A .tst extension means it's a game log +== Understanding and running tests == + +A .log extension means it's a game log A .chk extension means it's expected output from a test -The test files are run in alphabetical order. This allows you to ensure certain tests are run in a particular order merely by giving them appropriate names, e.g.: test.1.log, test.2.log, test.3.log. This is useful for testing save and resume. +The test files are run in alphabetical order. This allows you to +ensure certain tests are run in a particular order merely by giving +them appropriate names, e.g.: test.1.log, test.2.log, test.3.log. This +is useful for testing save and resume. -In general, a file named foo.chk is the expected output from theb game log +In general, a file named foo.chk is the expected output from the game log foo.log. To add new tests, just drop log files in this directory. To see summary lines from all tests, 'make testlist'. The summary lines are those led with ##; you should have one such descriptive line at the -head of the file. +head of each file. To run the tests, "make regress". To remake the check files, "make buildregress". +== Composing tests == + +The simplest way to make a test is to simply play a game with the -l +option giving a log path. Commands will be captured to that log. + +To re-use a command sequence from an existing log, run advent -s and +paste it to the advent command log from the clipboard. If you don't +use -s to disable advanced ediiting, the code used for that will consume +the first line of the paste and discare the rest. This is almost +certainly not what you want. + +To see where we can use more tests, have a look at our test coverage +report: + +http://esr.gitlab.io/open-adventure/coverage/ + +Improvements in test coverage are always welcome. + // end diff --git a/tests/illformed.chk b/tests/illformed.chk index 279f06f..e633769 100644 --- a/tests/illformed.chk +++ b/tests/illformed.chk @@ -49,6 +49,11 @@ minerals, but is not unpleasant. It is extremely cold. I can only tell you what you see as you move about and manipulate things. I cannot tell you where remote things are. +> inven keys + +I can only tell you what you see as you move about and manipulate +things. I cannot tell you where remote things are. + > in You are inside a building, a well house for a large spring. @@ -238,7 +243,7 @@ Okay, "BOO". > score -You have garnered 32 out of a possible 430 points, using 46 turns. +You have garnered 32 out of a possible 430 points, using 47 turns. > quit @@ -248,7 +253,7 @@ Do you really want to quit now? OK -You scored 32 out of a possible 430, using 47 turns. +You scored 32 out of a possible 430, using 48 turns. You are obviously a rank amateur. Better luck next time. diff --git a/tests/illformed.log b/tests/illformed.log index ac0b209..76ce746 100644 --- a/tests/illformed.log +++ b/tests/illformed.log @@ -8,6 +8,7 @@ forward eat drink find keys +inven keys in listen keys -- 2.31.1