From 10e53a419e13c55cd7e0ad7752e93140a9bb50fe Mon Sep 17 00:00:00 2001 From: "Eric S. Raymond" Date: Mon, 19 Jun 2017 08:43:51 -0400 Subject: [PATCH] L12 is gone again. Magic numbers have been almost eliminated. --- notes.adoc | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/notes.adoc b/notes.adoc index 067ddf1..75c2333 100644 --- a/notes.adoc +++ b/notes.adoc @@ -117,10 +117,9 @@ ways: and the choice to refrain will make forward translation into future languages easier. -* There are a few gotos left that resist restructuring; all but of these - are in the principal command interpreter function implementing its - state machine. the remaining one is a truly mysterious artficat in - the player-movement code. +* There are a few gotos left that resist restructuring; all are in the + principal command interpreter function implementing its state + machine. * Linked lists (for objects at a location) are implemented using an array of link indices. This is a surviving FORTRANism that is quite unlike @@ -128,9 +127,6 @@ ways: to fix it because doing so would (a) be quite difficult, and (b) compromise forward-portability to other languages. -* The code still has an unfortunately high density of magic numbers - in - particular, numeric object IDs. There are plans to fix this. - * Much of the code still uses FORTRAN-style uppercase names. * The code still assumes one-origin array indexing. Thus, arrays are -- 2.31.1