open-adventure.git
5 years agoImprove INSTALL.adoc's directions and asciidoc-ness.
Jason Ninneman [Thu, 28 Feb 2019 01:06:39 +0000 (18:06 -0700)]
Improve INSTALL.adoc's directions and asciidoc-ness.

View it in the Gitlab web interface to see the intended result.

5 years agoRemove use of Unicode number sign in comments.
Eric S. Raymond [Thu, 28 Feb 2019 10:18:04 +0000 (05:18 -0500)]
Remove use of Unicode number sign in comments.

"#" for this use is well established in English.  It's not worth opening the
i18n can of worms here.

5 years agoDocument a user-visible change.
Eric S. Raymond [Thu, 28 Feb 2019 09:59:44 +0000 (04:59 -0500)]
Document a user-visible change.

5 years agoA few in-game message typos... 278/head
Horst H. von Brand [Tue, 11 Dec 2018 01:26:39 +0000 (22:26 -0300)]
A few in-game message typos...

Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl>
5 years agoAnother typo
Horst H. von Brand [Tue, 11 Dec 2018 01:09:22 +0000 (22:09 -0300)]
Another typo

Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl>
5 years agoA couple of "locaiton" in advent.h
Horst H. von Brand [Tue, 11 Dec 2018 00:38:27 +0000 (21:38 -0300)]
A couple of "locaiton" in advent.h

Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl>
5 years agoCommenting and cleanups 277/head
Aaron Traas [Mon, 10 Dec 2018 14:51:58 +0000 (09:51 -0500)]
Commenting and cleanups

5 years agoCorrect return types for all of the action handling functions in actions, so it's...
Aaron Traas [Fri, 7 Dec 2018 15:36:42 +0000 (10:36 -0500)]
Correct return types for all of the action handling functions in actions, so it's clear we're not just using arbitrary ints

5 years agoAbstracted a chuck of do_command() into seperate function do_move(), moved that call...
Aaron Traas [Fri, 7 Dec 2018 15:35:36 +0000 (10:35 -0500)]
Abstracted a chuck of do_command() into seperate function do_move(), moved that call to main loop, so as to narrow the focus of do_command() to getting and processing commands.

5 years agoFix warning on macOS
Aaron Traas [Thu, 6 Dec 2018 15:01:34 +0000 (10:01 -0500)]
Fix warning on macOS

5 years agoRefactored; added state property to command struct to notate where in the lifecycle... 276/head
Aaron Traas [Wed, 5 Dec 2018 14:40:09 +0000 (09:40 -0500)]
Refactored; added state property to command struct to notate where in the lifecycle of command processing that the command is.

5 years agoMajor cleanups. Pre-process loop back in main loop, pre-processing abstracted into... 275/head
Aaron Traas [Tue, 20 Nov 2018 16:21:54 +0000 (11:21 -0500)]
Major cleanups. Pre-process loop back in main loop, pre-processing abstracted into a function that makes sense.

5 years agoReady for 1.7 release. 1.7
Eric S. Raymond [Tue, 4 Dec 2018 03:23:29 +0000 (22:23 -0500)]
Ready for 1.7 release.

5 years agoNEWS update.
Eric S. Raymond [Tue, 4 Dec 2018 02:06:03 +0000 (21:06 -0500)]
NEWS update.

5 years agoMakefile fix for macOS 10.14 274/head
Aaron Traas [Mon, 3 Dec 2018 18:51:02 +0000 (13:51 -0500)]
Makefile fix for macOS 10.14

5 years agoFix for change in list handling behavior in Python 3
Aaron Traas [Mon, 3 Dec 2018 18:48:00 +0000 (13:48 -0500)]
Fix for change in list handling behavior in Python 3

5 years agoAddress GitLab issue #45: OSX Compile issue
Eric S. Raymond [Fri, 30 Nov 2018 14:49:23 +0000 (09:49 -0500)]
Address GitLab issue #45: OSX Compile issue

5 years agoResolve GitLab issue #46: -o (oldstyle) clarification.
Eric S. Raymond [Fri, 30 Nov 2018 14:28:27 +0000 (09:28 -0500)]
Resolve GitLab issue #46: -o (oldstyle) clarification.

5 years agoDocumentation fix.
Eric S. Raymond [Tue, 20 Nov 2018 12:09:31 +0000 (07:09 -0500)]
Documentation fix.

5 years agoReindentation, typo fix 273/head
NHOrus [Fri, 23 Nov 2018 17:19:22 +0000 (20:19 +0300)]
Reindentation, typo fix

5 years agoRemove comments that are obsolete now that the code is goto-less.
Eric S. Raymond [Tue, 20 Nov 2018 11:54:24 +0000 (06:54 -0500)]
Remove comments that are obsolete now that the code is goto-less.

5 years agoWe are now goto free! 271/head 272/head
Aaron Traas [Mon, 19 Nov 2018 22:01:31 +0000 (17:01 -0500)]
We are now goto free!

5 years agoEliminated "Lookup" label
Aaron Traas [Mon, 19 Nov 2018 19:52:13 +0000 (14:52 -0500)]
Eliminated "Lookup" label

5 years agoComment polishing.
Eric S. Raymond [Sun, 18 Nov 2018 21:27:06 +0000 (16:27 -0500)]
Comment polishing.

5 years agoAttempting voodoo change to banish GitLab error.
Eric S. Raymond [Sun, 18 Nov 2018 17:39:04 +0000 (12:39 -0500)]
Attempting voodoo change to banish GitLab error.

This shouldn't be necessary.

5 years agoEliminate a label.
Eric S. Raymond [Fri, 16 Nov 2018 13:30:26 +0000 (08:30 -0500)]
Eliminate a label.

5 years agoExplicit preserve logic is no longer needed...
Eric S. Raymond [Fri, 16 Nov 2018 12:38:49 +0000 (07:38 -0500)]
Explicit preserve logic is no longer needed...

...now that we're not heedlessly nuking the command state.

5 years agoExtend coverage.
Eric S. Raymond [Fri, 16 Nov 2018 12:20:58 +0000 (07:20 -0500)]
Extend coverage.

5 years agoMagic-number elimination.
Eric S. Raymond [Fri, 16 Nov 2018 10:19:31 +0000 (05:19 -0500)]
Magic-number elimination.

5 years agoRecover 100% test coverage.
Eric S. Raymond [Fri, 16 Nov 2018 10:04:18 +0000 (05:04 -0500)]
Recover 100% test coverage.

5 years agoTry to get that last line of coverage.
Eric S. Raymond [Fri, 16 Nov 2018 00:56:01 +0000 (19:56 -0500)]
Try to get that last line of coverage.

5 years agoChoose a less obscure label name.
Eric S. Raymond [Thu, 15 Nov 2018 19:03:20 +0000 (14:03 -0500)]
Choose a less obscure label name.

5 years agoRemove some dead symbols revealed by coverage analysis.
Eric S. Raymond [Thu, 15 Nov 2018 19:00:37 +0000 (14:00 -0500)]
Remove some dead symbols revealed by coverage analysis.

5 years agoCoverage improvement. Also, it's rude to die silently.
Eric S. Raymond [Thu, 15 Nov 2018 18:55:10 +0000 (13:55 -0500)]
Coverage improvement. Also, it's rude to die silently.

5 years agoMore coverage tweaks.
Eric S. Raymond [Thu, 15 Nov 2018 18:33:16 +0000 (13:33 -0500)]
More coverage tweaks.

5 years agoAnother coverage tweak.
Eric S. Raymond [Thu, 15 Nov 2018 18:23:16 +0000 (13:23 -0500)]
Another coverage tweak.

5 years agoAnother coverage tweak.
Eric S. Raymond [Thu, 15 Nov 2018 17:40:04 +0000 (12:40 -0500)]
Another coverage tweak.

5 years agoTweak code-coverage exclusions.
Eric S. Raymond [Thu, 15 Nov 2018 17:16:44 +0000 (12:16 -0500)]
Tweak code-coverage exclusions.

5 years agoReady for 1.6 release.
Eric S. Raymond [Thu, 15 Nov 2018 15:08:10 +0000 (10:08 -0500)]
Ready for 1.6 release.

5 years agoReady for 1.6 release. 1.6
Eric S. Raymond [Thu, 15 Nov 2018 15:08:10 +0000 (10:08 -0500)]
Ready for 1.6 release.

5 years agoRemove unneeded code.
Eric S. Raymond [Thu, 15 Nov 2018 00:08:55 +0000 (19:08 -0500)]
Remove unneeded code.

5 years agotypo fix.
Eric S. Raymond [Wed, 14 Nov 2018 18:53:17 +0000 (13:53 -0500)]
typo fix.

5 years agoNEWS update.
Eric S. Raymond [Wed, 14 Nov 2018 18:42:04 +0000 (13:42 -0500)]
NEWS update.

5 years agoTypo fixes from Horst H. von Brand.
Eric S. Raymond [Wed, 14 Nov 2018 18:33:09 +0000 (13:33 -0500)]
Typo fixes from Horst H. von Brand.

5 years agoCreate regression test for issue #36.
Eric S. Raymond [Wed, 14 Nov 2018 18:17:56 +0000 (13:17 -0500)]
Create regression test for issue #36.

5 years agoRegression test for GitLab issue #37 fix.
Eric S. Raymond [Wed, 14 Nov 2018 18:03:33 +0000 (13:03 -0500)]
Regression test for GitLab issue #37 fix.

5 years agoFix for GitLab issue #37: prompt incorrectly handled.
Eric S. Raymond [Wed, 14 Nov 2018 18:01:39 +0000 (13:01 -0500)]
Fix for GitLab issue #37: prompt incorrectly handled.

5 years agoPrepare for sync with the issue #37 bugfix branch.
Eric S. Raymond [Wed, 14 Nov 2018 16:52:55 +0000 (11:52 -0500)]
Prepare for sync with the issue #37 bugfix branch.

5 years agoSync patch.
Eric S. Raymond [Wed, 14 Nov 2018 16:43:38 +0000 (11:43 -0500)]
Sync patch.

5 years agoTypo fix.
Eric S. Raymond [Mon, 12 Nov 2018 09:19:54 +0000 (04:19 -0500)]
Typo fix.

5 years agoFix typo in the NEWS file (2016 -> 2017) 269/head
Javier [Sun, 11 Nov 2018 22:11:32 +0000 (22:11 +0000)]
Fix typo in the NEWS file (2016 -> 2017)

5 years agoReady for 1.5 release. 1.5
Eric S. Raymond [Sun, 11 Nov 2018 14:06:44 +0000 (09:06 -0500)]
Ready for 1.5 release.

5 years agoHandle a bare numeric token on the command line a bit more gracefully.
Eric S. Raymond [Sun, 11 Nov 2018 14:05:03 +0000 (09:05 -0500)]
Handle a bare numeric token on the command line a bit more gracefully.

5 years agoNEWS update.
Eric S. Raymond [Sun, 11 Nov 2018 13:56:15 +0000 (08:56 -0500)]
NEWS update.

5 years agoIdentify libedit better.
Eric S. Raymond [Sun, 11 Nov 2018 13:37:15 +0000 (08:37 -0500)]
Identify libedit better.

5 years agoFix some accidental test damage in Javier's last commit.
Eric S. Raymond [Sun, 11 Nov 2018 13:02:21 +0000 (08:02 -0500)]
Fix some accidental test damage in Javier's last commit.

5 years agoPatch 1
Javier [Sun, 11 Nov 2018 12:56:03 +0000 (12:56 +0000)]
Patch 1

6 years agoAn attempt to fix GitLab issue #37 failed, but...
Eric S. Raymond [Mon, 12 Mar 2018 03:47:43 +0000 (23:47 -0400)]
An attempt to fix GitLab issue #37 failed, but...

...update the condioned-out code to at least make sense with the
current versions of the data structures.

6 years agoFix for GitLab issue #40: Inconsistant inventory space
Eric S. Raymond [Sat, 10 Mar 2018 22:58:46 +0000 (17:58 -0500)]
Fix for GitLab issue #40: Inconsistant inventory space

6 years agoSPDXify the code.
Eric S. Raymond [Fri, 9 Mar 2018 01:56:21 +0000 (20:56 -0500)]
SPDXify the code.

6 years agoHistory update.
Eric S. Raymond [Thu, 8 Mar 2018 15:26:22 +0000 (10:26 -0500)]
History update.

6 years agoAddress GitLab issue #42.
Eric S. Raymond [Thu, 8 Mar 2018 13:38:27 +0000 (08:38 -0500)]
Address GitLab issue #42.

6 years agoRemove an unnecessary argument.
Eric S. Raymond [Thu, 8 Mar 2018 13:35:46 +0000 (08:35 -0500)]
Remove an unnecessary argument.

6 years agoAdditional warnings 267/head
NHOrus [Thu, 8 Mar 2018 12:20:14 +0000 (15:20 +0300)]
Additional warnings
One of the two is fixed and GCC-exclusive, will cause more
warnings on Clang

6 years agoFix CI pipeline
NHOrus [Thu, 8 Mar 2018 12:18:32 +0000 (15:18 +0300)]
Fix CI pipeline

6 years agoTypo fix.
Eric S. Raymond [Sun, 17 Sep 2017 15:35:45 +0000 (11:35 -0400)]
Typo fix.

6 years agoUnlike objects, player doesn't go to -1 when destroyed. 264/head
NHOrus [Wed, 13 Sep 2017 16:34:35 +0000 (19:34 +0300)]
Unlike objects, player doesn't go to -1 when destroyed.
Tighten bounds check.

6 years agoType constants to prevent overflow
NHOrus [Tue, 12 Sep 2017 05:18:17 +0000 (08:18 +0300)]
Type constants to prevent overflow

6 years agoIf divident negative, then remainder is negative too.
NHOrus [Mon, 11 Sep 2017 18:20:46 +0000 (21:20 +0300)]
If divident negative, then remainder is negative too.
RNG values need to be always positive.
Solution: Transposing positively by divisor. In all the two places it may happen.

6 years agoBe consistent
NHOrus [Sun, 10 Sep 2017 21:32:21 +0000 (00:32 +0300)]
Be consistent

6 years agoPut some of important parameters into fixed width signed integers
NHOrus [Sun, 10 Sep 2017 21:13:55 +0000 (00:13 +0300)]
Put some of important parameters into fixed width signed integers
Massaged test files. Fixes issue #41

6 years agoSilenced fallthrough warning 263/head
NHOrus [Tue, 5 Sep 2017 15:32:56 +0000 (18:32 +0300)]
Silenced fallthrough warning

6 years agoPrevent RNG overflow.
NHOrus [Tue, 5 Sep 2017 15:20:21 +0000 (18:20 +0300)]
Prevent RNG overflow.
Pass save under validation by pointer, so we could mess with underlying
values a little. Only thing I feel we can safely and sanely modify.

6 years agoRemoved old copy-paste error
NHOrus [Tue, 5 Sep 2017 14:46:38 +0000 (17:46 +0300)]
Removed old copy-paste error
Put numdie bounds check in croak to prevent OOB access on negative
numdie while preserving tests

6 years agoPrevent tampering with PRNG parameters in save
NHOrus [Thu, 24 Aug 2017 11:48:02 +0000 (14:48 +0300)]
Prevent tampering with PRNG parameters in save

6 years agoFixed copy-paste errors
NHOrus [Thu, 24 Aug 2017 11:41:21 +0000 (14:41 +0300)]
Fixed copy-paste errors

6 years agoPrevent division by zero
NHOrus [Thu, 24 Aug 2017 11:24:13 +0000 (14:24 +0300)]
Prevent division by zero

6 years agoVerify bounds for linked lists
NHOrus [Thu, 24 Aug 2017 10:47:57 +0000 (13:47 +0300)]
Verify bounds for linked lists

6 years agoCorrected limit for atloc, see init.c for filling double-linked list
NHOrus [Thu, 24 Aug 2017 10:40:10 +0000 (13:40 +0300)]
Corrected limit for atloc, see init.c for filling double-linked list

6 years agoFix value, add check for linked locations
NHOrus [Thu, 24 Aug 2017 10:02:51 +0000 (13:02 +0300)]
Fix value, add check for linked locations

6 years agoBounds check for properties; it is not violated in normal game
NHOrus [Thu, 24 Aug 2017 08:21:10 +0000 (11:21 +0300)]
Bounds check for properties; it is not violated in normal game

6 years agoSyntax error
NHOrus [Sun, 13 Aug 2017 14:58:35 +0000 (15:58 +0100)]
Syntax error

6 years agoValidate dwarves and tally
NHOrus [Sun, 13 Aug 2017 14:56:37 +0000 (15:56 +0100)]
Validate dwarves and tally

6 years agoReindentation
NHOrus [Sun, 13 Aug 2017 14:56:07 +0000 (15:56 +0100)]
Reindentation

6 years agoVerify sanity of location arrays
NHOrus [Sun, 13 Aug 2017 14:16:09 +0000 (15:16 +0100)]
Verify sanity of location arrays

6 years agoValidating sanity of locations in restored game
NHOrus [Sun, 13 Aug 2017 11:41:42 +0000 (12:41 +0100)]
Validating sanity of locations in restored game

6 years agoRemove extraneous listing of files
NHOrus [Sun, 13 Aug 2017 11:14:09 +0000 (12:14 +0100)]
Remove extraneous listing of files

6 years agoReady for 1.4 release. 1.4
Eric S. Raymond [Tue, 8 Aug 2017 03:21:10 +0000 (23:21 -0400)]
Ready for 1.4 release.

6 years agoRemove duplicative phase code.
Eric S. Raymond [Thu, 3 Aug 2017 19:51:39 +0000 (15:51 -0400)]
Remove duplicative phase code.

6 years agoUse the '=' operator (not memcpy()) to shallow-copy structs. 262/head
Jason S. Ninneman [Thu, 3 Aug 2017 19:41:35 +0000 (12:41 -0700)]
Use the '=' operator (not memcpy()) to shallow-copy structs.

6 years agoCanonicalize OV commands to VO form.
Eric S. Raymond [Thu, 3 Aug 2017 19:02:41 +0000 (15:02 -0400)]
Canonicalize OV commands to VO form.

Allows us to get rid of some obscure logic that causes an unnecessary
word shift. One error message changes in a benign way.

6 years agoMassage "{oil|water} {plant|door} into equivalent pourcommand.
Eric S. Raymond [Thu, 3 Aug 2017 18:48:44 +0000 (14:48 -0400)]
Massage "{oil|water} {plant|door} into equivalent pourcommand.

Bedfore this change the command was passed in OV form, which we want
to get rid of.

6 years agoSimplify overcomplicated code.
Eric S. Raymond [Thu, 3 Aug 2017 18:22:38 +0000 (14:22 -0400)]
Simplify overcomplicated code.

6 years agoMore breadcrumb improvements.
Eric S. Raymond [Thu, 3 Aug 2017 16:56:50 +0000 (12:56 -0400)]
More breadcrumb improvements.

6 years agoImprove debugging.
Eric S. Raymond [Thu, 3 Aug 2017 16:25:56 +0000 (12:25 -0400)]
Improve debugging.

6 years agoTypedefify command_t; simplify code accordingly. 261/head
Jason S. Ninneman [Thu, 3 Aug 2017 15:29:46 +0000 (08:29 -0700)]
Typedefify command_t; simplify code accordingly.

6 years agoSimplify command word handling.
Jason S. Ninneman [Thu, 3 Aug 2017 06:43:52 +0000 (23:43 -0700)]
Simplify command word handling.

6 years agoUpgrade get_vocab_metadata() to use command_type_t.
Jason S. Ninneman [Thu, 3 Aug 2017 06:08:55 +0000 (23:08 -0700)]
Upgrade get_vocab_metadata() to use command_type_t.

6 years agoEncapsulate command words into their own struct.
Jason S. Ninneman [Thu, 3 Aug 2017 03:11:40 +0000 (20:11 -0700)]
Encapsulate command words into their own struct.

6 years agoAdd command_word_t, for command words.
Jason S. Ninneman [Thu, 3 Aug 2017 02:26:29 +0000 (19:26 -0700)]
Add command_word_t, for command words.