open-adventure.git
6 years agoRemove unneeded vocabulary lookup.
Eric S. Raymond [Thu, 20 Jul 2017 14:13:15 +0000 (10:13 -0400)]
Remove unneeded vocabulary lookup.

6 years agoEliminate last logic guard on a packed value.
Eric S. Raymond [Thu, 20 Jul 2017 13:50:58 +0000 (09:50 -0400)]
Eliminate last logic guard on a packed value.

6 years agoRemove a packing call - word buffer is good enough.
Eric S. Raymond [Thu, 20 Jul 2017 13:11:13 +0000 (09:11 -0400)]
Remove a packing call - word buffer is good enough.

6 years agoRemove special-case code that was inducing bugs.
Eric S. Raymond [Thu, 20 Jul 2017 13:08:10 +0000 (09:08 -0400)]
Remove special-case code that was inducing bugs.

6 years agoImproved word type checking.
Eric S. Raymond [Thu, 20 Jul 2017 11:40:19 +0000 (07:40 -0400)]
Improved word type checking.

6 years agoEliminate some uses of wd2 - tests can be done on raw2 buffer instead.
Eric S. Raymond [Thu, 20 Jul 2017 11:09:20 +0000 (07:09 -0400)]
Eliminate some uses of wd2 - tests can be done on raw2 buffer instead.

6 years agoAdd some word-type checking where it's needed.
Eric S. Raymond [Thu, 20 Jul 2017 11:02:35 +0000 (07:02 -0400)]
Add some word-type checking where it's needed.

6 years agoMake compparuson out to TOKLEN only explicit in vocab lookups.
Eric S. Raymond [Thu, 20 Jul 2017 09:54:55 +0000 (05:54 -0400)]
Make compparuson out to TOKLEN only explicit in vocab lookups.

6 years agoGet symbol coverage on LOC_SMALLPIT
Eric S. Raymond [Wed, 19 Jul 2017 19:38:31 +0000 (15:38 -0400)]
Get symbol coverage on LOC_SMALLPIT

6 years agoRemove a test pair that seems to be duplicative.
Eric S. Raymond [Wed, 19 Jul 2017 18:00:12 +0000 (14:00 -0400)]
Remove a test pair that seems to be duplicative.

6 years agoTell the compiler not to warn about legitimate case fallthroughs. 254/head
Jason S. Ninneman [Wed, 19 Jul 2017 16:47:20 +0000 (09:47 -0700)]
Tell the compiler not to warn about legitimate case fallthroughs.

6 years agoTypo fix.
Eric S. Raymond [Mon, 17 Jul 2017 20:30:41 +0000 (16:30 -0400)]
Typo fix.

6 years agoCover short descriotion of LOC_SMALLPIT.
Eric S. Raymond [Mon, 17 Jul 2017 20:22:09 +0000 (16:22 -0400)]
Cover short descriotion of LOC_SMALLPIT.

6 years agoRecord 100% code coverage.
Eric S. Raymond [Mon, 17 Jul 2017 18:28:40 +0000 (14:28 -0400)]
Record 100% code coverage.

6 years agoStep with debug compiling with Clang, to contrast with GCC
NHOrus [Mon, 17 Jul 2017 17:12:16 +0000 (20:12 +0300)]
Step with debug compiling with Clang, to contrast with GCC

6 years agoNo magic, revert some experimental changes in pipeline
NHOrus [Mon, 17 Jul 2017 16:59:55 +0000 (19:59 +0300)]
No magic, revert some experimental changes in pipeline

6 years agoUse OpenSUSE in CI pipeline, instead
NHOrus [Sun, 16 Jul 2017 04:43:56 +0000 (07:43 +0300)]
Use OpenSUSE in CI pipeline, instead

6 years agoUse Fedora for the CI pipeline.
Jason S. Ninneman [Sat, 15 Jul 2017 03:45:19 +0000 (20:45 -0700)]
Use Fedora for the CI pipeline.

6 years agoUse ASan and UBSan in debug builds.
Jason S. Ninneman [Sat, 15 Jul 2017 03:19:54 +0000 (20:19 -0700)]
Use ASan and UBSan in debug builds.

6 years agoDeploy maximum "fortified source" and stack protection.
Jason S. Ninneman [Sat, 15 Jul 2017 02:52:20 +0000 (19:52 -0700)]
Deploy maximum "fortified source" and stack protection.

6 years agoEnsure cheat is built with debug options when 'make debug' is given.
Jason S. Ninneman [Sat, 15 Jul 2017 02:45:17 +0000 (19:45 -0700)]
Ensure cheat is built with debug options when 'make debug' is given.

6 years agoLOC_SMALLPIT.small and LOC_TOPSTALACTITE.small
Aaron Traas [Mon, 17 Jul 2017 15:56:19 +0000 (11:56 -0400)]
LOC_SMALLPIT.small and LOC_TOPSTALACTITE.small

6 years agoYAML coverage generator minor cleanup
Aaron Traas [Mon, 17 Jul 2017 14:57:13 +0000 (10:57 -0400)]
YAML coverage generator minor cleanup

6 years agoAdd .desktop file for advent 250/head
Dr. Tobias Quathamer [Mon, 17 Jul 2017 14:19:34 +0000 (16:19 +0200)]
Add .desktop file for advent

6 years agoAdd SVG file for advent icon
Dr. Tobias Quathamer [Mon, 17 Jul 2017 14:13:43 +0000 (16:13 +0200)]
Add SVG file for advent icon

6 years agoRemove flawed code to drop batteries.
Eric S. Raymond [Mon, 17 Jul 2017 11:29:44 +0000 (07:29 -0400)]
Remove flawed code to drop batteries.

6 years agoCover MISSING_BATTERIES in a test. Needs unducumented "waste" fallback.
Eric S. Raymond [Mon, 17 Jul 2017 10:07:01 +0000 (06:07 -0400)]
Cover MISSING_BATTERIES in a test. Needs unducumented "waste" fallback.

6 years agoPrevent multiline string quotes from confusing Emacs.
Eric S. Raymond [Sun, 16 Jul 2017 21:23:40 +0000 (17:23 -0400)]
Prevent multiline string quotes from confusing Emacs.

6 years agoDe-FORTRANIZE some IDs.
Eric S. Raymond [Sun, 16 Jul 2017 20:05:26 +0000 (16:05 -0400)]
De-FORTRANIZE some IDs.

6 years agoInformation hiding.
Eric S. Raymond [Sun, 16 Jul 2017 19:17:39 +0000 (15:17 -0400)]
Information hiding.

6 years agoDiscuss specials: in the adventure.yaml comments. 249/head
Jason S. Ninneman [Sun, 16 Jul 2017 19:14:23 +0000 (12:14 -0700)]
Discuss specials: in the adventure.yaml comments.

6 years agoFix adventitious '' occurrences.
Eric S. Raymond [Sun, 16 Jul 2017 18:17:26 +0000 (14:17 -0400)]
Fix adventitious '' occurrences.

6 years agoConsolidare window1 test into bigfail.
Eric S. Raymond [Sun, 16 Jul 2017 18:06:04 +0000 (14:06 -0400)]
Consolidare window1 test into bigfail.

6 years agoTest consolidation into bigfail.log.
Eric S. Raymond [Sun, 16 Jul 2017 17:05:34 +0000 (13:05 -0400)]
Test consolidation into bigfail.log.

6 years agoExtend bigfail test.
Eric S. Raymond [Sun, 16 Jul 2017 13:23:40 +0000 (09:23 -0400)]
Extend bigfail test.

6 years agoRemoved temporary variable for clarity; Upsized text buffer in fallback to maximum... 248/head
NHOrus [Sun, 16 Jul 2017 13:07:23 +0000 (16:07 +0300)]
Removed temporary variable for clarity; Upsized text buffer in fallback to maximum possible size

6 years agoDeal with more agressive gcov 7.1; Reindent
NHOrus [Sun, 16 Jul 2017 13:00:19 +0000 (16:00 +0300)]
Deal with more agressive gcov 7.1; Reindent

6 years agoTest consolidation 247/head
Aaron Traas [Sun, 16 Jul 2017 11:39:45 +0000 (07:39 -0400)]
Test consolidation

6 years agoYAML coverage generator minor cleanup
Aaron Traas [Sun, 16 Jul 2017 11:27:39 +0000 (07:27 -0400)]
YAML coverage generator minor cleanup

6 years agoFixed YAML coverage generator in python3
Aaron Traas [Sun, 16 Jul 2017 11:16:40 +0000 (07:16 -0400)]
Fixed YAML coverage generator in python3

6 years agoFold smallpit test into bigfail.
Eric S. Raymond [Sun, 16 Jul 2017 11:48:37 +0000 (07:48 -0400)]
Fold smallpit test into bigfail.

6 years agoFix bug where knife hit might not be reported.
Eric S. Raymond [Sun, 16 Jul 2017 11:13:06 +0000 (07:13 -0400)]
Fix bug where knife hit might not be reported.

6 years agoTest consolidation - move a lot of nonlethal failures into bigfail.log.
Eric S. Raymond [Sun, 16 Jul 2017 10:26:51 +0000 (06:26 -0400)]
Test consolidation - move a lot of nonlethal failures into bigfail.log.

6 years agoTwo coverage imprivenents, one by recognizing dead code.
Eric S. Raymond [Sun, 16 Jul 2017 09:33:43 +0000 (05:33 -0400)]
Two coverage imprivenents, one by recognizing dead code.

6 years agoApply state_change() to mirror object.
Eric S. Raymond [Sun, 16 Jul 2017 09:08:03 +0000 (05:08 -0400)]
Apply state_change() to mirror object.

6 years agoMore test consolidation.
Eric S. Raymond [Sun, 16 Jul 2017 08:13:08 +0000 (04:13 -0400)]
More test consolidation.

6 years agoTest consolidation.
Eric S. Raymond [Sun, 16 Jul 2017 08:00:33 +0000 (04:00 -0400)]
Test consolidation.

6 years agoImprove symbol coverage.
Eric S. Raymond [Sun, 16 Jul 2017 00:49:38 +0000 (20:49 -0400)]
Improve symbol coverage.

6 years agoYAML coverage - TROLL_BLOCKS arbitrary message 246/head
Aaron Traas [Sat, 15 Jul 2017 22:10:29 +0000 (18:10 -0400)]
YAML coverage - TROLL_BLOCKS arbitrary message

6 years agoNamed unnamed actions and specials
Aaron Traas [Sat, 15 Jul 2017 21:20:02 +0000 (17:20 -0400)]
Named unnamed actions and specials

6 years agoFull refactor of YAML dungeon generator.
Aaron Traas [Sat, 15 Jul 2017 21:19:29 +0000 (17:19 -0400)]
Full refactor of YAML dungeon generator.

The big difference is that the differences between the entity types
is concentrated in one place.

Also concentrated all File I/O in main function, moved most processing
outside of main

6 years agoFirst stage cleanup of YAML dungeon generator. Less hard-coded stuff.
Aaron Traas [Sat, 15 Jul 2017 17:10:39 +0000 (13:10 -0400)]
First stage cleanup of YAML dungeon generator. Less hard-coded stuff.

Next stage will be rewrite so report object contains all of the keys
and coverage values, so we're not scribbling over DB all the time, and
we don't have to walk over things multiple times, and can keep HTML
generation in one place

6 years agoImprove symbol coverage.
Eric S. Raymond [Sat, 15 Jul 2017 17:00:48 +0000 (13:00 -0400)]
Improve symbol coverage.

6 years agoDocumentation polishing.
Eric S. Raymond [Sat, 15 Jul 2017 09:05:59 +0000 (05:05 -0400)]
Documentation polishing.

6 years agoYAML coverage - last object message 244/head
Aaron Traas [Fri, 14 Jul 2017 17:06:44 +0000 (13:06 -0400)]
YAML coverage - last object message

6 years agoCode cleanup.
Eric S. Raymond [Fri, 14 Jul 2017 17:10:13 +0000 (13:10 -0400)]
Code cleanup.

6 years agoFix off-by-two bug.
Eric S. Raymond [Fri, 14 Jul 2017 16:39:06 +0000 (12:39 -0400)]
Fix off-by-two bug.

6 years agoYAML coverage - object messages 100% covered
Aaron Traas [Fri, 14 Jul 2017 15:39:54 +0000 (11:39 -0400)]
YAML coverage - object messages 100% covered

6 years agoReplace some more wd? with id?. 245/head
Jason S. Ninneman [Wed, 12 Jul 2017 21:32:46 +0000 (14:32 -0700)]
Replace some more wd? with id?.

6 years agoReplace some uses of wd[12] with id[12].
Jason S. Ninneman [Wed, 12 Jul 2017 20:54:14 +0000 (13:54 -0700)]
Replace some uses of wd[12] with id[12].

6 years agoDragon attack code no longer edits the command struct.
Jason S. Ninneman [Wed, 12 Jul 2017 20:49:28 +0000 (13:49 -0700)]
Dragon attack code no longer edits the command struct.

This also fixes a minor bug where refusing to attack the dragon
costs the player two turns instead of one.

6 years agoHandle word type and raw strings.
Jason S. Ninneman [Wed, 12 Jul 2017 19:10:00 +0000 (12:10 -0700)]
Handle word type and raw strings.

6 years agoUse vocab IDs along side packed words.
Jason S. Ninneman [Wed, 12 Jul 2017 18:17:12 +0000 (11:17 -0700)]
Use vocab IDs along side packed words.

6 years agoMore coverage improvements.
Eric S. Raymond [Fri, 14 Jul 2017 16:00:29 +0000 (12:00 -0400)]
More coverage improvements.

6 years agoPartially address GitLab issue #27: arbitrary_messages unreachable
Eric S. Raymond [Fri, 14 Jul 2017 15:33:22 +0000 (11:33 -0400)]
Partially address GitLab issue #27: arbitrary_messages unreachable

6 years agoRefactored discard to concentrate bird-related things in one place 243/head
NHOrus [Fri, 14 Jul 2017 13:34:54 +0000 (16:34 +0300)]
Refactored discard to concentrate bird-related things in one place

6 years agoRefactored carry for clarity
NHOrus [Fri, 14 Jul 2017 13:02:52 +0000 (16:02 +0300)]
Refactored carry for clarity

6 years agoDo not base endgame bonus on arbitrary messages
NHOrus [Fri, 14 Jul 2017 12:40:59 +0000 (15:40 +0300)]
Do not base endgame bonus on arbitrary messages
This may break save files, but doesn't, due to padding

6 years agoYAML coverage - commented out unused arbitrary messages 242/head
Aaron Traas [Fri, 14 Jul 2017 03:20:27 +0000 (23:20 -0400)]
YAML coverage - commented out unused arbitrary messages

6 years agoYAML coverage - all the listen messages
Aaron Traas [Fri, 14 Jul 2017 03:16:24 +0000 (23:16 -0400)]
YAML coverage - all the listen messages

6 years agoYAML coverage - cleanup and comments
Aaron Traas [Thu, 13 Jul 2017 22:24:20 +0000 (18:24 -0400)]
YAML coverage - cleanup and comments

6 years agoYAML coverage - locations 100% covered
Aaron Traas [Thu, 13 Jul 2017 21:42:10 +0000 (17:42 -0400)]
YAML coverage - locations 100% covered

6 years agoYAML coverage - more locations and message
Aaron Traas [Thu, 13 Jul 2017 21:30:08 +0000 (17:30 -0400)]
YAML coverage - more locations and message

- LOC_DEADCRAWL
- CROSS_BRIDGE
- LOC_BOULDERS2.short
- LOC_WINDOW1

6 years agoYAML coverage - hints 100% covered
Aaron Traas [Thu, 13 Jul 2017 20:05:15 +0000 (16:05 -0400)]
YAML coverage - hints 100% covered

6 years agoYAML coverage parser bug fixed -- handling `\n` and `\t` correctly
Aaron Traas [Thu, 13 Jul 2017 19:56:37 +0000 (15:56 -0400)]
YAML coverage parser bug fixed -- handling `\n` and `\t` correctly

6 years agoYAML coverage parser fixed to equate "NO_MESSAGE" with None
Aaron Traas [Thu, 13 Jul 2017 19:10:26 +0000 (15:10 -0400)]
YAML coverage parser fixed to equate "NO_MESSAGE" with None

6 years agoadventure.yaml - coverage of all scoring class thresholds
Aaron Traas [Thu, 13 Jul 2017 19:04:49 +0000 (15:04 -0400)]
adventure.yaml - coverage of all scoring class thresholds

6 years agoPrompt and taunt you after 3rd and final death
Aaron Traas [Thu, 13 Jul 2017 18:44:55 +0000 (14:44 -0400)]
Prompt and taunt you after 3rd and final death

Fixed a bug where you'd not be asked about whether to be resurrected a
final time. Now you are.

6 years agoNo spk remains in the code base
NHOrus [Thu, 13 Jul 2017 17:44:18 +0000 (20:44 +0300)]
No spk remains in the code base

6 years agoTest that troll really retuns after we take eggs
NHOrus [Thu, 13 Jul 2017 17:25:57 +0000 (20:25 +0300)]
Test that troll really retuns after we take eggs

6 years agoRemoved unused code, reindented
NHOrus [Thu, 13 Jul 2017 17:20:11 +0000 (20:20 +0300)]
Removed unused code, reindented

6 years agoExpand scope of coverage_dungeon.py - actions and obituaries
Aaron Traas [Thu, 13 Jul 2017 16:24:52 +0000 (12:24 -0400)]
Expand scope of coverage_dungeon.py - actions and obituaries

6 years agoExpand scope of coverage_dungeon.py - specials
Aaron Traas [Thu, 13 Jul 2017 15:50:51 +0000 (11:50 -0400)]
Expand scope of coverage_dungeon.py - specials

6 years agoExpand scope of coverage_dungeon.py
Aaron Traas [Wed, 12 Jul 2017 21:52:56 +0000 (17:52 -0400)]
Expand scope of coverage_dungeon.py

hints, classes and turn thrusholds are now supported

6 years agoCosmetic text fix.
Eric S. Raymond [Wed, 12 Jul 2017 17:48:55 +0000 (13:48 -0400)]
Cosmetic text fix.

6 years agoExpress word type with an enum instead of magic numbers. 238/head
Jason S. Ninneman [Wed, 12 Jul 2017 00:44:06 +0000 (17:44 -0700)]
Express word type with an enum instead of magic numbers.

* Make a cleaner function for getting vocab metadata.
* Get rid of magic numbers.
* Purge get_vocab_id().
* Abolish the *_WORD() macros.
* Add FIXME comment on some ugliness.

6 years agoForcing floating point division for % coverage, so we don't show 0% 237/head
Aaron Traas [Wed, 12 Jul 2017 12:56:50 +0000 (08:56 -0400)]
Forcing floating point division for % coverage, so we don't show 0%

6 years agoRemove obsolete comment.
Eric S. Raymond [Wed, 12 Jul 2017 09:24:12 +0000 (05:24 -0400)]
Remove obsolete comment.

6 years agoRemove obsolete caveat.
Eric S. Raymond [Wed, 12 Jul 2017 09:11:03 +0000 (05:11 -0400)]
Remove obsolete caveat.

6 years agoIn TODO, note some possible tests.
Eric S. Raymond [Wed, 12 Jul 2017 08:42:24 +0000 (04:42 -0400)]
In TODO, note some possible tests.

6 years agoPrevent game from uttering solecisms about the "floor" when outside.
Eric S. Raymond [Wed, 12 Jul 2017 04:19:16 +0000 (00:19 -0400)]
Prevent game from uttering solecisms about the "floor" when outside.

6 years agoPython-agnosticize coverage_dungeon.py. 236/head
Jason S. Ninneman [Tue, 11 Jul 2017 23:07:09 +0000 (16:07 -0700)]
Python-agnosticize coverage_dungeon.py.

6 years agoInstall Python 2 pip in Alpine.
Jason S. Ninneman [Tue, 11 Jul 2017 23:01:02 +0000 (16:01 -0700)]
Install Python 2 pip in Alpine.

6 years agoUse Python 2 in Alpine Linux, because that's default.
Jason S. Ninneman [Tue, 11 Jul 2017 22:57:50 +0000 (15:57 -0700)]
Use Python 2 in Alpine Linux, because that's default.

6 years agoMake the build Python-2/3 agnostic.
Jason S. Ninneman [Tue, 11 Jul 2017 22:54:16 +0000 (15:54 -0700)]
Make the build Python-2/3 agnostic.

6 years agoReplace tests on packed words with tests on strings.
Jason S. Ninneman [Tue, 11 Jul 2017 15:52:50 +0000 (08:52 -0700)]
Replace tests on packed words with tests on strings.

6 years agoRecord a fix.
Eric S. Raymond [Tue, 11 Jul 2017 23:13:24 +0000 (19:13 -0400)]
Record a fix.

6 years agoDemonstrate that we don't have the vase bug.
Eric S. Raymond [Tue, 11 Jul 2017 23:06:10 +0000 (19:06 -0400)]
Demonstrate that we don't have the vase bug.

6 years agoLOC_* coverage - at 98.4% 235/head
Aaron Traas [Tue, 11 Jul 2017 21:35:23 +0000 (17:35 -0400)]
LOC_* coverage - at 98.4%

6 years agoMinor bug fix in an error notification.
Eric S. Raymond [Tue, 11 Jul 2017 21:05:55 +0000 (17:05 -0400)]
Minor bug fix in an error notification.