open-adventure.git
6 years agoDiscard implementation of %L and %U format specifiers, now never used.
Eric S. Raymond [Mon, 3 Jul 2017 22:40:06 +0000 (18:40 -0400)]
Discard implementation of %L and %U format specifiers, now never used.

6 years agoReducing use of dynamic allocation forecloses many errors.
Eric S. Raymond [Mon, 3 Jul 2017 21:53:25 +0000 (17:53 -0400)]
Reducing use of dynamic allocation forecloses many errors.

6 years agoInformation hiding.
Eric S. Raymond [Mon, 3 Jul 2017 21:21:06 +0000 (17:21 -0400)]
Information hiding.

6 years agoSimplify tokenization code.
Eric S. Raymond [Mon, 3 Jul 2017 21:13:28 +0000 (17:13 -0400)]
Simplify tokenization code.

6 years agoEntirely eliminate wd1x and wd2x members of the command block.
Eric S. Raymond [Mon, 3 Jul 2017 20:49:33 +0000 (16:49 -0400)]
Entirely eliminate wd1x and wd2x members of the command block.

In the process, fix another case-smashing bug.

6 years agoCaptured output of help and info commands 203/head
NHOrus [Mon, 3 Jul 2017 18:54:27 +0000 (21:54 +0300)]
Captured output of help and info commands
Can't believe it wasn't done before

6 years agoUse DOWN rather thabnd D in YAML.
Eric S. Raymond [Mon, 3 Jul 2017 18:55:34 +0000 (14:55 -0400)]
Use DOWN rather thabnd D in YAML.

6 years agoUse the raw buffer in tr command structure for editing.
Eric S. Raymond [Mon, 3 Jul 2017 16:52:28 +0000 (12:52 -0400)]
Use the raw buffer in tr command structure for editing.

This fixes some minor bugs. Unknown words are no longer truncated
nor uppercased on echo.

6 years agoRemove a bad command from a check log.
Eric S. Raymond [Mon, 3 Jul 2017 14:10:14 +0000 (10:10 -0400)]
Remove a bad command from a check log.

It's interfering with a refactor, and pathological cases really
ought to be checked elsewhere.

6 years agoRefactor tokenization to save raw tokens and use static buffer space...
Eric S. Raymond [Mon, 3 Jul 2017 12:53:10 +0000 (08:53 -0400)]
Refactor tokenization to save raw tokens and use static buffer space...

...rather than dynamic storage.

As a side effect, this seems to have fixed a very ninor bug in the processing
of the bare word 'nothing'.  But I don't know where the bug was.  Not happy.

6 years agoMagic-number elimination.
Eric S. Raymond [Mon, 3 Jul 2017 11:14:15 +0000 (07:14 -0400)]
Magic-number elimination.

6 years agoNamed state labels for every not clause.
Eric S. Raymond [Mon, 3 Jul 2017 11:00:42 +0000 (07:00 -0400)]
Named state labels for every not clause.

6 years agoMake the YAML less fussy.
Eric S. Raymond [Mon, 3 Jul 2017 10:31:44 +0000 (06:31 -0400)]
Make the YAML less fussy.

Don't string-quote things that are semantically like enums.

6 years agoplayermove() never returns false; simplify accordingly
Eric S. Raymond [Mon, 3 Jul 2017 10:08:37 +0000 (06:08 -0400)]
playermove() never returns false; simplify accordingly

6 years agoVisit room with breathtaking view 201/head
NHOrus [Mon, 3 Jul 2017 04:30:53 +0000 (07:30 +0300)]
Visit room with breathtaking view
Try to extinguish a volcano
Closes #22

6 years agoBroke all logical or into multiline statement to show lcov's lies 200/head
NHOrus [Mon, 3 Jul 2017 04:20:37 +0000 (07:20 +0300)]
Broke all logical or into multiline statement to show lcov's lies
Results are weird, some things that need to be checked aren't and
at least my local lcov doesn't show them as unchecked

6 years agoUnspk'd bivalve action, exposing more untested surface 199/head
NHOrus [Mon, 3 Jul 2017 03:46:24 +0000 (06:46 +0300)]
Unspk'd bivalve action, exposing more untested surface

6 years agoUnspk'd fly command
NHOrus [Mon, 3 Jul 2017 03:29:02 +0000 (06:29 +0300)]
Unspk'd fly command

6 years agoUnspk'd listen and lock commands
NHOrus [Mon, 3 Jul 2017 03:21:38 +0000 (06:21 +0300)]
Unspk'd listen and lock commands

6 years agoUnspk'd pour command
NHOrus [Mon, 3 Jul 2017 03:12:19 +0000 (06:12 +0300)]
Unspk'd pour command

6 years agoUnspk and streamline eat command
NHOrus [Mon, 3 Jul 2017 03:07:57 +0000 (06:07 +0300)]
Unspk and streamline eat command

6 years agoRemoved helper function
NHOrus [Mon, 3 Jul 2017 02:59:57 +0000 (05:59 +0300)]
Removed helper function

6 years agoWake dwarves differently
NHOrus [Mon, 3 Jul 2017 02:41:49 +0000 (05:41 +0300)]
Wake dwarves differently

6 years agoCover branch last branch of bird action
NHOrus [Mon, 3 Jul 2017 02:30:46 +0000 (05:30 +0300)]
Cover branch last branch of bird action
And remove distracting line from tests

6 years agoCoverage -- attack bird after game closed 198/head
Aaron Traas [Mon, 3 Jul 2017 02:04:42 +0000 (22:04 -0400)]
Coverage -- attack bird after game closed

6 years agoRemove testing for intransitive seperate from NO_OBJECT in attact()
Aaron Traas [Mon, 3 Jul 2017 01:56:49 +0000 (21:56 -0400)]
Remove testing for intransitive seperate from NO_OBJECT in attact()

because we look for it immediately below, and this code is never
reached. If it were, intransitive attacks would never work.

6 years agoCoverage -- corner cases in lock and find
Aaron Traas [Mon, 3 Jul 2017 01:53:28 +0000 (21:53 -0400)]
Coverage -- corner cases in lock and find

6 years agoCoverage -- giant words
Aaron Traas [Mon, 3 Jul 2017 01:41:53 +0000 (21:41 -0400)]
Coverage -- giant words

6 years agoCoverage -- intransitive attack
Aaron Traas [Mon, 3 Jul 2017 01:32:47 +0000 (21:32 -0400)]
Coverage -- intransitive attack

6 years agoRemoved spk from wave, fixed compiler warning 197/head
NHOrus [Sun, 2 Jul 2017 22:01:01 +0000 (01:01 +0300)]
Removed spk from wave, fixed compiler warning

6 years agoUndid unspeaking of wave, fixed test again.
NHOrus [Sun, 2 Jul 2017 21:47:17 +0000 (00:47 +0300)]
Undid unspeaking of wave, fixed test again.
Changed property math to helper function.

6 years agoDon't spk in wave and action
NHOrus [Sun, 2 Jul 2017 21:04:44 +0000 (00:04 +0300)]
Don't spk in wave and action

6 years agoMore magic number elimination
NHOrus [Sun, 2 Jul 2017 19:57:12 +0000 (22:57 +0300)]
More magic number elimination

6 years agoUnfalsify coverage check
NHOrus [Sun, 2 Jul 2017 19:27:41 +0000 (22:27 +0300)]
Unfalsify coverage check

6 years agoMagic-number elimination.
Eric S. Raymond [Sun, 2 Jul 2017 19:32:50 +0000 (15:32 -0400)]
Magic-number elimination.

6 years agoMore tests, multilined yaml
NHOrus [Sun, 2 Jul 2017 19:13:14 +0000 (22:13 +0300)]
More tests, multilined yaml

6 years agoMagic-number elimination.
Eric S. Raymond [Sun, 2 Jul 2017 18:47:21 +0000 (14:47 -0400)]
Magic-number elimination.

6 years agoAttack content and dead bear 195/head
NHOrus [Sun, 2 Jul 2017 18:07:44 +0000 (21:07 +0300)]
Attack content and dead bear

6 years agoImprive coverage of cheat.
Eric S. Raymond [Sun, 2 Jul 2017 17:57:01 +0000 (13:57 -0400)]
Imprive coverage of cheat.

6 years agoCoverage - attack sitting bear
Aaron Traas [Sun, 2 Jul 2017 17:31:47 +0000 (13:31 -0400)]
Coverage - attack sitting bear

6 years agoEliminate the global game.blklin. 194/head
Jason S. Ninneman [Sun, 2 Jul 2017 17:36:51 +0000 (10:36 -0700)]
Eliminate the global game.blklin.

6 years agoRationalize attack logic 192/head
NHOrus [Sun, 2 Jul 2017 16:41:57 +0000 (19:41 +0300)]
Rationalize attack logic
Fix the compiler warnings about bunching ands with ors

6 years agoMagic-number elimination.
Eric S. Raymond [Sun, 2 Jul 2017 17:22:50 +0000 (13:22 -0400)]
Magic-number elimination.

6 years agoBump save file version number. 191/head
Jason S. Ninneman [Sun, 2 Jul 2017 16:54:33 +0000 (09:54 -0700)]
Bump save file version number.

Also add missing space in the version mesage.

6 years agoTest coverage: intransitive lock
Aaron Traas [Sun, 2 Jul 2017 16:49:46 +0000 (12:49 -0400)]
Test coverage: intransitive lock

6 years agoEliminate unreachable code in lock()
Aaron Traas [Sun, 2 Jul 2017 16:49:29 +0000 (12:49 -0400)]
Eliminate unreachable code in lock()

6 years agoAdd capabilities to cheat. Expand testing to cover.
Aaron Traas [Sun, 2 Jul 2017 16:26:04 +0000 (12:26 -0400)]
Add capabilities to cheat. Expand testing to cover.

6 years agoMoved application settings to settings_t struct
Aaron Traas [Sun, 2 Jul 2017 06:46:04 +0000 (02:46 -0400)]
Moved application settings to settings_t struct

Since logfp, oldstyle, and prompt were application settings, rather than
have them all as global vars, move them to a single global var, seperate
from game state, as they aren't, technically, game state, but are
application settings.

6 years agoReplace datime() with just time(). 190/head
Jason S. Ninneman [Sun, 2 Jul 2017 16:42:07 +0000 (09:42 -0700)]
Replace datime() with just time().

Also make the 'savetime' value meaningful.

This removes a separate library dependency on some systems.

6 years agoChange VERSION_SKEW message - save file cersion is now...
Eric S. Raymond [Sun, 2 Jul 2017 16:39:56 +0000 (12:39 -0400)]
Change VERSION_SKEW message - save file cersion is now...

...decoupled from program version.

6 years agoDocumentation polishing.
Eric S. Raymond [Sun, 2 Jul 2017 15:19:29 +0000 (11:19 -0400)]
Documentation polishing.

6 years agoDocumentation polishing.
Eric S. Raymond [Sun, 2 Jul 2017 15:01:32 +0000 (11:01 -0400)]
Documentation polishing.

6 years agoBegin decomposing cond magic numbers.
Eric S. Raymond [Sun, 2 Jul 2017 14:38:17 +0000 (10:38 -0400)]
Begin decomposing cond magic numbers.

6 years agoFixed logic, documented it in notes and tests 188/head
NHOrus [Sun, 2 Jul 2017 14:50:42 +0000 (17:50 +0300)]
Fixed logic, documented it in notes and tests

6 years agoFixed regression in #21 Cleaned up logic of light/extinguish
NHOrus [Sun, 2 Jul 2017 13:27:20 +0000 (16:27 +0300)]
Fixed regression in #21 Cleaned up logic of light/extinguish

6 years agoFix for issue #21, hopefully
NHOrus [Sun, 2 Jul 2017 13:08:57 +0000 (16:08 +0300)]
Fix for issue #21, hopefully

6 years agoreally capture it
NHOrus [Sun, 2 Jul 2017 08:36:29 +0000 (11:36 +0300)]
really capture it

6 years agoCapture current state of bugs, for #21
NHOrus [Sun, 2 Jul 2017 08:16:29 +0000 (11:16 +0300)]
Capture current state of bugs, for #21

6 years agoCapture wonkyness of extinguishing urn
NHOrus [Sun, 2 Jul 2017 07:50:07 +0000 (10:50 +0300)]
Capture wonkyness of extinguishing urn

6 years agomore tests
NHOrus [Sun, 2 Jul 2017 07:16:03 +0000 (10:16 +0300)]
more tests

6 years agoAbility to use non-standard FreeBSD gcov tool
NHOrus [Sun, 2 Jul 2017 06:49:18 +0000 (09:49 +0300)]
Ability to use non-standard FreeBSD gcov tool

6 years agoMake include of dependency platform-generic
NHOrus [Sun, 2 Jul 2017 06:28:18 +0000 (09:28 +0300)]
Make include of dependency platform-generic

6 years agoLocalize scope for restore file pointer in main. 186/head
Aaron Traas [Sun, 2 Jul 2017 06:28:58 +0000 (02:28 -0400)]
Localize scope for restore file pointer in main.

6 years agoCoverage -- version command
Aaron Traas [Sun, 2 Jul 2017 06:14:41 +0000 (02:14 -0400)]
Coverage -- version command

6 years agocentralize calls to make_zzword()
Aaron Traas [Sun, 2 Jul 2017 06:02:09 +0000 (02:02 -0400)]
centralize calls to make_zzword()

make_zzword() now called in set_seed(), because the only times it was
called in the entire application is after every invocation of set_seed().

6 years agoFixed -r option. Added test to make sure it doesn't break later.
Aaron Traas [Sun, 2 Jul 2017 05:36:28 +0000 (01:36 -0400)]
Fixed -r option. Added test to make sure it doesn't break later.

6 years agoChanged usage message to multi-line string for cheat
Aaron Traas [Sun, 2 Jul 2017 05:17:14 +0000 (01:17 -0400)]
Changed usage message to multi-line string for cheat

6 years agomake_zzword() moved to initialize. Pruned unused stuff from cheat.c
Aaron Traas [Sun, 2 Jul 2017 05:07:53 +0000 (01:07 -0400)]
make_zzword() moved to initialize. Pruned unused stuff from cheat.c

6 years agoImprove test coverage.
Eric S. Raymond [Sun, 2 Jul 2017 03:51:24 +0000 (23:51 -0400)]
Improve test coverage.

6 years agoRewrite dwarf-encounter ceck so coverage testing sees all predicates.
Eric S. Raymond [Sun, 2 Jul 2017 03:33:57 +0000 (23:33 -0400)]
Rewrite dwarf-encounter ceck so coverage testing sees all predicates.

6 years agoMore magic-number elimination.
Eric S. Raymond [Sun, 2 Jul 2017 03:07:23 +0000 (23:07 -0400)]
More magic-number elimination.

6 years agoMagic-number elimination.
Eric S. Raymond [Sun, 2 Jul 2017 02:50:08 +0000 (22:50 -0400)]
Magic-number elimination.

6 years agoFix typo in data comments
Wayne Conrad [Sat, 1 Jul 2017 21:25:29 +0000 (14:25 -0700)]
Fix typo in data comments

6 years agoFix typo in notes
Wayne Conrad [Sat, 1 Jul 2017 21:24:41 +0000 (14:24 -0700)]
Fix typo in notes

6 years agoSupply missing implementation of nodwarf bit in travel rules.
Eric S. Raymond [Sat, 1 Jul 2017 22:56:46 +0000 (18:56 -0400)]
Supply missing implementation of nodwarf bit in travel rules.

6 years agoAnother step in de-obscurifying the travel code.
Eric S. Raymond [Sat, 1 Jul 2017 18:20:34 +0000 (14:20 -0400)]
Another step in de-obscurifying the travel code.

6 years agoRefactor specials[] to have strings instead of enum references. 184/head
Jason S. Ninneman [Sat, 1 Jul 2017 18:53:54 +0000 (11:53 -0700)]
Refactor specials[] to have strings instead of enum references.

Clean up arbitrary_messages[] accordingly.

6 years agoMinor refactor - create an equality function to simplify skip logic.
Eric S. Raymond [Sat, 1 Jul 2017 18:03:01 +0000 (14:03 -0400)]
Minor refactor - create an equality function to simplify skip logic.

6 years agoNever write the input prompt to log files. 183/head
Jason S. Ninneman [Sat, 1 Jul 2017 18:03:20 +0000 (11:03 -0700)]
Never write the input prompt to log files.

6 years agoForther break apart the magic enconding of travel arrays.
Eric S. Raymond [Sat, 1 Jul 2017 16:51:12 +0000 (12:51 -0400)]
Forther break apart the magic enconding of travel arrays.

6 years agoRemove debris from a misclick.
Eric S. Raymond [Sat, 1 Jul 2017 16:40:12 +0000 (12:40 -0400)]
Remove debris from a misclick.

6 years agoIgnore l g z i under oldstyle.
Eric S. Raymond [Sat, 1 Jul 2017 16:34:44 +0000 (12:34 -0400)]
Ignore l g z i under oldstyle.

6 years agoChange state of vase 182/head
NHOrus [Sat, 1 Jul 2017 15:23:51 +0000 (18:23 +0300)]
Change state of vase
Clear temporary save where it needs to be cleared instead of random places

6 years agoDo not compare state to magic numbers
NHOrus [Sat, 1 Jul 2017 15:12:25 +0000 (18:12 +0300)]
Do not compare state to magic numbers

6 years agoLittle more less magic in dragon state
NHOrus [Sat, 1 Jul 2017 14:44:58 +0000 (17:44 +0300)]
Little more less magic in dragon state

6 years agoDocumentation polishing.
Eric S. Raymond [Sat, 1 Jul 2017 15:01:06 +0000 (11:01 -0400)]
Documentation polishing.

6 years agoEnsure libedit is installed for the pipeline jobs. 181/head
Jason S. Ninneman [Sat, 1 Jul 2017 14:29:53 +0000 (07:29 -0700)]
Ensure libedit is installed for the pipeline jobs.

6 years agoAttempt to unbreak pipeline.
Jason S. Ninneman [Sat, 1 Jul 2017 14:27:37 +0000 (07:27 -0700)]
Attempt to unbreak pipeline.

6 years agoJettison the -s option. 180/head
Jason S. Ninneman [Sat, 1 Jul 2017 14:22:12 +0000 (07:22 -0700)]
Jettison the -s option.

It's no longer needed since libedit doesn't have the 'paste bug'.

6 years agoRemove the linenoise submodule.
Jason S. Ninneman [Sat, 1 Jul 2017 14:17:35 +0000 (07:17 -0700)]
Remove the linenoise submodule.

6 years agoMove most build instructions into INSTALL.adoc.
Jason S. Ninneman [Sat, 1 Jul 2017 14:14:27 +0000 (07:14 -0700)]
Move most build instructions into INSTALL.adoc.

6 years agoUpdate documentation about the libedit conversion.
Jason S. Ninneman [Sat, 1 Jul 2017 13:59:39 +0000 (06:59 -0700)]
Update documentation about the libedit conversion.

6 years agoReplace linenoise with libedit in code and build.
Jason S. Ninneman [Sat, 1 Jul 2017 13:51:00 +0000 (06:51 -0700)]
Replace linenoise with libedit in code and build.

6 years agoMagic-number elimination for dragon and rug.
Eric S. Raymond [Sat, 1 Jul 2017 13:58:45 +0000 (09:58 -0400)]
Magic-number elimination for dragon and rug.

6 years agoReindend, compile out all save stuff 179/head
NHOrus [Sat, 1 Jul 2017 13:46:51 +0000 (16:46 +0300)]
Reindend, compile out all save stuff

6 years agoPut stuff back in init, C-style
NHOrus [Sat, 1 Jul 2017 13:45:42 +0000 (16:45 +0300)]
Put stuff back in init, C-style

6 years agoApply DEMOTE_WORD(). 178/head
Jason S. Ninneman [Sat, 1 Jul 2017 13:21:37 +0000 (06:21 -0700)]
Apply DEMOTE_WORD().

6 years agoMagic-number and state-arithmetic removal.
Eric S. Raymond [Sat, 1 Jul 2017 13:21:04 +0000 (09:21 -0400)]
Magic-number and state-arithmetic removal.

6 years agoAdd a DEMOTE_WORD() macro. 177/head
Jason S. Ninneman [Sat, 1 Jul 2017 13:18:24 +0000 (06:18 -0700)]
Add a DEMOTE_WORD() macro.

6 years agoInterim magic number replacement.
Jason S. Ninneman [Sat, 1 Jul 2017 13:15:54 +0000 (06:15 -0700)]
Interim magic number replacement.