X-Git-Url: https://jxself.org/git/?p=open-adventure.git;a=blobdiff_plain;f=notes.adoc;h=3c568ce008a42b11bef13e28cec034b1365e1bfc;hp=5994b54e80de547aaec85fdda492571e4b0f9b98;hb=b84a2392a1ab43b2beee2c01b10c4663c887b1a3;hpb=4a4c113624239b55b176ee23ed8e23c2337d42e2 diff --git a/notes.adoc b/notes.adoc index 5994b54..3c568ce 100644 --- a/notes.adoc +++ b/notes.adoc @@ -13,7 +13,7 @@ the game; Jason signed on early in the process to help. The assistance of Peje Nilsson in restructuring some particularly grotty gotos is gratefully acknowledged. Petr Voropaev contributed fuzz testing and code cleanups. Aaron Traas did a lot of painstaking work to improve -test coverage. +test coverage, and factored out the last handful of gotos. == Nomenclature == @@ -116,8 +116,7 @@ ugly and quite unreadable. Jason Ninneman and I have moved it to what is almost, but not quite, idiomatic modern C. We refactored the right way, checking correctness against a comprehensive test suite that we built first and verified -with coverage tools (we have over 98% coverage, with the remaining -confined to exception cases that are very difficult to reach). This is +with coverage tools (there is effectively 100% code coverage). This is what you are running when you do "make check". The move to modern C entailed some structural changes. The most @@ -153,10 +152,6 @@ ways: and the choice to refrain will make forward translation into future languages easier. -* There are a few gotos left that resist restructuring; all are in the - principal command interpreter function implementing its state - machine. - * Linked lists (for objects at a location) are implemented using an array of link indices. This is a surviving FORTRANism that is quite unlike normal practice in C or any more modern language. We have not tried @@ -175,6 +170,6 @@ We have made exactly one minor architectural change. In addition to the old code's per-object state-description messages, we now have a per-object message series for state *changes*. This makes it possible to pull a fair amount of text out of the arbitrary-messages list and associate those -mesages with the objects that conceptually own them. +messages with the objects that conceptually own them. // end