X-Git-Url: https://jxself.org/git/?p=open-adventure.git;a=blobdiff_plain;f=notes.adoc;h=14ba9e30438206c6b2de68235f8fbe04f9ac7d10;hp=4119d612ab7e9c6da41415b3ae2656a024510f40;hb=83f432780a89718de95d41166db8a6eef22e2eee;hpb=bbdaa0717201b54c5e2717bd64f5fd12e19550d0 diff --git a/notes.adoc b/notes.adoc index 4119d61..14ba9e3 100644 --- a/notes.adoc +++ b/notes.adoc @@ -13,7 +13,7 @@ the game; Jason signed on early in the process to help. The assistance of Peje Nilsson in restructuring some particularly grotty gotos is gratefully acknowledged. Petr Voropaev contributed fuzz testing and code cleanups. Aaron Traas did a lot of painstaking work to improve -test coverage. +test coverage, and factored out the last handful of gotos. == Nomenclature == @@ -58,6 +58,10 @@ Bug fixes: incorrect most places it appeared and has been replaced by "A crystal bridge spans the fissure." (timeless present). +* A few minor typos have been corrected: absence of capitalization on + "Swiss" and "Persian", inconsistent selling of "imbedded" vs. "embedded", + "eying" for "eyeing". "thresholds" for "threshholds". + * Under odd circumstances (dropping rug or vase outdoors) the game could say "floor" when it should say "ground" (or "dirt", or something). @@ -128,7 +132,7 @@ The original code was greatly complicated by a kind of bit-packing that was performed because the FORTRAN it was written in had no string type. Text from the adventure.text file was compiled into sequences of sixbit code points in a restricted character set, packed 5 to a -32-bit word (it seems clear from the code that words were originally +32-bit word (and it seems clear from the code that words were originally *6* chars each packed into a PDP-10 36-bit word). A command noun or verb was one of these words, and what would be string operations in a more recent language were all done on sequences of these words. @@ -152,10 +156,6 @@ ways: and the choice to refrain will make forward translation into future languages easier. -* There are a few gotos left that resist restructuring; all are in the - principal command interpreter function implementing its state - machine. - * Linked lists (for objects at a location) are implemented using an array of link indices. This is a surviving FORTRANism that is quite unlike normal practice in C or any more modern language. We have not tried @@ -174,6 +174,6 @@ We have made exactly one minor architectural change. In addition to the old code's per-object state-description messages, we now have a per-object message series for state *changes*. This makes it possible to pull a fair amount of text out of the arbitrary-messages list and associate those -mesages with the objects that conceptually own them. +messages with the objects that conceptually own them. // end