X-Git-Url: https://jxself.org/git/?p=open-adventure.git;a=blobdiff_plain;f=main.c;h=027f92d46ba00fa5bd4c4541ca52737944dbcdbd;hp=c27ac1ce1935350f84856a5c8b74dc77ad7d3a5b;hb=08f77c692a84d836e494c8cd469f5ac00524cf1c;hpb=42a42c49ac16602933344d5c1f6236cb9683afd4 diff --git a/main.c b/main.c index c27ac1c..027f92d 100644 --- a/main.c +++ b/main.c @@ -972,6 +972,13 @@ static void listobjects(void) } } +void clear_command(command_t *cmd) +{ + cmd->verb = ACT_NULL; + game.oldobj = cmd->obj; + cmd->obj = NO_OBJECT; +} + static bool do_command() /* Get and execute a command */ { @@ -1035,12 +1042,8 @@ static bool do_command() rspeak(SAYS_PLUGH); listobjects(); - -Lclearobj: - command.verb = ACT_NULL; - game.oldobj = command.obj; - command.obj = NO_OBJECT; - + clear_command(&command); + Lcheckhint: checkhints(); @@ -1060,9 +1063,6 @@ Lcheckhint: if (game.knfloc > 0 && game.knfloc != game.loc) game.knfloc = 0; - /* Preserve state from last command for reuse when required */ - command_t preserve = command; - // Get command input from user if (!get_command_input(&command)) return false; @@ -1073,12 +1073,6 @@ Lclosecheck: const char *types[] = {"NO_WORD_TYPE", "MOTION", "OBJECT", "ACTION", "NUMERIC"}; /* needs to stay synced with enum speechpart */ const char *roles[] = {"unknown", "intransitive", "transitive"}; - printf("Preserve: role = %s type1 = %s, id1 = %ld, type2 = %s, id2 = %ld\n", - roles[preserve.part], - types[preserve.word[0].type], - preserve.word[0].id, - types[preserve.word[1].type], - preserve.word[1].id); printf("Command: role = %s type1 = %s, id1 = %ld, type2 = %s, id2 = %ld\n", roles[command.part], types[command.word[0].type], @@ -1087,10 +1081,6 @@ Lclosecheck: command.word[1].id); #endif - /* Handle of objectless action followed by actionless object */ - if (preserve.word[0].type == ACTION && preserve.word[1].type == NO_WORD_TYPE && command.word[1].id == 0) - command.verb = preserve.verb; - ++game.turns; if (closecheck()) { @@ -1106,7 +1096,8 @@ Lclosecheck: else rspeak(WHERE_QUERY); - goto Lclearobj; + clear_command(&command); + goto Lcheckhint; } if (command.word[0].type == OBJECT) { @@ -1159,7 +1150,8 @@ Lookup: if (command.word[0].id == WORD_NOT_FOUND) { /* Gee, I don't understand. */ sspeak(DONT_KNOW, command.word[0].raw); - goto Lclearobj; + clear_command(&command); + goto Lcheckhint; } switch (command.word[0].type) { case NO_WORD_TYPE: // FIXME: treating NO_WORD_TYPE as a motion word is confusing @@ -1180,7 +1172,8 @@ Lookup: case NUMERIC: if (!settings.oldstyle) { sspeak(DONT_KNOW, command.word[0].raw); - goto Lclearobj; + clear_command(&command); + goto Lcheckhint; } default: // LCOV_EXCL_LINE BUG(VOCABULARY_TYPE_N_OVER_1000_NOT_BETWEEN_0_AND_3); // LCOV_EXCL_LINE @@ -1194,7 +1187,8 @@ Lookup: case GO_TOP: continue; /* back to top of main interpreter loop */ case GO_CLEAROBJ: - goto Lclearobj; + clear_command(&command); + /* FALL THROUGH */ case GO_CHECKHINT: goto Lcheckhint; case GO_WORD2: