X-Git-Url: https://jxself.org/git/?p=open-adventure.git;a=blobdiff_plain;f=actions.c;h=5433a7dad1c0839b90e09f4b2264a66302d64784;hp=efa52a6bf9adecafe5db8c2ea85de6fb03c297af;hb=08c40bc9993ce5684077b9ceac492e4fb642a722;hpb=8d9c8e4d5c035213bb41abc64c59fb25672e8e50 diff --git a/actions.c b/actions.c index efa52a6..5433a7d 100644 --- a/actions.c +++ b/actions.c @@ -201,15 +201,14 @@ static int bigwords(long id) * crossing. */ if (game.place[EGGS] == LOC_NOWHERE && game.place[TROLL] == LOC_NOWHERE && game.prop[TROLL] == TROLL_UNPAID) game.prop[TROLL] = TROLL_PAIDONCE; - int k; if (HERE(EGGS)) - k = EGGS_VANISHED; + pspeak(EGGS, look, EGGS_VANISHED, true); else if (game.loc == objects[EGGS].plac) - k = EGGS_HERE; + pspeak(EGGS, look, EGGS_HERE, true); else - k = EGGS_DONE; + pspeak(EGGS, look, EGGS_DONE, true); move(EGGS, objects[EGGS].plac); - pspeak(EGGS, look, k, true); + return GO_CLEAROBJ; } } else { @@ -266,6 +265,7 @@ static int vbreak(verb_t verb, obj_t obj) game.fixed[VASE] = IS_FIXED; break; } + /* FALLTHRU */ default: speak(actions[verb].message); } @@ -592,6 +592,7 @@ static int eat(verb_t verb, obj_t obj) case INTRANSITIVE: if (!HERE(FOOD)) return GO_UNKNOWN; + /* FALLTHRU */ case FOOD: DESTROY(FOOD); rspeak(THANKS_DELICIOUS); @@ -1142,17 +1143,11 @@ static int rub(verb_t verb, obj_t obj) } static int say(struct command_t *command) -/* Say. Echo WD2 (or WD1 if no WD2 (SAY WHAT?, etc.).) Magic words override. */ +/* Say. Echo WD2. Magic words override. */ { - if (command->wd2 > 0) { - command->wd1 = command->wd2; - strncpy(command->raw1, command->raw2, LINESIZE - 1); - } - char word1[TOKLEN + 1]; - packed_to_token(command->wd1, word1); long wd; enum wordtype type; - get_vocab_metadata(word1, &wd, &type); + get_vocab_metadata(command->raw2, &wd, &type); if (wd == XYZZY || wd == PLUGH || wd == PLOVER || @@ -1162,11 +1157,9 @@ static int say(struct command_t *command) wd == FOO || wd == FUM || wd == PART) { - /* FIXME: scribbles on the interpreter's command block */ - wordclear(&command->wd2); - return GO_LOOKUP; + return GO_WORD2; } - sspeak(OKEY_DOKEY, command->raw1); + sspeak(OKEY_DOKEY, command->raw2); return GO_CLEAROBJ; } @@ -1316,14 +1309,14 @@ int action(struct command_t *command) if (game.loc == LOC_START || game.loc == LOC_VALLEY || game.loc == LOC_SLIT) { - command->obj = DPRSSN; + command->obj = DEPRESSION; } if (game.loc == LOC_COBBLE || game.loc == LOC_DEBRIS || game.loc == LOC_AWKWARD || game.loc == LOC_BIRD || game.loc == LOC_PITTOP) { - command->obj = ENTRNC; + command->obj = ENTRANCE; } } else if (command->obj == DWARF && atdwrf(game.loc) > 0) /* FALL THROUGH */; @@ -1359,10 +1352,13 @@ int action(struct command_t *command) switch (command->part) { case intransitive: - if (command->wd2 > 0 && command->verb != SAY) + if (command->raw2[0] != '\0' && command->verb != SAY) return GO_WORD2; if (command->verb == SAY) - command->obj = command->wd2; + /* KEYS is not special, anything not NO_OBJECT or INTRANSITIVE + * will do here. We're preventing interpretation as an intransitive + * verb when the word is unknown. */ + command->obj = command->raw2[0] != '\0' ? KEYS : NO_OBJECT; if (command->obj == NO_OBJECT || command->obj == INTRANSITIVE) { /* Analyse an intransitive verb (ie, no object given yet). */