X-Git-Url: https://jxself.org/git/?p=open-adventure.git;a=blobdiff_plain;f=TODO;h=429052847b5b7b9b703d39e4cb1d8fc4330caf30;hp=37857feb7015fb6501f11ad3eb43fb59b26389d1;hb=HEAD;hpb=55610bb1de8f861af7567d8b6d8ab47006148fce diff --git a/TODO b/TODO deleted file mode 100644 index 37857fe..0000000 --- a/TODO +++ /dev/null @@ -1,21 +0,0 @@ -= Open Adventure TODO = - -The FORTRANish mess that once was is now mostly idiomatic C. Some issues -remain to be cleaned up: - -* The remaining shared globals: K, SPK, WD1, WD1X, WD2, WD2X. These are used - rather promiscuously to pass around information that ought to be function - arguments in a modern language. K and SPK are particular offenders - -* Remaining unstructured gotos in playermove() and do_command(). The goto L12 - in playermove() is particularly horrible, jumping backwards into the - middle of a loop. - -* In playermove(), why doesn't replacing the global motion number K - with a passed-in argument work? There's some unobvious information - leak here. - -* The way return values from handlers such as 2012 trigger side effects - based on global state such as K and SPK is nasty. - -