Remove extraneous listing of files

[open-adventure.git] / tests / Makefile

diff --git a/tests/Makefile b/tests/Makefile
index b364432475082e487d58b2af6b27bd81cd09a4e5..fc4801fc11e4378b6542f30c3d250f37d64117e5 100644 (file)
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -3,7 +3,8 @@
 # Use absolute path so tests that change working directory still use
 # scripts from parent directory.  Note that using $PWD seems to fail
 # here under Gitlab's CI environment.
-PATH := $(realpath ..):$(realpath .):${PATH}
+PARDIR=$(realpath ..)
+PATH := $(PARDIR):$(realpath .):${PATH}
 GCOV?=gcov
 
 # Make this overrideable so it's easier to test old versions
@@ -24,9 +25,9 @@ check: savecheck regress
        @-advent -l /dev/null <pitfall.log >/dev/null
 
 coverage: check
-       lcov -t "advent" -o ../advent.info -c -d .. --gcov-tool=$(GCOV)
-       genhtml -o ../coverage/ ../advent.info
-       python3 coverage_dungeon.py
+       lcov -t "advent" -o $(PARDIR)/advent.info -c -d $(PARDIR) --gcov-tool=$(GCOV)
+       genhtml -o $(PARDIR)/coverage/ $(PARDIR)/advent.info
+       ./coverage_dungeon.py
 
 .SUFFIXES: .chk
 
@@ -43,22 +44,24 @@ listcheck:
 
 # Generate bogus savegames.
 savegames:
+       @$(ECHO) "cheat: Generate save file with -900 deaths"
+       @$(PARDIR)/cheat -d -900 -o cheat_numdie.adv > /tmp/cheat_numdie
        @$(ECHO) "cheat: Generate save file with -1000 deaths"
-       @../cheat -d -1000 -o cheat_numdie.adv > /tmp/cheat_numdie
+       @$(PARDIR)/cheat -d -1000 -o cheat_numdie1000.adv > /tmp/cheat_numdie1000
        @$(ECHO) "cheat: Generate save file with version -1337"
-       @../cheat -v -1337 -o resume_badversion.adv > /tmp/cheat_badversion
+       @$(PARDIR)/cheat -v -1337 -o resume_badversion.adv > /tmp/cheat_badversion
        @$(ECHO) "cheat: Generate save file 1000 saves"
-       @../cheat -s -1000 -o thousand_saves.adv > /tmp/cheat_1000saves
+       @$(PARDIR)/cheat -s -1000 -o thousand_saves.adv > /tmp/cheat_1000saves
        @$(ECHO) "cheat: Generate save file 1000 turns"
-       @../cheat -t -1000 -o thousand_saves.adv > /tmp/cheat_1000turns
+       @$(PARDIR)/cheat -t -1000 -o thousand_saves.adv > /tmp/cheat_1000turns
        @$(ECHO) "cheat: Generate save file 1000 turns"
-       @../cheat -l -1000 -o thousand_lamp.adv > /tmp/cheat_1000lamp
+       @$(PARDIR)/cheat -l -1000 -o thousand_lamp.adv > /tmp/cheat_1000lamp
        @rm -f /tmp/cheat*
 
 
 # Rebuild characterizing tests
 buildregress: savegames
-       ../cheat -s -1000 -o thousand_saves.adv > /tmp/regress1000saves
+       $(PARDIR)/cheat -s -1000 -o thousand_saves.adv > /tmp/regress1000saves
        @for file in $(TESTLOADS); do \
            echo "Remaking $${file}.chk"; \
            OPTS=`sed -n /#options:/s///p <$${file}.log`; \
@@ -68,16 +71,16 @@ buildregress: savegames
 
 savecheck: savegames
        @$(ECHO) "TEST cheat: Bogus option for save file generation"
-       @../cheat -QqQ 2> /tmp/coverage_cheat_batopt | true
+       @$(PARDIR)/cheat -QqQ 2> /tmp/coverage_cheat_batopt | true
        @$(ECHO) "TEST cheat: No save file specified"
-       @../cheat 2>/dev/null | true
+       @$(PARDIR)/cheat 2>/dev/null | true
        @$(ECHO) "TEST cheat: Fail to save because we omit -o"
-       @../cheat -d 1 2> /tmp/coverage_cheat_nooutput | true
+       @$(PARDIR)/cheat -d 1 2> /tmp/coverage_cheat_nooutput | true
        @$(ECHO) "TEST cheat: Fail to save to invalid path"
-       @../cheat -o / 2> /tmp/coverage_cheat_badoutput | true
+       @$(PARDIR)/cheat -o / 2> /tmp/coverage_cheat_badoutput | true
        @$(ECHO) "TEST advent: Start with invalid file with -r"
        @advent -r /badfilename < pitfall.log > /tmp/coverage_advent_readfail 2>&1 || exit 1
-       @$(ECHO) "TEST advent: Start with invalid file with -r"
+       @$(ECHO) "TEST advent: Start with invalid file with -l"
        @advent -l / < pitfall.log > /tmp/coverage_advent_logfail 2>&1 || exit 1
        @$(ECHO) "TEST advent: Test -r with valid input"
        @advent -r thousand_saves.adv < pitfall.log > /tmp/coverage_advent_readfail 2>&1 || exit 1