From: Ulf Magnusson <ulfalizer@gmail.com>
Date: Sun, 8 Oct 2017 17:35:44 +0000 (+0200)
Subject: kconfig: Fix automatic menu creation mem leak
X-Git-Url: https://jxself.org/git/?p=carl9170fw.git;a=commitdiff_plain;h=43aa2e536b483b7b4b4b29776fabcb1bc2ca4d02;hp=7a1eeacf618f59e1f56b6743c642719230523664

kconfig: Fix automatic menu creation mem leak

expr_trans_compare() always allocates and returns a new expression,
giving the following leak outline:

	...
	*Allocate*
	basedep = expr_trans_compare(basedep, E_UNEQUAL, &symbol_no);
	...
	for (menu = parent->next; menu; menu = menu->next) {
		...
		*Copy*
		dep2 = expr_copy(basedep);
		...
		*Free copy*
		expr_free(dep2);
	}
	*basedep lost!*

Fix by freeing 'basedep' after the loop.

Summary from Valgrind on 'menuconfig' (ARCH=x86) before the fix:

	LEAK SUMMARY:
	   definitely lost: 344,376 bytes in 14,349 blocks
	   ...

Summary after the fix:

	LEAK SUMMARY:
	   definitely lost: 44,448 bytes in 1,852 blocks
	   ...

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
---

diff --git a/config/menu.c b/config/menu.c
index 2baebe3..5b24159 100644
--- a/config/menu.c
+++ b/config/menu.c
@@ -440,6 +440,7 @@ void menu_finalize(struct menu *parent)
 			menu->parent = parent;
 			last_menu = menu;
 		}
+		expr_free(basedep);
 		if (last_menu) {
 			parent->list = parent->next;
 			parent->next = last_menu->next;