kconfig: Fix choice symbol expression leak
[carl9170fw.git] / config / menu.c
1 /*
2  * Copyright (C) 2002 Roman Zippel <zippel@linux-m68k.org>
3  * Released under the terms of the GNU GPL v2.0.
4  */
5
6 #include <ctype.h>
7 #include <stdarg.h>
8 #include <stdlib.h>
9 #include <string.h>
10
11 #include "lkc.h"
12
13 static const char nohelp_text[] = "There is no help available for this option.";
14
15 struct menu rootmenu;
16 static struct menu **last_entry_ptr;
17
18 struct file *file_list;
19 struct file *current_file;
20
21 void menu_warn(struct menu *menu, const char *fmt, ...)
22 {
23         va_list ap;
24         va_start(ap, fmt);
25         fprintf(stderr, "%s:%d:warning: ", menu->file->name, menu->lineno);
26         vfprintf(stderr, fmt, ap);
27         fprintf(stderr, "\n");
28         va_end(ap);
29 }
30
31 static void prop_warn(struct property *prop, const char *fmt, ...)
32 {
33         va_list ap;
34         va_start(ap, fmt);
35         fprintf(stderr, "%s:%d:warning: ", prop->file->name, prop->lineno);
36         vfprintf(stderr, fmt, ap);
37         fprintf(stderr, "\n");
38         va_end(ap);
39 }
40
41 void _menu_init(void)
42 {
43         current_entry = current_menu = &rootmenu;
44         last_entry_ptr = &rootmenu.list;
45 }
46
47 void menu_add_entry(struct symbol *sym)
48 {
49         struct menu *menu;
50
51         menu = xmalloc(sizeof(*menu));
52         memset(menu, 0, sizeof(*menu));
53         menu->sym = sym;
54         menu->parent = current_menu;
55         menu->file = current_file;
56         menu->lineno = zconf_lineno();
57
58         *last_entry_ptr = menu;
59         last_entry_ptr = &menu->next;
60         current_entry = menu;
61         if (sym)
62                 menu_add_symbol(P_SYMBOL, sym, NULL);
63 }
64
65 void menu_end_entry(void)
66 {
67 }
68
69 struct menu *menu_add_menu(void)
70 {
71         menu_end_entry();
72         last_entry_ptr = &current_entry->list;
73         return current_menu = current_entry;
74 }
75
76 void menu_end_menu(void)
77 {
78         last_entry_ptr = &current_menu->next;
79         current_menu = current_menu->parent;
80 }
81
82 /*
83  * Rewrites 'm' to 'm' && MODULES, so that it evaluates to 'n' when running
84  * without modules
85  */
86 static struct expr *rewrite_m(struct expr *e)
87 {
88         if (!e)
89                 return e;
90
91         switch (e->type) {
92         case E_NOT:
93                 e->left.expr = rewrite_m(e->left.expr);
94                 break;
95         case E_OR:
96         case E_AND:
97                 e->left.expr = rewrite_m(e->left.expr);
98                 e->right.expr = rewrite_m(e->right.expr);
99                 break;
100         case E_SYMBOL:
101                 /* change 'm' into 'm' && MODULES */
102                 if (e->left.sym == &symbol_mod)
103                         return expr_alloc_and(e, expr_alloc_symbol(modules_sym));
104                 break;
105         default:
106                 break;
107         }
108         return e;
109 }
110
111 void menu_add_dep(struct expr *dep)
112 {
113         current_entry->dep = expr_alloc_and(current_entry->dep, dep);
114 }
115
116 void menu_set_type(int type)
117 {
118         struct symbol *sym = current_entry->sym;
119
120         if (sym->type == type)
121                 return;
122         if (sym->type == S_UNKNOWN) {
123                 sym->type = type;
124                 return;
125         }
126         menu_warn(current_entry,
127                 "ignoring type redefinition of '%s' from '%s' to '%s'",
128                 sym->name ? sym->name : "<choice>",
129                 sym_type_name(sym->type), sym_type_name(type));
130 }
131
132 static struct property *menu_add_prop(enum prop_type type, char *prompt, struct expr *expr, struct expr *dep)
133 {
134         struct property *prop = prop_alloc(type, current_entry->sym);
135
136         prop->menu = current_entry;
137         prop->expr = expr;
138         prop->visible.expr = dep;
139
140         if (prompt) {
141                 if (isspace(*prompt)) {
142                         prop_warn(prop, "leading whitespace ignored");
143                         while (isspace(*prompt))
144                                 prompt++;
145                 }
146                 if (current_entry->prompt && current_entry != &rootmenu)
147                         prop_warn(prop, "prompt redefined");
148
149                 /* Apply all upper menus' visibilities to actual prompts. */
150                 if(type == P_PROMPT) {
151                         struct menu *menu = current_entry;
152
153                         while ((menu = menu->parent) != NULL) {
154                                 struct expr *dup_expr;
155
156                                 if (!menu->visibility)
157                                         continue;
158                                 /*
159                                  * Do not add a reference to the
160                                  * menu's visibility expression but
161                                  * use a copy of it.  Otherwise the
162                                  * expression reduction functions
163                                  * will modify expressions that have
164                                  * multiple references which can
165                                  * cause unwanted side effects.
166                                  */
167                                 dup_expr = expr_copy(menu->visibility);
168
169                                 prop->visible.expr
170                                         = expr_alloc_and(prop->visible.expr,
171                                                          dup_expr);
172                         }
173                 }
174
175                 current_entry->prompt = prop;
176         }
177         prop->text = prompt;
178
179         return prop;
180 }
181
182 struct property *menu_add_prompt(enum prop_type type, char *prompt, struct expr *dep)
183 {
184         return menu_add_prop(type, prompt, NULL, dep);
185 }
186
187 void menu_add_visibility(struct expr *expr)
188 {
189         current_entry->visibility = expr_alloc_and(current_entry->visibility,
190             expr);
191 }
192
193 void menu_add_expr(enum prop_type type, struct expr *expr, struct expr *dep)
194 {
195         menu_add_prop(type, NULL, expr, dep);
196 }
197
198 void menu_add_symbol(enum prop_type type, struct symbol *sym, struct expr *dep)
199 {
200         menu_add_prop(type, NULL, expr_alloc_symbol(sym), dep);
201 }
202
203 void menu_add_option(int token, char *arg)
204 {
205         switch (token) {
206         case T_OPT_MODULES:
207                 if (modules_sym)
208                         zconf_error("symbol '%s' redefines option 'modules'"
209                                     " already defined by symbol '%s'",
210                                     current_entry->sym->name,
211                                     modules_sym->name
212                                     );
213                 modules_sym = current_entry->sym;
214                 break;
215         case T_OPT_DEFCONFIG_LIST:
216                 if (!sym_defconfig_list)
217                         sym_defconfig_list = current_entry->sym;
218                 else if (sym_defconfig_list != current_entry->sym)
219                         zconf_error("trying to redefine defconfig symbol");
220                 break;
221         case T_OPT_ENV:
222                 prop_add_env(arg);
223                 break;
224         case T_OPT_ALLNOCONFIG_Y:
225                 current_entry->sym->flags |= SYMBOL_ALLNOCONFIG_Y;
226                 break;
227         }
228 }
229
230 static int menu_validate_number(struct symbol *sym, struct symbol *sym2)
231 {
232         return sym2->type == S_INT || sym2->type == S_HEX ||
233                (sym2->type == S_UNKNOWN && sym_string_valid(sym, sym2->name));
234 }
235
236 static void sym_check_prop(struct symbol *sym)
237 {
238         struct property *prop;
239         struct symbol *sym2;
240         char *use;
241
242         for (prop = sym->prop; prop; prop = prop->next) {
243                 switch (prop->type) {
244                 case P_DEFAULT:
245                         if ((sym->type == S_STRING || sym->type == S_INT || sym->type == S_HEX) &&
246                             prop->expr->type != E_SYMBOL)
247                                 prop_warn(prop,
248                                     "default for config symbol '%s'"
249                                     " must be a single symbol", sym->name);
250                         if (prop->expr->type != E_SYMBOL)
251                                 break;
252                         sym2 = prop_get_symbol(prop);
253                         if (sym->type == S_HEX || sym->type == S_INT) {
254                                 if (!menu_validate_number(sym, sym2))
255                                         prop_warn(prop,
256                                             "'%s': number is invalid",
257                                             sym->name);
258                         }
259                         if (sym_is_choice(sym)) {
260                                 struct property *choice_prop =
261                                         sym_get_choice_prop(sym2);
262
263                                 if (!choice_prop ||
264                                     prop_get_symbol(choice_prop) != sym)
265                                         prop_warn(prop,
266                                                   "choice default symbol '%s' is not contained in the choice",
267                                                   sym2->name);
268                         }
269                         break;
270                 case P_SELECT:
271                 case P_IMPLY:
272                         use = prop->type == P_SELECT ? "select" : "imply";
273                         sym2 = prop_get_symbol(prop);
274                         if (sym->type != S_BOOLEAN && sym->type != S_TRISTATE)
275                                 prop_warn(prop,
276                                     "config symbol '%s' uses %s, but is "
277                                     "not boolean or tristate", sym->name, use);
278                         else if (sym2->type != S_UNKNOWN &&
279                                  sym2->type != S_BOOLEAN &&
280                                  sym2->type != S_TRISTATE)
281                                 prop_warn(prop,
282                                     "'%s' has wrong type. '%s' only "
283                                     "accept arguments of boolean and "
284                                     "tristate type", sym2->name, use);
285                         break;
286                 case P_RANGE:
287                         if (sym->type != S_INT && sym->type != S_HEX)
288                                 prop_warn(prop, "range is only allowed "
289                                                 "for int or hex symbols");
290                         if (!menu_validate_number(sym, prop->expr->left.sym) ||
291                             !menu_validate_number(sym, prop->expr->right.sym))
292                                 prop_warn(prop, "range is invalid");
293                         break;
294                 default:
295                         ;
296                 }
297         }
298 }
299
300 void menu_finalize(struct menu *parent)
301 {
302         struct menu *menu, *last_menu;
303         struct symbol *sym;
304         struct property *prop;
305         struct expr *parentdep, *basedep, *dep, *dep2, **ep;
306
307         sym = parent->sym;
308         if (parent->list) {
309                 /*
310                  * This menu node has children. We (recursively) process them
311                  * and propagate parent dependencies before moving on.
312                  */
313
314                 if (sym && sym_is_choice(sym)) {
315                         if (sym->type == S_UNKNOWN) {
316                                 /* find the first choice value to find out choice type */
317                                 current_entry = parent;
318                                 for (menu = parent->list; menu; menu = menu->next) {
319                                         if (menu->sym && menu->sym->type != S_UNKNOWN) {
320                                                 menu_set_type(menu->sym->type);
321                                                 break;
322                                         }
323                                 }
324                         }
325                         /* set the type of the remaining choice values */
326                         for (menu = parent->list; menu; menu = menu->next) {
327                                 current_entry = menu;
328                                 if (menu->sym && menu->sym->type == S_UNKNOWN)
329                                         menu_set_type(sym->type);
330                         }
331                         parentdep = expr_alloc_symbol(sym);
332                 } else if (parent->prompt)
333                         parentdep = parent->prompt->visible.expr;
334                 else
335                         parentdep = parent->dep;
336
337                 /* For each child menu node... */
338                 for (menu = parent->list; menu; menu = menu->next) {
339                         /*
340                          * Propagate parent dependencies to the child menu
341                          * node, also rewriting and simplifying expressions
342                          */
343                         basedep = rewrite_m(menu->dep);
344                         basedep = expr_transform(basedep);
345                         basedep = expr_alloc_and(expr_copy(parentdep), basedep);
346                         basedep = expr_eliminate_dups(basedep);
347                         menu->dep = basedep;
348
349                         if (menu->sym)
350                                 /*
351                                  * Note: For symbols, all prompts are included
352                                  * too in the symbol's own property list
353                                  */
354                                 prop = menu->sym->prop;
355                         else
356                                 /*
357                                  * For non-symbol menu nodes, we just need to
358                                  * handle the prompt
359                                  */
360                                 prop = menu->prompt;
361
362                         /* For each property... */
363                         for (; prop; prop = prop->next) {
364                                 if (prop->menu != menu)
365                                         /*
366                                          * Two possibilities:
367                                          *
368                                          * 1. The property lacks dependencies
369                                          *    and so isn't location-specific,
370                                          *    e.g. an 'option'
371                                          *
372                                          * 2. The property belongs to a symbol
373                                          *    defined in multiple locations and
374                                          *    is from some other location. It
375                                          *    will be handled there in that
376                                          *    case.
377                                          *
378                                          * Skip the property.
379                                          */
380                                         continue;
381
382                                 /*
383                                  * Propagate parent dependencies to the
384                                  * property's condition, rewriting and
385                                  * simplifying expressions at the same time
386                                  */
387                                 dep = rewrite_m(prop->visible.expr);
388                                 dep = expr_transform(dep);
389                                 dep = expr_alloc_and(expr_copy(basedep), dep);
390                                 dep = expr_eliminate_dups(dep);
391                                 if (menu->sym && menu->sym->type != S_TRISTATE)
392                                         dep = expr_trans_bool(dep);
393                                 prop->visible.expr = dep;
394
395                                 /*
396                                  * Handle selects and implies, which modify the
397                                  * dependencies of the selected/implied symbol
398                                  */
399                                 if (prop->type == P_SELECT) {
400                                         struct symbol *es = prop_get_symbol(prop);
401                                         es->rev_dep.expr = expr_alloc_or(es->rev_dep.expr,
402                                                         expr_alloc_and(expr_alloc_symbol(menu->sym), expr_copy(dep)));
403                                 } else if (prop->type == P_IMPLY) {
404                                         struct symbol *es = prop_get_symbol(prop);
405                                         es->implied.expr = expr_alloc_or(es->implied.expr,
406                                                         expr_alloc_and(expr_alloc_symbol(menu->sym), expr_copy(dep)));
407                                 }
408                         }
409                 }
410
411                 if (sym && sym_is_choice(sym))
412                         expr_free(parentdep);
413
414                 /*
415                  * Recursively process children in the same fashion before
416                  * moving on
417                  */
418                 for (menu = parent->list; menu; menu = menu->next)
419                         menu_finalize(menu);
420         } else if (sym) {
421                 basedep = parent->prompt ? parent->prompt->visible.expr : NULL;
422                 basedep = expr_trans_compare(basedep, E_UNEQUAL, &symbol_no);
423                 basedep = expr_eliminate_dups(expr_transform(basedep));
424                 last_menu = NULL;
425                 for (menu = parent->next; menu; menu = menu->next) {
426                         dep = menu->prompt ? menu->prompt->visible.expr : menu->dep;
427                         if (!expr_contains_symbol(dep, sym))
428                                 break;
429                         if (expr_depends_symbol(dep, sym))
430                                 goto next;
431                         dep = expr_trans_compare(dep, E_UNEQUAL, &symbol_no);
432                         dep = expr_eliminate_dups(expr_transform(dep));
433                         dep2 = expr_copy(basedep);
434                         expr_eliminate_eq(&dep, &dep2);
435                         expr_free(dep);
436                         if (!expr_is_yes(dep2)) {
437                                 expr_free(dep2);
438                                 break;
439                         }
440                         expr_free(dep2);
441                 next:
442                         menu_finalize(menu);
443                         menu->parent = parent;
444                         last_menu = menu;
445                 }
446                 expr_free(basedep);
447                 if (last_menu) {
448                         parent->list = parent->next;
449                         parent->next = last_menu->next;
450                         last_menu->next = NULL;
451                 }
452
453                 sym->dir_dep.expr = expr_alloc_or(sym->dir_dep.expr, parent->dep);
454         }
455         for (menu = parent->list; menu; menu = menu->next) {
456                 if (sym && sym_is_choice(sym) &&
457                     menu->sym && !sym_is_choice_value(menu->sym)) {
458                         current_entry = menu;
459                         menu->sym->flags |= SYMBOL_CHOICEVAL;
460                         if (!menu->prompt)
461                                 menu_warn(menu, "choice value must have a prompt");
462                         for (prop = menu->sym->prop; prop; prop = prop->next) {
463                                 if (prop->type == P_DEFAULT)
464                                         prop_warn(prop, "defaults for choice "
465                                                   "values not supported");
466                                 if (prop->menu == menu)
467                                         continue;
468                                 if (prop->type == P_PROMPT &&
469                                     prop->menu->parent->sym != sym)
470                                         prop_warn(prop, "choice value used outside its choice group");
471                         }
472                         /* Non-tristate choice values of tristate choices must
473                          * depend on the choice being set to Y. The choice
474                          * values' dependencies were propagated to their
475                          * properties above, so the change here must be re-
476                          * propagated.
477                          */
478                         if (sym->type == S_TRISTATE && menu->sym->type != S_TRISTATE) {
479                                 basedep = expr_alloc_comp(E_EQUAL, sym, &symbol_yes);
480                                 menu->dep = expr_alloc_and(basedep, menu->dep);
481                                 for (prop = menu->sym->prop; prop; prop = prop->next) {
482                                         if (prop->menu != menu)
483                                                 continue;
484                                         prop->visible.expr = expr_alloc_and(expr_copy(basedep),
485                                                                             prop->visible.expr);
486                                 }
487                         }
488                         menu_add_symbol(P_CHOICE, sym, NULL);
489                         prop = sym_get_choice_prop(sym);
490                         for (ep = &prop->expr; *ep; ep = &(*ep)->left.expr)
491                                 ;
492                         *ep = expr_alloc_one(E_LIST, NULL);
493                         (*ep)->right.sym = menu->sym;
494                 }
495                 if (menu->list && (!menu->prompt || !menu->prompt->text)) {
496                         for (last_menu = menu->list; ; last_menu = last_menu->next) {
497                                 last_menu->parent = parent;
498                                 if (!last_menu->next)
499                                         break;
500                         }
501                         last_menu->next = menu->next;
502                         menu->next = menu->list;
503                         menu->list = NULL;
504                 }
505         }
506
507         if (sym && !(sym->flags & SYMBOL_WARNED)) {
508                 if (sym->type == S_UNKNOWN)
509                         menu_warn(parent, "config symbol defined without type");
510
511                 if (sym_is_choice(sym) && !parent->prompt)
512                         menu_warn(parent, "choice must have a prompt");
513
514                 /* Check properties connected to this symbol */
515                 sym_check_prop(sym);
516                 sym->flags |= SYMBOL_WARNED;
517         }
518
519         if (sym && !sym_is_optional(sym) && parent->prompt) {
520                 sym->rev_dep.expr = expr_alloc_or(sym->rev_dep.expr,
521                                 expr_alloc_and(parent->prompt->visible.expr,
522                                         expr_alloc_symbol(&symbol_mod)));
523         }
524 }
525
526 bool menu_has_prompt(struct menu *menu)
527 {
528         if (!menu->prompt)
529                 return false;
530         return true;
531 }
532
533 /*
534  * Determine if a menu is empty.
535  * A menu is considered empty if it contains no or only
536  * invisible entries.
537  */
538 bool menu_is_empty(struct menu *menu)
539 {
540         struct menu *child;
541
542         for (child = menu->list; child; child = child->next) {
543                 if (menu_is_visible(child))
544                         return(false);
545         }
546         return(true);
547 }
548
549 bool menu_is_visible(struct menu *menu)
550 {
551         struct menu *child;
552         struct symbol *sym;
553         tristate visible;
554
555         if (!menu->prompt)
556                 return false;
557
558         if (menu->visibility) {
559                 if (expr_calc_value(menu->visibility) == no)
560                         return false;
561         }
562
563         sym = menu->sym;
564         if (sym) {
565                 sym_calc_value(sym);
566                 visible = menu->prompt->visible.tri;
567         } else
568                 visible = menu->prompt->visible.tri = expr_calc_value(menu->prompt->visible.expr);
569
570         if (visible != no)
571                 return true;
572
573         if (!sym || sym_get_tristate_value(menu->sym) == no)
574                 return false;
575
576         for (child = menu->list; child; child = child->next) {
577                 if (menu_is_visible(child)) {
578                         if (sym)
579                                 sym->flags |= SYMBOL_DEF_USER;
580                         return true;
581                 }
582         }
583
584         return false;
585 }
586
587 const char *menu_get_prompt(struct menu *menu)
588 {
589         if (menu->prompt)
590                 return menu->prompt->text;
591         else if (menu->sym)
592                 return menu->sym->name;
593         return NULL;
594 }
595
596 struct menu *menu_get_root_menu(struct menu *menu)
597 {
598         return &rootmenu;
599 }
600
601 struct menu *menu_get_parent_menu(struct menu *menu)
602 {
603         enum prop_type type;
604
605         for (; menu != &rootmenu; menu = menu->parent) {
606                 type = menu->prompt ? menu->prompt->type : 0;
607                 if (type == P_MENU)
608                         break;
609         }
610         return menu;
611 }
612
613 bool menu_has_help(struct menu *menu)
614 {
615         return menu->help != NULL;
616 }
617
618 const char *menu_get_help(struct menu *menu)
619 {
620         if (menu->help)
621                 return menu->help;
622         else
623                 return "";
624 }
625
626 static void get_prompt_str(struct gstr *r, struct property *prop,
627                            struct list_head *head)
628 {
629         int i, j;
630         struct menu *submenu[8], *menu, *location = NULL;
631         struct jump_key *jump = NULL;
632
633         str_printf(r, _("Prompt: %s\n"), _(prop->text));
634         menu = prop->menu->parent;
635         for (i = 0; menu != &rootmenu && i < 8; menu = menu->parent) {
636                 bool accessible = menu_is_visible(menu);
637
638                 submenu[i++] = menu;
639                 if (location == NULL && accessible)
640                         location = menu;
641         }
642         if (head && location) {
643                 jump = xmalloc(sizeof(struct jump_key));
644
645                 if (menu_is_visible(prop->menu)) {
646                         /*
647                          * There is not enough room to put the hint at the
648                          * beginning of the "Prompt" line. Put the hint on the
649                          * last "Location" line even when it would belong on
650                          * the former.
651                          */
652                         jump->target = prop->menu;
653                 } else
654                         jump->target = location;
655
656                 if (list_empty(head))
657                         jump->index = 0;
658                 else
659                         jump->index = list_entry(head->prev, struct jump_key,
660                                                  entries)->index + 1;
661
662                 list_add_tail(&jump->entries, head);
663         }
664
665         if (i > 0) {
666                 str_printf(r, _("  Location:\n"));
667                 for (j = 4; --i >= 0; j += 2) {
668                         menu = submenu[i];
669                         if (jump && menu == location)
670                                 jump->offset = strlen(r->s);
671                         str_printf(r, "%*c-> %s", j, ' ',
672                                    _(menu_get_prompt(menu)));
673                         if (menu->sym) {
674                                 str_printf(r, " (%s [=%s])", menu->sym->name ?
675                                         menu->sym->name : _("<choice>"),
676                                         sym_get_string_value(menu->sym));
677                         }
678                         str_append(r, "\n");
679                 }
680         }
681 }
682
683 /*
684  * get property of type P_SYMBOL
685  */
686 static struct property *get_symbol_prop(struct symbol *sym)
687 {
688         struct property *prop = NULL;
689
690         for_all_properties(sym, prop, P_SYMBOL)
691                 break;
692         return prop;
693 }
694
695 static void get_symbol_props_str(struct gstr *r, struct symbol *sym,
696                                  enum prop_type tok, const char *prefix)
697 {
698         bool hit = false;
699         struct property *prop;
700
701         for_all_properties(sym, prop, tok) {
702                 if (!hit) {
703                         str_append(r, prefix);
704                         hit = true;
705                 } else
706                         str_printf(r, " && ");
707                 expr_gstr_print(prop->expr, r);
708         }
709         if (hit)
710                 str_append(r, "\n");
711 }
712
713 /*
714  * head is optional and may be NULL
715  */
716 static void get_symbol_str(struct gstr *r, struct symbol *sym,
717                     struct list_head *head)
718 {
719         struct property *prop;
720
721         if (sym && sym->name) {
722                 str_printf(r, "Symbol: %s [=%s]\n", sym->name,
723                            sym_get_string_value(sym));
724                 str_printf(r, "Type  : %s\n", sym_type_name(sym->type));
725                 if (sym->type == S_INT || sym->type == S_HEX) {
726                         prop = sym_get_range_prop(sym);
727                         if (prop) {
728                                 str_printf(r, "Range : ");
729                                 expr_gstr_print(prop->expr, r);
730                                 str_append(r, "\n");
731                         }
732                 }
733         }
734         for_all_prompts(sym, prop)
735                 get_prompt_str(r, prop, head);
736
737         prop = get_symbol_prop(sym);
738         if (prop) {
739                 str_printf(r, _("  Defined at %s:%d\n"), prop->menu->file->name,
740                         prop->menu->lineno);
741                 if (!expr_is_yes(prop->visible.expr)) {
742                         str_append(r, _("  Depends on: "));
743                         expr_gstr_print(prop->visible.expr, r);
744                         str_append(r, "\n");
745                 }
746         }
747
748         get_symbol_props_str(r, sym, P_SELECT, _("  Selects: "));
749         if (sym->rev_dep.expr) {
750                 str_append(r, _("  Selected by: "));
751                 expr_gstr_print(sym->rev_dep.expr, r);
752                 str_append(r, "\n");
753         }
754
755         get_symbol_props_str(r, sym, P_IMPLY, _("  Implies: "));
756         if (sym->implied.expr) {
757                 str_append(r, _("  Implied by: "));
758                 expr_gstr_print(sym->implied.expr, r);
759                 str_append(r, "\n");
760         }
761
762         str_append(r, "\n\n");
763 }
764
765 struct gstr get_relations_str(struct symbol **sym_arr, struct list_head *head)
766 {
767         struct symbol *sym;
768         struct gstr res = str_new();
769         int i;
770
771         for (i = 0; sym_arr && (sym = sym_arr[i]); i++)
772                 get_symbol_str(&res, sym, head);
773         if (!i)
774                 str_append(&res, _("No matches found.\n"));
775         return res;
776 }
777
778
779 void menu_get_ext_help(struct menu *menu, struct gstr *help)
780 {
781         struct symbol *sym = menu->sym;
782         const char *help_text = nohelp_text;
783
784         if (menu_has_help(menu)) {
785                 if (sym->name)
786                         str_printf(help, "%s%s:\n\n", CONFIG_, sym->name);
787                 help_text = menu_get_help(menu);
788         }
789         str_printf(help, "%s\n", _(help_text));
790         if (sym)
791                 get_symbol_str(help, sym, NULL);
792 }