From 69f7043e7a2223e25cc525161a2de45d293d21d0 Mon Sep 17 00:00:00 2001 From: Christian Lamparter Date: Sun, 1 Jul 2012 02:14:04 +0200 Subject: [PATCH] carl9170 firmware: add note about BAR tx status issues The workaround will be implemented in the driver as the firmware can't efficiently deal with BA responses. Signed-off-by: Christian Lamparter --- carlfw/src/wlan.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/carlfw/src/wlan.c b/carlfw/src/wlan.c index cc25055..e581fa8 100644 --- a/carlfw/src/wlan.c +++ b/carlfw/src/wlan.c @@ -345,6 +345,16 @@ static bool wlan_tx_status(struct dma_queue *queue, /* update hangcheck */ fw.wlan.last_super_num[qidx] = 0; + /* + * Note: + * There could be a corner case when the TXFAIL is set + * even though the frame was properly ACKed by the peer: + * a BlockAckReq with the immediate policy will cause + * the receiving peer to produce a BlockACK unfortunately + * the MAC in this chip seems to be expecting a legacy + * ACK and marks the BAR as failed! + */ + if (!!(desc->ctrl & AR9170_CTRL_FAIL)) { txfail = !!(desc->ctrl & AR9170_CTRL_TXFAIL); -- 2.31.1