From d163400e0dd5cee9517305c2d6b2644ac75e1d1c Mon Sep 17 00:00:00 2001 From: Christian Lamparter Date: Sat, 20 Oct 2012 19:12:49 +0200 Subject: [PATCH] carl9170 firmware: add note about rx filter usage This patch adds a note about what it means when a rx filter bit is set. Because unlike what most people assume, it means that the data which matches the condition is discarded and not "passed to the host". Reported-by: Javier Lopez Signed-off-by: Christian Lamparter --- include/shared/fwcmd.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/include/shared/fwcmd.h b/include/shared/fwcmd.h index 9443c80..9111d4f 100644 --- a/include/shared/fwcmd.h +++ b/include/shared/fwcmd.h @@ -156,6 +156,14 @@ struct carl9170_psm { } __packed; #define CARL9170_PSM_SIZE 4 +/* + * Note: If a bit in rx_filter is set, then it + * means that the particular frames which matches + * the condition are FILTERED/REMOVED/DISCARDED! + * (This is can be a bit confusing, especially + * because someone people think it's the exact + * opposite way, so watch out!) + */ struct carl9170_rx_filter_cmd { __le32 rx_filter; } __packed; -- 2.31.1