From: Juerg Haefliger <juergh@proton.me>
Date: Fri, 10 Feb 2023 09:31:51 +0000 (+0100)
Subject: annotations: Fix pylint violations
X-Git-Tag: v0.1~28
X-Git-Url: https://jxself.org/git/?a=commitdiff_plain;h=f827825327a6c36cfdf62d1fdb6f005fbcbee750;p=annotations.git

annotations: Fix pylint violations

Fix the following:
R1722: Consider using sys.exit() (consider-using-sys-exit)
C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
W0703: Catching too general exception Exception (broad-except)
W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
C0411: standard import "from signal import signal, SIGPIPE, SIG_DFL" should be placed before "from kconfig.annotations import Annotation, KConfig" (wrong-import-order)

Signed-off-by: Juerg Haefliger <juergh@proton.me>
---

diff --git a/annotations b/annotations
index 7e7ff5e..ea6bc9b 100755
--- a/annotations
+++ b/annotations
@@ -8,9 +8,10 @@ sys.dont_write_bytecode = True
 import os
 import argparse
 import json
-from kconfig.annotations import Annotation, KConfig
 from signal import signal, SIGPIPE, SIG_DFL
 
+from kconfig.annotations import Annotation, KConfig
+
 VERSION = '0.1'
 
 SKIP_CONFIGS = (
@@ -76,7 +77,7 @@ _ARGPARSER = make_parser()
 def arg_fail(message):
     print(message)
     _ARGPARSER.print_usage()
-    exit(1)
+    sys.exit(1)
 
 
 def print_result(config, res):
@@ -96,7 +97,8 @@ def do_query(args):
 def do_autocomplete(args):
     a = Annotation(args.file)
     res = (c.removeprefix('CONFIG_') for c in a.search_config())
-    print('complete -W "{}" annotations'.format(' '.join(res)))
+    res_str = ' '.join(res)
+    print(f'complete -W "{res_str}" annotations')
 
 
 def do_source(args):
@@ -104,7 +106,7 @@ def do_source(args):
         arg_fail('error: --source requires --config')
     if not os.path.exists('tags'):
         print('tags not found in the current directory, try: `make tags`')
-        exit(1)
+        sys.exit(1)
     os.system(f'vim -t {args.config}')
 
 
@@ -221,7 +223,7 @@ def do_check(args):
         total += 1
 
     print(f"check-config: {good}/{total} checks passed -- exit {ret}")
-    exit(ret)
+    sys.exit(ret)
 
 
 def autodetect_annotations(args):
@@ -230,9 +232,9 @@ def autodetect_annotations(args):
     # If --file/-f isn't specified try to automatically determine the right
     # location of the annotations file looking at debian/debian.env.
     try:
-        with open('debian/debian.env', 'rt') as fd:
+        with open('debian/debian.env', 'rt', encoding='utf-8') as fd:
             args.file = fd.read().rstrip().split('=')[1] + '/config/annotations'
-    except Exception:
+    except (FileNotFoundError, IndexError):
         arg_fail('error: could not determine DEBDIR, try using: --file/-f')