From: Mario Limonciello <mario.limonciello@amd.com>
Date: Thu, 31 Aug 2023 04:03:33 +0000 (-0500)
Subject: Fix carl9170fw shell scripts for shellcheck errors
X-Git-Url: https://jxself.org/git/?a=commitdiff_plain;h=f497d778ef6fdf5791bbd86aa0247b8d67d3a79e;p=carl9170fw.git

Fix carl9170fw shell scripts for shellcheck errors

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
---

diff --git a/autogen.sh b/autogen.sh
index a360065..85f011d 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -24,6 +24,7 @@ case "$1" in
 			exit 1
 		fi
 
+		# shellcheck source=/dev/null
 		. ./.config
 		make
 
@@ -40,7 +41,7 @@ case "$1" in
 		fi
 
 		install -m 644 carlfw/carl9170.fw \
-			../carl9170-$CONFIG_CARL9170FW_RELEASE_VERSION.fw
+			../carl9170-"$CONFIG_CARL9170FW_RELEASE_VERSION".fw
 		echo "done."
 	;;
 
diff --git a/genapi.sh b/genapi.sh
index 8912cc6..ae9f330 100755
--- a/genapi.sh
+++ b/genapi.sh
@@ -3,9 +3,9 @@
 cat <<EOF > include/shared/version.h
 #ifndef __CARL9170_SHARED_VERSION_H
 #define __CARL9170_SHARED_VERSION_H
-#define CARL9170FW_VERSION_YEAR $((100`date +%Y`%100))
-#define CARL9170FW_VERSION_MONTH $((100`date +%m`%100))
-#define CARL9170FW_VERSION_DAY $((100`date +%d`%100))
-#define CARL9170FW_VERSION_GIT "`git describe 2>/dev/null`"
+#define CARL9170FW_VERSION_YEAR $((100$(date +%Y)%100))
+#define CARL9170FW_VERSION_MONTH $((100$(date +%m)%100))
+#define CARL9170FW_VERSION_DAY $((100$(date +%d)%100))
+#define CARL9170FW_VERSION_GIT $(git describe 2>/dev/null)
 #endif /* __CARL9170_SHARED_VERSION_H */
 EOF