From: Eric S. Raymond <esr@thyrsus.com>
Date: Fri, 30 Jun 2017 16:10:26 +0000 (-0400)
Subject: Less magical numbers.
X-Git-Tag: takebird~180
X-Git-Url: https://jxself.org/git/?a=commitdiff_plain;h=8675c4facd154b9;p=open-adventure.git

Less magical numbers.
---

diff --git a/actions.c b/actions.c
index fbd7f55..0f17bea 100644
--- a/actions.c
+++ b/actions.c
@@ -966,8 +966,8 @@ static int say(struct command_t *command)
     char word1[6];
     packed_to_token(command->wd1, word1);
     int wd = (int) get_vocab_id(word1);
-    /* FIXME: issue in lexical analyzer, last two magic numbers can't change */
-    if (wd == XYZZY || wd == PLUGH || wd == PLOVER || wd == 2025 || wd == 2034) {
+    /* FIXME: magic numbers */
+    if (wd == XYZZY || wd == PLUGH || wd == PLOVER || wd == 2000 + GIANTWORDS || wd == 2000 + PART) {
         /* FIXME: scribbles on the interpreter's command block */
         wordclear(&command->wd2);
         return GO_LOOKUP;