From: Alexander Popov <alex.popov@linux.com>
Date: Wed, 8 Jun 2022 22:03:19 +0000 (+0300)
Subject: Turn some error conditions into assertions (part 4)
X-Git-Tag: v0.6.1~143
X-Git-Url: https://jxself.org/git/?a=commitdiff_plain;h=55164d26f50133027deb9928c8fa607c7427fd65;p=kconfig-hardened-check.git

Turn some error conditions into assertions (part 4)
---

diff --git a/kconfig_hardened_check/__init__.py b/kconfig_hardened_check/__init__.py
index 0ed7dd3..fea8272 100644
--- a/kconfig_hardened_check/__init__.py
+++ b/kconfig_hardened_check/__init__.py
@@ -747,10 +747,10 @@ def populate_simple_opt_with_data(opt, data, data_type):
 
     if data_type in ('kconfig', 'cmdline'):
         opt.state = data.get(opt.name, None)
-    elif data_type == 'version':
-        opt.ver = data
     else:
-        sys.exit('[!] ERROR: unexpected data type "{}"'.format(data_type))
+        assert(data_type == 'version'), \
+               'unexpected data type "{}"'.format(data_type)
+        opt.ver = data
 
 
 def populate_opt_with_data(opt, data, data_type):
@@ -762,8 +762,8 @@ def populate_opt_with_data(opt, data, data_type):
             else:
                 populate_simple_opt_with_data(o, data, data_type)
     else:
-        if opt.type not in ('kconfig', 'cmdline'):
-            sys.exit('[!] ERROR: bad type "{}" for a simple check {}'.format(opt.type, opt.name))
+        assert(opt.type in ('kconfig', 'cmdline')), \
+               'bad type "{}" for a simple check'.format(opt.type)
         populate_simple_opt_with_data(opt, data, data_type)