From: Adrian Chadd Date: Sun, 16 Nov 2014 02:36:17 +0000 (-0800) Subject: Merge pull request #67 from IanR778/timestamp_fix X-Git-Tag: 1.4.0~1 X-Git-Url: https://jxself.org/git/?a=commitdiff_plain;h=1bce676df33ed9ce2b53a95ef3a04e80b6a41e77;hp=b568900f35cef12a8440a6a449474b00c1206a79;p=open-ath9k-htc-firmware.git Merge pull request #67 from IanR778/timestamp_fix Timestamp fix - looks good! Thanks! --- diff --git a/target_firmware/wlan/ar5416_hw.c b/target_firmware/wlan/ar5416_hw.c index 3f3c4bc..4d2a9f4 100644 --- a/target_firmware/wlan/ar5416_hw.c +++ b/target_firmware/wlan/ar5416_hw.c @@ -275,14 +275,23 @@ ar5416SetInterrupts(struct ath_hal *ah, HAL_INT ints) /* TSF Handling */ /****************/ +#define ATH9K_HTC_MAX_TSF_READ 3 + u_int64_t ar5416GetTsf64(struct ath_hal *ah) { - u_int64_t tsf; - - tsf = ioread32_mac(AR_TSF_U32); - tsf = (tsf << 32) | ioread32_mac(AR_TSF_L32); + a_uint32_t tsf_lower, tsf_upper1, tsf_upper2; + a_int32_t i; + + tsf_upper1 = ioread32_mac(AR_TSF_U32); + for (i = 0; i < ATH9K_HTC_MAX_TSF_READ; i++) { + tsf_lower = ioread32_mac(AR_TSF_L32); + tsf_upper2 = ioread32_mac(AR_TSF_U32); + if (tsf_upper2 == tsf_upper1) + break; + tsf_upper1 = tsf_upper2; + } - return tsf; + return (((u_int64_t)tsf_upper2 << 32) | tsf_lower); } /******/ diff --git a/target_firmware/wlan/if_ath.c b/target_firmware/wlan/if_ath.c index 864f48f..2d6a7f7 100755 --- a/target_firmware/wlan/if_ath.c +++ b/target_firmware/wlan/if_ath.c @@ -82,26 +82,36 @@ void ath_tgt_tx_sched_normal(struct ath_softc_tgt *sc, struct ath_buf *bf); void ath_tgt_tx_sched_nonaggr(struct ath_softc_tgt *sc,struct ath_buf * bf_host); /* - * Extend a 32 bit TSF to 64 bit, taking wrapping into account. + * Extend a 32 bit TSF to nearest 64 bit TSF value. + * When the adapter is a STATION, its local TSF is periodically modified by + * the hardware to match the BSS TSF (as received in beacon packets), and + * rstamp may appear to be from the future or from the past (with reference + * to the current local TSF) because of jitter. This is mostly noticable in + * highly congested channels. The code uses signed modulo arithmetic to + * handle both past/future cases and signed-extension to avoid branches. + * Test cases: + * extend(0x0000001200000004, 0x00000006) == 0x0000001200000006 + * extend(0x0000001200000004, 0x00000002) == 0x0000001200000002 + * extend(0x0000001200000004, 0xfffffffe) == 0x00000011fffffffe ! tsfhigh-- + * extend(0x000000127ffffffe, 0x80000002) == 0x0000001280000002 + * extend(0x0000001280000002, 0x7ffffffe) == 0x000000127ffffffe + * extend(0x00000012fffffffc, 0xfffffffe) == 0x00000012fffffffe + * extend(0x00000012fffffffc, 0xfffffffa) == 0x00000012fffffffa + * extend(0x00000012fffffffc, 0x00000002) == 0x0000001300000002 ! tsfhigh++ */ static u_int64_t ath_extend_tsf(struct ath_softc_tgt *sc, u_int32_t rstamp) { struct ath_hal *ah = sc->sc_ah; u_int64_t tsf; u_int32_t tsf_low; - u_int64_t tsf64; + a_int64_t tsf_delta; /* signed int64 */ tsf = ah->ah_getTsf64(ah); - tsf_low = tsf & 0xffffffff; - tsf64 = (tsf & ~0xffffffffULL) | rstamp; + tsf_low = tsf & 0xffffffffUL; - if (rstamp > tsf_low && (rstamp - tsf_low > 0x10000000)) - tsf64 -= 0x100000000ULL; + tsf_delta = (a_int32_t)((rstamp - tsf_low) & 0xffffffffUL); - if (rstamp < tsf_low && (tsf_low - rstamp > 0x10000000)) - tsf64 += 0x100000000ULL; - - return tsf64; + return (tsf + (u_int64_t)tsf_delta); } static a_int32_t ath_rate_setup(struct ath_softc_tgt *sc, a_uint32_t mode)