From: Eric S. Raymond Date: Sun, 11 Jun 2017 13:24:52 +0000 (-0400) Subject: Questions for the future. X-Git-Tag: 1.1~433 X-Git-Url: https://jxself.org/git/?a=commitdiff_plain;ds=sidebyside;h=55610bb1de8f861af7567d8b6d8ab47006148fce;p=open-adventure.git Questions for the future. --- diff --git a/TODO b/TODO index f8dc544..37857fe 100644 --- a/TODO +++ b/TODO @@ -7,7 +7,13 @@ remain to be cleaned up: rather promiscuously to pass around information that ought to be function arguments in a modern language. K and SPK are particular offenders -* Remaining unstructured gotos in playermove() and do_command(). +* Remaining unstructured gotos in playermove() and do_command(). The goto L12 + in playermove() is particularly horrible, jumping backwards into the + middle of a loop. + +* In playermove(), why doesn't replacing the global motion number K + with a passed-in argument work? There's some unobvious information + leak here. * The way return values from handlers such as 2012 trigger side effects based on global state such as K and SPK is nasty.