X-Git-Url: https://jxself.org/git/?a=blobdiff_plain;f=tests%2FMakefile;h=498dbb80a4293e1ffb0c9a604e9b14f5a2103742;hb=7b3b5d32c0eeb2cd516b39a6d84848b23b6d1b9c;hp=a2892a7558273fdbb3eb4a51dff1ad98205d17a1;hpb=49e2479efadce8f678966fc21a6db40b9b2024ac;p=open-adventure.git

diff --git a/tests/Makefile b/tests/Makefile
index a2892a7..498dbb8 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -101,26 +101,32 @@ regress:
 	@(echo "inven" | advent isofoo.log /dev/stdin | diff --text -u multifile.chk -) || exit 1
 	rm -f scratch.tmp /tmp/regress$$$$
 
-# Steps towards TAP and parallelization.
-# There's a blocker in that the log tests can't be run concurrently
-# due to issues with colliding save files.
+# Steps towards TAP. savecheck and the isofoo test are not yet integrated.
 
 # The TAP filter. Only affects presentation of the test suite messages
-TAPCONSUMER=tappy
+TAPCONSUMER=tapview
 
 # Fall back to safety if our declared TAP consumer does not exist.
 # This is helpful in the CI environment, where it would be better for
 # the logfiles to carry the raw TAP messages. 
 TAPFILTER=$(shell command -v $(TAPCONSUMER) || echo cat)
 
-RUN_TARGETS=$(TESTLOADS:%=run-regress-%)
-$(RUN_TARGETS): run-regress-%: %.log
+# Parallel make doesn't return a fail status when a single subprocess fails,
+# so we need to log the failures and check the log for nonemptiness in order
+# to hand a real status back. This is important for CI/CD.  
+FAILLOG=/tmp/advent-test.log
+
+TEST_TARGETS=$(TESTLOADS:%=run-regress-%)
+$(TEST_TARGETS): run-regress-%: %.log
 	@(test=$(<:.log=); legend=$$(sed -n '/^## /s///p' <"$<" 2>/dev/null || echo "(no description)"); \
 	OPTS=`sed -n /#options:/s///p $<`; \
-	$(advent) $$OPTS <$< | tapdiffer "$<: $${legend}" "$${test}.chk")
+	$(advent) $$OPTS <$< | tapdiffer "$<: $${legend}" "$${test}.chk") >>$(FAILLOG)
 
-tap: savecheck count $(RUN_TARGETS)
+tap: count $(TEST_TARGETS)
 count:
-	@echo 1..$(words $(RUN_TARGETS))
+	@echo 1..$(words $(TEST_TARGETS)) >$(FAILLOG)
+
+tapcheck:
+	@make --no-print-directory tap; tapview <$(FAILLOG)
 
 # end