X-Git-Url: https://jxself.org/git/?a=blobdiff_plain;f=notes.adoc;h=fd3504a6f2ce68a4d62668690e3b4542f0cf070e;hb=d4fc7a88b4aac2f72013e7c681c907de09db349d;hp=cc4246c440abadd0b4b0605988261214a9e2ba3a;hpb=60126c3dac4788cd5c01f5da6bb50986aeaac0d3;p=open-adventure.git diff --git a/notes.adoc b/notes.adoc index cc4246c..fd3504a 100644 --- a/notes.adoc +++ b/notes.adoc @@ -11,7 +11,7 @@ The principal maintainers of this code are Eric S. Raymond and Jason Ninneman. Eric received Don Woods's encouragement to update and ship the game; Jason signed on early in the process to help. The assistance of Peje Nilsson in restructuring some particularly grotty gotos is -gratefully acknowledged. +gratefully acknowledged. Petr Voropaev contributed fuzz testing. == Nomenclature == @@ -113,6 +113,7 @@ ways: We don't need whatever minor performance gains this might collect, and the choice to refrain will make forward translation into future languages easier. + * There are a few gotos left that resist restructuring; all of these are in the principal command interpreter function implementing its state machine. @@ -124,10 +125,13 @@ ways: compromise forward-portability to other languages. * The code still has an unfortunately high density of magic numbers - in - particular, numeric object and room IDs. There are plans to fix this. + particular, numeric object IDs. There are plans to fix this. * Much of the code still uses FORTRAN-style uppercase names. +* The code still assumes one-origin array indexing. Thus, arrays are + a cell larger than they strictly need to be and cell 0 is unused. + * The code is still mostly typeless, slinging around machine longs like a FORTRAN or BCPL program. Some (incomplete) effort has been made to introduce semantic types.