X-Git-Url: https://jxself.org/git/?a=blobdiff_plain;f=notes.adoc;h=4a166bd9eb6f8230427a8936c6807fee90c7f07f;hb=e07cedf332029369f2ce09a6f6ced3dda0de2558;hp=8cab27f5184c1a24799ee1c55a71580a4e779852;hpb=8a46a60c8c976073ef958cee0d919bc911a8f944;p=open-adventure.git diff --git a/notes.adoc b/notes.adoc index 8cab27f..4a166bd 100644 --- a/notes.adoc +++ b/notes.adoc @@ -10,7 +10,7 @@ separate link:history.html[history] describing how it came to us. The principal maintainers of this code are Eric S. Raymond and Jason Ninneman. Eric received Don Woods's encouragement to update and ship the game; Jason signed on early in the process to help. The assistance -of Peje Nilson in restructuring some particularly grotty gotos is +of Peje Nilsson in restructuring some particularly grotty gotos is gratefully acknowledged. == Nomenclature == @@ -64,12 +64,12 @@ The adventure.text file is no longer required at runtime. Instead, it is compiled at build time to a source module containing C structures, which is then linked to the advent binary. -The game-save format has changed. This was done to simplify -FORTRAN-derived code that formerly implemented these functions; -without C's fread(3)/fwrite() and structs it was necessarily pretty -ugly by modern standards. Encryption and checksumming have been -discarded - it's pointless to try tamper-proofing saves when everyone -has the source code. +The game-save format has changed. This was done to simplify the +FORTRAN-derived code that formerly implemented the save/restore +functions; without C's fread(3)/fwrite() and structs it was +necessarily pretty ugly by modern standards. Encryption and +checksumming have been discarded - it's pointless to try +tamper-proofing saves when everyone has the source code. == Translation == @@ -79,7 +79,7 @@ ugly and quite unreadable. Jason Ninneman and I have moved it to what is almost, but not quite, idiomatic modern C. We refactored the right way, checking correctness -against a comprehesive test suite that we built first and verified with +against a comprehensive test suite that we built first and verified with coverage tools. This is what you are running when you do "make check". This move entailed some structural changes. The most important was