X-Git-Url: https://jxself.org/git/?a=blobdiff_plain;f=notes.adoc;h=475ca94fa7aea635737685bbb3137f4349f203b7;hb=a48d75b999aa03ba97a2e09787ca0c3c8dfbc1bd;hp=4a166bd9eb6f8230427a8936c6807fee90c7f07f;hpb=89829f45be2f5b481ac101cbe082ba0b6741d955;p=open-adventure.git diff --git a/notes.adoc b/notes.adoc index 4a166bd..475ca94 100644 --- a/notes.adoc +++ b/notes.adoc @@ -79,8 +79,10 @@ ugly and quite unreadable. Jason Ninneman and I have moved it to what is almost, but not quite, idiomatic modern C. We refactored the right way, checking correctness -against a comprehensive test suite that we built first and verified with -coverage tools. This is what you are running when you do "make check". +against a comprehensive test suite that we built first and verified +with coverage tools (we have 88% coverage, with the remaining 12% +confined to exception cases that are difficult to reach). This is +what you are running when you do "make check". This move entailed some structural changes. The most important was the refactoring of over 350 gotos into if/loop/break structures. We @@ -109,7 +111,6 @@ ways: We don't need whatever minor performance gains this might collect, and the choice to refrain will make forward translation into future languages easier. - * There are a few gotos left that resist restructuring; all of these are in the principal command interpreter function implementing its state machine.