X-Git-Url: https://jxself.org/git/?a=blobdiff_plain;f=misc.c;h=d04760266c45903d7897ac100e5091df67069d18;hb=8d409c6b3b911746df45aed2d88db1b37232bbff;hp=cf404f7507f17268e7ab8098ee7cdff0559fcc36;hpb=00c2182d9b21b3d9071b090bad7b168b13322ee3;p=open-adventure.git diff --git a/misc.c b/misc.c index cf404f7..d047602 100644 --- a/misc.c +++ b/misc.c @@ -1,5 +1,5 @@ /* - * I/O and support riutines. + * I/O and support routines. * * Copyright (c) 1977, 2005 by Will Crowther and Don Woods * Copyright (c) 2017 by Eric S. Raymond @@ -221,8 +221,8 @@ static char* get_input(void) // Print a blank line printf("\n"); - char* input; - while (true) { + char* input = ""; + for (;;) { input = myreadline(input_prompt); if (input == NULL) // Got EOF; return with it. @@ -411,7 +411,7 @@ static bool is_valid_int(const char *str) if (!*str) return false; // LCOV_EXCL_LINE - // Check for non-digit chars in the rest of the stirng. + // Check for non-digit chars in the rest of the string. while (*str) { if (!isdigit(*str)) return false; @@ -476,7 +476,7 @@ static void get_vocab_metadata(const char* word, vocab_t* id, word_type_t* type) static void tokenize(char* raw, command_t *cmd) { /* - * Be caereful about modifing this. We do not want to nuke the + * Be careful about modifying this. We do not want to nuke the * the speech part or ID from the previous turn. */ memset(&cmd->word[0].raw, '\0', sizeof(cmd->word[0].raw)); @@ -490,7 +490,7 @@ static void tokenize(char* raw, command_t *cmd) /* (ESR) In oldstyle mode, simulate the uppercasing and truncating * effect on raw tokens of packing them into sixbit characters, 5 * to a 32-bit word. This is something the FORTRAN version did - * becuse archaic FORTRAN had no string types. Don Wood's + * because archaic FORTRAN had no string types. Don Wood's * mechanical translation of 2.5 to C retained the packing and * thus this misfeature. * @@ -617,6 +617,13 @@ void carry(obj_t object, loc_t where) return; game.place[object] = CARRIED; + /* + * Without this conditional your inventory is overcounted + * when you pick up the bird while it's caged. This fixes + * a cosmetic bug in the original. + * + * Possibly this check should be skipped whwn oldstyle is on. + */ if (object != BIRD) ++game.holdng; } @@ -641,7 +648,7 @@ void drop(obj_t object, loc_t where) if (game.place[object] == CARRIED) if (object != BIRD) /* The bird has to be weightless. This ugly hack (and the - * corresponding code in the drop function) brought to you + * corresponding code in the carry function) brought to you * by the fact that when the bird is caged, we need to be able * to either 'take bird' or 'take cage' and have the right thing * happen.