X-Git-Url: https://jxself.org/git/?a=blobdiff_plain;f=TODO;h=ce5d5cbfe1e670a0469e3ab63c90d7d847bf8dbe;hb=e07cedf332029369f2ce09a6f6ced3dda0de2558;hp=f8dc544d5af8234867f339f6dc653e322bfb1b38;hpb=0e160a665eeb24d4614ff14e779d1c13bec3e778;p=open-adventure.git diff --git a/TODO b/TODO index f8dc544..ce5d5cb 100644 --- a/TODO +++ b/TODO @@ -3,13 +3,15 @@ The FORTRANish mess that once was is now mostly idiomatic C. Some issues remain to be cleaned up: -* The remaining shared globals: K, SPK, WD1, WD1X, WD2, WD2X. These are used +* The remaining shared globals: WD1, WD1X, WD2, WD2X. These are used rather promiscuously to pass around information that ought to be function - arguments in a modern language. K and SPK are particular offenders + arguments in a modern language. -* Remaining unstructured gotos in playermove() and do_command(). +* Remaining unstructured gotos in do_command(). + +* The program is still pretty much typeless - full of magic numbers being + sliced and diced in cryptic ways. Some attempt has been made to introduce + semantic types, but the job is barely started. -* The way return values from handlers such as 2012 trigger side effects - based on global state such as K and SPK is nasty.