X-Git-Url: https://jxself.org/git/?a=blobdiff_plain;f=TODO;h=62eef63e12afc119442a1d7813af9bfe4bd8127e;hb=c366ddb7334cf85dba1f0dc75a68a8a094960aa3;hp=6abcb59866ad0c68ac07bac9f51b669acfa3d59f;hpb=04db8370752c6600b05d2059f8a15d1340d380fd;p=open-adventure.git diff --git a/TODO b/TODO index 6abcb59..62eef63 100644 --- a/TODO +++ b/TODO @@ -3,18 +3,14 @@ The FORTRANish mess that once was is now mostly idiomatic C. Some issues remain to be cleaned up: -* The remaining shared globals: K, WD1, WD1X, WD2, WD2X. These are used +* The remaining shared globals: WD1, WD1X, WD2, WD2X. These are used rather promiscuously to pass around information that ought to be function - arguments in a modern language. K is a particular offender. + arguments in a modern language. * Remaining unstructured gotos in playermove() and do_command(). The goto L12 in playermove() is particularly horrible, jumping backwards into the middle of a loop. -* In playermove(), why doesn't replacing the global motion number K - with a passed-in argument work? There's some unobvious information - leak here. - * The way return values from handlers such as 2012 trigger side effects based on global state is nasty.