X-Git-Url: https://jxself.org/git/?a=blobdiff_plain;f=TODO;h=39915afc82993bc247114688e734594c6dc1650a;hb=156b39c34af6b8c866e28dcced79debbdcbdc8a7;hp=37857feb7015fb6501f11ad3eb43fb59b26389d1;hpb=55610bb1de8f861af7567d8b6d8ab47006148fce;p=open-adventure.git diff --git a/TODO b/TODO index 37857fe..39915af 100644 --- a/TODO +++ b/TODO @@ -1,21 +1,5 @@ = Open Adventure TODO = -The FORTRANish mess that once was is now mostly idiomatic C. Some issues -remain to be cleaned up: - -* The remaining shared globals: K, SPK, WD1, WD1X, WD2, WD2X. These are used - rather promiscuously to pass around information that ought to be function - arguments in a modern language. K and SPK are particular offenders - -* Remaining unstructured gotos in playermove() and do_command(). The goto L12 - in playermove() is particularly horrible, jumping backwards into the - middle of a loop. - -* In playermove(), why doesn't replacing the global motion number K - with a passed-in argument work? There's some unobvious information - leak here. - -* The way return values from handlers such as 2012 trigger side effects - based on global state such as K and SPK is nasty. - - +* We are aware that the lamp currently used as the project logo is a + hurricane lamp, not a proper miner's lamp. Submissions of potential + replacement images would be welcome.