X-Git-Url: https://jxself.org/git/?a=blobdiff_plain;f=TODO;h=37857feb7015fb6501f11ad3eb43fb59b26389d1;hb=bcfecca1a138d2b53238e213365d16b9e008881b;hp=8db67c45d6b91a694d4a83b0dd443686a75f31b8;hpb=e0ae1b84b8b48ecada8214510357603541f1360d;p=open-adventure.git diff --git a/TODO b/TODO index 8db67c4..37857fe 100644 --- a/TODO +++ b/TODO @@ -1,5 +1,21 @@ = Open Adventure TODO = -* Translate the FORTRANish mess to actual C. +The FORTRANish mess that once was is now mostly idiomatic C. Some issues +remain to be cleaned up: + +* The remaining shared globals: K, SPK, WD1, WD1X, WD2, WD2X. These are used + rather promiscuously to pass around information that ought to be function + arguments in a modern language. K and SPK are particular offenders + +* Remaining unstructured gotos in playermove() and do_command(). The goto L12 + in playermove() is particularly horrible, jumping backwards into the + middle of a loop. + +* In playermove(), why doesn't replacing the global motion number K + with a passed-in argument work? There's some unobvious information + leak here. + +* The way return values from handlers such as 2012 trigger side effects + based on global state such as K and SPK is nasty.